#9419: Update Developers Guide to state how patches should be made.
---------------------------------------------------+------------------------
   Reporter:  drkirkby                             |          Owner:  mvngu     
                
       Type:  enhancement                          |         Status:  
positive_review           
   Priority:  major                                |      Milestone:  sage-4.8  
                
  Component:  documentation                        |       Keywords:  patch doc 
howto spkgs diff
Work_issues:  finance.py.patch in too many places  |       Upstream:  N/A       
                
   Reviewer:  Karl-Dieter Crisman                  |         Author:  John 
Palmieri             
     Merged:                                       |   Dependencies:            
                
---------------------------------------------------+------------------------
Changes (by kcrisman):

  * status:  needs_review => positive_review


Comment:

 Ok, that clarifies `patch`.

 I also did a ''lot'' of reading of man pages and searches, and the shell
 stuff checks out.  I agree than `diff -u` is totally appropriate for this
 particular context of creating spkg patches (not in general!).

 Last question (but positive review!) - why
 {{{
 [[ -z "$SAGE_LOCAL" ]]
 }}}
 and not
 {{{
 [ -z "$SAGE_LOCAL" ]
 }}}
 since it seems like in this situation (no 'and's) they behave identically?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9419#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to