#9419: Update Developers Guide to state how patches should be made.
-----------------------------+----------------------------------------------
   Reporter:  drkirkby       |          Owner:  mvngu                     
       Type:  enhancement    |         Status:  needs_review              
   Priority:  major          |      Milestone:  sage-4.8                  
  Component:  documentation  |       Keywords:  patch doc howto spkgs diff
Work_issues:                 |       Upstream:  N/A                       
   Reviewer:                 |         Author:                            
     Merged:                 |   Dependencies:                            
-----------------------------+----------------------------------------------

Comment(by kcrisman):

 This is great stuff, John.  Once this is in I will actually be able to
 change a few spkgs to use `patch` correctly, and to more easily review
 them - since the syntax is there.

 As a non-expert in shell syntax I will not give this a positive review,
 but everything I do know about seems good, and the examples are more
 informative.  One tiny request.  In
 {{{
 Now provide a high-level explanation of your changes in
 ``SPKG.txt``. Once you are satisfied with your changes, use Mercurial
 to check in your changes with a meaningful commit message. Next,
 }}}
 I wonder if you could put two more comments.
  * One with the syntax for the changes in SPKG.txt (the {{{=== pkg-name
 1.4.5.p3 (John Palmieri, Octember 33 2011) ===}}} thing)
  * One to tell people they might as well tag the tip with the new spkg
 version number.  I know Jeroen currently does this anyway when merging,
 but it would make things easier for him (and for any new release manager
 eventually).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9419#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to