#9419: Update Developers Guide to state how patches should be made.
---------------------------------------------------+------------------------
Reporter: drkirkby | Owner: mvngu
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-4.8
Component: documentation | Keywords: patch doc
howto spkgs diff
Work_issues: finance.py.patch in too many places | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: John
Palmieri
Merged: | Dependencies:
---------------------------------------------------+------------------------
Changes (by jhpalmieri):
* status: needs_work => needs_review
Comment:
Replying to [comment:22 kcrisman]:
> > > One tiny request.
> >
> > Okay, here's part 2 of the patch, which addresses your suggestions.
>
> Wow, great! Looks good, applies to alpha4 fine, builds and doc looks
great.
>
> As I said, I don't feel comfortable addressing the shell stuff, but I
like this. Here are a few tiny things.
Great, thanks for catching these. I've updated the "part2" patch.
> * A question, probably due to ignorance:
{{{
diff -u src/configure src-patched/configure > patches/configure.patch
}}}
> will that make a patch that actually applies correctly? I feel like
this will produce one with a header that says
{{{
--- a/src/configure
+++ b/src-patched/configure
}}}
> that wouldn't apply, as opposed to
When you run "patch -p1 file.patch", it strips the file names up to the
first slash ("-pN" strips up to the Nth slash), so it will patch a file
"configure" in the current directory. (So this patch command should be
run after cd'ing to `src`. I've added such a cd command to one of the
examples.)
> Regarding "a" versus "an".
> > The letter 's' is certainly a consonant, and not a vowel, and I don't
think 'spkg' sounds like a vowel (as for example 'hour' does, despite it
starting with a consonant). So I would have thought it should have been "a
spkg" and not "an spkg". But it's not a big deal.
> Ah, but I've never heard "spkg" pronounced other than as "esspackage".
Vowel sound. Sort of like how different people will say "an (h)istorical"
or "a historical", and both are right.
Me too.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9419#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
