#9419: Update Developers Guide to state how patches should be made.
---------------------------------------------------+------------------------
Reporter: drkirkby | Owner: mvngu
Type: enhancement | Status:
positive_review
Priority: major | Milestone: sage-4.8
Component: documentation | Keywords: patch doc
howto spkgs diff
Work_issues: finance.py.patch in too many places | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: John
Palmieri
Merged: | Dependencies:
---------------------------------------------------+------------------------
Comment(by jhpalmieri):
Replying to [comment:25 kcrisman]:
> Ok, that clarifies `patch`.
>
> I also did a ''lot'' of reading of man pages and searches, and the shell
stuff checks out.
Great! Thanks for doing that work.
> Last question (but positive review!) - why
{{{
[[ -z "$SAGE_LOCAL" ]]
}}}
>and not
{{{
[ -z "$SAGE_LOCAL" ]
}}}
> since it seems like in this situation (no 'and's) they behave
identically?
I think they do behave identically. The double bracket version calls a
bash built-in function, whereas the single bracket version runs another
program. So the double bracket version is faster, although it doesn't
matter too much here of course. I think that if we're using bash scripts,
using double brackets is slightly preferable to single ones: double
brackets are faster and have some extra functionality. I found
[http://stackoverflow.com/questions/2188199/bash-double-or-single-bracket-
parentheses-curly-braces this link] and
[http://stackoverflow.com/questions/669452/is-preferable-over-in-bash-
scripts this one], which seem like good explanations.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9419#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
