#11754: Computation of rank-decompositions in Sage
-----------------------------+----------------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: graph theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Coudert | Author: Nathann Cohen
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Old description:
> Hello everybody !
>
> This patch is an interface between Sage and the software RW, written by
> Philipp Klaus Krause [1]. It is written in C, and freshly licensed under
> the GPL2. It is a highly enumerative code that uses a lot of memory, but
> is still so far the best practical way to obtain optimal decompositions.
>
> This patch creates the module sage.graphs.graph_decompositions and the
> rankwidth-related files. As it requires some documentation, some words
> are added on what a rank-decomposition is and where the code is coming
> from. Doing that, I also added sage.graphs.modular_decompositions to the
> documentation.
>
> (As I created a module graph_decompositions, it would make sense to move
> te modular_decomposition there. It thought it best to do it in a distinct
> patch, this one being large enough already)
>
> Oh. By the way, most of the patch actually contains the copy of the files
> written by Philipp Klaus Krause.
>
> Nathann
>
> http://pholia.tdi.informatik.uni-frankfurt.de/~philipp/software/rw.shtml
>
> APPLY:
> * [attachment:trac_11754.patch]
> * [attachment:trac_11754_warning.patch]
> * [attachment:trac_11754-ifndef.patch]
New description:
Hello everybody !
This patch is an interface between Sage and the software RW, written by
Philipp Klaus Krause [1]. It is written in C, and freshly licensed under
the GPL2. It is a highly enumerative code that uses a lot of memory, but
is still so far the best practical way to obtain optimal decompositions.
This patch creates the module sage.graphs.graph_decompositions and the
rankwidth-related files. As it requires some documentation, some words are
added on what a rank-decomposition is and where the code is coming from.
Doing that, I also added sage.graphs.modular_decompositions to the
documentation.
(As I created a module graph_decompositions, it would make sense to move
te modular_decomposition there. It thought it best to do it in a distinct
patch, this one being large enough already)
Oh. By the way, most of the patch actually contains the copy of the files
written by Philipp Klaus Krause.
Nathann
http://pholia.tdi.informatik.uni-frankfurt.de/~philipp/software/rw.shtml
APPLY:
* [attachment:trac_11754.patch]
* [attachment:trac_11754_warning.patch]
* [attachment:trac_11754-ifndef.patch]
* [attachment:trac_11754-ifndef-rev.patch]
--
Comment(by dcoudert):
Nathann,
I have added a review patch because 1) the test in rw.h was not correct.
We have to define a tag. 2) the test in rw.c was also incorrect due to
missing braces.
Now compilation is correct on both my 32 bits and 64 bits computers. The
execution is correct, in particular it returns the correct error message
when memory is insufficient. Tests are OK, and documentation was already
OK.
For me the patch is now good to go.
D.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11754#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
