#11754: Computation of rank-decompositions in Sage
-----------------------------+----------------------------------------------
   Reporter:  ncohen         |          Owner:  jason, ncohen, rlm
       Type:  enhancement    |         Status:  positive_review   
   Priority:  major          |      Milestone:  sage-5.0          
  Component:  graph theory   |       Keywords:                    
Work_issues:                 |       Upstream:  N/A               
   Reviewer:  David Coudert  |         Author:  Nathann Cohen     
     Merged:                 |   Dependencies:                    
-----------------------------+----------------------------------------------
Changes (by dcoudert):

  * status:  needs_review => positive_review


Comment:

 The author is right ;-)

 The previous version was also working for me because the test was true for
 N> 31, n <0, and N=30, but it was an accident. With the correct version,
 we have the same result but it is more expected.

 I have updated the patch accordingly and its working fine on all my
 computers: compilation, tests, documentation, functionality, error
 messages.

 For me it's good to go so I give positive review.

 D.

 PS: I hope the ARM guys will not experience similar problems than for
 vertex separation...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11754#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to