#11754: Computation of rank-decompositions in Sage
-----------------------------+----------------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: graph theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Coudert | Author: Nathann Cohen
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by ncohen):
Hellooooo !!!
> I have added a review patch because 1) the test in rw.h was not correct.
We have to define a tag. 2) the test in rw.c was also incorrect due to
missing braces.
Hmm... That should be fixed in *his* code. I will email him about it `O_o`
> Now compilation is correct on both my 32 bits and 64 bits computers. The
execution is correct, in particular it returns the correct error message
when memory is insufficient. Tests are OK, and documentation was already
OK.
One last mail exchange with him, and I'll be glad to see this patch merged
! `:-p`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11754#comment:41>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
