#10993: Update eclib to latest upstream release
-----------------------------------+----------------------------------------
Reporter: cremona | Owner: cremona
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Resolution:
Keywords: elliptic curves | Work issues: ldconfig in spkg-install
Report Upstream: N/A | Reviewers: Frithjof Schulze, Jeroen
Demeyer
Authors: John Cremona | Merged in:
Dependencies: #11354 | Stopgaps:
-----------------------------------+----------------------------------------
Comment (by cremona):
Replying to [comment:112 leif]:
> W.r.t. your latest upstream changes:
>
> The `filename` string buffer might still overflow, since `/%c%ld`
(including a terminating `\0`) can have up to 23 characters (1+1+20+1).
One usually allocates a few more bytes than needed, as `sprintf()` is said
to need some "scratch space" in addition (at least some implementations
may).
You may be technically correct (based on {{{2^64-1}}} having 20 digits,
but I know that n will never be anywhere near that big! I doubt if I'll
get to a 7-digit n in my lifetime with his code. But still, I'll change
20 to 23 and repost. The old code was much worse: I was relying on the
entire path to the directory being a local filename of a few characters,
but wilth all the testing I have been doing recently I was setting NF_DIR
to be some much longer path and that caused segfaults...
>
> Otherwise positive review modulo testing on Cygwin (if needed).
Good -- we have the official verdict from William saying that it is not
necessary. Just wait for p2...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10993#comment:114>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
