#320: preiodical faad failure when polling aac stream with input.http
----------------------------+-----------------------------------------------
  Reporter:  romeodeepmind  |       Owner:  admin      
      Type:  Bugs           |      Status:  new        
  Priority:  1              |   Milestone:  NEAR FUTURE
 Component:  Liquidsoap     |     Version:  0.9.1+svn  
Resolution:                 |    Keywords:             
       Mac:  1              |       Linux:  1          
    Netbsd:  1              |       Other:  1          
   Freebsd:  1              |  
----------------------------+-----------------------------------------------

Comment(by mrpingouin):

 Our MP3 decoder, based on libmad, also often accepts files that are not
 (at all) MP3. It can even decode a directory... But at least it doesn't
 segfault, it fails cleanly. Libfaad should do the same, and perhaps they
 fixed it with version 2.

 In any case, the above problem is with files. With streams we can (and do)
 rely on the provided MIME type. So, the problem here seems to be that our
 faad stream decoding claims to accepts aac+:
 {{{
 src/sources/http_aac.ml:  Http_source.stream_decoders#register "audio/aac"
 decode_aac;
 src/sources/http_aac.ml:  Http_source.stream_decoders#register
 "audio/aacp" decode_aac
 }}}
 Simply remove the second line in that file, and it should stop attempting
 stupid things.

-- 
Ticket URL: <http://savonet.rastageeks.org/ticket/320#comment:17>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Savonet-trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-trac

Reply via email to