On Wed, Jul 04, 2012 at 11:43:38AM +0200, Olivier Grisel wrote: > > Thanks -- I will pick up this "lucky to succeed once" fix ;)
> I think that using the numpy.random singleton (or any other mutable > singleton) in scikit-learn tests should be considered a failure in > itself as it breaks the tests order-independence assumption. Yes, calling an unprotected np.random in the source code is a bug, IMHO. When people review code, they should point it out. Also, in the tests, all random_state should be assigned to. G ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
