On Mon, Oct 15, 2012 at 2:29 PM, Gael Varoquaux <
[email protected]> wrote:
> Just to make it clear: adding a dependency on make or cmake is just not
> an option. These tools are not part of the standard Python build chain.
> The reason why we are checking in the C files is that we want to avoid
> having a dependency on Cython. We are striving to have a low dependency
> package. This is an important goal of scikit-learn, and part of its
> success.
>
Even if we do check the generated C files in, "make" could still be used to
make our life easier, just like we use it for running nosetest. For
example, we could have a "make gen_C" task which takes into account
dependencies and regenerate C files when needed (this command would be run
*manually*). My main concern about checking in the generated C files was
that it pollutes the commit diffs. Hopefully, this should have been solved
by the recently added ".gitattributes" file.
# BTW, make is available by default on Linux, Mac and Cygwin.
Mathieu
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
