Am 15.10.2012 08:36, schrieb Mathieu Blondel:


On Mon, Oct 15, 2012 at 2:29 PM, Gael Varoquaux <[email protected] <mailto:[email protected]>> wrote:

    Just to make it clear: adding a dependency on make or cmake is
    just not
    an option. These tools are not part of the standard Python build
    chain.
    The reason why we are checking in the C files is that we want to avoid
    having a dependency on Cython. We are striving to have a low
    dependency
    package. This is an important goal of scikit-learn, and part of its
    success.


Even if we do check the generated C files in, "make" could still be used to make our life easier, just like we use it for running nosetest. For example, we could have a "make gen_C" task which takes into account dependencies and regenerate C files when needed (this command would be run *manually*). My main concern about checking in the generated C files was that it pollutes the commit diffs. Hopefully, this should have been solved by the recently added ".gitattributes" file.

+1 for having developer convenience in make, as long as it is not needed.
# BTW, make is available by default on Linux, Mac and Cygwin.

Using a standard Python-(x, y) installation on a windows box, I didn't have make. It uses MinGW, I think. So for the last 3 month I developed without Make. I tried to install Cygwin, but then had some 32bit /64bit issues,
problems setting the path and abandoned it.
Luckily i'm not at M$ any more ;)
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general

Reply via email to