I've been using mypy on a much smaller codebase I've been developing. The main benefits are:
1- Much nicer IDE experience when using something like pycharm. I expect more text editors to start supporting this in the future. 2- An additional way to catch some compile time errors early on. For a codebase as mature as scikit-learn, that's probably not a huge deal. 3- Makes it nicer for other codebases using mypy to use scikit-learn. Of those, the main benefit is by far 1. I also think that the opportunity cost is very low: annotations are easy to keep up to date, and the annotation syntax is really very simple. On Fri, 29 Jul 2016 at 21:57 Gael Varoquaux <gael.varoqu...@normalesup.org> wrote: > I am still worried that this is going to add even more complexity to > contributing: people will contribute without knowing type hint, CI will > break, they won't understand why it breaks, won't be able to reproduce > it, and it will stall PRs. > > Can you summarize once again in very simple terms what would be the big > benefits? > _______________________________________________ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn >
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
