On 07/30/2016 03:20 AM, Alexandre Gramfort wrote:
I am still worried that this is going to add even more complexity to
contributing: people will contribute without knowing type hint, CI will
break, they won't understand why it breaks, won't be able to reproduce
it, and it will stall PRs.
+1
same feeling here.
That is "only" a concern if they change the type of something that is
annotated, right?
Is that something that happens often?
I guess it would also break if someone adds an argument to an annotated
function,
that might happen more often.
_______________________________________________
scikit-learn mailing list
scikit-learn@python.org
https://mail.python.org/mailman/listinfo/scikit-learn
