Neil Hodgson wrote:
I have corrected the bug and uploaded the correction to the same file as
above.
The CmdQueue code looks like an abandoned experiment as it doesn't
appear to be linked in.
I was planning on renaming the Job* system to Command* but reversed this
and forgot about these files. I've removed them from my HD.
I don't much like specifying all the string modes explicitly like
("savebefore", "savebefore:1", "savebefore:yes", "savebefore:2", and
"savebefore:no"). Shouldn't this be broken up into recognition of the
mode name and the value as it was previously? This is a good example
of not following "don't repeat yourself" with the chance of failing to
spell all instances the same or only updating some when making a
change.
I am of the opposite opinion. If the flags were only 0/1 then there
would be nothing gained by my implementation, but there are currently 2
switches that have three options. A solution that does not use the form
I wrote would have to be specifically programmed for these variations,
whereas my implementation is merely a simple for..next loop.
With SciTE itself probably being the editor someone would use to update
this code, duplicating a line to create a new option would be a few
keystrokes (ctrl+d) and would thereby not have any misspellings. New
switches could be programmed by merely adding lines of the same form,
and would not require special programming to handle.
Neil, you are the architect of SciTE and Scintilla, if you do not prefer
this form I will revert it but IMHO it has some advantages.
Methods shouldn't end with ';' after the '}'.
Found and fixed
A warning from Borland (line number may differ from your version)
Warning W8004 .\SciTEWin.cxx 817: 'cancelled' is assigned a value that
is never used in function SciTEWin::ExecuteOne(const Job &,bool &)
Found and removed.
Thank you Neil.
--
I'm one of those bad things that happen to good people.
_______________________________________________
Scite-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scite-interest
