April White:

   Another thing to avoid is typedefs. SciTE is C++ so there should be
no need to use "typedef enum" or "typedef struct".

   The job system code doesn't currently compile for GTK+ so someone
will have to be found to port it although its mostly just a matter of
editorial changes (executing changes to something like
JobQueue.IsExecuting(), etc) as the mutex can be implemented as null
sine ScinTE on GTK+ is single threaded.

> I am of the opposite opinion.  If the flags were only 0/1 then there
> would be nothing gained by my implementation, but there are currently 2
> switches that have three options.  A solution that does not use the form
> I wrote would have to be specifically programmed for these variations,
> whereas my implementation is merely a simple for..next loop.

   There are many other ways to implement this that don't lead to
value or code replication. Even the current version which contains
quite a bit of explicit code is preferrable IMO although there are
ways to improve it.

> With SciTE itself probably being the editor someone would use to update
> this code, duplicating a line to create a new option would be a few
> keystrokes (ctrl+d) and would thereby not have any misspellings.

http://en.wikipedia.org/wiki/DRY

   Neil

_______________________________________________
Scite-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scite-interest

Reply via email to