Richard Lowe writes: > James Carlson <james.d.carlson at sun.com> writes: > > usr/src/tools/scripts/cstyle.pl > > > > 194,203,211: why set this flag only when we print errors? It seems > > to me that even if $no_errs is set, we should still return an error > > code when something is wrong. (Shouldn't we?) > > > > $no_errs is set to deal with /*CSTYLED*/, I don't think we want to > indicate failure in those cases.
Well, duh. ;-} Thanks for setting me straight; you're quite right on that. > I think I got this wrong in the case of jstyle.pl however. Not necessary. Line 154 will skip over the next line in the case of /*JSTYLED*/. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
