Stephen Hahn <sch at sun.com> writes: > * Richard Lowe <richlowe at richlowe.net> [2008-05-29 02:38]: >> Richard Lowe <richlowe at richlowe.net> writes: >> >> > James Carlson <james.d.carlson at sun.com> writes: >> >> >> usr/src/tools/onbld/Checks/DbLookups.py >> >> >> >> It'd be nice if this knew about defect.opensolaris.org. Lack of >> >> direct support of open bug tracking in the new tools is going to be >> >> a stumbling block for external committers. >> > >> > defect.opensolaris.org is not even currently a beta, fervent desire >> > aside. I happen to have code that would support its use, but I have >> > no plan to integrate it currently. >> > >> > The block on external committers to most places, right now, is that >> > bugs in d.o.o don't count for (ON, SFW, etc, etc). Only the various >> > project gates making use of it. >> > >> >> Sorry, let me expand upon that somewhat. I don't want the comment >> checks to accept bugs from defect.opensolaris.org as long as that's >> not an absolutely correct thing to do. >> >> While for a change to slim_install or pkg-gate it would be valid, it's >> absolutely wrong for others. The other alternative I can think of >> (baking that knowledge into the code) is untenable, I think. >> >> If there's another way to go about it, I'm open to suggestions. > > (I may have missed some context on what the checks are doing for bug > lookups; apologies if the following is redundant.) > > Why couldn't we define a syntax for defect. bugs, like "[0-9]+o", and > match/check both that and the "[1-9][0]9]{5}" pattern for Bugster? > > I agree that the tools shouldn't know about any specific > gates/projects. >
I spoke to comay some about this yesterday, though with no real conclusion. One thing that occured to me in talking to him, is that while the dev tools can't know which gates is which, and what is acceptable to whom, the gate hooks quite clearly can, so at least in concept the tools can say Ok to a d.o.o ID, but ON and SFW refuse them. I'm still not convinced that's a great idea to do now. With your idea above, the same would be necessary, as ON and friends would still need to know that [0-9]+o or whatever pattern was used was incorrect for them. -- Rich