Mike Kupfer writes:
> JimC> usr/src/tools/scripts/nightly.1
> JimC>
> JimC> 275: should add back in "This is the source to be built."
>
> I took that phrase out for a variety of reasons. In particular, it
> could be read to imply that only this source will be built, which will
> not be true for internal builds with separate (but nested) open and
> closed repositories. It also muddies the distinction between the source
> and the repo metadata. If anything it's SRC that's the source to be
> built, not CODEMGR_WS.
OK. How about this?
"This is the workspace in which the build will be done."
The issue I have (and it's perhaps a fairly minor one) is that nightly
is pretty confusing for new users. One of the many things that
confuses them is that it's unclear exactly where the "make install"
will be run.
> JimC> usr/src/tools/scripts/nightly.sh
> JimC>
> JimC> 382-383,2548-2549: what is this? It looks out of place.
>
> These should be guarded by an error check. See bug #481.
OK; that makes more sense.
> JimC> 1707: uuoc
>
> I don't know what "uuoc" means. There does seem to be some sort of
> mismerge here (1704-1707), though.
Useless use of cat. There used to be an award. ;-}
Now that the actual concatenation occurs once on line 1704, line 1707
could just be:
< ${LLOG}/mail_msg /usr/bin/mailx -s \
(The '<' can go anywhere; move to the end if you prefer.)
> JimC> usr/src/tools/scripts/wx2hg.sh
> JimC>
> JimC> 115: does this work?
>
> This should go away with the fix for #462.
OK.
Richard Lowe writes:
> Mike Kupfer <mike.kupfer at sun.com> writes:
>
> > JimC> 1707: uuoc
> >
> > I don't know what "uuoc" means. There does seem to be some sort of
> > mismerge here (1704-1707), though.
>
> UUOC -> Useless Use Of Cat
>
> What do you see on the stated lines that's bad? The mail_msg file
> should be constructed regardless of whether it's actually sent via
> mail, no?
Yes, it should. What I see is that we're no longer concatenating
anything on 1707, so we shouldn't be calling 'cat'.
A nit, maybe, but an annoyance.
--
James Carlson, Solaris Networking <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
