James Carlson <james.d.carlson at sun.com> writes: > Richard Lowe writes: >> A webrev is available for prelim code review: >> >> http://cr.opensolaris.org/~richlowe/scm-review_90 > > Completing the review notes from yesterday: >
> usr/src/tools/scripts/cstyle.pl > > 194,203,211: why set this flag only when we print errors? It seems > to me that even if $no_errs is set, we should still return an error > code when something is wrong. (Shouldn't we?) > $no_errs is set to deal with /*CSTYLED*/, I don't think we want to indicate failure in those cases. I think I got this wrong in the case of jstyle.pl however. -- Rich
