Mike Kupfer <mike.kupfer at sun.com> writes:

> I looked at the updated changes in
> http://cr.opensolaris.org/~vijaybk/webrev_355/, and I have a couple
> concerns about cdm_branchchk():
>
> - If there are multiple heads, do we want to display more than just the
>   revision number for each head?  I don't know if we need to display all
>   the same information that "hg heads" provides, I'd like to see at
>   least the short-form changeset ID and the 1-line log (summary)
>   message.

recommit only shows the revisions.  Though perhaps it would be good to
show more there, too.

The short node would certainly be a good idea for both.

> - The named branch check looks like it just checks the name of the
>   current branch.  So it wouldn't catch the case where somebody commits
>   something on a new branch, goes back to using the default branch, and
>   then merges with the new branch.  Is there some way to review the
>   entries in the active list and see if any of them belong to a branch
>   other than "default"?

But then they'd trip the multi-head check.  I think this is attempting
to make sure the 'default' branch is not renamed.  I'm not certain
it's possible to do that (I hadn't tried), but I assume Vijay has, and
it is.

-- Rich

Reply via email to