Hi Kristis, On 6/21/07, Kristis Makris <[EMAIL PROTECTED]> wrote:
Hi Dmitri, Thanks for the patch!
Most of it isn't mine - I just took the latest patch from the bug and added the get_vdd method.
I have a question on integration_get_vdd. Shouldn't this: categorizeVDD($vdd, %comment, $bugid, ++$comment_counter); actually be $self->categorizeVDD($vdd, %comment, $bugid, $comment_counter); $comment_counter++;
yes. For some reason I thought it needed the pre-inc, although it doesn't makes sense now.
Does the VDD document get generated in your tests ?
I didn't actually check - the test passed so I was assuming it was ok. Looking at the testcase it doesn't seem to save it anywhere, however this doesn't look promising: [EMAIL PROTECTED] system]$ scmbug_vdd_generator --scm=Subversion --product=TestProduct --repository=file://tmp/testsuite_repository --from=tags/p_kpm_tag1 --to=tags/p_kpm_tag2 Unable to change into tmp/testsuite_repository/hooks at /usr/share/scmbug/lib/Scmbug/Tools/SCM_Functions.pm line 63. It doesn't sound like its related, but its the closest I can get to it. I'll try changing the tag name soon and see how that goes.
Yikes! How about you ensure the tagging tests pass first ?
Its only when removing a tag right? We don't remove our tags so I figure we won't hit it.... and my team are continually asking me when it'll be back online (o: cheers, dim _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
