Hi Dmitri, Thanks for the patch! I have a question on integration_get_vdd. Shouldn't this:
categorizeVDD($vdd, %comment, $bugid, ++$comment_counter); actually be $self->categorizeVDD($vdd, %comment, $bugid, $comment_counter); $comment_counter++; ... else we just reported the next comment counter instead of the current one. And we must add the $self reference. Does the VDD document get generated in your tests ? On Thu, 2007-06-21 at 15:59 +1000, Dmitri Colebatch wrote: > This diff is against 1.34 of Bugzilla.pm.in. Kristis - could you take > a look at this, and run the tests on a Bugzilla 2.x environment (I > don't have a 2.x test environment setup). The tests pass against my test 2.20. So the patch doesn't break anything. > I still have one failing test - delete tag. It looks to me like > someone has already worked on this in the diff, so I'm hesitant to > change it. It would appear that the failure is because there are > still bugs associated with the version we're trying to delete (by > deleting the tag). Anyone have any ideas? This shouldn't be a problem. I suspect this is an error with your test Bugzilla instance. After the testsuite inserts a version in the versions table it does not assign that version to any bugs. I wonder if you have a left-over version associated in there. It should be easy to correct. Or just modify for your own testing in the testsuite the files: add_tag.sh delete_tag.sh and change TAG_NAME="p_ats_new_tag" into ...something else like: TAG_NAME="p_dc_new_tag" > In the meantime I'm going to give this a go on our real environment > and see how it goes. Yikes! How about you ensure the tagging tests pass first ? I applied the patch. It seems very close to being finished.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
