(I meant to send this to the list)
On 6/26/07, Dmitri Colebatch <[EMAIL PROTECTED]> wrote:
On 6/25/07, Kristis Makris <[EMAIL PROTECTED]> wrote:
> Yes, that's correct. Had you tried changing the TAG_NAME in the tagging
> tests ?
Yep, I tried that, and then I tried deleting all the versions in
bugzilla. My guess is that its a genuine failure - I'll try to make
time to take a look.
I think the difference here is that the previous code removed the
version via SQL, meaning there were no checks to see if any bugs were
raised against that version. We're now removing it via the
remove_from_db method which looks like this:
sub remove_from_db {
my $self = shift;
my $dbh = Bugzilla->dbh;
# The version cannot be removed if there are bugs
# associated with it.
if ($self->bug_count) {
ThrowUserError("version_has_bugs", { nb => $self->bug_count });
}
$dbh->do(q{DELETE FROM versions WHERE product_id = ? AND value = ?},
undef, ($self->product_id, $self->name));
}
So obviously this isn't going to work if bugs are still raised against
that version. I see three options here:
1. Leave it as is - don't allow people to remove tags that have bugs
raised against them. This to me seems valid - if there's a bug raised
against a version then it has been used by users and to me that would
mean it shouldn't be deleted. Having said all this, different
organisations have different policies.
2. Go back to SQL and delete the version in the database as per
previous behaviour.
3. Go through the bugs and change the version to null before removing
the version.
Kristis - what would you like me to do?
cheers,
dim
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
