Hello Kristis!
Hi Oliver, I've been reviewing your patch trying to merge it. You
did quite, quite a lot!! And it is hard work to make such changes
ensuring nothing broke.
Hopefully you aren't complaining about that :-)
Could you please clarify a few things for me ?
I will try.
- Could you comment on:
http://bugzilla.mkgnu.net/show_bug.cgi?id=1061#c1
This code was taken from Bugzilla itself, and splice is removing the
entry from the array. And yes, in bz3 you can change a bug from
'resolved fixed' to 'resolved worksforme'.
>$status_map->{ 'RESOLVED' }->{ accepts_data_as_resolution } = 1;
>for resolving bugs as duplicates ?
Duplicates doesn't need 'accepts_data_as_resolution', we receive
three parameters here.
- I understand categorizeVDD was changed, trying to reduce
duplication of code. Was anything else changed ? Can you comment on:
http://bugzilla.mkgnu.net/show_bug.cgi?id=948#c36
I meant duplicate code with 'redundant data'. Dmitris' work wasn't
complete here and it never worked for bz3. I've just moved
categorizeVDD near to the calling methods (I was sick to scroll 500
lines between the methods :-) ), made cleanups and added bz3 support
to integration_get_bugs.
All changes have been made to fix/add code and not to break existing
one.
- I'll need to edit integration_change_bug_resolution() for style
changes. I hope I won't break... much. One question: How is case
sensitivity of resolutions handled ?
I don't understand this question, can't say more than the code itself.
- I've merged your test cases. Perhaps when I apply the patch you
could use them to verify I didn't break anything on 3.x ?
http://bugzilla.mkgnu.net/show_bug.cgi?id=1082
You'll need to define some more global variables in your tester
configuration files.
I will do some tests giving me a notice when you applied the patches.
--
Oliver
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
