On Jan 15, 2008, at 9:34 , Kristis Makris wrote:
On Tue, 2008-01-15 at 08:36 +0100, Oliver Schäfer wrote:
Hi Oliver, I've been reviewing your patch trying to merge it. You
did quite, quite a lot!! And it is hard work to make such changes
ensuring nothing broke.
Hopefully you aren't complaining about that :-)
Not at all. You went out of your way to formally test this work.
I committed parts of the patch.
That's fine. I was setting up tests to provide full bz3 support, and
so I decided to complete the open issues.
All changes have been made to fix/add code and not to break existing
one.
Why were categorizeVDD and integration_get_vdd changed ?
Where you aiming just at cleanups or was something broken ?
The bz3 part was broken, and as I said never worked, although we had
code for it. I've tested those functions heavily, so every change has
its sense and meanwhile I've made some cleanups and code reviews.
- I'll need to edit integration_change_bug_resolution() for style
Is it possible to add some more documentation in this function ?
There are
some if/else blocks that are unclear to me.
Surely. I'll revisit it in the next days, I'm quite busy until
Friday, is this weekend OK for you?
changes. I hope I won't break... much. One question: How is case
sensitivity of resolutions handled ?
I don't understand this question, can't say more than the code
itself.
For example the implementation reads:
if ( $status =~ /^resolved$/ ) {
$resolution = lc $resolution;
So we are assuming a resolution in lowercase is accepted by Bugzilla.
But then we say:
if ( $status =~ /^reopened$/ ) {
we don't set to lowercase the resolution. What if someone sets
"resolved
DUPLICATE".
Oh yes we do:
/^resolved$/ && do {
$resolution = lc $resolution;
--
Oliver
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
