On Tue, 2008-01-15 at 08:36 +0100, Oliver Schäfer wrote: > > Hi Oliver, I've been reviewing your patch trying to merge it. You > > did quite, quite a lot!! And it is hard work to make such changes > > ensuring nothing broke. > Hopefully you aren't complaining about that :-)
Not at all. You went out of your way to formally test this work.
I committed parts of the patch.
> All changes have been made to fix/add code and not to break existing
> one.
Why were categorizeVDD and integration_get_vdd changed ?
Where you aiming just at cleanups or was something broken ?
> > - I'll need to edit integration_change_bug_resolution() for style
Is it possible to add some more documentation in this function ? There are
some if/else blocks that are unclear to me.
> > changes. I hope I won't break... much. One question: How is case
> > sensitivity of resolutions handled ?
> I don't understand this question, can't say more than the code itself.
For example the implementation reads:
if ( $status =~ /^resolved$/ ) {
$resolution = lc $resolution;
So we are assuming a resolution in lowercase is accepted by Bugzilla.
But then we say:
if ( $status =~ /^reopened$/ ) {
we don't set to lowercase the resolution. What if someone sets "resolved
DUPLICATE".
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
