It is updated for "is_version_..." function adaptation to the newly introduced version checking mechanism
With the new mechanism multiple "is_version_..." may be "True" Indeed, more than one "is_version..." results needs to be "True" for version check relating to "Bugzilla:Bug::AppendComment" modification (see integration_add_comment function) So, I changed the general version checking mechanism and made it support multiple version checks I also checked ONE BY ONE all Bugzilla distributions from 3.0.0 to 3.4.1 with the new version checking mechanism. All tested distributions passed successfully the "init" version checking, taking into account file modifications from each distribution to the next one Any ideas/suggestions/corrections are welcome -----Original Message----- From: Kristis Makris [mailto:[email protected]] Sent: Wednesday, August 26, 2009 7:49 PM To: Elias Balasis Cc: [email protected] Subject: RE: [scmbug-users] scmbug with Bugzila 3.4.1 and SVN Why is Bugtracker.pm modified ? I see no reason for the changes applied there. On Tue, 2009-08-25 at 22:42 +0300, Elias Balasis wrote: > Modifications for comment handling (AppendComment) definitely work for > any version above 3.1.2 > > Modifications for version checking are tested with all Bugzilla > installations from 3.0.0 to 3.4.1 > > > > Unfortunately no resources for QA here J > > No, I haven't tested with actual 3.2 for comment handling > (Bugzilla::Bug::AppendComment) modifications > > BUT I checked ONE BY ONE every Bugzilla distribution from 3.0.0 to > 3.4.1 > > Found out that all Bugzilla versions above 3.1.2 do not use > Bugzilla::Bug::AppendComment but Bugzilla::Bug::add_comment instead > > My modification specifically handles this case and since all Bugzilla > versions above 3.1.2 use same function for same purpose > (Bugzilla::Bug::add_comment) > > the patch is expected to work for all Bugzilla versions above 3.1.2 > > > > Attached modified files for convenience (against scmbug 0-26-15) > > > > > ______________________________________________________________________ > From: Kristis Makris [mailto:[email protected]] > Sent: Tuesday, August 25, 2009 7:47 PM > To: Elias Balasis > Cc: [email protected] > Subject: Re: [scmbug-users] scmbug with Bugzila 3.4.1 and SVN > > > > > Elia, please send all communication to the mailing list. > > Which versions of Bugzilla has this work been tested with ? You > indicated it applies to Bugzilla 3.2 later, but also that you aimed to > get it to work with Bugzilla 3.4.1. Have you tested it with 3.2 ? > > On Tue, 2009-08-25 at 18:40 +0300, Elias Balasis wrote: > > Find attached the modified files. > > Contained modifications apply to Bugzilla 3.2 or later > > (Bugzilla::Bug::AppendComment function removed in Bugzilla 3.1.2) > > Also added support for more flexible version checking > > Modifications were performed against Scmbug 0-26-15 (handling all > > AppendComment cases, duplicates etc.) > > > > You can use the attached files to extract the modifications against > > scmbug 0-26-15 > > > > On Tue, Aug 25, 2009 at 7:33 AM, Kristis > Makris<[email protected]> wrote: > > > Elias, > > > > > > Can you supply a patch ? > > > > > > Which version of Scmbug were these produced against ? > > > > > > On Tue, 2009-08-25 at 01:02 +0300, Elias Balasis wrote: > > >> Kristis Makris, > > >> > > >> please check the modifications in previously attached files. > > >> They worked for me quite successfully and I believe they would > make an > > >> excellent addition to scmbug implementation > > >> Please consider including in next version of scmbug > > >> (re-ataching for convenience) you can extract a patch and compare > accordingly > > >> > > >> > > >> On Tue, Aug 25, 2009 at 12:50 AM, Kristis > Makris<[email protected]> wrote: > > >> > Hi Ben, > > >> > > > >> > Some ideas are in: > > >> > > > >> > http://bugzilla.mkgnu.net/show_bug.cgi?id=1422 > > >> > > > >> > On Mon, 2009-08-24 at 14:04 -0700, Ben wrote: > > >> >> Has anyone tried to use scmbug with Bugzila 3.4.1 and SVN? > > >> >> > > >> >> I keep getting following error. > > >> >> > > >> >> ******************************************* > > >> >> 2009/08/24 15:56:06 Scmbug WARN> > > >> >> Daemon.pm:81:Scmbug::Daemon::Daemon::read_configuration - Read > > >> >> configuration file '/etc/scmbug/daemon.conf' > > >> >> 2009/08/24 15:56:06 Scmbug ERROR> > > >> >> Daemon.pm:114:Scmbug::Daemon::Daemon::read_configuration - > > >> >> ******************************************* > > >> >> ** > > >> >> ** > > >> >> ** Scmbug error 79: Unsupported version '3.4.1'. This could be > because > > >> >> this version was never tested. If you use a different version > number > > >> >> and manage to get the integration working correctly please > notify > > >> >> '[email protected]'. > > >> >> Initialization of bug-tracking system 'Bugzilla' version > '3.4.1' > > >> >> failed. This could be due to an unsupported version of this > system, or > > >> >> misconfiguration. > > >> >> ** > > >> >> ** > > >> >> ******************************************* > > >> >> > > >> >> Any ideas on configuration to make it work? > > >> >> > > >> >> Thanks and regadrs, > > >> >> > > >> >> Ben > > >> >> > > >> >> _______________________________________________ > > >> >> scmbug-users mailing list > > >> >> [email protected] > > >> >> http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users > > >> > > > >> > _______________________________________________ > > >> > scmbug-users mailing list > > >> > [email protected] > > >> > http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users > > >> > > > >> > > > > > > No virus found in this incoming message. Checked by AVG - www.avg.com Version: 8.5.409 / Virus Database: 270.13.69/2328 - Release Date: 08/26/09 12:16:00 _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
