On Mon, 2011-03-14 at 12:30 +0200, Yavor Nikolov wrote:

> Kristis, are you against to have library initialization in BEGIN block

I'm against the BEGIN.

>  or you're against the ugly design after my patch? I admit it's a bit

I don't understand why the code does things it shouldn't.

Why do the following?

if ( $self->is_version_gte( $VERSION_3_2_0 ) ) {
        my $inst_lib_dir = File::Spec->catdir( $inst_dir, 'lib' );
        eval "use lib \"$inst_lib_dir\"";
     }


Instead of just:

if ( $self->is_version_gte( $VERSION_3_2_0 ) ) {
        eval "use lib \"$inst_dir\"";
} 

?? I do not understand why catdir was invoked. Why is the code trying to
list the directories in the $inst_dir?

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to