http://bugzilla.mkgnu.net/show_bug.cgi?id=1073

On Tue, 2011-03-15 at 08:55 +0100, Thorsten Schöning wrote:
> > ?? I do not understand why catdir was invoked. Why is the code trying to
> > list the directories in the $inst_dir?
> 
> It doesn't list anything, catdir builds paths in an OS independent
> way, e.g. using / vs. \. "use lib" must be used with the lib-directory

Thanks. It turns out using '/' works both for Linux and Windows, and
that's what Scmbug assumes anyway. When someone tries to run Scmbug on
some other OS and everything breaks, then I'll open a bug and use catdir
everywhere in Scmbug, not just the Bugzilla backend.

So, catdir() is not needed.

Can someone try the patch I suggested with eval, and no catdir(), no
BINMODE, no File::Spec, and no SERVER_SOFTWARE listed below?

Index: Bugzilla.pm.in
===================================================================
RCS file: 
/projects/scmbug/cvsroot/system/src/lib/product/Daemon/Bugzilla.pm.in,v
retrieving revision 1.89
diff -u -r1.89 Bugzilla.pm.in
--- Bugzilla.pm.in      6 Mar 2011 15:38:27 -0000       1.89
+++ Bugzilla.pm.in      24 Mar 2011 02:32:37 -0000
@@ -153,7 +153,8 @@
     if ($self->is_version_up_to_3_4() ||
         $self->is_version_up_to_3_6() ||
         $self->is_version_latest()) {
-        unshift @INC, $self->installation_directory() . "/lib";
+        my $installation_directory = $self->installation_directory() . "/lib";
+        eval "use lib \"$installation_directory\"";
     }
 
     #



Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to