[jira] [Created] (DISPATCH-1522) Aborted sender transfer closes receiver connection with framing error
Charles E. Rolke created DISPATCH-1522:
--
Summary: Aborted sender transfer closes receiver connection with
framing error
Key: DISPATCH-1522
URL: https://issues.apache.org/jira/browse/DISPATCH-1522
Project: Qpid Dispatch
Issue Type: Bug
Components: Router Node
Affects Versions: 1.9.0
Environment: Fedora 29, proton master @8c6d4 and dispatch master 2417e.
Reporter: Charles E. Rolke
Start a single router with a normal listener. Run a proton cpp simple_receiver
to receive on an address at that listener. Run proton c/examples/send-abort to
send to that address on the same listener.
The router forwards the abort and then immediately closes the connection with a
framing error.
This same behavior happens through a network of routers. The abort is
propagated properly through the router network but then the connection between
the final receiver and its attached router gets closed.
These are preliminary findings before proper blame between qpid-dispatch and
qpid-proton has been assessed.
In the one router case peer_4 is the receiver and peer_5 is the sender. Scraper
shows :
{noformat}
◊ 2019-12-11 17:12:30.331080 A0#2672 INTC [A0_6] -> [] peer_5 attach [0,0]
receiver my_sender (source: none, target: "examples", class: client)
◊ 2019-12-11 17:12:30.331216 A0#2673 INTC [A0_6] -> [] peer_5 flow [0,0]
(0,250)
◊ 2019-12-11 17:12:30.344997 A0#2674 INTC [A0_6] <- [] peer_5 transfer [0,0]
(0) more transfer_62 - 16350 bytes (pending)
◊ 2019-12-11 17:12:30.346441 A0#2687 INTC [A0_5] -> [] peer_4 transfer [0,0]
(0) more transfer_62 - 15872 bytes (pending)
◊ 2019-12-11 17:12:30.349521 A0#2689 INTC [A0_6] <- [] peer_5 transfer [0,0]
(0) more transfer_63 - 16350 bytes (pending)
◊ 2019-12-11 17:12:30.349965 A0#2695 INTC [A0_5] -> [] peer_4 transfer [0,0]
(0) more transfer_63 - 16384 bytes (pending)
◊ 2019-12-11 17:12:30.352966 A0#2697 INTC [A0_6] <- [] peer_5 transfer [0,0]
(0) more transfer_63 - 16350 bytes (pending)
◊ 2019-12-11 17:12:30.353264 A0#2703 INTC [A0_5] -> [] peer_4 transfer [0,0]
(0) more transfer_63 - 16384 bytes (pending)
◊ 2019-12-11 17:12:30.355887 A0#2705 INTC [A0_6] <- [] peer_5 transfer [0,0]
(0) more transfer_63 - 16350 bytes (pending)
◊ 2019-12-11 17:12:30.356269 A0#2711 INTC [A0_5] -> [] peer_4 transfer [0,0]
(0) more transfer_63 - 16384 bytes (pending)
◊ 2019-12-11 17:12:30.359045 A0#2713 INTC [A0_6] <- [] peer_5 transfer [0,0]
(0) more transfer_63 - 13626 bytes (pending)
◊ 2019-12-11 17:12:30.359090 A0#2714 INTC [A0_6] <- [] peer_5 transfer [0,0]
(0) settled aborted - 0 bytes transfer presettled
◊ 2019-12-11 17:12:30.359489 A0#2734 INTC [A0_6] -> [] peer_5 flow [0,0]
(1,250)
◊ 2019-12-11 17:12:30.359524 A0#2735 INTC [A0_5] -> [] peer_4 transfer [0,0]
(0) settled aborted - 0 bytes transfer presettled
◊ 2019-12-11 17:12:30.360812 A0#2739 INTC [A0_5] -> [] peer_4 close [0] error
:"amqp:connection:framing-error" "connection aborted"
◊ 2019-12-11 17:12:30.360850 A0#2740 INTC [A0_5] <- [] peer_4 EOS
◊ 2019-12-11 17:12:30.360870 A0#2741 INTC [A0_5] [] peer_4 Connection from
192.168.1.17:46324 (to 0.0.0.0:21015) failed: amqp:connection:framing-error
connection aborted
◊ 2019-12-11 17:12:30.360932 A0#2742 INTC [A0_5] -> [] peer_4 EOS
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-1709.
-
Fix Version/s: proton-c-0.31.0
Resolution: Fixed
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: leak
> Fix For: proton-c-0.31.0
>
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994058#comment-16994058
]
ASF subversion and git services commented on PROTON-1709:
-
Commit 427621bf19e84f6fba137b763d8dad25554377b0 in qpid-proton's branch
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=427621b ]
PROTON-1709: [Python] Fix ApplicationEvent to avoid always creating a new
EventType
- ApplicationEvent memoizes EventTypes created so it only creates one for any
one
typename string.
- ApplicationEvent accepts EventType as its first parameter so application can
create
their own EventType.
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: leak
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on issue #624: Bump angular from 1.5.11 to 1.7.9 in /console/stand-alone
dependabot[bot] commented on issue #624: Bump angular from 1.5.11 to 1.7.9 in /console/stand-alone URL: https://github.com/apache/qpid-dispatch/pull/624#issuecomment-564768860 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-1236) [console] building from scratch modifies console/stand-alone/package-lock.json
[ https://issues.apache.org/jira/browse/DISPATCH-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen closed DISPATCH-1236. -- Resolution: Won't Fix Dispatch-1358 moots this issue. The react console uses yarn as a package manager and their is no package-lock.json file in the source directory. > [console] building from scratch modifies console/stand-alone/package-lock.json > -- > > Key: DISPATCH-1236 > URL: https://issues.apache.org/jira/browse/DISPATCH-1236 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.4.1 > Environment: Fedora 29 - build tools up to date >Reporter: Charles E. Rolke >Assignee: Ernest Allen >Priority: Major > > Building the mission C code modifies a source file in the console tree. I > can't tell the exact conditions required to trigger the file change but it > happens routinely with a complete rebuild. > The changes are usually lower versions numbers (a downgrade?) for a dozen or > two packages. > The expectation is that the console build would fail when inappropriate > versions are specified. It is unexpected that the source file is > spontaneously rewritten with downgraded versions. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-1253) Show clients connected to edge routers on console's topology page.
[ https://issues.apache.org/jira/browse/DISPATCH-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen closed DISPATCH-1253. -- Resolution: Duplicate Implementing DISPATCH-1507 solves this issue > Show clients connected to edge routers on console's topology page. > -- > > Key: DISPATCH-1253 > URL: https://issues.apache.org/jira/browse/DISPATCH-1253 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Clients connected to edge routers are not shown on the console's topology > page. Clients connected directly to routers are shown. > All clients connected to an edge router (or edge router group) should be > displayed as a client group. > Clicking on that group should display a list of clients. > Clicking on a client in that list should show which edge router it is > connected to and the link info for that client. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] ssorj commented on a change in pull request #223: Fix errors in the Python tutorial
ssorj commented on a change in pull request #223: Fix errors in the Python tutorial URL: https://github.com/apache/qpid-proton/pull/223#discussion_r356876398 ## File path: python/docs/tutorial.rst ## @@ -249,17 +248,17 @@ Now let's create a simple client to test this service out. :linenos: As well as sending requests, we need to be able to get back the -responses. We create a receiver for that (see line 14), but we don't +responses. We create a receiver for that (see line 15), but we don't specify an address, we set the dynamic option which tells the broker -we are connected to to create a temporary address over which we can +we are connected to a temporary address over which we can Review comment: For this particular sentence, the original is correct, though a little unclear. Simplified, the sense is: the option tells the broker to create an address. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-1284) Conform to patternfly masthead recommendations
[ https://issues.apache.org/jira/browse/DISPATCH-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen closed DISPATCH-1284. -- Resolution: Won't Fix This was for the angular-js version of the console. The current console is based on patternfly-4 and react. The new console conforms to the patternfly masthead recommendations. > Conform to patternfly masthead recommendations > -- > > Key: DISPATCH-1284 > URL: https://issues.apache.org/jira/browse/DISPATCH-1284 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > The patternfly standard masthead requires the following: > * Application name in upper left > * About icon and About box > * User icon followed by user name > * Dropdown next to user name with at least a logout menu item > There may be a background image as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1358) Port console to patternfly 4 / React
[ https://issues.apache.org/jira/browse/DISPATCH-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1358. Resolution: Implemented > Port console to patternfly 4 / React > > > Key: DISPATCH-1358 > URL: https://issues.apache.org/jira/browse/DISPATCH-1358 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.10.0 > > > Initial wireframes are at https://marvelapp.com/1fhc8a26/screen/57601872 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1474) Console message path skips one router hop
[ https://issues.apache.org/jira/browse/DISPATCH-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1474. Fix Version/s: 1.10.0 Assignee: Ernest Allen Resolution: Fixed > Console message path skips one router hop > - > > Key: DISPATCH-1474 > URL: https://issues.apache.org/jira/browse/DISPATCH-1474 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.9.0 > Environment: Fedora 29, Firefox 68.0 (64bit), proton 0.29, dispatch > current master @2bd50. > >Reporter: Charles E. Rolke >Assignee: Ernest Allen >Priority: Major > Fix For: 1.10.0 > > Attachments: dispatch-console-0.9-traffic.png, > edge2-apr5-network-diagram.pdf > > > A test has 12 routers, 8 edge and 4 interior spread across two hosts > connected by a wireless lan. See attached diagrams. > The test client on one host sends messages into edge router EA1 and another > test client on the other host receives messages from INTD. > Viewing this with the console and Message path by address turned on the > message flow bubbles are visible on only four of the five interrouter hops. > Traffic between INTC and INTD never has the traffic flow. > Other tests show the traffic going all the way through the system correctly. > The missing bubbles between INTC and INTD are repeatable. The same test can > be restarted and the traffic is missing on that link. > If traffic enters the system at EC1 (not EA1) then the traffic between INTC > and INTD shows as expected. > --- > Also, router INTD has two edge routers connected to it. In the console app > each interior router has an edge bubble labeled "Edge * 2" but the console > connection to ED1 shows up as a third Edge bubble. I would expect to have > only one bubble labeled "Edge * 2" or two bubbles labeled "Edge". > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1507) Don't collapse small number of edge routers and clients into single circle
[ https://issues.apache.org/jira/browse/DISPATCH-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1507. Fix Version/s: (was: 1.11.0) 1.10.0 Resolution: Implemented > Don't collapse small number of edge routers and clients into single circle > -- > > Key: DISPATCH-1507 > URL: https://issues.apache.org/jira/browse/DISPATCH-1507 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.10.0 > > > Currently on the console's topology page, if there are multiple clients of > the same type, they will be collapsed into a single circle with text > indicating the number of clients. > This is also true for edge routers. > This prevents clients attached to edge routers for appearing on the page. > Add a user configurable threshold to the topology page. If the number of > clients/edge routers attached to an interior router is below the threshold, > they will be drawn individually, otherwise they will be collapsed as they are > now. > This would allow traffic to/from edge router to be visualized. > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1358) Port console to patternfly 4 / React
[ https://issues.apache.org/jira/browse/DISPATCH-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993954#comment-16993954 ] ASF subversion and git services commented on DISPATCH-1358: --- Commit 8257ecfd3b5ace5c0d38019a2d109cf3772affc5 in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8257ecf ] DISPATCH-1358 Removing stand-alone directory. Fixing refresh of console's topology view when there are new or lost connections > Port console to patternfly 4 / React > > > Key: DISPATCH-1358 > URL: https://issues.apache.org/jira/browse/DISPATCH-1358 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.10.0 > > > Initial wireframes are at https://marvelapp.com/1fhc8a26/screen/57601872 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1474) Console message path skips one router hop
[ https://issues.apache.org/jira/browse/DISPATCH-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993951#comment-16993951 ] ASF subversion and git services commented on DISPATCH-1474: --- Commit 9a6eda8fd2103afc7af225f08b5d81643c56c63e in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9a6eda8 ] DISPATCH-1474 Ensure all inter-router links are included in the console's traffic view > Console message path skips one router hop > - > > Key: DISPATCH-1474 > URL: https://issues.apache.org/jira/browse/DISPATCH-1474 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.9.0 > Environment: Fedora 29, Firefox 68.0 (64bit), proton 0.29, dispatch > current master @2bd50. > >Reporter: Charles E. Rolke >Priority: Major > Attachments: dispatch-console-0.9-traffic.png, > edge2-apr5-network-diagram.pdf > > > A test has 12 routers, 8 edge and 4 interior spread across two hosts > connected by a wireless lan. See attached diagrams. > The test client on one host sends messages into edge router EA1 and another > test client on the other host receives messages from INTD. > Viewing this with the console and Message path by address turned on the > message flow bubbles are visible on only four of the five interrouter hops. > Traffic between INTC and INTD never has the traffic flow. > Other tests show the traffic going all the way through the system correctly. > The missing bubbles between INTC and INTD are repeatable. The same test can > be restarted and the traffic is missing on that link. > If traffic enters the system at EC1 (not EA1) then the traffic between INTC > and INTD shows as expected. > --- > Also, router INTD has two edge routers connected to it. In the console app > each interior router has an edge bubble labeled "Edge * 2" but the console > connection to ED1 shows up as a third Edge bubble. I would expect to have > only one bubble labeled "Edge * 2" or two bubbles labeled "Edge". > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1507) Don't collapse small number of edge routers and clients into single circle
[ https://issues.apache.org/jira/browse/DISPATCH-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993949#comment-16993949 ] ASF subversion and git services commented on DISPATCH-1507: --- Commit 12d342f75a50ddd451611c0edbeb1afd26c201a2 in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=12d342f ] DISPATCH-1507 Add Expand/Collapse to group of edge router in console's topology view > Don't collapse small number of edge routers and clients into single circle > -- > > Key: DISPATCH-1507 > URL: https://issues.apache.org/jira/browse/DISPATCH-1507 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.11.0 > > > Currently on the console's topology page, if there are multiple clients of > the same type, they will be collapsed into a single circle with text > indicating the number of clients. > This is also true for edge routers. > This prevents clients attached to edge routers for appearing on the page. > Add a user configurable threshold to the topology page. If the number of > clients/edge routers attached to an interior router is below the threshold, > they will be drawn individually, otherwise they will be collapsed as they are > now. > This would allow traffic to/from edge router to be visualized. > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2161) Provide a means for issuing a Declared disposition state in python binding
[ https://issues.apache.org/jira/browse/PROTON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-2161: Labels: api (was: ) > Provide a means for issuing a Declared disposition state in python binding > -- > > Key: PROTON-2161 > URL: https://issues.apache.org/jira/browse/PROTON-2161 > Project: Qpid Proton > Issue Type: New Feature > Components: python-binding >Affects Versions: proton-c-0.30.0 >Reporter: Ken Giusti >Priority: Major > Labels: api > Fix For: proton-c-0.31.0 > > > While trying to write a qpid-dispatch-router transaction unit test it became > apparent that I could not issue a Declared outcome using the python client. > I was building the test around a stub transaction server that would simply > verify that transactional state is properly transferred via the router. > Having such a test would prevent regressions like > [DISPATCH-1488|https://issues.apache.org/jira/browse/DISPATCH-1488]. > [Incomplete dispatch unit > test|https://github.com/apache/qpid-dispatch/pull/638] > [Declare a > transaction|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transactions-v1.0-os.html#section-txn-declare] > I suspect there are likely additional changes to the python binding in order > to support the entire transaction, which will be necessary for the unit test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2161) Provide a means for issuing a Declared disposition state in python binding
Ken Giusti created PROTON-2161: -- Summary: Provide a means for issuing a Declared disposition state in python binding Key: PROTON-2161 URL: https://issues.apache.org/jira/browse/PROTON-2161 Project: Qpid Proton Issue Type: New Feature Components: python-binding Affects Versions: proton-c-0.30.0 Reporter: Ken Giusti Fix For: proton-c-0.31.0 While trying to write a qpid-dispatch-router transaction unit test it became apparent that I could not issue a Declared outcome using the python client. I was building the test around a stub transaction server that would simply verify that transactional state is properly transferred via the router. Having such a test would prevent regressions like [DISPATCH-1488|https://issues.apache.org/jira/browse/DISPATCH-1488]. [Incomplete dispatch unit test|https://github.com/apache/qpid-dispatch/pull/638] [Declare a transaction|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transactions-v1.0-os.html#section-txn-declare] I suspect there are likely additional changes to the python binding in order to support the entire transaction, which will be necessary for the unit test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1521) qdstat man page -l column header for "dev" is wrong
[ https://issues.apache.org/jira/browse/DISPATCH-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1521. -- Resolution: Fixed > qdstat man page -l column header for "dev" is wrong > --- > > Key: DISPATCH-1521 > URL: https://issues.apache.org/jira/browse/DISPATCH-1521 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.10.0 > > > Should be "deliv" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1517) delivery count is not incremented for undeliverable messages
[ https://issues.apache.org/jira/browse/DISPATCH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1517. -- Resolution: Fixed > delivery count is not incremented for undeliverable messages > > > Key: DISPATCH-1517 > URL: https://issues.apache.org/jira/browse/DISPATCH-1517 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Ken Giusti >Priority: Major > Fix For: 1.10.0 > > Attachments: dispatch-1517.py > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1514) Dynamically turning on trace logging via qdmanage does not turn proton frame tracing on existing connections
[ https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1514. - Resolution: Fixed > Dynamically turning on trace logging via qdmanage does not turn proton frame > tracing on existing connections > > > Key: DISPATCH-1514 > URL: https://issues.apache.org/jira/browse/DISPATCH-1514 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Steps to reproduce - > # Start a router > # Connect a sender and receiver to the router and let them send/receive > message > # While the sender and receiver are sending/receiving, use qdmanage to turn > on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+ > # Notice that the trace logging for the sender and receiver were not turned > on, > # Turning on trace logging must enable proton trace logging on existing > connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing …
asfgit closed pull request #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing … URL: https://github.com/apache/qpid-dispatch/pull/641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1514) Dynamically turning on trace logging via qdmanage does not turn proton frame tracing on existing connections
[ https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993900#comment-16993900 ] ASF subversion and git services commented on DISPATCH-1514: --- Commit 2417e17ddd5c5fc9667c9d9f5170f9bcb38c67a2 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2417e17 ] DISPATCH-1514 - Dynamically turn on proton frame trace on existing connections. This closes #641 > Dynamically turning on trace logging via qdmanage does not turn proton frame > tracing on existing connections > > > Key: DISPATCH-1514 > URL: https://issues.apache.org/jira/browse/DISPATCH-1514 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Steps to reproduce - > # Start a router > # Connect a sender and receiver to the router and let them send/receive > message > # While the sender and receiver are sending/receiving, use qdmanage to turn > on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+ > # Notice that the trace logging for the sender and receiver were not turned > on, > # Turning on trace logging must enable proton trace logging on existing > connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1514) Dynamically turning on trace logging via qdmanage does not turn proton frame tracing on existing connections
[ https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993901#comment-16993901 ] ASF GitHub Bot commented on DISPATCH-1514: -- asfgit commented on pull request #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing … URL: https://github.com/apache/qpid-dispatch/pull/641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dynamically turning on trace logging via qdmanage does not turn proton frame > tracing on existing connections > > > Key: DISPATCH-1514 > URL: https://issues.apache.org/jira/browse/DISPATCH-1514 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Steps to reproduce - > # Start a router > # Connect a sender and receiver to the router and let them send/receive > message > # While the sender and receiver are sending/receiving, use qdmanage to turn > on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+ > # Notice that the trace logging for the sender and receiver were not turned > on, > # Turning on trace logging must enable proton trace logging on existing > connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1516) Trace log the peer delivery id and link id when linking and unlinking peers
[ https://issues.apache.org/jira/browse/DISPATCH-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1516. - Resolution: Fixed > Trace log the peer delivery id and link id when linking and unlinking peers > --- > > Key: DISPATCH-1516 > URL: https://issues.apache.org/jira/browse/DISPATCH-1516 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It is easier to correlate a delivery to its peer and to track the path the > peer took if the function qdr_delivery_link_peers_CT and > qdr_delivery_unlink_peers_CT logged the peer's delivery id and link > identifier if trace logging in turned on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1516) Trace log the peer delivery id and link id when linking and unlinking peers
[ https://issues.apache.org/jira/browse/DISPATCH-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993890#comment-16993890 ] ASF subversion and git services commented on DISPATCH-1516: --- Commit 7819caa3f42f7675ace92e92de21255537a2c30f in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7819caa ] DISPATCH-1516 - Modified log statements to include link identifier. Also logged delivery outcome. This closes #645. > Trace log the peer delivery id and link id when linking and unlinking peers > --- > > Key: DISPATCH-1516 > URL: https://issues.apache.org/jira/browse/DISPATCH-1516 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It is easier to correlate a delivery to its peer and to track the path the > peer took if the function qdr_delivery_link_peers_CT and > qdr_delivery_unlink_peers_CT logged the peer's delivery id and link > identifier if trace logging in turned on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A…
asfgit closed pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A… URL: https://github.com/apache/qpid-dispatch/pull/645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1516) Trace log the peer delivery id and link id when linking and unlinking peers
[ https://issues.apache.org/jira/browse/DISPATCH-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993891#comment-16993891 ] ASF GitHub Bot commented on DISPATCH-1516: -- asfgit commented on pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A… URL: https://github.com/apache/qpid-dispatch/pull/645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Trace log the peer delivery id and link id when linking and unlinking peers > --- > > Key: DISPATCH-1516 > URL: https://issues.apache.org/jira/browse/DISPATCH-1516 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It is easier to correlate a delivery to its peer and to track the path the > peer took if the function qdr_delivery_link_peers_CT and > qdr_delivery_unlink_peers_CT logged the peer's delivery id and link > identifier if trace logging in turned on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1517) delivery count is not incremented for undeliverable messages
[ https://issues.apache.org/jira/browse/DISPATCH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993873#comment-16993873 ] ASF GitHub Bot commented on DISPATCH-1517: -- asfgit commented on pull request #640: DISPATCH-1517: fix delivery count on inbound links URL: https://github.com/apache/qpid-dispatch/pull/640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > delivery count is not incremented for undeliverable messages > > > Key: DISPATCH-1517 > URL: https://issues.apache.org/jira/browse/DISPATCH-1517 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Ken Giusti >Priority: Major > Fix For: 1.10.0 > > Attachments: dispatch-1517.py > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1517) delivery count is not incremented for undeliverable messages
[ https://issues.apache.org/jira/browse/DISPATCH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993872#comment-16993872 ] ASF subversion and git services commented on DISPATCH-1517: --- Commit f2e80d57e0a4430ba28ac06e9af5aeb49702ad27 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f2e80d5 ] DISPATCH-1517: fix delivery count on inbound links This closes #640 > delivery count is not incremented for undeliverable messages > > > Key: DISPATCH-1517 > URL: https://issues.apache.org/jira/browse/DISPATCH-1517 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Ken Giusti >Priority: Major > Fix For: 1.10.0 > > Attachments: dispatch-1517.py > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #640: DISPATCH-1517: fix delivery count on inbound links
asfgit closed pull request #640: DISPATCH-1517: fix delivery count on inbound links URL: https://github.com/apache/qpid-dispatch/pull/640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1521) qdstat man page -l column header for "dev" is wrong
[ https://issues.apache.org/jira/browse/DISPATCH-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993871#comment-16993871 ] ASF GitHub Bot commented on DISPATCH-1521: -- asfgit commented on pull request #644: DISPATCH-1521: update qdstat man page URL: https://github.com/apache/qpid-dispatch/pull/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdstat man page -l column header for "dev" is wrong > --- > > Key: DISPATCH-1521 > URL: https://issues.apache.org/jira/browse/DISPATCH-1521 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.10.0 > > > Should be "deliv" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1521) qdstat man page -l column header for "dev" is wrong
[ https://issues.apache.org/jira/browse/DISPATCH-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993870#comment-16993870 ] ASF subversion and git services commented on DISPATCH-1521: --- Commit f8e882bdf0249bfc1f172b3b056afc8611f819f2 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f8e882b ] DISPATCH-1521: update qdstat man page This closes #644 > qdstat man page -l column header for "dev" is wrong > --- > > Key: DISPATCH-1521 > URL: https://issues.apache.org/jira/browse/DISPATCH-1521 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.10.0 > > > Should be "deliv" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #644: DISPATCH-1521: update qdstat man page
asfgit closed pull request #644: DISPATCH-1521: update qdstat man page URL: https://github.com/apache/qpid-dispatch/pull/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993860#comment-16993860
]
Andrew Stitcher commented on PROTON-1709:
-
the TYPES map is indexed on number (as most events don't really have a name) so
I'd need to add another map to do this whether I do it in EventType or
ApplicationEvent seems somewhat arbitrary.
new named EventTypes are only used by ApplicationEvents anyway.
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: leak
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1514) Dynamically turning on trace logging via qdmanage does not turn proton frame tracing on existing connections
[ https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993856#comment-16993856 ] ASF GitHub Bot commented on DISPATCH-1514: -- codecov-io commented on issue #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing … URL: https://github.com/apache/qpid-dispatch/pull/641#issuecomment-564266612 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=h1) Report > Merging [#641](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d7f8d4d0a774b0914ec86f6113b0126be111fabc?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `90.47%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=tree) ```diff @@Coverage Diff @@ ## master #641 +/- ## == + Coverage86.5% 86.52% +0.02% == Files 91 91 Lines 2063120651 +20 == + Hits1784717869 +22 + Misses 2784 2782 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.15% <100%> (+0.17%)` | :arrow_up: | | [src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL2xvZy5j) | `90.23% <100%> (+0.16%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.32% <84.61%> (-0.03%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.09% <0%> (+0.22%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.23% <0%> (+0.23%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=footer). Last update [d7f8d4d...064f0b7](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Dynamically turning on trace logging via qdmanage does not turn proton frame > tracing on existing connections > > > Key: DISPATCH-1514 > URL: https://issues.apache.org/jira/browse/DISPATCH-1514 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Steps to reproduce - > # Start a router > # Connect a sender and receiver to the router and let them send/receive > message > # While the sender and receiver are sending/receiving, use qdmanage to turn > on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+ > # Notice that the trace logging for the sender and receiver were not turned > on, > # Turning on trace logging must enable proton trace logging on existing > connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing …
codecov-io edited a comment on issue #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing … URL: https://github.com/apache/qpid-dispatch/pull/641#issuecomment-564266612 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=h1) Report > Merging [#641](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d7f8d4d0a774b0914ec86f6113b0126be111fabc?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `90.47%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=tree) ```diff @@Coverage Diff @@ ## master #641 +/- ## == + Coverage86.5% 86.52% +0.02% == Files 91 91 Lines 2063120651 +20 == + Hits1784717869 +22 + Misses 2784 2782 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.15% <100%> (+0.17%)` | :arrow_up: | | [src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL2xvZy5j) | `90.23% <100%> (+0.16%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.32% <84.61%> (-0.03%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.09% <0%> (+0.22%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.23% <0%> (+0.23%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=footer). Last update [d7f8d4d...064f0b7](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1516) Trace log the peer delivery id and link id when linking and unlinking peers
[ https://issues.apache.org/jira/browse/DISPATCH-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993833#comment-16993833 ] ASF GitHub Bot commented on DISPATCH-1516: -- kgiusti commented on pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A… URL: https://github.com/apache/qpid-dispatch/pull/645#discussion_r356779966 ## File path: src/router_core/delivery.c ## @@ -373,6 +376,8 @@ void qdr_delivery_increment_counters_CT(qdr_core_t *core, qdr_delivery_t *delive core->modified_deliveries++; } +qd_log(core->log, QD_LOG_DEBUG, delivery->presettled?"Delivery outcome for pre-settled: dlv:%lx link:%"PRIu64" is %s": "Delivery outcome for: dlv:%lx link:%"PRIu64" is %s", (long) delivery, link->identity, pn_disposition_type_name(outcome)); Review comment: I had to read this a couple of times to figure out what's going on. I'd avoid using a ?: to pick the format argument - that will work but it's clever. Why not use a format string with a %s entry for the part of the output that varies, i.e.: qd_log(..., ..., "Delivery outcome for%s: dlv:%lx link: is %s", (delivery->presettled) ? " pre-settled" : "", ) Note the lack of space between "for" and the ":" in the format string and the leading space before "presettled" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Trace log the peer delivery id and link id when linking and unlinking peers > --- > > Key: DISPATCH-1516 > URL: https://issues.apache.org/jira/browse/DISPATCH-1516 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It is easier to correlate a delivery to its peer and to track the path the > peer took if the function qdr_delivery_link_peers_CT and > qdr_delivery_unlink_peers_CT logged the peer's delivery id and link > identifier if trace logging in turned on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A…
kgiusti commented on a change in pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A… URL: https://github.com/apache/qpid-dispatch/pull/645#discussion_r356779966 ## File path: src/router_core/delivery.c ## @@ -373,6 +376,8 @@ void qdr_delivery_increment_counters_CT(qdr_core_t *core, qdr_delivery_t *delive core->modified_deliveries++; } +qd_log(core->log, QD_LOG_DEBUG, delivery->presettled?"Delivery outcome for pre-settled: dlv:%lx link:%"PRIu64" is %s": "Delivery outcome for: dlv:%lx link:%"PRIu64" is %s", (long) delivery, link->identity, pn_disposition_type_name(outcome)); Review comment: I had to read this a couple of times to figure out what's going on. I'd avoid using a ?: to pick the format argument - that will work but it's clever. Why not use a format string with a %s entry for the part of the output that varies, i.e.: qd_log(..., ..., "Delivery outcome for%s: dlv:%lx link: is %s", (delivery->presettled) ? " pre-settled" : "", ) Note the lack of space between "for" and the ":" in the format string and the leading space before "presettled" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1514) Dynamically turning on trace logging via qdmanage does not turn proton frame tracing on existing connections
[
https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993814#comment-16993814
]
ASF GitHub Bot commented on DISPATCH-1514:
--
kgiusti commented on pull request #641: DISPATCH-1514 - Dynamically turned on
proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770256
##
File path: src/server.c
##
@@ -1276,6 +1277,25 @@ void qd_server_set_container(qd_dispatch_t *qd,
qd_container_t *container)
qd->server->container = container;
}
+void qd_server_trace_all_connections()
+{
+qd_dispatch_t *qd = qd_dispatch_get_dispatch();
+if (qd->server) {
+qd_connection_list_t conn_list = qd->server->conn_list;
+qd_connection_t *conn = DEQ_HEAD(conn_list);
+while(conn) {
Review comment:
the qd->server->conn_list is protected by qd->server->lock. this loop will
need to hold that lock while walking the list or it is possible the connection
it is working on is removed (and possibly freed) by another thread.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dynamically turning on trace logging via qdmanage does not turn proton frame
> tracing on existing connections
>
>
> Key: DISPATCH-1514
> URL: https://issues.apache.org/jira/browse/DISPATCH-1514
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.9.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
>
> Steps to reproduce -
> # Start a router
> # Connect a sender and receiver to the router and let them send/receive
> message
> # While the sender and receiver are sending/receiving, use qdmanage to turn
> on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+
> # Notice that the trace logging for the sender and receiver were not turned
> on,
> # Turning on trace logging must enable proton trace logging on existing
> connections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1514) Dynamically turning on trace logging via qdmanage does not turn proton frame tracing on existing connections
[
https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993815#comment-16993815
]
ASF GitHub Bot commented on DISPATCH-1514:
--
kgiusti commented on pull request #641: DISPATCH-1514 - Dynamically turned on
proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770898
##
File path: src/log.c
##
@@ -541,7 +542,16 @@ qd_error_t qd_log_entity(qd_entity_t *entity) {
if (qd_entity_has(entity, "enable")) {
enable = qd_entity_get_string(entity, "enable");
QD_ERROR_BREAK();
+
src->mask = enable_mask(enable);
+
+//
+// If trace logging is enabled, loop thru all connections in the
router and call the pn_transport_set_tracer callback
+// so proton frame trace can be output as part of the router trace
log.
+//
+if (qd_log_enabled(src, QD_LOG_TRACE)) {
Review comment:
would it be possible to move this outside of the log_source_lock? For
example, just set a flag here then check the flag after dropping the lock and
making the call to qd_server_trace_all_connections() then?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dynamically turning on trace logging via qdmanage does not turn proton frame
> tracing on existing connections
>
>
> Key: DISPATCH-1514
> URL: https://issues.apache.org/jira/browse/DISPATCH-1514
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.9.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
>
> Steps to reproduce -
> # Start a router
> # Connect a sender and receiver to the router and let them send/receive
> message
> # While the sender and receiver are sending/receiving, use qdmanage to turn
> on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+
> # Notice that the trace logging for the sender and receiver were not turned
> on,
> # Turning on trace logging must enable proton trace logging on existing
> connections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing …
kgiusti commented on a change in pull request #641: DISPATCH-1514 - Dynamically
turned on proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770898
##
File path: src/log.c
##
@@ -541,7 +542,16 @@ qd_error_t qd_log_entity(qd_entity_t *entity) {
if (qd_entity_has(entity, "enable")) {
enable = qd_entity_get_string(entity, "enable");
QD_ERROR_BREAK();
+
src->mask = enable_mask(enable);
+
+//
+// If trace logging is enabled, loop thru all connections in the
router and call the pn_transport_set_tracer callback
+// so proton frame trace can be output as part of the router trace
log.
+//
+if (qd_log_enabled(src, QD_LOG_TRACE)) {
Review comment:
would it be possible to move this outside of the log_source_lock? For
example, just set a flag here then check the flag after dropping the lock and
making the call to qd_server_trace_all_connections() then?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #641: DISPATCH-1514 - Dynamically turned on proton frame trace on existing …
kgiusti commented on a change in pull request #641: DISPATCH-1514 - Dynamically
turned on proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770256
##
File path: src/server.c
##
@@ -1276,6 +1277,25 @@ void qd_server_set_container(qd_dispatch_t *qd,
qd_container_t *container)
qd->server->container = container;
}
+void qd_server_trace_all_connections()
+{
+qd_dispatch_t *qd = qd_dispatch_get_dispatch();
+if (qd->server) {
+qd_connection_list_t conn_list = qd->server->conn_list;
+qd_connection_t *conn = DEQ_HEAD(conn_list);
+while(conn) {
Review comment:
the qd->server->conn_list is protected by qd->server->lock. this loop will
need to hold that lock while walking the list or it is possible the connection
it is working on is removed (and possibly freed) by another thread.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993809#comment-16993809
]
Mike Bonnet edited comment on PROTON-1709 at 12/11/19 6:42 PM:
---
It seems like a {{EventType.___new___()}} method could look up an existing
{{EventType}} with the given name in the {{TYPES}} map and return that, only
creating a new instance if one doesn't already exist. If {{number}} and/or
{{method}} were also specified, it would have to check that they match the
existing {{EventType}}, or raise an exception.
was (Author: mbonnet):
It seems like a {{EventType.__new__()}} method could look up an existing
{{EventType}} with the given name in the {{TYPES}} map and return that, only
creating a new instance if one doesn't already exist. If {{number}} and/or
{{method}} were also specified, it would have to check that they match the
existing {{EventType}}, or raise an exception.
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: leak
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993809#comment-16993809
]
Mike Bonnet commented on PROTON-1709:
-
It seems like a {{EventType.__new__()}} method could look up an existing
{{EventType}} with the given name in the {{TYPES}} map and return that, only
creating a new instance if one doesn't already exist. If {{number}} and/or
{{method}} were also specified, it would have to check that they match the
existing {{EventType}}, or raise an exception.
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: leak
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993793#comment-16993793
]
Andrew Stitcher commented on PROTON-1709:
-
Hmm, yes this is a rather serious API flaw.
I think the simplest solution is to allow ApplicationEvent to take an EventType
object as well as a string so that the application can create an EventType and
continue using it.
Alternatively ApplicationEvent could keep a static dictionary of
string->EventTypes instead of creating a new EventType for every new
ApplicationEvent.
Actually probably doing both of these is a good plan.
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: leak
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[ANNOUNCE] Apache Qpid JMS 0.48.0 released
The Apache Qpid (http://qpid.apache.org) community is pleased to announce the immediate availability of Apache Qpid JMS 0.48.0. This is the latest release of our newer JMS client supporting the Advanced Message Queuing Protocol 1.0 (AMQP 1.0, ISO/IEC 19464, http://www.amqp.org), based around the Apache Qpid Proton protocol engine and implementing the AMQP JMS Mapping as it evolves at OASIS. The release is available now from our website: http://qpid.apache.org/download.html Binaries are also available via Maven Central: http://qpid.apache.org/maven.html Release notes can be found at: http://qpid.apache.org/releases/qpid-jms-0.48.0/release-notes.html Thanks to all involved, Robbie - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1516) Trace log the peer delivery id and link id when linking and unlinking peers
[ https://issues.apache.org/jira/browse/DISPATCH-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1516: Summary: Trace log the peer delivery id and link id when linking and unlinking peers (was: Trace log the peer delivery id when linking and unlinking peers) > Trace log the peer delivery id and link id when linking and unlinking peers > --- > > Key: DISPATCH-1516 > URL: https://issues.apache.org/jira/browse/DISPATCH-1516 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It is easier to correlate a delivery to its peer and to track the path the > peer took if the function qdr_delivery_link_peers_CT and > qdr_delivery_unlink_peers_CT logged the peer's delivery id and link > identifier if trace logging in turned on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1516) Trace log the peer delivery id when linking and unlinking peers
[ https://issues.apache.org/jira/browse/DISPATCH-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993780#comment-16993780 ] ASF GitHub Bot commented on DISPATCH-1516: -- ganeshmurthy commented on pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A… URL: https://github.com/apache/qpid-dispatch/pull/645 …lso logged delivery outcome This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Trace log the peer delivery id when linking and unlinking peers > --- > > Key: DISPATCH-1516 > URL: https://issues.apache.org/jira/browse/DISPATCH-1516 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It is easier to correlate a delivery to its peer and to track the path the > peer took if the function qdr_delivery_link_peers_CT and > qdr_delivery_unlink_peers_CT logged the peer's delivery id and link > identifier if trace logging in turned on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A…
ganeshmurthy opened a new pull request #645: DISPATCH-1516 - Modified log statements to include link identifier. A… URL: https://github.com/apache/qpid-dispatch/pull/645 …lso logged delivery outcome This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1516) Trace log the peer delivery id when linking and unlinking peers
[ https://issues.apache.org/jira/browse/DISPATCH-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1516: Description: It is easier to correlate a delivery to its peer and to track the path the peer took if the function qdr_delivery_link_peers_CT and qdr_delivery_unlink_peers_CT logged the peer's delivery id and link identifier if trace logging in turned on. (was: It is easier to correlate a delivery to its peer and to track the path the peer took if the function qdr_delivery_link_peers_CT and qdr_delivery_unlink_peers_CT logged the peer's delivery id if trace logging in turned on.) > Trace log the peer delivery id when linking and unlinking peers > --- > > Key: DISPATCH-1516 > URL: https://issues.apache.org/jira/browse/DISPATCH-1516 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It is easier to correlate a delivery to its peer and to track the path the > peer took if the function qdr_delivery_link_peers_CT and > qdr_delivery_unlink_peers_CT logged the peer's delivery id and link > identifier if trace logging in turned on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross reassigned PROTON-1709:
---
Assignee: Andrew Stitcher (was: Justin Ross)
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Andrew Stitcher
>Priority: Major
> Labels: leak
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] nicob87 closed pull request #643: WIP: simple tests that issues a qdstat command on a router mesh wiht a lot…
nicob87 closed pull request #643: WIP: simple tests that issues a qdstat command on a router mesh wiht a lot… URL: https://github.com/apache/qpid-dispatch/pull/643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1521) qdstat man page -l column header for "dev" is wrong
[ https://issues.apache.org/jira/browse/DISPATCH-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993654#comment-16993654 ] ASF GitHub Bot commented on DISPATCH-1521: -- kgiusti commented on pull request #644: DISPATCH-1521: update qdstat man page URL: https://github.com/apache/qpid-dispatch/pull/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdstat man page -l column header for "dev" is wrong > --- > > Key: DISPATCH-1521 > URL: https://issues.apache.org/jira/browse/DISPATCH-1521 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.10.0 > > > Should be "deliv" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #644: DISPATCH-1521: update qdstat man page
kgiusti opened a new pull request #644: DISPATCH-1521: update qdstat man page URL: https://github.com/apache/qpid-dispatch/pull/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1709) [python] ApplicationEvent causing memory growth
[
https://issues.apache.org/jira/browse/PROTON-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993647#comment-16993647
]
Mike Bonnet commented on PROTON-1709:
-
We have workflows that make extensive use of ApplicationEvents (for running
message handlers in a separate thread, then manually ack'ing via the main
loop), and they will be affected by this issue. Can someone take a look?
> [python] ApplicationEvent causing memory growth
> ---
>
> Key: PROTON-1709
> URL: https://issues.apache.org/jira/browse/PROTON-1709
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Xin Chen
>Assignee: Justin Ross
>Priority: Major
> Labels: leak
>
> ApplicationEvent creates a new EventType object in the constructor. The
> EventType object adds itself to the TYPES dict always, even for the same
> typename. There is no way for the application to avoid this by providing an
> EventType object directly. Repro code below:
> {code:java}
> import threading
> from proton.reactor import Container, ApplicationEvent, EventInjector
> class Program:
> def __init__(self, injector):
> self.injector = injector
> def on_reactor_init(self, event):
> event.reactor.selectable(self.injector)
> def on_hello(self, event):
> print(event.subject)
> def on_done(self, event):
> event.subject.stop()
> e = EventInjector()
> r = Container(Program(e))
> t = threading.Thread(target=r.run)
> t.start()
> for i in range(1, 1000):
> e.trigger(ApplicationEvent("hello", subject=str(i)))
> e.trigger(ApplicationEvent("done", subject=r))
> t.join()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1521) qdstat man page -l column header for "dev" is wrong
Ken Giusti created DISPATCH-1521: Summary: qdstat man page -l column header for "dev" is wrong Key: DISPATCH-1521 URL: https://issues.apache.org/jira/browse/DISPATCH-1521 Project: Qpid Dispatch Issue Type: Bug Components: Tools Affects Versions: 1.9.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.10.0 Should be "deliv" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] nicob87 opened a new pull request #643: WIP: simple tests that issues a qdstat command on a router mesh wiht a lot…
nicob87 opened a new pull request #643: WIP: simple tests that issues a qdstat command on a router mesh wiht a lot… URL: https://github.com/apache/qpid-dispatch/pull/643 - Just reusing the "multireceive.py" file attached in: https://issues.apache.org/jira/browse/DISPATCH-1491 to create a system test, that executes all the procedure to reproduce the error. - WORK IN PROGRESS because: Currently the test takes about 1 minute, probably using other command (than qdstat) and setting a smaller timeout, we can make the test faster, using less connections, and a smaller timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993583#comment-16993583
]
ASF GitHub Bot commented on DISPATCH-1513:
--
ganeshmurthy commented on issue #642: DISPATCH-1513: add LWS flag to allow
plain HTTP on an HTTPS listener.
URL: https://github.com/apache/qpid-dispatch/pull/642#issuecomment-564562413
Compiling this on Fedora 29 gives the following error -
/home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c: In function
‘listener_start’:
/home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c:357:87:
error: ‘LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER’ undeclared (first use
in this function); did you mean ‘LWS_SERVER_OPTION_ALLOW_LISTEN_SHARE’?
(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT |
LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER ) |
^~
LWS_SERVER_OPTION_ALLOW_LISTEN_SHARE
/home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c:357:87:
note: each undeclared identifier is reported only once for each function it
appears in
make[2]: *** [src/CMakeFiles/qpid-dispatch.dir/build.make:978:
src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:987:
src/CMakeFiles/qpid-dispatch.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
[gmurthy@localhost build]$
Looks like the flag LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER was
introduced in libwebsockets 3.2.0 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Michael Goulish
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r =
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #642: DISPATCH-1513: add LWS flag to allow plain HTTP on an HTTPS listener.
ganeshmurthy commented on issue #642: DISPATCH-1513: add LWS flag to allow plain HTTP on an HTTPS listener. URL: https://github.com/apache/qpid-dispatch/pull/642#issuecomment-564562413 Compiling this on Fedora 29 gives the following error - /home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c: In function ‘listener_start’: /home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c:357:87: error: ‘LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER’ undeclared (first use in this function); did you mean ‘LWS_SERVER_OPTION_ALLOW_LISTEN_SHARE’? (config->ssl_required ? 0 : LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT | LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER ) | ^~ LWS_SERVER_OPTION_ALLOW_LISTEN_SHARE /home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c:357:87: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [src/CMakeFiles/qpid-dispatch.dir/build.make:978: src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:987: src/CMakeFiles/qpid-dispatch.dir/all] Error 2 make: *** [Makefile:141: all] Error 2 [gmurthy@localhost build]$ Looks like the flag LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER was introduced in libwebsockets 3.2.0 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993572#comment-16993572
]
ASF GitHub Bot commented on DISPATCH-1513:
--
mgoulish commented on pull request #642: DISPATCH-1513: add LWS flag to allow
plain HTTP on an HTTPS listener.
URL: https://github.com/apache/qpid-dispatch/pull/642
One line fix -- we just need to tell Libwebsockets that we want it to do
this, and it will let us.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Michael Goulish
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] mgoulish opened a new pull request #642: DISPATCH-1513: add LWS flag to allow plain HTTP on an HTTPS listener.
mgoulish opened a new pull request #642: DISPATCH-1513: add LWS flag to allow plain HTTP on an HTTPS listener. URL: https://github.com/apache/qpid-dispatch/pull/642 One line fix -- we just need to tell Libwebsockets that we want it to do this, and it will let us. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
