[webkit-changes] [94767] trunk/LayoutTests
Title: [94767] trunk/LayoutTests Revision 94767 Author a...@apple.com Date 2011-09-08 11:05:05 -0700 (Thu, 08 Sep 2011) Log Message Some file-url-mimetypes subtests fail on rare extensions https://bugs.webkit.org/show_bug.cgi?id=67679 Reviewed by Darin Adler. * platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: * platform/mac/fast/loader/file-url-mimetypes-2.html: * platform/mac/fast/loader/file-url-mimetypes-expected.txt: * platform/mac/fast/loader/file-url-mimetypes.html: It doesn't appear important to investigate why a few subtests fail on some machines, so just removing those. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2.html trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-expected.txt trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes.html Diff Modified: trunk/LayoutTests/ChangeLog (94766 => 94767) --- trunk/LayoutTests/ChangeLog 2011-09-08 17:41:48 UTC (rev 94766) +++ trunk/LayoutTests/ChangeLog 2011-09-08 18:05:05 UTC (rev 94767) @@ -1,5 +1,19 @@ 2011-09-08 Alexey Proskuryakov a...@apple.com +Some file-url-mimetypes subtests fail on rare extensions +https://bugs.webkit.org/show_bug.cgi?id=67679 + +Reviewed by Darin Adler. + +* platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: +* platform/mac/fast/loader/file-url-mimetypes-2.html: +* platform/mac/fast/loader/file-url-mimetypes-expected.txt: +* platform/mac/fast/loader/file-url-mimetypes.html: +It doesn't appear important to investigate why a few subtests fail on some machines, so +just removing those. + +2011-09-08 Alexey Proskuryakov a...@apple.com + Some cookie related tests fail on Lion https://bugs.webkit.org/show_bug.cgi?id=67674 Modified: trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt (94766 => 94767) --- trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt 2011-09-08 17:41:48 UTC (rev 94766) +++ trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt 2011-09-08 18:05:05 UTC (rev 94767) @@ -3,13 +3,11 @@ example-kar.kar has MIME type audio/midi example-l.l has MIME type text/plain example-latex.latex has MIME type application/x-latex -example-lha.lha has MIME type application/octet-stream example-lid.lid has MIME type text/plain example-lm.lm has MIME type text/plain example-lmm.lmm has MIME type text/plain example-lpp.lpp has MIME type text/plain example-lxx.lxx has MIME type text/plain -example-lzh.lzh has MIME type application/octet-stream example-m.m has MIME type text/plain example-m15.m15 has MIME type video/mpeg example-m2v.m2v has MIME type video/mpeg2 Modified: trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2.html (94766 => 94767) --- trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2.html 2011-09-08 17:41:48 UTC (rev 94766) +++ trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2.html 2011-09-08 18:05:05 UTC (rev 94767) @@ -15,13 +15,11 @@ resources/mimeTypeExamples/example-kar.kar, resources/mimeTypeExamples/example-l.l, resources/mimeTypeExamples/example-latex.latex, -resources/mimeTypeExamples/example-lha.lha, resources/mimeTypeExamples/example-lid.lid, resources/mimeTypeExamples/example-lm.lm, resources/mimeTypeExamples/example-lmm.lmm, resources/mimeTypeExamples/example-lpp.lpp, resources/mimeTypeExamples/example-lxx.lxx, -resources/mimeTypeExamples/example-lzh.lzh, resources/mimeTypeExamples/example-m.m, resources/mimeTypeExamples/example-m15.m15, resources/mimeTypeExamples/example-m2v.m2v, Modified: trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-expected.txt (94766 => 94767) --- trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-expected.txt 2011-09-08 17:41:48 UTC (rev 94766) +++ trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes-expected.txt 2011-09-08 18:05:05 UTC (rev 94767) @@ -38,7 +38,6 @@ example-cpgz.cpgz has MIME type application/x-gzip example-cpio.cpio has MIME type application/x-cpio example-cpp.cpp has MIME type text/plain -example-cpt.cpt has MIME type application/mac-compactpro example-cr2.cr2 has MIME type application/octet-stream example-crw.crw has MIME type image/x-canon-crw example-csh.csh has MIME type application/x-csh Modified: trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes.html (94766 => 94767) --- trunk/LayoutTests/platform/mac/fast/loader/file-url-mimetypes.html 2011-09-08 17:41:48
[webkit-changes] [94768] trunk/LayoutTests
Title: [94768] trunk/LayoutTests
Revision 94768
Author hay...@chromium.org
Date 2011-09-08 11:14:59 -0700 (Thu, 08 Sep 2011)
Log Message
Add a layout test for the case where an accesskey is defined in shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=67096
Reviewed by Dimitri Glazkov.
* fast/dom/shadow/access-key-expected.txt: Added.
* fast/dom/shadow/access-key.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/dom/shadow/access-key-expected.txt
trunk/LayoutTests/fast/dom/shadow/access-key.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94767 => 94768)
--- trunk/LayoutTests/ChangeLog 2011-09-08 18:05:05 UTC (rev 94767)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 18:14:59 UTC (rev 94768)
@@ -1,3 +1,14 @@
+2011-09-08 Hayato Ito hay...@chromium.org
+
+Add a layout test for the case where an accesskey is defined in shadow DOM.
+
+https://bugs.webkit.org/show_bug.cgi?id=67096
+
+Reviewed by Dimitri Glazkov.
+
+* fast/dom/shadow/access-key-expected.txt: Added.
+* fast/dom/shadow/access-key.html: Added.
+
2011-09-08 Alexey Proskuryakov a...@apple.com
Some file-url-mimetypes subtests fail on rare extensions
Added: trunk/LayoutTests/fast/dom/shadow/access-key-expected.txt (0 => 94768)
--- trunk/LayoutTests/fast/dom/shadow/access-key-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/access-key-expected.txt 2011-09-08 18:14:59 UTC (rev 94768)
@@ -0,0 +1,13 @@
+Tests to ensure that accesskey works in regard to shadow DOM boundary. Can only run within DRT.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+
+PASS dispatchedEvent(focus) is [inputE]
+PASS dispatchedEvent(focus) is [inputE]
+PASS dispatchedEvent(focus) is [inputE]
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/shadow/access-key.html (0 => 94768)
--- trunk/LayoutTests/fast/dom/shadow/access-key.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/access-key.html 2011-09-08 18:14:59 UTC (rev 94768)
@@ -0,0 +1,111 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+/head
+body
+p id=description/p
+div id=sandbox/div
+pre id=console/pre
+script
+description(Tests to ensure that accesskey works in regard to shadow DOM boundary. Can only run within DRT.);
+
+function pressAccessKey(key)
+{
+if (navigator.userAgent.search(/\bMac OS X\b/) != -1)
+modifiers = [ctrlKey, altKey];
+else
+modifiers = [altKey];
+eventSender.keyDown(key, modifiers);
+}
+
+var eventRecords = {};
+
+function clearEventRecords()
+{
+eventRecords = {};
+}
+
+function dispatchedEvent(eventType)
+{
+var events = eventRecords[eventType];
+if (!events)
+return [];
+return events;
+}
+
+function recordEvent(event)
+{
+var eventType = event.type
+if (!eventRecords[eventType]) {
+eventRecords[eventType] = []
+}
+eventRecords[eventType].push(event.target.id);
+}
+
+function getElementInShadow(path)
+{
+var ids = path.split('/');
+var element = document.getElementById(ids[0]);
+for (var i = 1; element != null i ids.length; ++i) {
+var shadowRoot = internals.shadowRoot(element);
+element = internals.getElementByIdInShadowRoot(shadowRoot, ids[i]);
+}
+return element;
+}
+
+function prepareDomTree(parent)
+{
+parent.appendChild(
+createDom('div', {'id': 'divA'},
+ createDom('input', {'id': 'inputB'}),
+ createShadow('div', {'id': 'shadowC', 'tabindex': 0},
+ createDom('input', {'id': 'inputD'}),
+ createDom('input', {'id': 'inputE', 'accesskey': 'a'}),
+ createShadow('div', {'id': 'shadowF', 'tabindex': 0},
+createDom('input', {'id': 'inputG'});
+
+var ids = ['inputB',
+ 'shadowC/inputD', 'shadowC/inputE',
+ 'shadowC/shadowF/inputG'];
+for (var i = 0; i ids.length; ++i) {
+var element = getElementInShadow(ids[i]);
+element.addEventListener('focus', recordEvent, false);
+}
+}
+
+function test()
+{
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+prepareDomTree(document.getElementById('sandbox'));
+
+// Please see the discussion of https://bugs.webkit.org/show_bug.cgi?id=67096.
+// We don't have a clear idea how accesskey should work in regard to shadow DOM.
+// In current implementation, accesskeys defined inside of components are exposed to an outer document.
+// Every accesskeys are flattened per each document.
+document.getElementById('inputB').focus();
+clearEventRecords();
+pressAccessKey('a');
+shouldBe('dispatchedEvent(focus)', '[inputE]');
+
+getElementInShadow('shadowC/inputD').focus();
+
[webkit-changes] [94771] trunk
Title: [94771] trunk
Revision 94771
Author commit-qu...@webkit.org
Date 2011-09-08 11:28:42 -0700 (Thu, 08 Sep 2011)
Log Message
Implement a ProgressEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67537
Patch by Kentaro Hara hara...@google.com on 2011-09-08
Reviewed by Sam Weinig.
Source/WebCore:
The spec for the ProgressEvent constructor is here:
http://www.w3.org/TR/progress-events/#interface-progressevent
Test: fast/events/constructors/progress-event-constructor.html
* bindings/generic/EventConstructors.h: Added a definition for the ProgressEvent constructor.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Converts an ECMA-262 Number into an IDL unsigned long long value. Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long
* bindings/js/JSEventConstructors.cpp: Added #includes for ProgressEvent.
* dom/ProgressEvent.cpp:
(WebCore::ProgressEventInit::ProgressEventInit):
(WebCore::ProgressEvent::ProgressEvent):
* dom/ProgressEvent.h: Added a definition for ProgressEventInit.
(WebCore::ProgressEvent::create):
* dom/ProgressEvent.idl: Makes ProgressEvent constructible.
LayoutTests:
* fast/events/constructors/progress-event-constructor-expected.txt: Added.
* fast/events/constructors/progress-event-constructor.html: Added. Checks the behavior of the ProgressEvent constructor.
* platform/chromium/test_expectations.txt: Skipped progress-event-constructor.html, since V8 does not yet have the ProgressEvent constructor.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/EventConstructors.h
trunk/Source/WebCore/bindings/js/JSDictionary.cpp
trunk/Source/WebCore/bindings/js/JSEventConstructors.cpp
trunk/Source/WebCore/dom/ProgressEvent.cpp
trunk/Source/WebCore/dom/ProgressEvent.h
trunk/Source/WebCore/dom/ProgressEvent.idl
Added Paths
trunk/LayoutTests/fast/events/constructors/progress-event-constructor-expected.txt
trunk/LayoutTests/fast/events/constructors/progress-event-constructor.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94770 => 94771)
--- trunk/LayoutTests/ChangeLog 2011-09-08 18:22:11 UTC (rev 94770)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 18:28:42 UTC (rev 94771)
@@ -1,3 +1,14 @@
+2011-09-08 Kentaro Hara hara...@google.com
+
+Implement a ProgressEvent constructor for JSC
+https://bugs.webkit.org/show_bug.cgi?id=67537
+
+Reviewed by Sam Weinig.
+
+* fast/events/constructors/progress-event-constructor-expected.txt: Added.
+* fast/events/constructors/progress-event-constructor.html: Added. Checks the behavior of the ProgressEvent constructor.
+* platform/chromium/test_expectations.txt: Skipped progress-event-constructor.html, since V8 does not yet have the ProgressEvent constructor.
+
2011-09-08 Nate Chapin jap...@chromium.org
Rebaseline svg/W3C-SVG-1.1-SE/filters-image-05-f.svg text for chromium win/linux.
Added: trunk/LayoutTests/fast/events/constructors/progress-event-constructor-expected.txt (0 => 94771)
--- trunk/LayoutTests/fast/events/constructors/progress-event-constructor-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/constructors/progress-event-constructor-expected.txt 2011-09-08 18:28:42 UTC (rev 94771)
@@ -0,0 +1,67 @@
+This tests the constructor for the ProgressEvent DOM class.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS new ProgressEvent('eventType').bubbles is false
+PASS new ProgressEvent('eventType').cancelable is false
+PASS new ProgressEvent('eventType').lengthComputable is false
+PASS new ProgressEvent('eventType').loaded is 0
+PASS new ProgressEvent('eventType').total is 0
+PASS new ProgressEvent('eventType', { bubbles: false }).bubbles is false
+PASS new ProgressEvent('eventType', { bubbles: true }).bubbles is true
+PASS new ProgressEvent('eventType', { cancelable: false }).cancelable is false
+PASS new ProgressEvent('eventType', { cancelable: true }).cancelable is true
+PASS new ProgressEvent('eventType', { lengthComputable: false }).lengthComputable is false
+PASS new ProgressEvent('eventType', { lengthComputable: true }).lengthComputable is true
+PASS new ProgressEvent('eventType', { loaded: 0 }).loaded is 0
+PASS new ProgressEvent('eventType', { loaded: 1 }).loaded is 1
+PASS new ProgressEvent('eventType', { loaded: 9007199254740990 }).loaded is 9007199254740990
+PASS new ProgressEvent('eventType', { loaded: 9007199254740991 }).loaded is 9007199254740991
+PASS new ProgressEvent('eventType', { loaded: 18446744073709551615 }).loaded is 0
+PASS new ProgressEvent('eventType', { loaded: 12345678901234567890 }).loaded is 12345678901234567168
+PASS new ProgressEvent('eventType', { loaded: -1 }).loaded is 18446744073709551615
+PASS new ProgressEvent('eventType', { loaded: NaN }).loaded is 0
+PASS new ProgressEvent('eventType', { loaded: 123.45
[webkit-changes] [94772] trunk
Title: [94772] trunk
Revision 94772
Author commit-qu...@webkit.org
Date 2011-09-08 11:30:40 -0700 (Thu, 08 Sep 2011)
Log Message
Split Tap gesture detection into TapDown and Tap.
We need this distinction to highlight links when they are first touched. The link is
followed only if the tap is completed, otherwise, if a scroll is detected, the highlight
goes away.
https://bugs.webkit.org/show_bug.cgi?id=67645
Patch by Varun Jain varunj...@google.com on 2011-09-08
Reviewed by Dimitri Glazkov.
* Source/WebCore/page/EventHandler.cpp:
* Source/WebCore/platform/PlatformGestureEvent.h:
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/platform/PlatformGestureEvent.h
trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp
trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.h
trunk/Source/WebCore/platform/chromium/PopupContainer.cpp
trunk/Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp
Diff
Modified: trunk/ChangeLog (94771 => 94772)
--- trunk/ChangeLog 2011-09-08 18:28:42 UTC (rev 94771)
+++ trunk/ChangeLog 2011-09-08 18:30:40 UTC (rev 94772)
@@ -1,3 +1,16 @@
+2011-09-08 Varun Jain varunj...@google.com
+
+Split Tap gesture detection into TapDown and Tap.
+We need this distinction to highlight links when they are first touched. The link is
+followed only if the tap is completed, otherwise, if a scroll is detected, the highlight
+goes away.
+https://bugs.webkit.org/show_bug.cgi?id=67645
+
+Reviewed by Dimitri Glazkov.
+
+* Source/WebCore/page/EventHandler.cpp:
+* Source/WebCore/platform/PlatformGestureEvent.h:
+
2011-09-07 Alexei Svitkine asvitk...@chromium.org
Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
Modified: trunk/Source/WebCore/page/EventHandler.cpp (94771 => 94772)
--- trunk/Source/WebCore/page/EventHandler.cpp 2011-09-08 18:28:42 UTC (rev 94771)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2011-09-08 18:30:40 UTC (rev 94772)
@@ -2209,6 +2209,8 @@
// end gesture as well.
switch (gestureEvent.type()) {
+case PlatformGestureEvent::TapDownType:
+break;
case PlatformGestureEvent::TapType: {
// FIXME: Refactor this code to not hit test multiple times once hit testing has been corrected as suggested above.
PlatformMouseEvent fakeMouseMove(gestureEvent.position(), gestureEvent.globalPosition(), NoButton, MouseEventMoved, /* clickCount */ 1, gestureEvent.shiftKey(), gestureEvent.ctrlKey(), gestureEvent.altKey(), gestureEvent.metaKey(), gestureEvent.timestamp());
Modified: trunk/Source/WebCore/platform/PlatformGestureEvent.h (94771 => 94772)
--- trunk/Source/WebCore/platform/PlatformGestureEvent.h 2011-09-08 18:28:42 UTC (rev 94771)
+++ trunk/Source/WebCore/platform/PlatformGestureEvent.h 2011-09-08 18:30:40 UTC (rev 94772)
@@ -38,7 +38,8 @@
ScrollBeginType,
ScrollEndType,
ScrollUpdateType,
-TapType
+TapType,
+TapDownType,
};
PlatformGestureEvent()
Modified: trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp (94771 => 94772)
--- trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp 2011-09-08 18:28:42 UTC (rev 94771)
+++ trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp 2011-09-08 18:30:40 UTC (rev 94772)
@@ -92,6 +92,11 @@
return manhattanDistance maximumTouchMoveInPixelsForClick;
}
+void GestureRecognizerChromium::appendTapDownGestureEvent(const PlatformTouchPoint touchPoint, Gestures gestures)
+{
+gestures-append(PlatformGestureEvent(PlatformGestureEvent::TapDownType, m_firstTouchPosition, m_firstTouchScreenPosition, m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
+}
+
void GestureRecognizerChromium::appendClickGestureEvent(const PlatformTouchPoint touchPoint, Gestures gestures)
{
gestures-append(PlatformGestureEvent(PlatformGestureEvent::TapType, m_firstTouchPosition, m_firstTouchScreenPosition, m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
@@ -160,7 +165,7 @@
bool GestureRecognizerChromium::touchDown(const PlatformTouchPoint touchPoint, Gestures gestures)
{
setState(PendingSyntheticClick);
-// FIXME: Divide TapType into down and up events.
+appendTapDownGestureEvent(touchPoint, gestures);
return false;
}
Modified: trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.h (94771 => 94772)
--- trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.h 2011-09-08 18:28:42 UTC (rev 94771)
+++ trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.h 2011-09-08 18:30:40 UTC (rev 94772)
@@ -66,6 +66,7 @@
static unsigned int signature(State, unsigned, PlatformTouchPoint::State, bool);
void addEdgeFunction(State, unsigned finger,
[webkit-changes] [94774] trunk/Source/JavaScriptCore
Title: [94774] trunk/Source/_javascript_Core
Revision 94774
Author commit-qu...@webkit.org
Date 2011-09-08 11:41:55 -0700 (Thu, 08 Sep 2011)
Log Message
Remove getUInt32 from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67691
Patch by Mark Hahnenberg mhahnenb...@apple.com on 2011-09-08
Reviewed by Oliver Hunt.
We don't use JSCell::getUInt32 anymore, so it has been removed.
* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94773 => 94774)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-08 18:41:55 UTC (rev 94774)
@@ -1,3 +1,17 @@
+2011-09-08 Mark Hahnenberg mhahnenb...@apple.com
+
+Remove getUInt32 from JSCell
+https://bugs.webkit.org/show_bug.cgi?id=67691
+
+Reviewed by Oliver Hunt.
+
+ We don't use JSCell::getUInt32 anymore, so it has been removed.
+
+* _javascript_Core.exp:
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+* runtime/JSCell.cpp:
+* runtime/JSCell.h:
+
2011-09-07 Filip Pizlo fpi...@apple.com
PPC build fix.
Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (94773 => 94774)
--- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-08 18:41:55 UTC (rev 94774)
@@ -547,7 +547,6 @@
__ZNK3JSC6JSCell8toStringEPNS_9ExecStateE
__ZNK3JSC6JSCell9getStringEPNS_9ExecStateE
__ZNK3JSC6JSCell9getStringEPNS_9ExecStateERNS_7UStringE
-__ZNK3JSC6JSCell9getUInt32ERj
__ZNK3JSC6JSCell9toBooleanEPNS_9ExecStateE
__ZNK3JSC7ArgList8getSliceEiRS0_
__ZNK3JSC7JSArray12subclassDataEv
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (94773 => 94774)
--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-09-08 18:41:55 UTC (rev 94774)
@@ -212,7 +212,6 @@
?getSlice@ArgList@JSC@@QBEXHAAV12@@Z
?getString@JSCell@JSC@@QBE?AVUString@2@PAVExecState@2@@Z
?getString@JSCell@JSC@@QBE_NPAVExecState@2@AAVUString@2@@Z
-?getUInt32@JSCell@JSC@@UBE_NAAI@Z
?getter@PropertyDescriptor@JSC@@QBE?AVJSValue@2@XZ
?globalExec@JSGlobalObject@JSC@@QAEPAVExecState@2@XZ
?globalObjectCount@Heap@JSC@@QAEIXZ
Modified: trunk/Source/_javascript_Core/runtime/JSCell.cpp (94773 => 94774)
--- trunk/Source/_javascript_Core/runtime/JSCell.cpp 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/runtime/JSCell.cpp 2011-09-08 18:41:55 UTC (rev 94774)
@@ -30,11 +30,6 @@
namespace JSC {
-bool JSCell::getUInt32(uint32_t) const
-{
-return false;
-}
-
bool JSCell::getString(ExecState* exec, UStringstringValue) const
{
if (!isString())
Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (94773 => 94774)
--- trunk/Source/_javascript_Core/runtime/JSCell.h 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h 2011-09-08 18:41:55 UTC (rev 94774)
@@ -103,10 +103,6 @@
virtual CallType getCallData(CallData);
virtual ConstructType getConstructData(ConstructData);
-// Extracting integer values.
-// FIXME: remove these methods, can check isNumberCell in JSValue then call asNumberCell::*.
-virtual bool getUInt32(uint32_t) const;
-
// Basic conversions.
virtual JSValue toPrimitive(ExecState*, PreferredPrimitiveType) const;
virtual bool getPrimitiveNumber(ExecState*, double number, JSValue);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94776] trunk/Source/WebCore
Title: [94776] trunk/Source/WebCore Revision 94776 Author jchaffr...@webkit.org Date 2011-09-08 11:53:02 -0700 (Thu, 08 Sep 2011) Log Message Factor out the code to get the first non-null RenderTableSection in RenderTable https://bugs.webkit.org/show_bug.cgi?id=66972 Reviewed by Darin Adler. Refactoring only, covered by existing tests. * accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cellForColumnAndRow): * accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::rowIndexRange): Updated those for the signature change in sectionBelow. Also added a FIXME where topSection should be used instead of iterating over the section (and likely missing some corner cases). * rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): * rendering/RenderTable.cpp: (WebCore::RenderTable::calcBorderStart): (WebCore::RenderTable::calcBorderEnd): (WebCore::RenderTable::outerBorderBefore): (WebCore::RenderTable::sectionAbove): (WebCore::RenderTable::sectionBelow): (WebCore::RenderTable::firstLineBoxBaseline): Updated all those functions to use the newly added functions. Also changed the variable names to match the functions. (WebCore::RenderTable::layout): (WebCore::RenderTable::topNonEmptySection): Newly added function that returns the top non null section of the table that has at least a row. (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): Update the signature of those 2 functions to take an enum as it makes the rest of the code more readable. * rendering/RenderTable.h: (WebCore::RenderTable::topSection): Newly added function to return the top non null section in the table. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityTable.cpp trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp trunk/Source/WebCore/rendering/FixedTableLayout.cpp trunk/Source/WebCore/rendering/RenderTable.cpp trunk/Source/WebCore/rendering/RenderTable.h Diff Modified: trunk/Source/WebCore/ChangeLog (94775 => 94776) --- trunk/Source/WebCore/ChangeLog 2011-09-08 18:46:01 UTC (rev 94775) +++ trunk/Source/WebCore/ChangeLog 2011-09-08 18:53:02 UTC (rev 94776) @@ -1,3 +1,47 @@ +2011-09-08 Julien Chaffraix jchaffr...@webkit.org + +Factor out the code to get the first non-null RenderTableSection in RenderTable +https://bugs.webkit.org/show_bug.cgi?id=66972 + +Reviewed by Darin Adler. + +Refactoring only, covered by existing tests. + +* accessibility/AccessibilityTable.cpp: +(WebCore::AccessibilityTable::addChildren): +(WebCore::AccessibilityTable::cellForColumnAndRow): +* accessibility/AccessibilityTableCell.cpp: +(WebCore::AccessibilityTableCell::rowIndexRange): +Updated those for the signature change in sectionBelow. Also added +a FIXME where topSection should be used instead of iterating +over the section (and likely missing some corner cases). + +* rendering/FixedTableLayout.cpp: +(WebCore::FixedTableLayout::calcWidthArray): +* rendering/RenderTable.cpp: +(WebCore::RenderTable::calcBorderStart): +(WebCore::RenderTable::calcBorderEnd): +(WebCore::RenderTable::outerBorderBefore): +(WebCore::RenderTable::sectionAbove): +(WebCore::RenderTable::sectionBelow): +(WebCore::RenderTable::firstLineBoxBaseline): +Updated all those functions to use the newly added functions. Also changed +the variable names to match the functions. + +(WebCore::RenderTable::layout): +(WebCore::RenderTable::topNonEmptySection): Newly added function +that returns the top non null section of the table that has at least a +row. + +(WebCore::RenderTable::cellAbove): +(WebCore::RenderTable::cellBelow): +Update the signature of those 2 functions to take an enum as it makes the +rest of the code more readable. + +* rendering/RenderTable.h: +(WebCore::RenderTable::topSection): Newly added function to return +the top non null section in the table. + 2011-04-19 Eric Seidel e...@webkit.org Reviewed by Ryosuke Niwa. Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (94775 => 94776) --- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2011-09-08 18:46:01 UTC (rev 94775) +++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2011-09-08 18:53:02 UTC (rev 94776) @@ -299,6 +299,7 @@ // go through all the available sections to pull out the rows // and add them as children +// FIXME: This will skip a table with just a tfoot. Should fix by using RenderTable::topSection. RenderTableSection* tableSection = table-header(); if (!tableSection) tableSection = table-firstBody(); @@ -343,7 +344,7 @@ } } -tableSection =
[webkit-changes] [94777] trunk/Source/WebCore
Title: [94777] trunk/Source/WebCore
Revision 94777
Author jchaffr...@webkit.org
Date 2011-09-08 11:54:33 -0700 (Thu, 08 Sep 2011)
Log Message
Remove LayoutStateDisabler instances from RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=66896
Reviewed by Simon Fraser.
As part of r93614, scrollTo does not call updateLayerPositions anymore.
This means that we don't need to disable LayoutState from the scrolling code
in RenderLayer.
This change is covered by the existing tests.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Updated the comment
that was not accurate anymore. Also explained what is wrong with
LayoutState vs RenderLayer now. Note that the ASSERT is still
valid and will not trigger as the remaining calls to updateLayerPositions
are done *outside* layout() where LayoutState is not set (thus disabled).
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed
2 LayoutStateDisabler surrounding scrollToOffset.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94776 => 94777)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 18:53:02 UTC (rev 94776)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 18:54:33 UTC (rev 94777)
@@ -1,5 +1,28 @@
2011-09-08 Julien Chaffraix jchaffr...@webkit.org
+Remove LayoutStateDisabler instances from RenderLayer
+https://bugs.webkit.org/show_bug.cgi?id=66896
+
+Reviewed by Simon Fraser.
+
+As part of r93614, scrollTo does not call updateLayerPositions anymore.
+This means that we don't need to disable LayoutState from the scrolling code
+in RenderLayer.
+
+This change is covered by the existing tests.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::updateLayerPositions): Updated the comment
+that was not accurate anymore. Also explained what is wrong with
+LayoutState vs RenderLayer now. Note that the ASSERT is still
+valid and will not trigger as the remaining calls to updateLayerPositions
+are done *outside* layout() where LayoutState is not set (thus disabled).
+
+(WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed
+2 LayoutStateDisabler surrounding scrollToOffset.
+
+2011-09-08 Julien Chaffraix jchaffr...@webkit.org
+
Factor out the code to get the first non-null RenderTableSection in RenderTable
https://bugs.webkit.org/show_bug.cgi?id=66972
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (94776 => 94777)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-09-08 18:53:02 UTC (rev 94776)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-09-08 18:54:33 UTC (rev 94777)
@@ -334,8 +334,9 @@
if (m_hasVisibleContent) {
RenderView* view = renderer()-view();
ASSERT(view);
-// FIXME: Optimize using LayoutState and remove LayoutStateDisabler instantiation
-// from updateScrollInfoAfterLayout().
+// FIXME: LayoutState does not work with RenderLayers as there is not a 1-to-1
+// mapping between them and the RenderObjects. It would be neat to enable
+// LayoutState outside the layout() phase and use it here.
ASSERT(!view-layoutStateEnabled());
RenderBoxModelObject* repaintContainer = renderer()-containerForRepaint();
@@ -2247,15 +2248,8 @@
// to pull our scroll offsets back to the max (or push them up to the min).
LayoutUnit newX = maxLayoutUnit(0, min(scrollXOffset(), scrollWidth() - box-clientWidth()));
LayoutUnit newY = maxLayoutUnit(0, min(scrollYOffset(), scrollHeight() - box-clientHeight()));
-if (newX != scrollXOffset() || newY != scrollYOffset()) {
-RenderView* view = renderer()-view();
-ASSERT(view);
-// scrollToOffset() may call updateLayerPositions(), which doesn't work
-// with LayoutState.
-// FIXME: Remove the LayoutStateDisabler instantiation if the above changes.
-LayoutStateDisabler layoutStateDisabler(view);
+if (newX != scrollXOffset() || newY != scrollYOffset())
scrollToOffset(newX, newY);
-}
}
bool haveHorizontalBar = m_hBar;
@@ -2328,11 +2322,7 @@
m_vBar-setProportion(clientHeight, m_scrollSize.height());
}
-RenderView* view = renderer()-view();
-{
-LayoutStateDisabler layoutStateDisabler(view);
-scrollToOffset(scrollXOffset(), scrollYOffset());
-}
+scrollToOffset(scrollXOffset(), scrollYOffset());
if (renderer()-node() renderer()-document()-hasListenerType(Document::OVERFLOWCHANGED_LISTENER))
updateOverflowStatus(horizontalOverflow, verticalOverflow);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94778] trunk/Source/WebCore
Title: [94778] trunk/Source/WebCore
Revision 94778
Author commit-qu...@webkit.org
Date 2011-09-08 12:18:43 -0700 (Thu, 08 Sep 2011)
Log Message
Refactor hyphen measurement
https://bugs.webkit.org/show_bug.cgi?id=67728
Patch by Ned Holbrook nholbr...@apple.com on 2011-09-08
Reviewed by Darin Adler.
No new tests, purely refactoring.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::measureHyphenWidth): Added.
(WebCore::setLogicalWidthForTextRun): Use measureHyphenWidth().
(WebCore::tryHyphenating): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94777 => 94778)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 18:54:33 UTC (rev 94777)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 19:18:43 UTC (rev 94778)
@@ -1,3 +1,18 @@
+2011-09-08 Ned Holbrook nholbr...@apple.com
+
+Refactor hyphen measurement
+https://bugs.webkit.org/show_bug.cgi?id=67728
+
+Reviewed by Darin Adler.
+
+No new tests, purely refactoring.
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::measureHyphenWidth): Added.
+(WebCore::setLogicalWidthForTextRun): Use measureHyphenWidth().
+(WebCore::tryHyphenating): Ditto.
+(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.
+
2011-09-08 Julien Chaffraix jchaffr...@webkit.org
Remove LayoutStateDisabler instances from RenderLayer
Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (94777 => 94778)
--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2011-09-08 18:54:33 UTC (rev 94777)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2011-09-08 19:18:43 UTC (rev 94778)
@@ -478,6 +478,12 @@
setMarginEndForChild(renderer, -endOverhang);
}
+static inline float measureHyphenWidth(RenderText* renderer, const Font font)
+{
+RenderStyle* style = renderer-style();
+return font.width(RenderBlock::constructTextRun(renderer, font, style-hyphenString().string(), style));
+}
+
static inline void setLogicalWidthForTextRun(RootInlineBox* lineBox, BidiRun* run, RenderText* renderer, float xPos, const LineInfo lineInfo,
GlyphOverflowAndFallbackFontsMap textBoxDataMap, VerticalPositionCache verticalPositionCache)
{
@@ -500,9 +506,8 @@
int hyphenWidth = 0;
if (toInlineTextBox(run-m_box)-hasHyphen()) {
-const AtomicString hyphenString = renderer-style()-hyphenString();
const Font font = renderer-style(lineInfo.isFirstLine())-font();
-hyphenWidth = font.width(RenderBlock::constructTextRun(renderer, font, hyphenString.string(), renderer-style()));
+hyphenWidth = measureHyphenWidth(renderer, font);
}
run-m_box-setLogicalWidth(renderer-width(run-m_start, run-m_stop - run-m_start, xPos, lineInfo.isFirstLine(), fallbackFonts, glyphOverflow) + hyphenWidth);
if (!fallbackFonts.isEmpty()) {
@@ -1753,8 +1758,7 @@
if (consecutiveHyphenatedLinesLimit = 0 consecutiveHyphenatedLines = static_castunsigned(consecutiveHyphenatedLinesLimit))
return;
-const AtomicString hyphenString = text-style()-hyphenString();
-int hyphenWidth = font.width(RenderBlock::constructTextRun(text, font, hyphenString.string(), text-style()));
+int hyphenWidth = measureHyphenWidth(text, font);
float maxPrefixWidth = availableWidth - xPos - hyphenWidth - lastSpaceWordSpacing;
// If the maximum width available for the prefix before the hyphen is small, then it is very unlikely
@@ -2254,8 +2258,7 @@
lineInfo.setEmpty(false);
if (c == softHyphen autoWrap !hyphenWidth style-hyphens() != HyphensNone) {
-const AtomicString hyphenString = style-hyphenString();
-hyphenWidth = f.width(constructTextRun(t, f, hyphenString.string(), current.m_obj-style()));
+hyphenWidth = measureHyphenWidth(t, f);
width.addUncommittedWidth(hyphenWidth);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94779] trunk
Title: [94779] trunk Revision 94779 Author fsam...@chromium.org Date 2011-09-08 12:20:27 -0700 (Thu, 08 Sep 2011) Log Message Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms https://bugs.webkit.org/show_bug.cgi?id=67723 Reviewed by Adam Barth. Tools: * DumpRenderTree/chromium/EventSender.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::enableFixedLayoutMode): (LayoutTestController::setFixedLayoutSize): * DumpRenderTree/chromium/LayoutTestController.h: LayoutTests: * platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added. * platform/chromium/fast/repaint/fixed-layout-360x240-expected.txt: Added. * platform/chromium/fast/repaint/fixed-layout-360x240.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/EventSender.h trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h Added Paths trunk/LayoutTests/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png trunk/LayoutTests/platform/chromium/fast/repaint/fixed-layout-360x240-expected.txt trunk/LayoutTests/platform/chromium/fast/repaint/fixed-layout-360x240.html Diff Modified: trunk/LayoutTests/ChangeLog (94778 => 94779) --- trunk/LayoutTests/ChangeLog 2011-09-08 19:18:43 UTC (rev 94778) +++ trunk/LayoutTests/ChangeLog 2011-09-08 19:20:27 UTC (rev 94779) @@ -1,3 +1,14 @@ +2011-09-08 Fady Samuel fsam...@chromium.org + +Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms +https://bugs.webkit.org/show_bug.cgi?id=67723 + +Reviewed by Adam Barth. + +* platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added. +* platform/chromium/fast/repaint/fixed-layout-360x240-expected.txt: Added. +* platform/chromium/fast/repaint/fixed-layout-360x240.html: Added. + 2011-04-19 Eric Seidel e...@webkit.org Reviewed by Ryosuke Niwa. Added: trunk/LayoutTests/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png (0 => 94779) --- trunk/LayoutTests/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png 2011-09-08 19:20:27 UTC (rev 94779) @@ -0,0 +1,6 @@ +\x89PNG + + +IHDR X ' )tEXtchecksum c89d5b5fda7d7a82ab60eaaafcd7abaf\x94Y\xAB8 +\xB7IDATx\x9C\xED\xD8\xC1 \x80@A\xCF\xC45\xF35\xA1\xE1D\xAA\x98g3\xEB\xB8\x80W\xE6\x9A\xDD \xED\xDC= \xE0o @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4\xD6\xCC\xEC\xDE \xF0+ , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88
[webkit-changes] [94780] trunk
Title: [94780] trunk
Revision 94780
Author crog...@google.com
Date 2011-09-08 12:22:59 -0700 (Thu, 08 Sep 2011)
Log Message
Check AudioContext createChannelMerger() for thread safety
https://bugs.webkit.org/show_bug.cgi?id=67247
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/audiochannelmerger-stereo.html
* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::process):
(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):
* webaudio/AudioChannelMerger.h:
LayoutTests:
* webaudio/audiochannelmerger-stereo-expected.txt: Added.
* webaudio/audiochannelmerger-stereo.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioChannelMerger.cpp
trunk/Source/WebCore/webaudio/AudioChannelMerger.h
Added Paths
trunk/LayoutTests/webaudio/audiochannelmerger-stereo-expected.txt
trunk/LayoutTests/webaudio/audiochannelmerger-stereo.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94779 => 94780)
--- trunk/LayoutTests/ChangeLog 2011-09-08 19:20:27 UTC (rev 94779)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 19:22:59 UTC (rev 94780)
@@ -1,3 +1,13 @@
+2011-09-08 Chris Rogers crog...@google.com
+
+Check AudioContext createChannelMerger() for thread safety
+https://bugs.webkit.org/show_bug.cgi?id=67247
+
+Reviewed by Kenneth Russell.
+
+* webaudio/audiochannelmerger-stereo-expected.txt: Added.
+* webaudio/audiochannelmerger-stereo.html: Added.
+
2011-09-08 Fady Samuel fsam...@chromium.org
Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
Added: trunk/LayoutTests/webaudio/audiochannelmerger-stereo-expected.txt (0 => 94780)
--- trunk/LayoutTests/webaudio/audiochannelmerger-stereo-expected.txt (rev 0)
+++ trunk/LayoutTests/webaudio/audiochannelmerger-stereo-expected.txt 2011-09-08 19:22:59 UTC (rev 94780)
@@ -0,0 +1,9 @@
+Tests audio channel merging of two mono streams into a single stereo stream.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+PASS Correctly merged from two mono streams to stereo.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/webaudio/audiochannelmerger-stereo.html (0 => 94780)
--- trunk/LayoutTests/webaudio/audiochannelmerger-stereo.html (rev 0)
+++ trunk/LayoutTests/webaudio/audiochannelmerger-stereo.html 2011-09-08 19:22:59 UTC (rev 94780)
@@ -0,0 +1,117 @@
+!DOCTYPE html
+
+!--
+Tests that that we can merge two mono streams into a stereo stream.
+--
+
+html
+head
+link rel=stylesheet href=""
+script src=""
+script type=text/_javascript_ src=""
+script type=text/_javascript_ src=""
+/head
+
+body
+
+div id=description/div
+div id=console/div
+
+script
+description(Tests audio channel merging of two mono streams into a single stereo stream.);
+
+var sampleRate = 44100.0;
+var lengthInSampleFrames = 512;
+
+var context = 0;
+var bufferLoader = 0;
+var buffer1;
+var buffer2;
+var bufferSource1;
+var bufferSource2;
+var channelMerger;
+
+function createBufferWithDCOffset(length, sampleRate, offset) {
+var buffer = context.createBuffer(1, length, sampleRate);
+var data = ""
+for (var i = 0; i buffer.length; ++i)
+data[i] = offset;
+
+return buffer;
+}
+
+// checkResult() checks that the rendered buffer is stereo and that the left channel is all -1 and right channel all +1.
+function checkResult(event) {
+var buffer = event.renderedBuffer;
+
+var success = true;
+
+if (buffer.numberOfChannels == 2) {
+var bufferDataL = buffer.getChannelData(0);
+var bufferDataR = buffer.getChannelData(1);
+
+// Go through every sample and make sure it's all -1 for the left-channel, and all +1 for the right-channel.
+for (var i = 0; i buffer.length; ++i) {
+if (bufferDataL[i] != -1 || bufferDataR[i] != 1) {
+success = false;
+break;
+}
+}
+} else {
+success = false;
+}
+
+if (success) {
+testPassed(Correctly merged from two mono streams to stereo.);
+} else {
+testFailed(Merging error from two mono streams to stereo.);
+}
+
+finishJSTest();
+}
+
+function runTest() {
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+window.jsTestIsAsync = true;
+
+// Create stereo offline audio context.
+context = new webkitAudioContext(2, lengthInSampleFrames, sampleRate);
+
+// Create two mono buffers, one having all -1 values, the other all +1.
+buffer1 = createBufferWithDCOffset(lengthInSampleFrames, sampleRate, -1);
+buffer2 = createBufferWithDCOffset(lengthInSampleFrames, sampleRate, 1);
+
+// Create a buffer source for each of these buffers.
+bufferSource1 =
[webkit-changes] [94781] trunk
Title: [94781] trunk Revision 94781 Author a...@chromium.org Date 2011-09-08 12:38:18 -0700 (Thu, 08 Sep 2011) Log Message Move Element.contains to Node https://bugs.webkit.org/show_bug.cgi?id=67651 Reviewed by Darin Adler. This moves the contains method from Element to Node as in the DOM4 working draft: http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-contains This also special cases Document contains to make it O(1) instead of O(depth). Source/WebCore: Tests: fast/dom/Node/contains-method.html perf/document-contains.html * dom/Element.idl: * dom/Node.cpp: (WebCore::Node::contains): Added document special case. * dom/Node.idl: * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Added a null check. LayoutTests: * fast/dom/Element/contains-method-expected.txt: Removed. * fast/dom/Element/script-tests/contains-method.js: Removed. * fast/dom/Node/contains-method-expected.txt: Added. * fast/dom/Node/contains-method.html: Renamed from LayoutTests/fast/dom/Element/contains-method.html. * fast/dom/Node/script-tests/contains-method.js: Added. Expanded tests. * fast/dom/Window/window-properties-expected.txt: * perf/document-contains-expected.txt: Added. * perf/document-contains.html: Added. Perf test to ensure that document.contains is O(1). * platform/gtk/fast/dom/Window/window-properties-expected.txt: * platform/mac/fast/dom/Window/window-properties-expected.txt: * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-properties-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.idl trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.idl trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp Added Paths trunk/LayoutTests/fast/dom/Node/contains-method-expected.txt trunk/LayoutTests/fast/dom/Node/contains-method.html trunk/LayoutTests/fast/dom/Node/script-tests/contains-method.js trunk/LayoutTests/perf/document-contains-expected.txt trunk/LayoutTests/perf/document-contains.html Removed Paths trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt trunk/LayoutTests/fast/dom/Element/contains-method.html trunk/LayoutTests/fast/dom/Element/script-tests/contains-method.js Diff Modified: trunk/LayoutTests/ChangeLog (94780 => 94781) --- trunk/LayoutTests/ChangeLog 2011-09-08 19:22:59 UTC (rev 94780) +++ trunk/LayoutTests/ChangeLog 2011-09-08 19:38:18 UTC (rev 94781) @@ -1,3 +1,29 @@ +2011-09-08 Erik Arvidsson a...@chromium.org + +Move Element.contains to Node +https://bugs.webkit.org/show_bug.cgi?id=67651 + +Reviewed by Darin Adler. + +This moves the contains method from Element to Node as in the DOM4 working draft: +http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-contains + +This also special cases Document contains to make it O(1) instead of O(depth). + +* fast/dom/Element/contains-method-expected.txt: Removed. +* fast/dom/Element/script-tests/contains-method.js: Removed. +* fast/dom/Node/contains-method-expected.txt: Added. +* fast/dom/Node/contains-method.html: Renamed from LayoutTests/fast/dom/Element/contains-method.html. +* fast/dom/Node/script-tests/contains-method.js: Added. Expanded tests. +* fast/dom/Window/window-properties-expected.txt: +* perf/document-contains-expected.txt: Added. +* perf/document-contains.html: Added. + Perf test to ensure that document.contains is O(1). +* platform/gtk/fast/dom/Window/window-properties-expected.txt: +* platform/mac/fast/dom/Window/window-properties-expected.txt: +* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-properties-expected.txt: + 2011-09-08 Chris Rogers crog...@google.com Check AudioContext createChannelMerger() for thread safety Deleted: trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt (94780 => 94781) --- trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt 2011-09-08 19:22:59 UTC (rev 94780) +++ trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt 2011-09-08 19:38:18 UTC (rev 94781) @@ -1,15 +0,0 @@ -This test checks behavior of Element.contains. - -[test1 [test 2]] -On success, you will see a series of PASS messages, followed by TEST COMPLETE. - - -PASS document.contains is undefined. -PASS test1.contains(test2) is true
[webkit-changes] [94783] trunk
Title: [94783] trunk Revision 94783 Author commit-qu...@webkit.org Date 2011-09-08 12:55:20 -0700 (Thu, 08 Sep 2011) Log Message [v8] Improve performance of typed array set() taking Array https://bugs.webkit.org/show_bug.cgi?id=63644 Patch by Ulan Degenbaev u...@chromium.org on 2011-09-08 Reviewed by Kenneth Russell. Overwrite the native 'set' method of the type arrays with JS implementation after initialization of the global context. Add tests for invalid and boundary offsets. No performance tests. * LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt: * LayoutTests/fast/canvas/webgl/array-unit-tests.html: * Source/WebCore/WebCore.gyp/WebCore.gyp: * Source/WebCore/WebCore.gypi: * Source/WebCore/bindings/v8/V8BindingScripts.cpp: Added. * Source/WebCore/bindings/v8/V8BindingScripts.h: Added. * Source/WebCore/bindings/v8/V8DOMWindowShell.cpp: * Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp: * Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js: Added. Modified Paths trunk/ChangeLog trunk/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt trunk/LayoutTests/fast/canvas/webgl/array-unit-tests.html trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp Added Paths trunk/Source/WebCore/bindings/v8/V8BindingScripts.cpp trunk/Source/WebCore/bindings/v8/V8BindingScripts.h trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js Diff Modified: trunk/ChangeLog (94782 => 94783) --- trunk/ChangeLog 2011-09-08 19:44:57 UTC (rev 94782) +++ trunk/ChangeLog 2011-09-08 19:55:20 UTC (rev 94783) @@ -1,3 +1,25 @@ +2011-09-08 Ulan Degenbaev u...@chromium.org + +[v8] Improve performance of typed array set() taking Array +https://bugs.webkit.org/show_bug.cgi?id=63644 + +Reviewed by Kenneth Russell. + +Overwrite the native 'set' method of the type arrays with JS +implementation after initialization of the global context. + +Add tests for invalid and boundary offsets. No performance tests. + +* LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt: +* LayoutTests/fast/canvas/webgl/array-unit-tests.html: +* Source/WebCore/WebCore.gyp/WebCore.gyp: +* Source/WebCore/WebCore.gypi: +* Source/WebCore/bindings/v8/V8BindingScripts.cpp: Added. +* Source/WebCore/bindings/v8/V8BindingScripts.h: Added. +* Source/WebCore/bindings/v8/V8DOMWindowShell.cpp: +* Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp: +* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js: Added. + 2011-09-08 Varun Jain varunj...@google.com Split Tap gesture detection into TapDown and Tap. Modified: trunk/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt (94782 => 94783) --- trunk/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt 2011-09-08 19:44:57 UTC (rev 94782) +++ trunk/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt 2011-09-08 19:55:20 UTC (rev 94783) @@ -43,8 +43,16 @@ PASS array.subarray(-2).length is 2 PASS array.subarray(-2147483648).length is (32 / typeSize) PASS Setting Float32Array from array with out-of-range offset was caught +PASS Setting Float32Array from Float32Array with out-of-range offset was caught +PASS Setting Float32Array from array with negative offset was caught +PASS Setting Float32Array from Float32Array with negative offset was caught +PASS Setting Float32Array from array with -0 offset +PASS Setting Float32Array from Float32Array with -0 offset +PASS Setting Float32Array from array with boundary offset +PASS Setting Float32Array from Float32Array with boundary offset +PASS Setting Float32Array from array with non-integer offset +PASS Setting Float32Array from Float32Array with non-integer offset PASS Setting Float32Array from fake array with invalid length was caught -PASS Setting Float32Array from Float32Array with out-of-range offset was caught PASS array.get is undefined. PASS array.set(0, 1) threw exception. PASS test storing NaN in Float32Array @@ -89,8 +97,16 @@ PASS array.subarray(-2).length is 2 PASS array.subarray(-2147483648).length is (32 / typeSize) PASS Setting Float64Array from array with out-of-range offset was caught +PASS Setting Float64Array from Float64Array with out-of-range offset was caught +PASS Setting Float64Array from array with negative offset was caught +PASS Setting Float64Array from Float64Array with negative offset was caught +PASS Setting Float64Array from array with -0 offset +PASS Setting Float64Array from Float64Array with -0 offset +PASS Setting Float64Array from array with boundary offset +PASS Setting Float64Array from Float64Array with boundary offset +PASS Setting Float64Array from array with non-integer offset +PASS Setting Float64Array from Float64Array with
[webkit-changes] [94784] trunk
Title: [94784] trunk
Revision 94784
Author rolandstei...@chromium.org
Date 2011-09-08 12:56:38 -0700 (Thu, 08 Sep 2011)
Log Message
style scoped: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718
Source/WebCore:
Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.
Reviewed by Dimitri Glazkov.
Test: fast/css/style-scoped/basic-attribute.html
* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:
LayoutTests:
Test setting/resetting of the 'scoped' attribute in various circumstances.
Reviewed by Dimitri Glazkov.
* fast/css/style-scoped/basic-attribute-expected.txt: Added.
* fast/css/style-scoped/basic-attribute.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAttributeNames.in
trunk/Source/WebCore/html/HTMLStyleElement.cpp
trunk/Source/WebCore/html/HTMLStyleElement.h
trunk/Source/WebCore/html/HTMLStyleElement.idl
Added Paths
trunk/LayoutTests/fast/css/style-scoped/
trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt
trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94783 => 94784)
--- trunk/LayoutTests/ChangeLog 2011-09-08 19:55:20 UTC (rev 94783)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 19:56:38 UTC (rev 94784)
@@ -1,3 +1,15 @@
+2011-09-08 Roland Steiner rolandstei...@chromium.org
+
+style scoped: Add 'scoped' attribute
+https://bugs.webkit.org/show_bug.cgi?id=67718
+
+Test setting/resetting of the 'scoped' attribute in various circumstances.
+
+Reviewed by Dimitri Glazkov.
+
+* fast/css/style-scoped/basic-attribute-expected.txt: Added.
+* fast/css/style-scoped/basic-attribute.html: Added.
+
2011-09-08 Ben Wells benwe...@chromium.org
Rebaseline for bug 65583 (path based border radius drawing on skia) part 2
Added: trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt (0 => 94784)
--- trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt 2011-09-08 19:56:38 UTC (rev 94784)
@@ -0,0 +1,62 @@
+Basic test for the style scoped attribute.
+
+--- Initial ---
+PASS global1.getAttribute('scoped') is null
+PASS global1.scoped is false
+PASS global2.getAttribute('scoped') is null
+PASS global2.scoped is false
+PASS testBooleanAttribute(scoped1, 'scoped') is true
+PASS scoped1.scoped is true
+PASS testBooleanAttribute(scoped2, 'scoped') is true
+PASS scoped2.scoped is true
+PASS testBooleanAttribute(scoped3, 'scoped') is true
+PASS scoped3.scoped is true
+--- After insertion into tree ---
+PASS global1.getAttribute('scoped') is null
+PASS global1.scoped is false
+PASS global2.getAttribute('scoped') is null
+PASS global2.scoped is false
+PASS testBooleanAttribute(scoped1, 'scoped') is true
+PASS scoped1.scoped is true
+PASS testBooleanAttribute(scoped2, 'scoped') is true
+PASS scoped2.scoped is true
+PASS testBooleanAttribute(scoped3, 'scoped') is true
+PASS scoped3.scoped is true
+--- Inverting 'scoped' attribute while in tree ---
+PASS testBooleanAttribute(global1, 'scoped') is true
+PASS global1.scoped is true
+PASS testBooleanAttribute(global2, 'scoped') is true
+PASS global2.scoped is true
+PASS scoped1.getAttribute('scoped') is null
+PASS scoped1.scoped is false
+PASS scoped2.getAttribute('scoped') is null
+PASS scoped2.scoped is false
+PASS scoped3.getAttribute('scoped') is null
+PASS scoped3.scoped is false
+--- After removal from tree (attribute is still inverted) ---
+PASS testBooleanAttribute(global1, 'scoped') is true
+PASS global1.scoped is true
+PASS testBooleanAttribute(global2, 'scoped') is true
+PASS global2.scoped is true
+PASS scoped1.getAttribute('scoped') is null
+PASS scoped1.scoped is false
+PASS scoped2.getAttribute('scoped') is null
+PASS scoped2.scoped is false
+PASS scoped3.getAttribute('scoped') is null
+PASS scoped3.scoped is false
+--- Inverting 'scoped' attribute again, while outside tree ---
+PASS global1.getAttribute('scoped') is null
+PASS global1.scoped is false
+PASS global2.getAttribute('scoped') is null
+PASS global2.scoped is false
+PASS testBooleanAttribute(scoped1, 'scoped') is true
+PASS scoped1.scoped is true
+PASS testBooleanAttribute(scoped2, 'scoped') is true
+PASS scoped2.scoped is true
+PASS testBooleanAttribute(scoped3, 'scoped') is true
+PASS scoped3.scoped is true
+--- DONE ---
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html (0 => 94784)
--- trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html (rev 0)
+++
[webkit-changes] [94785] trunk
Title: [94785] trunk
Revision 94785
Author rob...@webkit.org
Date 2011-09-08 12:58:32 -0700 (Thu, 08 Sep 2011)
Log Message
Elements with position:absolute don't move to correct position after images load
https://bugs.webkit.org/show_bug.cgi?id=54611
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/block/positioning/absolute-layout-after-image-load.html
In the test the 'label' block is an absolutely positioned child of an inline flow. So during layout,
this RenderBlock::layoutPositionedObjects fails to dirty it for rendering because it requires
the parent to be a BlockFlow. The code to do this was introduced in http://trac.webkit.org/changeset/8284.
There doesn't seem to be a good reason for requiring a BlockFlow, so remove the check.
Note: Although the issue is encountered only on first load without a fragment identifier, it
happens reliably when you include the fragment identifier in the url (#Footnote_1). This is so
because scrolling to the fragment always happens before the image has loaded, rendering the page
and clearing the initial dirty bits in the positioned element's renderer. When the image finally
loads in this scenario, the positioned element is otherwise clean and relies on the above code to get
re-rendered.
Note: This was originally landed in r94755 but positioned-float-layout-after-image-load.html exposed
an ASSERT bug, unrelated to this change, and was rolled out. That issue is tracked separately
in bug 67759.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects): remove the check for r-parent()-isBlockFlow() when
deciding whether to mark children for layout
LayoutTests:
* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
* fast/block/positioning/absolute-layout-after-image-load.html: Added.
* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt
trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html
trunk/LayoutTests/fast/block/positioning/resources/absolute-layout-after-image-load-2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94784 => 94785)
--- trunk/LayoutTests/ChangeLog 2011-09-08 19:56:38 UTC (rev 94784)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 19:58:32 UTC (rev 94785)
@@ -1,3 +1,14 @@
+2011-09-03 Robert Hogan rob...@webkit.org
+
+Elements with position:absolute don't move to correct position after images load
+https://bugs.webkit.org/show_bug.cgi?id=54611
+
+Reviewed by Simon Fraser.
+
+* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
+* fast/block/positioning/absolute-layout-after-image-load.html: Added.
+* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.
+
2011-09-08 Roland Steiner rolandstei...@chromium.org
style scoped: Add 'scoped' attribute
Added: trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt (0 => 94785)
--- trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt 2011-09-08 19:58:32 UTC (rev 94785)
@@ -0,0 +1,3 @@
+
+[1]
+SUCCESS
Property changes on: trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html (0 => 94785)
--- trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html (rev 0)
+++ trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html 2011-09-08 19:58:32 UTC (rev 94785)
@@ -0,0 +1,21 @@
+html
+head
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+ }
+
+// https://bugs.webkit.org/show_bug.cgi?id=54611
+// When navigating to absolute-layout-after-image-load-2.html#anchor1 directly, the anchor should be positioned below
+// the image on first load. The test is sensitive to caching of the image, so you should reload
+// absolute-layout-after-image-load-2.html#anchor1 if testing manually.
+
+function test(){
+setTimeout(location.assign(resources/absolute-layout-after-image-load-2.html#anchor1),0);
+}
+/script
+/head
+body _onload_=test();
+/body/html
+
Property changes on: trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html
[webkit-changes] [94787] trunk
Title: [94787] trunk
Revision 94787
Author eric.carl...@apple.com
Date 2011-09-08 13:19:34 -0700 (Thu, 08 Sep 2011)
Log Message
HTMLMediaElement is missing initialTime attribute
https://bugs.webkit.org/show_bug.cgi?id=67791
Reviewed by Darin Adler.
Source/WebCore:
Test: media/media-initialTime.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::initialTime):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::initialTime):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::initialTime):
LayoutTests:
* media/media-initialTime-expected.txt: Added.
* media/media-initialTime.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLMediaElement.idl
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
Added Paths
trunk/LayoutTests/media/media-initialTime-expected.txt
trunk/LayoutTests/media/media-initialTime.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94786 => 94787)
--- trunk/LayoutTests/ChangeLog 2011-09-08 20:03:54 UTC (rev 94786)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 20:19:34 UTC (rev 94787)
@@ -1,3 +1,13 @@
+2011-09-08 Eric Carlson eric.carl...@apple.com
+
+HTMLMediaElement is missing initialTime attribute
+https://bugs.webkit.org/show_bug.cgi?id=67791
+
+Reviewed by Darin Adler.
+
+* media/media-initialTime-expected.txt: Added.
+* media/media-initialTime.html: Added.
+
2011-09-03 Robert Hogan rob...@webkit.org
Elements with position:absolute don't move to correct position after images load
Added: trunk/LayoutTests/media/media-initialTime-expected.txt (0 => 94787)
--- trunk/LayoutTests/media/media-initialTime-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-initialTime-expected.txt 2011-09-08 20:19:34 UTC (rev 94787)
@@ -0,0 +1,8 @@
+Test the, so far unused, 'initialTime' attribute.
+
+EVENT(loadeddata)
+EXPECTED (video.initialTime == '0') OK
+RUN(video.initialTime = 10)
+EXPECTED (video.initialTime == '0') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/media-initialTime.html (0 => 94787)
--- trunk/LayoutTests/media/media-initialTime.html (rev 0)
+++ trunk/LayoutTests/media/media-initialTime.html 2011-09-08 20:19:34 UTC (rev 94787)
@@ -0,0 +1,32 @@
+html
+head
+titleinitialTime attribute test/title
+script src=""
+script src=""
+
+script
+function loadeddata()
+{
+testExpected(video.initialTime, 0);
+run(video.initialTime = 10);
+testExpected(video.initialTime, 0);
+endTest();
+}
+
+function start()
+{
+findMediaElement();
+waitForEvent('loadeddata', loadeddata);
+
+video.src = "" content/test);
+}
+
+/script
+/head
+
+body _onload_=start()
+video controls /video
+pTest the, so far unused, 'initialTime' attribute./p
+
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (94786 => 94787)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 20:03:54 UTC (rev 94786)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 20:19:34 UTC (rev 94787)
@@ -1,3 +1,22 @@
+2011-09-08 Eric Carlson eric.carl...@apple.com
+
+HTMLMediaElement is missing initialTime attribute
+https://bugs.webkit.org/show_bug.cgi?id=67791
+
+Reviewed by Darin Adler.
+
+Test: media/media-initialTime.html
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::initialTime):
+* html/HTMLMediaElement.h:
+* html/HTMLMediaElement.idl:
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::initialTime):
+* platform/graphics/MediaPlayer.h:
+* platform/graphics/MediaPlayerPrivate.h:
+(WebCore::MediaPlayerPrivateInterface::initialTime):
+
2011-09-03 Robert Hogan rob...@webkit.org
Elements with position:absolute don't move to correct position after images load
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (94786 => 94787)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-09-08 20:03:54 UTC (rev 94786)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-09-08 20:19:34 UTC (rev 94787)
@@ -1472,6 +1472,13 @@
return m_player-startTime();
}
+double HTMLMediaElement::initialTime() const
+{
+if (!m_player)
+return 0;
+return m_player-initialTime();
+}
+
float HTMLMediaElement::duration() const
{
if (m_player m_readyState = HAVE_METADATA)
Modified:
[webkit-changes] [94788] trunk/LayoutTests
Title: [94788] trunk/LayoutTests
Revision 94788
Author o...@webkit.org
Date 2011-09-08 13:23:53 -0700 (Thu, 08 Sep 2011)
Log Message
[Qt] Unreviewed gardening.
* platform/qt/Skipped: Skip tests introduced in r94775 because of missing test fonts.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. (test introduced in r94147)
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
Added Paths
trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94787 => 94788)
--- trunk/LayoutTests/ChangeLog 2011-09-08 20:19:34 UTC (rev 94787)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 20:23:53 UTC (rev 94788)
@@ -1,3 +1,10 @@
+2011-09-08 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Unreviewed gardening.
+
+* platform/qt/Skipped: Skip tests introduced in r94775 because of missing test fonts.
+* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. (test introduced in r94147)
+
2011-09-08 Eric Carlson eric.carl...@apple.com
HTMLMediaElement is missing initialTime attribute
Modified: trunk/LayoutTests/platform/qt/Skipped (94787 => 94788)
--- trunk/LayoutTests/platform/qt/Skipped 2011-09-08 20:19:34 UTC (rev 94787)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-09-08 20:23:53 UTC (rev 94788)
@@ -2415,3 +2415,7 @@
# new test introduced in r94696, but fails on Qt.
# https://bugs.webkit.org/show_bug.cgi?id=67772
fast/css/line-after-floating-div.html
+
+# new tests introduced in r94775, but fails on Qt because of missing test font
+css3/unicode-bidi-isolate-aharon.html
+css3/unicode-bidi-isolate-basic.html
Added: trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt (0 => 94788)
--- trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-08 20:23:53 UTC (rev 94788)
@@ -0,0 +1,41 @@
+Make sure prototypes are set up using the window a property came from, instead of the lexical global object.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS (new inner.Audio()).isInner is true
+PASS (new inner.Audio()).constructor.isInner is true
+PASS (new inner.CustomEvent()).isInner is true
+PASS (new inner.CustomEvent()).constructor.isInner is true
+PASS (new inner.DOMParser()).isInner is true
+PASS (new inner.DOMParser()).constructor.isInner is true
+PASS (new inner.Event()).isInner is true
+PASS (new inner.Event()).constructor.isInner is true
+PASS (new inner.FormData()).isInner is true
+PASS (new inner.FormData()).constructor.isInner is true
+PASS (new inner.Image()).isInner is true
+PASS (new inner.Image()).constructor.isInner is true
+PASS (new inner.MessageChannel()).isInner is true
+PASS (new inner.MessageChannel()).constructor.isInner is true
+PASS (new inner.Option()).isInner is true
+PASS (new inner.Option()).constructor.isInner is true
+PASS (new inner.ProgressEvent()).isInner is true
+PASS (new inner.ProgressEvent()).constructor.isInner is true
+PASS (new inner.WebKitCSSMatrix()).isInner is true
+PASS (new inner.WebKitCSSMatrix()).constructor.isInner is true
+PASS (new inner.WebKitPoint()).isInner is true
+PASS (new inner.WebKitPoint()).constructor.isInner is true
+PASS (new inner.Worker('foo')).isInner is true
+PASS (new inner.Worker('foo')).constructor.isInner is true
+PASS (new inner.XMLHttpRequest()).isInner is true
+PASS (new inner.XMLHttpRequest()).constructor.isInner is true
+PASS (new inner.XMLSerializer()).isInner is true
+PASS (new inner.XMLSerializer()).constructor.isInner is true
+PASS (new inner.XPathEvaluator()).isInner is true
+PASS (new inner.XPathEvaluator()).constructor.isInner is true
+PASS (new inner.XSLTProcessor()).isInner is true
+PASS (new inner.XSLTProcessor()).constructor.isInner is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94789] trunk
Title: [94789] trunk
Revision 94789
Author wjmacl...@chromium.org
Date 2011-09-08 13:31:02 -0700 (Thu, 08 Sep 2011)
Log Message
[chromium] Add backend compositor support for rescaling (zooming) textures during zoom animation.
https://bugs.webkit.org/show_bug.cgi?id=66472
Source/WebCore:
This patch contains plumbing from Internals to WebViewImpl that can be removed
at a later time when the zoom animator code is complete.
Reviewed by James Robinson.
Test: platform/chromium/compositing/zoom-animator-scale-test.html
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setZoomAnimatorScale):
(WebCore::Settings::zoomAnimatorScale):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setZoomAnimatorScale):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setZoomAnimatorScale):
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorScale):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorScale):
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit/chromium:
This patch contains plumbing from Internals to WebViewImpl that can be removed
at a later time when the zoom animator code is complete.
Reviewed by James Robinson.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
LayoutTests:
Initial tests for zoomAnimatorChromium backend.
Reviewed by James Robinson.
* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
* platform/chromium/compositing/zoom-animator-scale-test.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Added Paths
trunk/LayoutTests/platform/chromium/compositing/zoom-animator-scale-test.html
trunk/LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png
trunk/LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94788 => 94789)
--- trunk/LayoutTests/ChangeLog 2011-09-08 20:23:53 UTC (rev 94788)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 20:31:02 UTC (rev 94789)
@@ -1,3 +1,16 @@
+2011-09-08 W. James MacLean wjmacl...@chromium.org
+
+[chromium] Add backend compositor support for rescaling (zooming) textures during zoom animation.
+https://bugs.webkit.org/show_bug.cgi?id=66472
+
+Initial tests for zoomAnimatorChromium backend.
+
+Reviewed by James Robinson.
+
+* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
+* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
+* platform/chromium/compositing/zoom-animator-scale-test.html: Added.
+
2011-09-08 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening.
Added: trunk/LayoutTests/platform/chromium/compositing/zoom-animator-scale-test.html (0 => 94789)
--- trunk/LayoutTests/platform/chromium/compositing/zoom-animator-scale-test.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/compositing/zoom-animator-scale-test.html 2011-09-08 20:31:02 UTC (rev 94789)
@@ -0,0 +1,24 @@
+html
+ head
+script
+if (window.internals) {
+window.internals.setForceCompositingMode(document, true);
+window.internals.setZoomAnimatorScale(document, 1.25);
+}
+if (window.layoutTestController) {
+window.layoutTestController.dumpAsText(true);
+}
+
+function doTest() {
+
[webkit-changes] [94790] trunk
Title: [94790] trunk
Revision 94790
Author commit-qu...@webkit.org
Date 2011-09-08 13:33:45 -0700 (Thu, 08 Sep 2011)
Log Message
Unreviewed, rolling out r94784.
http://trac.webkit.org/changeset/94784
https://bugs.webkit.org/show_bug.cgi?id=67796
Commit was premature (Requested by rolandsteiner on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-08
Source/WebCore:
* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:
LayoutTests:
* fast/css/style-scoped/basic-attribute-expected.txt: Removed.
* fast/css/style-scoped/basic-attribute.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAttributeNames.in
trunk/Source/WebCore/html/HTMLStyleElement.cpp
trunk/Source/WebCore/html/HTMLStyleElement.h
trunk/Source/WebCore/html/HTMLStyleElement.idl
Removed Paths
trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt
trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94789 => 94790)
--- trunk/LayoutTests/ChangeLog 2011-09-08 20:31:02 UTC (rev 94789)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 20:33:45 UTC (rev 94790)
@@ -1,3 +1,14 @@
+2011-09-08 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r94784.
+http://trac.webkit.org/changeset/94784
+https://bugs.webkit.org/show_bug.cgi?id=67796
+
+Commit was premature (Requested by rolandsteiner on #webkit).
+
+* fast/css/style-scoped/basic-attribute-expected.txt: Removed.
+* fast/css/style-scoped/basic-attribute.html: Removed.
+
2011-09-08 W. James MacLean wjmacl...@chromium.org
[chromium] Add backend compositor support for rescaling (zooming) textures during zoom animation.
Deleted: trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt (94789 => 94790)
--- trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt 2011-09-08 20:31:02 UTC (rev 94789)
+++ trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt 2011-09-08 20:33:45 UTC (rev 94790)
@@ -1,62 +0,0 @@
-Basic test for the style scoped attribute.
-
Initial ---
-PASS global1.getAttribute('scoped') is null
-PASS global1.scoped is false
-PASS global2.getAttribute('scoped') is null
-PASS global2.scoped is false
-PASS testBooleanAttribute(scoped1, 'scoped') is true
-PASS scoped1.scoped is true
-PASS testBooleanAttribute(scoped2, 'scoped') is true
-PASS scoped2.scoped is true
-PASS testBooleanAttribute(scoped3, 'scoped') is true
-PASS scoped3.scoped is true
After insertion into tree ---
-PASS global1.getAttribute('scoped') is null
-PASS global1.scoped is false
-PASS global2.getAttribute('scoped') is null
-PASS global2.scoped is false
-PASS testBooleanAttribute(scoped1, 'scoped') is true
-PASS scoped1.scoped is true
-PASS testBooleanAttribute(scoped2, 'scoped') is true
-PASS scoped2.scoped is true
-PASS testBooleanAttribute(scoped3, 'scoped') is true
-PASS scoped3.scoped is true
Inverting 'scoped' attribute while in tree ---
-PASS testBooleanAttribute(global1, 'scoped') is true
-PASS global1.scoped is true
-PASS testBooleanAttribute(global2, 'scoped') is true
-PASS global2.scoped is true
-PASS scoped1.getAttribute('scoped') is null
-PASS scoped1.scoped is false
-PASS scoped2.getAttribute('scoped') is null
-PASS scoped2.scoped is false
-PASS scoped3.getAttribute('scoped') is null
-PASS scoped3.scoped is false
After removal from tree (attribute is still inverted) ---
-PASS testBooleanAttribute(global1, 'scoped') is true
-PASS global1.scoped is true
-PASS testBooleanAttribute(global2, 'scoped') is true
-PASS global2.scoped is true
-PASS scoped1.getAttribute('scoped') is null
-PASS scoped1.scoped is false
-PASS scoped2.getAttribute('scoped') is null
-PASS scoped2.scoped is false
-PASS scoped3.getAttribute('scoped') is null
-PASS scoped3.scoped is false
Inverting 'scoped' attribute again, while outside tree ---
-PASS global1.getAttribute('scoped') is null
-PASS global1.scoped is false
-PASS global2.getAttribute('scoped') is null
-PASS global2.scoped is false
-PASS testBooleanAttribute(scoped1, 'scoped') is true
-PASS scoped1.scoped is true
-PASS testBooleanAttribute(scoped2, 'scoped') is true
-PASS scoped2.scoped is true
-PASS testBooleanAttribute(scoped3, 'scoped') is true
-PASS scoped3.scoped is true
DONE ---
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html (94789 => 94790)
--- trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html 2011-09-08 20:31:02 UTC (rev 94789)
+++ trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html 2011-09-08 20:33:45 UTC (rev 94790)
@@ -1,124 +0,0 @@
-html
-head
-link rel=stylesheet href=""
-script src=""
-/head
-body
-pBasic test for the lt;style scopedgt; attribute./p
-div id=scope
-style
[webkit-changes] [94791] trunk/LayoutTests
Title: [94791] trunk/LayoutTests
Revision 94791
Author o...@webkit.org
Date 2011-09-08 13:46:55 -0700 (Thu, 08 Sep 2011)
Log Message
[Qt] Unreviewed gardening after r94771.
* fast/dom/constructed-objects-prototypes-expected.txt: Update, it will pass on Qt, GTK, SL, Win.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
Removed Paths
trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94790 => 94791)
--- trunk/LayoutTests/ChangeLog 2011-09-08 20:33:45 UTC (rev 94790)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 20:46:55 UTC (rev 94791)
@@ -1,3 +1,10 @@
+2011-09-08 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Unreviewed gardening after r94771.
+
+* fast/dom/constructed-objects-prototypes-expected.txt: Update, it will pass on Qt, GTK, SL, Win.
+* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
+
2011-09-08 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94784.
@@ -27,7 +34,7 @@
[Qt] Unreviewed gardening.
* platform/qt/Skipped: Skip tests introduced in r94775 because of missing test fonts.
-* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. (test introduced in r94147)
+* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. (test introduced in r94771)
2011-09-08 Eric Carlson eric.carl...@apple.com
Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (94790 => 94791)
--- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-08 20:33:45 UTC (rev 94790)
+++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-08 20:46:55 UTC (rev 94791)
@@ -19,6 +19,8 @@
PASS (new inner.MessageChannel()).constructor.isInner is true
PASS (new inner.Option()).isInner is true
PASS (new inner.Option()).constructor.isInner is true
+PASS (new inner.ProgressEvent()).isInner is true
+PASS (new inner.ProgressEvent()).constructor.isInner is true
PASS (new inner.WebKitCSSMatrix()).isInner is true
PASS (new inner.WebKitCSSMatrix()).constructor.isInner is true
PASS (new inner.WebKitPoint()).isInner is true
Deleted: trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt (94790 => 94791)
--- trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-08 20:33:45 UTC (rev 94790)
+++ trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-08 20:46:55 UTC (rev 94791)
@@ -1,41 +0,0 @@
-Make sure prototypes are set up using the window a property came from, instead of the lexical global object.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS (new inner.Audio()).isInner is true
-PASS (new inner.Audio()).constructor.isInner is true
-PASS (new inner.CustomEvent()).isInner is true
-PASS (new inner.CustomEvent()).constructor.isInner is true
-PASS (new inner.DOMParser()).isInner is true
-PASS (new inner.DOMParser()).constructor.isInner is true
-PASS (new inner.Event()).isInner is true
-PASS (new inner.Event()).constructor.isInner is true
-PASS (new inner.FormData()).isInner is true
-PASS (new inner.FormData()).constructor.isInner is true
-PASS (new inner.Image()).isInner is true
-PASS (new inner.Image()).constructor.isInner is true
-PASS (new inner.MessageChannel()).isInner is true
-PASS (new inner.MessageChannel()).constructor.isInner is true
-PASS (new inner.Option()).isInner is true
-PASS (new inner.Option()).constructor.isInner is true
-PASS (new inner.ProgressEvent()).isInner is true
-PASS (new inner.ProgressEvent()).constructor.isInner is true
-PASS (new inner.WebKitCSSMatrix()).isInner is true
-PASS (new inner.WebKitCSSMatrix()).constructor.isInner is true
-PASS (new inner.WebKitPoint()).isInner is true
-PASS (new inner.WebKitPoint()).constructor.isInner is true
-PASS (new inner.Worker('foo')).isInner is true
-PASS (new inner.Worker('foo')).constructor.isInner is true
-PASS (new inner.XMLHttpRequest()).isInner is true
-PASS (new inner.XMLHttpRequest()).constructor.isInner is true
-PASS (new inner.XMLSerializer()).isInner is true
-PASS (new inner.XMLSerializer()).constructor.isInner is true
-PASS (new inner.XPathEvaluator()).isInner is true
-PASS (new inner.XPathEvaluator()).constructor.isInner is true
-PASS (new inner.XSLTProcessor()).isInner is true
-PASS (new inner.XSLTProcessor()).constructor.isInner is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94793] trunk
Title: [94793] trunk
Revision 94793
Author commit-qu...@webkit.org
Date 2011-09-08 13:50:24 -0700 (Thu, 08 Sep 2011)
Log Message
Crashes in WebCore::ReplaceSelectionCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=67762
Patch by Shinya Kawanaka shin...@google.com on 2011-09-08
Reviewed by Ryosuke Niwa.
Source/WebCore:
WebCore::enclosingBlock may return null, but its return value was not checked. This patch checks it.
Tests: editing/inserting/insert-without-enclosing-block.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Added null check.
LayoutTests:
WebCore::enclosingBlock may return NULL, but its return value was not checked. This patch checks it.
* editing/inserting/insert-without-enclosing-block-expected.txt: Added.
* editing/inserting/insert-without-enclosing-block.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
Added Paths
trunk/LayoutTests/editing/inserting/insert-without-enclosing-block-expected.txt
trunk/LayoutTests/editing/inserting/insert-without-enclosing-block.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94792 => 94793)
--- trunk/LayoutTests/ChangeLog 2011-09-08 20:48:34 UTC (rev 94792)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 20:50:24 UTC (rev 94793)
@@ -1,3 +1,15 @@
+2011-09-08 Shinya Kawanaka shin...@google.com
+
+Crashes in WebCore::ReplaceSelectionCommand::doApply
+https://bugs.webkit.org/show_bug.cgi?id=67762
+
+Reviewed by Ryosuke Niwa.
+
+WebCore::enclosingBlock may return NULL, but its return value was not checked. This patch checks it.
+
+* editing/inserting/insert-without-enclosing-block-expected.txt: Added.
+* editing/inserting/insert-without-enclosing-block.html: Added.
+
2011-09-08 Nate Chapin jap...@chromium.org
Chromium baselines for new tests added in r94775 and r94779.
Added: trunk/LayoutTests/editing/inserting/insert-without-enclosing-block-expected.txt (0 => 94793)
--- trunk/LayoutTests/editing/inserting/insert-without-enclosing-block-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-without-enclosing-block-expected.txt 2011-09-08 20:50:24 UTC (rev 94793)
@@ -0,0 +1,3 @@
+This test ensures WebKit does not crash.
+
+PASS
Added: trunk/LayoutTests/editing/inserting/insert-without-enclosing-block.html (0 => 94793)
--- trunk/LayoutTests/editing/inserting/insert-without-enclosing-block.html (rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-without-enclosing-block.html 2011-09-08 20:50:24 UTC (rev 94793)
@@ -0,0 +1,9 @@
+feSpotLightsub id=div contenteditable=truescript
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+window.getSelection().setPosition(div, 0);
+document.execCommand(InsertHTML, false, dl);
+
+document.writeln('This test ensures WebKit does not crash.brbrPASS');
+/script
Modified: trunk/Source/WebCore/ChangeLog (94792 => 94793)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 20:48:34 UTC (rev 94792)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 20:50:24 UTC (rev 94793)
@@ -1,3 +1,17 @@
+2011-09-08 Shinya Kawanaka shin...@google.com
+
+Crashes in WebCore::ReplaceSelectionCommand::doApply
+https://bugs.webkit.org/show_bug.cgi?id=67762
+
+Reviewed by Ryosuke Niwa.
+
+WebCore::enclosingBlock may return null, but its return value was not checked. This patch checks it.
+
+Tests: editing/inserting/insert-without-enclosing-block.html
+
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::ReplaceSelectionCommand::doApply): Added null check.
+
2011-09-08 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94784.
Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (94792 => 94793)
--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2011-09-08 20:48:34 UTC (rev 94792)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2011-09-08 20:50:24 UTC (rev 94793)
@@ -994,7 +994,7 @@
Node* blockStart = enclosingBlock(insertionPos.deprecatedNode());
if ((isListElement(refNode.get()) || (isLegacyAppleStyleSpan(refNode.get()) isListElement(refNode-firstChild(
- blockStart-renderer()-isListItem())
+ blockStart blockStart-renderer()-isListItem())
refNode = insertAsListItems(refNode, blockStart, insertionPos);
else
insertNodeAtAndUpdateNodesInserted(refNode, insertionPos);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94794] trunk/LayoutTests
Title: [94794] trunk/LayoutTests Revision 94794 Author a...@apple.com Date 2011-09-08 13:53:29 -0700 (Thu, 08 Sep 2011) Log Message Some file-url-mimetypes subtests fail on rare extensions https://bugs.webkit.org/show_bug.cgi?id=67679 * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: * platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: * platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Update platform specific results, too. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt trunk/LayoutTests/platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt trunk/LayoutTests/platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94793 => 94794) --- trunk/LayoutTests/ChangeLog 2011-09-08 20:50:24 UTC (rev 94793) +++ trunk/LayoutTests/ChangeLog 2011-09-08 20:53:29 UTC (rev 94794) @@ -1,3 +1,14 @@ +2011-09-08 Alexey Proskuryakov a...@apple.com + +Some file-url-mimetypes subtests fail on rare extensions +https://bugs.webkit.org/show_bug.cgi?id=67679 + +* platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: +* platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: +* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: +* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: +Update platform specific results, too. + 2011-09-08 Shinya Kawanaka shin...@google.com Crashes in WebCore::ReplaceSelectionCommand::doApply Modified: trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt (94793 => 94794) --- trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt 2011-09-08 20:50:24 UTC (rev 94793) +++ trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt 2011-09-08 20:53:29 UTC (rev 94794) @@ -3,13 +3,11 @@ example-kar.kar has MIME type audio/midi example-l.l has MIME type text/plain example-latex.latex has MIME type application/x-latex -example-lha.lha has MIME type application/octet-stream example-lid.lid has MIME type text/plain example-lm.lm has MIME type text/plain example-lmm.lmm has MIME type text/plain example-lpp.lpp has MIME type text/plain example-lxx.lxx has MIME type text/plain -example-lzh.lzh has MIME type application/octet-stream example-m.m has MIME type text/plain example-m15.m15 has MIME type video/mpeg example-m2v.m2v has MIME type video/mpeg2 Modified: trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt (94793 => 94794) --- trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt 2011-09-08 20:50:24 UTC (rev 94793) +++ trunk/LayoutTests/platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt 2011-09-08 20:53:29 UTC (rev 94794) @@ -38,7 +38,6 @@ example-cpgz.cpgz has MIME type application/x-gzip example-cpio.cpio has MIME type application/x-cpio example-cpp.cpp has MIME type text/plain -example-cpt.cpt has MIME type application/mac-compactpro example-cr2.cr2 has MIME type application/octet-stream example-crw.crw has MIME type image/x-canon-crw example-csh.csh has MIME type application/x-csh Modified: trunk/LayoutTests/platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt (94793 => 94794) --- trunk/LayoutTests/platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt 2011-09-08 20:50:24 UTC (rev 94793) +++ trunk/LayoutTests/platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt 2011-09-08 20:53:29 UTC (rev 94794) @@ -3,13 +3,11 @@ example-kar.kar has MIME type audio/midi example-l.l has MIME type text/plain example-latex.latex has MIME type application/x-latex -example-lha.lha has MIME type application/octet-stream example-lid.lid has MIME type text/plain example-lm.lm has MIME type text/plain example-lmm.lmm has MIME type text/plain example-lpp.lpp has MIME type text/plain example-lxx.lxx has MIME type text/plain -example-lzh.lzh has MIME type application/octet-stream example-m.m has MIME type text/plain example-m15.m15 has MIME type video/mpeg example-m2v.m2v has MIME type video/mpeg2 Modified: trunk/LayoutTests/platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt (94793 => 94794) ---
[webkit-changes] [94795] trunk/Source/JavaScriptCore
Title: [94795] trunk/Source/_javascript_Core Revision 94795 Author commit-qu...@webkit.org Date 2011-09-08 13:54:10 -0700 (Thu, 08 Sep 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=67771 Fix sequenceGetByIdSlowCaseInstructionSpace, sequenceGetByIdSlowCaseConstantSpace and patchOffsetGetByIdSlowCaseCall and enables DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS flag for SH4 platforms. Patch by Thouraya ANDOLSI thouraya.ando...@st.com on 2011-09-08 Reviewed by Gavin Barraclough. * jit/JIT.h: * wtf/dtoa/utils.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/wtf/dtoa/utils.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94794 => 94795) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-08 20:53:29 UTC (rev 94794) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-08 20:54:10 UTC (rev 94795) @@ -1,3 +1,16 @@ +2011-09-08 Thouraya ANDOLSI thouraya.ando...@st.com + +https://bugs.webkit.org/show_bug.cgi?id=67771 + +Fix sequenceGetByIdSlowCaseInstructionSpace, sequenceGetByIdSlowCaseConstantSpace +and patchOffsetGetByIdSlowCaseCall +and enables DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS flag for SH4 platforms. + +Reviewed by Gavin Barraclough. + +* jit/JIT.h: +* wtf/dtoa/utils.h: + 2011-09-08 Mark Hahnenberg mhahnenb...@apple.com Remove getUInt32 from JSCell Modified: trunk/Source/_javascript_Core/jit/JIT.h (94794 => 94795) --- trunk/Source/_javascript_Core/jit/JIT.h 2011-09-08 20:53:29 UTC (rev 94794) +++ trunk/Source/_javascript_Core/jit/JIT.h 2011-09-08 20:54:10 UTC (rev 94795) @@ -510,8 +510,8 @@ static const int sequenceGetByIdHotPathInstructionSpace = 36; static const int sequenceGetByIdHotPathConstantSpace = 5; // sequenceGetByIdSlowCase -static const int sequenceGetByIdSlowCaseInstructionSpace = 26; -static const int sequenceGetByIdSlowCaseConstantSpace = 2; +static const int sequenceGetByIdSlowCaseInstructionSpace = 30; +static const int sequenceGetByIdSlowCaseConstantSpace = 3; // sequencePutById static const int sequencePutByIdInstructionSpace = 36; static const int sequencePutByIdConstantSpace = 5; @@ -525,7 +525,7 @@ #if ENABLE(OPCODE_SAMPLING) static const int patchOffsetGetByIdSlowCaseCall = 0; // FIMXE #else -static const int patchOffsetGetByIdSlowCaseCall = 22; +static const int patchOffsetGetByIdSlowCaseCall = 26; #endif static const int patchOffsetOpCallCompareToJump = 4; Modified: trunk/Source/_javascript_Core/wtf/dtoa/utils.h (94794 => 94795) --- trunk/Source/_javascript_Core/wtf/dtoa/utils.h 2011-09-08 20:53:29 UTC (rev 94794) +++ trunk/Source/_javascript_Core/wtf/dtoa/utils.h 2011-09-08 20:54:10 UTC (rev 94795) @@ -49,7 +49,7 @@ defined(__ARMEL__) || \ defined(_MIPS_ARCH_MIPS32R2) #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1 -#elif CPU(MIPS) || CPU(PPC) || CPU(PPC64) || OS(WINCE) +#elif CPU(MIPS) || CPU(PPC) || CPU(PPC64) || OS(WINCE) || CPU(SH4) #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1 #elif defined(_M_IX86) || defined(__i386__) #if defined(_WIN32) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94797] trunk
Title: [94797] trunk
Revision 94797
Author commit-qu...@webkit.org
Date 2011-09-08 14:11:44 -0700 (Thu, 08 Sep 2011)
Log Message
Implement double tap detection in GestureRecognizerChromium
https://bugs.webkit.org/show_bug.cgi?id=67709
Patch by Varun Jain varunj...@google.com on 2011-09-08
Reviewed by Dimitri Glazkov.
* Source/WebCore/page/EventHandler.cpp:
* Source/WebCore/platform/PlatformGestureEvent.h:
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/platform/PlatformGestureEvent.h
trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp
trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.h
trunk/Source/WebCore/platform/chromium/PopupContainer.cpp
trunk/Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp
Diff
Modified: trunk/ChangeLog (94796 => 94797)
--- trunk/ChangeLog 2011-09-08 21:00:05 UTC (rev 94796)
+++ trunk/ChangeLog 2011-09-08 21:11:44 UTC (rev 94797)
@@ -1,3 +1,13 @@
+2011-09-08 Varun Jain varunj...@google.com
+
+Implement double tap detection in GestureRecognizerChromium
+https://bugs.webkit.org/show_bug.cgi?id=67709
+
+Reviewed by Dimitri Glazkov.
+
+* Source/WebCore/page/EventHandler.cpp:
+* Source/WebCore/platform/PlatformGestureEvent.h:
+
2011-09-08 Ulan Degenbaev u...@chromium.org
[v8] Improve performance of typed array set() taking Array
Modified: trunk/Source/WebCore/page/EventHandler.cpp (94796 => 94797)
--- trunk/Source/WebCore/page/EventHandler.cpp 2011-09-08 21:00:05 UTC (rev 94796)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2011-09-08 21:11:44 UTC (rev 94797)
@@ -2221,6 +2221,8 @@
handleMouseReleaseEvent(fakeMouseUp);
return true;
}
+case PlatformGestureEvent::DoubleTapType:
+break;
case PlatformGestureEvent::ScrollUpdateType: {
const float tickDivisor = (float)WheelEvent::tickMultiplier;
// FIXME: Replace this interim implementation once the above fixme has been addressed.
Modified: trunk/Source/WebCore/platform/PlatformGestureEvent.h (94796 => 94797)
--- trunk/Source/WebCore/platform/PlatformGestureEvent.h 2011-09-08 21:00:05 UTC (rev 94796)
+++ trunk/Source/WebCore/platform/PlatformGestureEvent.h 2011-09-08 21:11:44 UTC (rev 94797)
@@ -40,6 +40,7 @@
ScrollUpdateType,
TapType,
TapDownType,
+DoubleTapType,
};
PlatformGestureEvent()
Modified: trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp (94796 => 94797)
--- trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp 2011-09-08 21:00:05 UTC (rev 94796)
+++ trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp 2011-09-08 21:11:44 UTC (rev 94797)
@@ -62,6 +62,12 @@
addEdgeFunction(Scroll, FirstFinger, Moved, false, GestureRecognizerChromium::inScroll);
addEdgeFunction(Scroll, FirstFinger, Released, false, GestureRecognizerChromium::scrollEnd);
addEdgeFunction(Scroll, FirstFinger, Cancelled, false, GestureRecognizerChromium::scrollEnd);
+
+addEdgeFunction(FirstClickReceived, FirstFinger, Pressed, false, GestureRecognizerChromium::touchDown);
+addEdgeFunction(PendingDoubleClick, FirstFinger, Cancelled, false, GestureRecognizerChromium::noGesture);
+addEdgeFunction(PendingDoubleClick, FirstFinger, Released, false, GestureRecognizerChromium::doubleClick);
+addEdgeFunction(PendingDoubleClick, FirstFinger, Moved, false, GestureRecognizerChromium::maybeDoubleClick);
+addEdgeFunction(PendingDoubleClick, FirstFinger, Stationary, false, GestureRecognizerChromium::maybeDoubleClick);
}
void GestureRecognizerChromium::reset()
@@ -86,6 +92,12 @@
return duration = minimumTouchDownDurationInSecondsForClick duration maximumTouchDownDurationInSecondsForClick;
}
+bool GestureRecognizerChromium::isInSecondClickTimeWindow()
+{
+double duration(m_lastTouchTime - m_lastClickTime);
+return duration = minimumTouchDownDurationInSecondsForClick duration maximumTouchDownDurationInSecondsForClick;
+}
+
bool GestureRecognizerChromium::isInsideManhattanSquare(const PlatformTouchPoint point)
{
int manhattanDistance = abs(point.pos().x() - m_firstTouchPosition.x()) + abs(point.pos().y() - m_firstTouchPosition.y());
@@ -102,6 +114,11 @@
gestures-append(PlatformGestureEvent(PlatformGestureEvent::TapType, m_firstTouchPosition, m_firstTouchScreenPosition, m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
}
+void GestureRecognizerChromium::appendDoubleClickGestureEvent(const PlatformTouchPoint touchPoint, Gestures gestures)
+{
+gestures-append(PlatformGestureEvent(PlatformGestureEvent::DoubleTapType, m_firstTouchPosition, m_firstTouchScreenPosition, m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
+}
+
PlatformGestureRecognizer::PassGestures GestureRecognizerChromium::processTouchEventForGestures(const PlatformTouchEvent
[webkit-changes] [94798] trunk/LayoutTests
Title: [94798] trunk/LayoutTests Revision 94798 Author commit-qu...@webkit.org Date 2011-09-08 14:16:31 -0700 (Thu, 08 Sep 2011) Log Message Chromium shadow-buffer-partial test change. Part1: Update and disable test. https://bugs.webkit.org/show_bug.cgi?id=67724 Patch by Ben Wagner bunge...@chromium.org on 2011-09-08 Reviewed by Kenneth Russell. * platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (94797 => 94798) --- trunk/LayoutTests/ChangeLog 2011-09-08 21:11:44 UTC (rev 94797) +++ trunk/LayoutTests/ChangeLog 2011-09-08 21:16:31 UTC (rev 94798) @@ -1,3 +1,14 @@ +2011-09-08 Ben Wagner bunge...@chromium.org + +Chromium shadow-buffer-partial test change. +Part1: Update and disable test. +https://bugs.webkit.org/show_bug.cgi?id=67724 + +Reviewed by Kenneth Russell. + +* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png: +* platform/chromium/test_expectations.txt: + 2011-09-08 Jarred Nicholls jar...@sencha.com frame-loading-via-document-write.html test cases have extra slash in path Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94797 => 94798) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 21:11:44 UTC (rev 94797) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 21:16:31 UTC (rev 94798) @@ -83,6 +83,9 @@ // fails for other platforms... BUGCR20404 : editing/execCommand/copy-without-selection.html = TEXT +// Skia clipped blur change in progress. +BUGWK67724 SKIP : fast/box-shadow/shadow-buffer-partial.html = PASS FAIL + // - // WONTFIX TESTS // - Modified: trunk/LayoutTests/platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94800] trunk/Source/WebCore
Title: [94800] trunk/Source/WebCore
Revision 94800
Author e...@webkit.org
Date 2011-09-08 14:31:36 -0700 (Thu, 08 Sep 2011)
Log Message
Remove DocumentWriter::setDecoder as a grep of WebKit shows no callers
https://bugs.webkit.org/show_bug.cgi?id=67803
Reviewed by Adam Barth.
Smells like dead code.
* loader/DocumentWriter.cpp:
* loader/DocumentWriter.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/DocumentWriter.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94799 => 94800)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 21:30:02 UTC (rev 94799)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 21:31:36 UTC (rev 94800)
@@ -1,3 +1,15 @@
+2011-09-08 Eric Seidel e...@webkit.org
+
+Remove DocumentWriter::setDecoder as a grep of WebKit shows no callers
+https://bugs.webkit.org/show_bug.cgi?id=67803
+
+Reviewed by Adam Barth.
+
+Smells like dead code.
+
+* loader/DocumentWriter.cpp:
+* loader/DocumentWriter.h:
+
2011-09-08 Shinya Kawanaka shin...@google.com
Crashes in WebCore::ReplaceSelectionCommand::doApply
Modified: trunk/Source/WebCore/loader/DocumentWriter.cpp (94799 => 94800)
--- trunk/Source/WebCore/loader/DocumentWriter.cpp 2011-09-08 21:30:02 UTC (rev 94799)
+++ trunk/Source/WebCore/loader/DocumentWriter.cpp 2011-09-08 21:31:36 UTC (rev 94800)
@@ -253,11 +253,6 @@
m_encodingWasChosenByUser = userChosen;
}
-void DocumentWriter::setDecoder(TextResourceDecoder* decoder)
-{
-m_decoder = decoder;
-}
-
String DocumentWriter::deprecatedFrameEncoding() const
{
return m_frame-document()-url().isEmpty() ? m_encoding : encoding();
Modified: trunk/Source/WebCore/loader/DocumentWriter.h (94799 => 94800)
--- trunk/Source/WebCore/loader/DocumentWriter.h 2011-09-08 21:30:02 UTC (rev 94799)
+++ trunk/Source/WebCore/loader/DocumentWriter.h 2011-09-08 21:31:36 UTC (rev 94800)
@@ -68,8 +68,6 @@
const String mimeType() const { return m_mimeType; }
void setMIMEType(const String type) { m_mimeType = type; }
-void setDecoder(TextResourceDecoder*);
-
// Exposed for DocumentParser::appendBytes.
TextResourceDecoder* createDecoderIfNeeded();
void reportDataReceived();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94803] trunk/Tools
Title: [94803] trunk/Tools
Revision 94803
Author le...@chromium.org
Date 2011-09-08 14:50:48 -0700 (Thu, 08 Sep 2011)
Log Message
check-webkit-style: Ref|Own Ptr should be allowed as a parameter.
https://bugs.webkit.org/show_bug.cgi?id=67797
Reviewed by Eric Seidel.
* Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with .
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (94802 => 94803)
--- trunk/Tools/ChangeLog 2011-09-08 21:38:04 UTC (rev 94802)
+++ trunk/Tools/ChangeLog 2011-09-08 21:50:48 UTC (rev 94803)
@@ -1,3 +1,13 @@
+2011-09-08 David Levin le...@chromium.org
+
+check-webkit-style: Ref|Own Ptr should be allowed as a parameter.
+https://bugs.webkit.org/show_bug.cgi?id=67797
+
+Reviewed by Eric Seidel.
+
+* Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with .
+* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
+
2011-09-08 Fady Samuel fsam...@chromium.org
Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (94802 => 94803)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-09-08 21:38:04 UTC (rev 94802)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-09-08 21:50:48 UTC (rev 94803)
@@ -1577,7 +1577,7 @@
match_ref_or_own_ptr = '(?=\W|^)(Ref|Own)Ptr(?=\W)'
bad_type_usage = search(match_ref_or_own_ptr, type_text)
-if not bad_type_usage:
+if not bad_type_usage or type_text.endswith(''):
return
type_name = bad_type_usage.group(0)
error(row, 'readability/pass_ptr', 5,
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (94802 => 94803)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-09-08 21:38:04 UTC (rev 94802)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-09-08 21:50:48 UTC (rev 94803)
@@ -3275,6 +3275,11 @@
'{\n'
'}',
'The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]')
+self.assert_pass_ptr_check(
+'int myFunction(RefPtrType1)\n'
+'{\n'
+'}',
+'')
def test_own_ptr_parameter_value(self):
self.assert_pass_ptr_check(
@@ -3287,6 +3292,11 @@
'{\n'
'}',
'The parameter type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5]')
+self.assert_pass_ptr_check(
+'int myFunction(OwnPtrType1 simple)\n'
+'{\n'
+'}',
+'')
def test_ref_ptr_member_variable(self):
self.assert_pass_ptr_check(
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94804] trunk/Source/WebKit2
Title: [94804] trunk/Source/WebKit2
Revision 94804
Author ander...@apple.com
Date 2011-09-08 14:51:58 -0700 (Thu, 08 Sep 2011)
Log Message
Don't release the modal placeholder window if it's closed
https://bugs.webkit.org/show_bug.cgi?id=67801
rdar://problem/10088059
Reviewed by Adam Roben.
This is a speculative fix - nothing should really be able to close the modal placeholder window.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::beginModal):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94803 => 94804)
--- trunk/Source/WebKit2/ChangeLog 2011-09-08 21:50:48 UTC (rev 94803)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-08 21:51:58 UTC (rev 94804)
@@ -1,3 +1,16 @@
+2011-09-08 Anders Carlsson ander...@apple.com
+
+Don't release the modal placeholder window if it's closed
+https://bugs.webkit.org/show_bug.cgi?id=67801
+rdar://problem/10088059
+
+Reviewed by Adam Roben.
+
+This is a speculative fix - nothing should really be able to close the modal placeholder window.
+
+* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
+(WebKit::PluginProcessProxy::beginModal):
+
2011-09-07 Alexei Svitkine asvitk...@chromium.org
Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
Modified: trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm (94803 => 94804)
--- trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2011-09-08 21:50:48 UTC (rev 94803)
+++ trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2011-09-08 21:51:58 UTC (rev 94804)
@@ -210,6 +210,7 @@
ASSERT(!m_activationObserver);
m_placeholderWindow.adoptNS([[WKPlaceholderModalWindow alloc] initWithContentRect:NSMakeRect(0, 0, 1, 1) styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES]);
+[m_placeholderWindow.get() setReleasedWhenClosed:NO];
m_activationObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationWillBecomeActiveNotification object:NSApp queue:nil
usingBlock:^(NSNotification *){ applicationDidBecomeActive(); }];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94805] trunk
Title: [94805] trunk Revision 94805 Author commit-qu...@webkit.org Date 2011-09-08 14:52:10 -0700 (Thu, 08 Sep 2011) Log Message Unreviewed, rolling out r94781. http://trac.webkit.org/changeset/94781 https://bugs.webkit.org/show_bug.cgi?id=67806 Broke Objective-C binding on Mac (Requested by rniwa on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-08 Source/WebCore: * dom/Element.idl: * dom/Node.cpp: (WebCore::Node::contains): * dom/Node.idl: * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): LayoutTests: * fast/dom/Element/contains-method-expected.txt: Added. * fast/dom/Element/contains-method.html: Renamed from LayoutTests/fast/dom/Node/contains-method.html. * fast/dom/Element/script-tests/contains-method.js: Added. * fast/dom/Node/contains-method-expected.txt: Removed. * fast/dom/Node/script-tests/contains-method.js: Removed. * fast/dom/Window/window-properties-expected.txt: * perf/document-contains-expected.txt: Removed. * perf/document-contains.html: Removed. * platform/gtk/fast/dom/Window/window-properties-expected.txt: * platform/mac/fast/dom/Window/window-properties-expected.txt: * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-properties-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.idl trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.idl trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp Added Paths trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt trunk/LayoutTests/fast/dom/Element/contains-method.html trunk/LayoutTests/fast/dom/Element/script-tests/contains-method.js Removed Paths trunk/LayoutTests/fast/dom/Node/contains-method-expected.txt trunk/LayoutTests/fast/dom/Node/contains-method.html trunk/LayoutTests/fast/dom/Node/script-tests/contains-method.js trunk/LayoutTests/perf/document-contains-expected.txt trunk/LayoutTests/perf/document-contains.html Diff Modified: trunk/LayoutTests/ChangeLog (94804 => 94805) --- trunk/LayoutTests/ChangeLog 2011-09-08 21:51:58 UTC (rev 94804) +++ trunk/LayoutTests/ChangeLog 2011-09-08 21:52:10 UTC (rev 94805) @@ -1,3 +1,25 @@ +2011-09-08 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r94781. +http://trac.webkit.org/changeset/94781 +https://bugs.webkit.org/show_bug.cgi?id=67806 + +Broke Objective-C binding on Mac (Requested by rniwa on +#webkit). + +* fast/dom/Element/contains-method-expected.txt: Added. +* fast/dom/Element/contains-method.html: Renamed from LayoutTests/fast/dom/Node/contains-method.html. +* fast/dom/Element/script-tests/contains-method.js: Added. +* fast/dom/Node/contains-method-expected.txt: Removed. +* fast/dom/Node/script-tests/contains-method.js: Removed. +* fast/dom/Window/window-properties-expected.txt: +* perf/document-contains-expected.txt: Removed. +* perf/document-contains.html: Removed. +* platform/gtk/fast/dom/Window/window-properties-expected.txt: +* platform/mac/fast/dom/Window/window-properties-expected.txt: +* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-properties-expected.txt: + 2011-09-08 Csaba Osztrogonác o...@webkit.org [WK2] evetSender.keyDown is unimplemented Added: trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt (0 => 94805) --- trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/Element/contains-method-expected.txt 2011-09-08 21:52:10 UTC (rev 94805) @@ -0,0 +1,15 @@ +This test checks behavior of Element.contains. + +[test1 [test 2]] +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS document.contains is undefined. +PASS test1.contains(test2) is true +PASS test1.contains(test1TextChild) is false +PASS test1.contains(123) is false +PASS test1.contains(null) is false +PASS successfullyParsed is true + +TEST COMPLETE + Copied: trunk/LayoutTests/fast/dom/Element/contains-method.html (from rev 94802, trunk/LayoutTests/fast/dom/Node/contains-method.html) (0 => 94805) --- trunk/LayoutTests/fast/dom/Element/contains-method.html (rev 0) +++ trunk/LayoutTests/fast/dom/Element/contains-method.html 2011-09-08 21:52:10 UTC (rev 94805) @@ -0,0 +1,13 @@ +!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN +html +head +link rel=stylesheet
[webkit-changes] [94806] trunk/Source/JavaScriptCore
Title: [94806] trunk/Source/_javascript_Core
Revision 94806
Author rn...@webkit.org
Date 2011-09-08 14:53:33 -0700 (Thu, 08 Sep 2011)
Log Message
Build fix.
* dfg/DFGCapabilities.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94805 => 94806)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-08 21:52:10 UTC (rev 94805)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-08 21:53:33 UTC (rev 94806)
@@ -1,3 +1,9 @@
+2011-09-08 Ryosuke Niwa rn...@webkit.org
+
+Build fix.
+
+* dfg/DFGCapabilities.cpp:
+
2011-09-08 Filip Pizlo fpi...@apple.com
Value profling and execution count profiling is performed even for
Modified: trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp (94805 => 94806)
--- trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp 2011-09-08 21:52:10 UTC (rev 94805)
+++ trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp 2011-09-08 21:53:33 UTC (rev 94806)
@@ -31,6 +31,8 @@
namespace JSC { namespace DFG {
+#if ENABLE(DFG_JIT)
+
bool canCompileOpcodes(CodeBlock* codeBlock)
{
Interpreter* interpreter = codeBlock-globalData()-interpreter;
@@ -56,5 +58,7 @@
return true;
}
+#endif
+
} } // namespace JSC::DFG
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94807] trunk/LayoutTests
Title: [94807] trunk/LayoutTests Revision 94807 Author jap...@chromium.org Date 2011-09-08 15:04:55 -0700 (Thu, 08 Sep 2011) Log Message 2011-09-08 Nate Chapin jap...@chromium.org Chromium rebaseline zoom-animator-scale-test.html and mark a couple svg-as-background tests flaky on chromium-win. * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Removed. * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Removed. * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added. * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png trunk/LayoutTests/platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png trunk/LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94806 => 94807) --- trunk/LayoutTests/ChangeLog 2011-09-08 21:53:33 UTC (rev 94806) +++ trunk/LayoutTests/ChangeLog 2011-09-08 22:04:55 UTC (rev 94807) @@ -1,3 +1,14 @@ +2011-09-08 Nate Chapin jap...@chromium.org + +Chromium rebaseline zoom-animator-scale-test.html and mark a couple +svg-as-background tests flaky on chromium-win. + +* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Removed. +* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Removed. +* platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added. +* platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added. +* platform/chromium/test_expectations.txt: + 2011-09-08 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r94781. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94806 => 94807) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 21:53:33 UTC (rev 94806) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 22:04:55 UTC (rev 94807) @@ -3717,3 +3717,6 @@ BUG_REED : fast/canvas/canvas-text-baseline.html = IMAGE BUG_REED : fast/canvas/quadraticCurveTo.xml = IMAGE BUG_REED : fast/canvas/canvas-lineWidth.html = TEXT + +BUG_ABARTH WIN : svg/as-background-image/svg-as-background-1.html = PASS IMAGE +BUG_ABARTH WIN : svg/as-background-image/svg-as-background-3.html = PASS IMAGE Deleted: trunk/LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png (94806 => 94807) --- trunk/LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png 2011-09-08 21:53:33 UTC (rev 94806) +++ trunk/LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png 2011-09-08 22:04:55 UTC (rev 94807) @@ -1,7 +0,0 @@ -\x89PNG - - -IHDR X ' )tEXtchecksum ff340bdf811048be7f4e8f8f83497749F\x80\xF7\xD3 -\xBFIDATx\x9C\xED\xD8\xD1 BAAO\xCC[\x8C|M\xA2a\xE1]U\xF3\xD9̙\x99 \x9D\xF7\xF6 \x80\xA7X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X \xB1\xCF\xF6\x80K\x9D\xDFٞp\xA3\xF9\xCE\xF6 \xAE\xE0\xC1 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88
[webkit-changes] [94808] trunk/LayoutTests
Title: [94808] trunk/LayoutTests Revision 94808 Author t...@chromium.org Date 2011-09-08 15:10:42 -0700 (Thu, 08 Sep 2011) Log Message remove fast/exclusions/triangle-exclusion.html which was originally added as a placeholder https://bugs.webkit.org/show_bug.cgi?id=67795 * fast/exclusions/triangle-exclusion.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/fast/exclusions/triangle-exclusion.html Diff Modified: trunk/LayoutTests/ChangeLog (94807 => 94808) --- trunk/LayoutTests/ChangeLog 2011-09-08 22:04:55 UTC (rev 94807) +++ trunk/LayoutTests/ChangeLog 2011-09-08 22:10:42 UTC (rev 94808) @@ -1,3 +1,10 @@ +2011-09-08 Tony Chang t...@chromium.org + +remove fast/exclusions/triangle-exclusion.html which was originally added as a placeholder +https://bugs.webkit.org/show_bug.cgi?id=67795 + +* fast/exclusions/triangle-exclusion.html: Removed. + 2011-09-08 Nate Chapin jap...@chromium.org Chromium rebaseline zoom-animator-scale-test.html and mark a couple Deleted: trunk/LayoutTests/fast/exclusions/triangle-exclusion.html (94807 => 94808) --- trunk/LayoutTests/fast/exclusions/triangle-exclusion.html 2011-09-08 22:04:55 UTC (rev 94807) +++ trunk/LayoutTests/fast/exclusions/triangle-exclusion.html 2011-09-08 22:10:42 UTC (rev 94808) @@ -1,20 +0,0 @@ -!DOCTYPE HTML - -html -head - -!-- This test is empty for now, as the syntax for exclusions - is still under discussion. When we have a new spec draft - available this test will define a triangular exclusion on the - left side of the window and flow two lines of content next to - it. Validation should check that the second line box is - positioned farther right and has less width than the first - line box (this will be described in the test content, and - checked by a DumpRenderTree result) -- - -style type=text/css -/style -/head -body -/body -/html \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94810] trunk/Source/WebCore
Title: [94810] trunk/Source/WebCore
Revision 94810
Author aba...@webkit.org
Date 2011-09-08 15:20:39 -0700 (Thu, 08 Sep 2011)
Log Message
Inline DocumentWriter::encoding() into it's only caller: deprecatedFrameEncoding()
https://bugs.webkit.org/show_bug.cgi?id=67807
Reviewed by Eric Seidel.
This function is super nutty. We don't want any more folks to call it
thinking that it does something sane.
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::deprecatedFrameEncoding):
* loader/DocumentWriter.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/DocumentWriter.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94809 => 94810)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 22:17:34 UTC (rev 94809)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 22:20:39 UTC (rev 94810)
@@ -1,3 +1,17 @@
+2011-09-08 Adam Barth aba...@webkit.org
+
+Inline DocumentWriter::encoding() into it's only caller: deprecatedFrameEncoding()
+https://bugs.webkit.org/show_bug.cgi?id=67807
+
+Reviewed by Eric Seidel.
+
+This function is super nutty. We don't want any more folks to call it
+thinking that it does something sane.
+
+* loader/DocumentWriter.cpp:
+(WebCore::DocumentWriter::deprecatedFrameEncoding):
+* loader/DocumentWriter.h:
+
2011-09-08 Roland Steiner rolandstei...@chromium.org
style scoped: Add 'scoped' attribute
Modified: trunk/Source/WebCore/loader/DocumentWriter.cpp (94809 => 94810)
--- trunk/Source/WebCore/loader/DocumentWriter.cpp 2011-09-08 22:17:34 UTC (rev 94809)
+++ trunk/Source/WebCore/loader/DocumentWriter.cpp 2011-09-08 22:20:39 UTC (rev 94810)
@@ -236,16 +236,6 @@
m_parser = 0;
}
-String DocumentWriter::encoding() const
-{
-if (m_encodingWasChosenByUser !m_encoding.isEmpty())
-return m_encoding;
-if (m_decoder m_decoder-encoding().isValid())
-return m_decoder-encoding().name();
-Settings* settings = m_frame-settings();
-return settings ? settings-defaultTextEncodingName() : String();
-}
-
void DocumentWriter::setEncoding(const String name, bool userChosen)
{
m_frame-loader()-willSetEncoding();
@@ -255,7 +245,17 @@
String DocumentWriter::deprecatedFrameEncoding() const
{
-return m_frame-document()-url().isEmpty() ? m_encoding : encoding();
+if (m_frame-document()-url().isEmpty())
+return m_encoding;
+
+if (m_encodingWasChosenByUser !m_encoding.isEmpty())
+return m_encoding;
+
+if (m_decoder m_decoder-encoding().isValid())
+return m_decoder-encoding().name();
+
+Settings* settings = m_frame-settings();
+return settings ? settings-defaultTextEncodingName() : String();
}
void DocumentWriter::setDocumentWasLoadedAsPartOfNavigation()
Modified: trunk/Source/WebCore/loader/DocumentWriter.h (94809 => 94810)
--- trunk/Source/WebCore/loader/DocumentWriter.h 2011-09-08 22:17:34 UTC (rev 94809)
+++ trunk/Source/WebCore/loader/DocumentWriter.h 2011-09-08 22:20:39 UTC (rev 94810)
@@ -57,7 +57,6 @@
void setFrame(Frame* frame) { m_frame = frame; }
-String encoding() const;
void setEncoding(const String encoding, bool userChosen);
// FIXME: It's really unforunate to need to expose this piece of state.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94812] trunk
Title: [94812] trunk Revision 94812 Author bweinst...@apple.com Date 2011-09-08 15:45:12 -0700 (Thu, 08 Sep 2011) Log Message Source/WebKit2: WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string https://bugs.webkit.org/show_bug.cgi?id=67794 rdar://problem/9892024 Don't call didPerformClientRedirect or didPerformServerRedirect when source or destination URL string is empty or null. If we call didPerformClientRedirect or didPerformServerRedirect when the source or destination is null, it causes an assert in WKURLCF::WKURLCopyCFURL when we try to convert the WKURLRef into a CFURLRef. Reviewed by Brady Eidson. * UIProcess/WebContext.cpp: (WebKit::WebContext::didPerformClientRedirect): Return early if the source or destination URL string is empty or null. (WebKit::WebContext::didPerformServerRedirect): Ditto. Tools: WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string https://bugs.webkit.org/show_bug.cgi?id=67794 rdar://problem/9892024 Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest. Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added. (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both. (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect. (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html. Once both frames have loaded (main frame and blocked iframe), make sure that we have never called didPerformServerRedirect. * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added. (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize our InjectedBundleTest. (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block the request. (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient. * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto. * TestWebKitAPI/win/copy-resources.cmd: Ditto. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj trunk/Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj trunk/Tools/TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj trunk/Tools/TestWebKitAPI/win/copy-resources.cmd Added Paths trunk/Tools/TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp trunk/Tools/TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp trunk/Tools/TestWebKitAPI/Tests/WebKit2/simple-iframe.html Diff Modified: trunk/Source/WebKit2/ChangeLog (94811 => 94812) --- trunk/Source/WebKit2/ChangeLog 2011-09-08 22:38:44 UTC (rev 94811) +++ trunk/Source/WebKit2/ChangeLog 2011-09-08 22:45:12 UTC (rev 94812) @@ -1,3 +1,21 @@ +2011-09-08 Brian Weinstein bweinst...@apple.com + +WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string +https://bugs.webkit.org/show_bug.cgi?id=67794 +rdar://problem/9892024 + +Don't call didPerformClientRedirect or didPerformServerRedirect when source or destination URL string +is empty or null. + +If we call didPerformClientRedirect or didPerformServerRedirect when the source or destination is null, +it causes an assert in WKURLCF::WKURLCopyCFURL when we try to convert the WKURLRef into a CFURLRef. + +Reviewed by Brady Eidson. + +* UIProcess/WebContext.cpp: +(WebKit::WebContext::didPerformClientRedirect): Return early if the source or destination URL string is empty or null. +(WebKit::WebContext::didPerformServerRedirect): Ditto. + 2011-09-08 Sam Weinig s...@webkit.org Remove the Completion object from JSC, I have never liked it Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (94811 => 94812) --- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-09-08 22:38:44 UTC (rev 94811) +++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-09-08 22:45:12 UTC (rev 94812) @@ -432,6 +432,9 @@ WebPageProxy* page = m_process-webPage(pageID); if (!page) return; + +if (sourceURLString.isEmpty() || destinationURLString.isEmpty()) +return; WebFrameProxy* frame = m_process-webFrame(frameID); MESSAGE_CHECK(frame); @@ -446,6 +449,9 @@ if
[webkit-changes] [94813] trunk
Title: [94813] trunk
Revision 94813
Author rolandstei...@chromium.org
Date 2011-09-08 15:45:23 -0700 (Thu, 08 Sep 2011)
Log Message
Unreviewed, rolling out r94809.
http://trac.webkit.org/changeset/94809
https://bugs.webkit.org/show_bug.cgi?id=67718
commit _still_ premature, despite CQ eagerness
Source/WebCore:
* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:
LayoutTests:
* fast/css/style-scoped/basic-attribute-expected.txt: Removed.
* fast/css/style-scoped/basic-attribute.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAttributeNames.in
trunk/Source/WebCore/html/HTMLStyleElement.cpp
trunk/Source/WebCore/html/HTMLStyleElement.h
trunk/Source/WebCore/html/HTMLStyleElement.idl
Removed Paths
trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt
trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94812 => 94813)
--- trunk/LayoutTests/ChangeLog 2011-09-08 22:45:12 UTC (rev 94812)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 22:45:23 UTC (rev 94813)
@@ -1,5 +1,16 @@
2011-09-08 Roland Steiner rolandstei...@chromium.org
+Unreviewed, rolling out r94809.
+http://trac.webkit.org/changeset/94809
+https://bugs.webkit.org/show_bug.cgi?id=67718
+
+commit _still_ premature, despite CQ eagerness
+
+* fast/css/style-scoped/basic-attribute-expected.txt: Removed.
+* fast/css/style-scoped/basic-attribute.html: Removed.
+
+2011-09-08 Roland Steiner rolandstei...@chromium.org
+
style scoped: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718
Deleted: trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt (94812 => 94813)
--- trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt 2011-09-08 22:45:12 UTC (rev 94812)
+++ trunk/LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt 2011-09-08 22:45:23 UTC (rev 94813)
@@ -1,62 +0,0 @@
-Basic test for the style scoped attribute.
-
Initial ---
-PASS global1.getAttribute('scoped') is null
-PASS global1.scoped is false
-PASS global2.getAttribute('scoped') is null
-PASS global2.scoped is false
-PASS testBooleanAttribute(scoped1, 'scoped') is true
-PASS scoped1.scoped is true
-PASS testBooleanAttribute(scoped2, 'scoped') is true
-PASS scoped2.scoped is true
-PASS testBooleanAttribute(scoped3, 'scoped') is true
-PASS scoped3.scoped is true
After insertion into tree ---
-PASS global1.getAttribute('scoped') is null
-PASS global1.scoped is false
-PASS global2.getAttribute('scoped') is null
-PASS global2.scoped is false
-PASS testBooleanAttribute(scoped1, 'scoped') is true
-PASS scoped1.scoped is true
-PASS testBooleanAttribute(scoped2, 'scoped') is true
-PASS scoped2.scoped is true
-PASS testBooleanAttribute(scoped3, 'scoped') is true
-PASS scoped3.scoped is true
Inverting 'scoped' attribute while in tree ---
-PASS testBooleanAttribute(global1, 'scoped') is true
-PASS global1.scoped is true
-PASS testBooleanAttribute(global2, 'scoped') is true
-PASS global2.scoped is true
-PASS scoped1.getAttribute('scoped') is null
-PASS scoped1.scoped is false
-PASS scoped2.getAttribute('scoped') is null
-PASS scoped2.scoped is false
-PASS scoped3.getAttribute('scoped') is null
-PASS scoped3.scoped is false
After removal from tree (attribute is still inverted) ---
-PASS testBooleanAttribute(global1, 'scoped') is true
-PASS global1.scoped is true
-PASS testBooleanAttribute(global2, 'scoped') is true
-PASS global2.scoped is true
-PASS scoped1.getAttribute('scoped') is null
-PASS scoped1.scoped is false
-PASS scoped2.getAttribute('scoped') is null
-PASS scoped2.scoped is false
-PASS scoped3.getAttribute('scoped') is null
-PASS scoped3.scoped is false
Inverting 'scoped' attribute again, while outside tree ---
-PASS global1.getAttribute('scoped') is null
-PASS global1.scoped is false
-PASS global2.getAttribute('scoped') is null
-PASS global2.scoped is false
-PASS testBooleanAttribute(scoped1, 'scoped') is true
-PASS scoped1.scoped is true
-PASS testBooleanAttribute(scoped2, 'scoped') is true
-PASS scoped2.scoped is true
-PASS testBooleanAttribute(scoped3, 'scoped') is true
-PASS scoped3.scoped is true
DONE ---
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html (94812 => 94813)
--- trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html 2011-09-08 22:45:12 UTC (rev 94812)
+++ trunk/LayoutTests/fast/css/style-scoped/basic-attribute.html 2011-09-08 22:45:23 UTC (rev 94813)
@@ -1,124 +0,0 @@
-html
-head
-link rel=stylesheet href=""
-script src=""
-/head
-body
-pBasic test for the lt;style scopedgt; attribute./p
-div id=scope
-style id=global1/style
-style scoped='scoped' id=scoped1/style
-/div
-
-div id=console/div
-
[webkit-changes] [94814] trunk/Source
Title: [94814] trunk/Source Revision 94814 Author oli...@apple.com Date 2011-09-08 15:52:04 -0700 (Thu, 08 Sep 2011) Log Message Use bump allocator for initial property storage https://bugs.webkit.org/show_bug.cgi?id=67494 Reviewed by Geoffrey Garen. ../../../../Volumes/Data/git/WebKit/OpenSource/Source/_javascript_Core: Use a bump allocator for initial allocation of property storage, and promote to fastMalloc memory only if it survives a GC pass. Comes out as a 1% win on v8, and is a useful step on the way to GC allocation of all property storage. * _javascript_Core.exp: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: * _javascript_Core.xcodeproj/project.pbxproj: * heap/Heap.cpp: (JSC::Heap::collect): * heap/Heap.h: (JSC::Heap::allocatePropertyStorage): (JSC::Heap::inPropertyStorageNursery): * heap/MarkedBlock.h: * heap/NewSpace.cpp: (JSC::NewSpace::NewSpace): * heap/NewSpace.h: (JSC::NewSpace::resetPropertyStorageNursery): (JSC::NewSpace::allocatePropertyStorage): (JSC::NewSpace::inPropertyStorageNursery): * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): * runtime/JSObject.cpp: (JSC::JSObject::allocatePropertyStorage): * runtime/JSObject.h: (JSC::JSObject::isUsingInlineStorage): (JSC::JSObject::JSObject): (JSC::JSObject::propertyStorage): (JSC::JSObject::~JSObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSObject::transitionTo): (JSC::JSObject::visitChildrenDirect): * runtime/StorageBarrier.h: Added. (JSC::StorageBarrier::StorageBarrier): (JSC::StorageBarrier::set): (JSC::StorageBarrier::operator-): (JSC::StorageBarrier::operator*): (JSC::StorageBarrier::operator[]): (JSC::StorageBarrier::get): ../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore: Add a forwarding header. * ForwardingHeaders/runtime/StorageBarrier.h: Added. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/_javascript_Core.gypi trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/heap/Heap.h trunk/Source/_javascript_Core/heap/MarkedBlock.h trunk/Source/_javascript_Core/heap/NewSpace.cpp trunk/Source/_javascript_Core/heap/NewSpace.h trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h trunk/Source/WebCore/ChangeLog Added Paths trunk/Source/_javascript_Core/runtime/StorageBarrier.h trunk/Source/WebCore/ForwardingHeaders/runtime/StorageBarrier.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94813 => 94814) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-08 22:45:23 UTC (rev 94813) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-08 22:52:04 UTC (rev 94814) @@ -1,3 +1,53 @@ +2011-09-08 Oliver Hunt oli...@apple.com + +Use bump allocator for initial property storage +https://bugs.webkit.org/show_bug.cgi?id=67494 + +Reviewed by Geoffrey Garen. + +Use a bump allocator for initial allocation of property storage, +and promote to fastMalloc memory only if it survives a GC pass. + +Comes out as a 1% win on v8, and is a useful step on the way to +GC allocation of all property storage. + +* _javascript_Core.exp: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: +* _javascript_Core.xcodeproj/project.pbxproj: +* heap/Heap.cpp: +(JSC::Heap::collect): +* heap/Heap.h: +(JSC::Heap::allocatePropertyStorage): +(JSC::Heap::inPropertyStorageNursery): +* heap/MarkedBlock.h: +* heap/NewSpace.cpp: +(JSC::NewSpace::NewSpace): +* heap/NewSpace.h: +(JSC::NewSpace::resetPropertyStorageNursery): +(JSC::NewSpace::allocatePropertyStorage): +(JSC::NewSpace::inPropertyStorageNursery): +* jit/JITStubs.cpp: +(JSC::DEFINE_STUB_FUNCTION): +* runtime/JSObject.cpp: +(JSC::JSObject::allocatePropertyStorage): +* runtime/JSObject.h: +(JSC::JSObject::isUsingInlineStorage): +(JSC::JSObject::JSObject): +(JSC::JSObject::propertyStorage): +(JSC::JSObject::~JSObject): +(JSC::JSObject::putDirectInternal): +(JSC::JSObject::putDirectWithoutTransition): +(JSC::JSObject::putDirectFunctionWithoutTransition): +(JSC::JSObject::transitionTo): +(JSC::JSObject::visitChildrenDirect): +* runtime/StorageBarrier.h: Added. +(JSC::StorageBarrier::StorageBarrier): +(JSC::StorageBarrier::set): +(JSC::StorageBarrier::operator-): +(JSC::StorageBarrier::operator*): +
[webkit-changes] [94816] trunk/Source/WebKit/chromium
Title: [94816] trunk/Source/WebKit/chromium
Revision 94816
Author aba...@webkit.org
Date 2011-09-08 16:03:46 -0700 (Thu, 08 Sep 2011)
Log Message
Attempt to fix Chromium build. We can just grab the encoding from the document.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebDocument.cpp:
(WebKit::WebDocument::encoding):
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
* src/WebSearchableFormData.cpp:
(HTMLNames::GetFormEncoding):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::pageEncoding):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebDocument.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp
trunk/Source/WebKit/chromium/src/WebSearchableFormData.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (94815 => 94816)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-08 22:56:16 UTC (rev 94815)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-08 23:03:46 UTC (rev 94816)
@@ -1,3 +1,18 @@
+2011-09-08 Adam Barth aba...@webkit.org
+
+Attempt to fix Chromium build. We can just grab the encoding from the document.
+
+* src/ContextMenuClientImpl.cpp:
+(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+* src/WebDocument.cpp:
+(WebKit::WebDocument::encoding):
+* src/WebPageSerializerImpl.cpp:
+(WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
+* src/WebSearchableFormData.cpp:
+(HTMLNames::GetFormEncoding):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::pageEncoding):
+
2011-09-08 W. James MacLean wjmacl...@chromium.org
[chromium] Add backend compositor support for rescaling (zooming) textures during zoom animation.
Modified: trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp (94815 => 94816)
--- trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp 2011-09-08 22:56:16 UTC (rev 94815)
+++ trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp 2011-09-08 23:03:46 UTC (rev 94816)
@@ -244,7 +244,7 @@
// If it's not a link, an image, a media element, or an image/media link,
// show a selection menu or a more generic page menu.
if (selectedFrame-document()-loader())
-data.frameEncoding = selectedFrame-document()-loader()-writer()-encoding();
+data.frameEncoding = selectedFrame-document()-encoding();
// Send the frame and page URLs in any case.
data.pageURL = urlFromFrame(m_webView-mainFrameImpl()-frame());
Modified: trunk/Source/WebKit/chromium/src/WebDocument.cpp (94815 => 94816)
--- trunk/Source/WebKit/chromium/src/WebDocument.cpp 2011-09-08 22:56:16 UTC (rev 94815)
+++ trunk/Source/WebKit/chromium/src/WebDocument.cpp 2011-09-08 23:03:46 UTC (rev 94816)
@@ -74,7 +74,7 @@
WebString WebDocument::encoding() const
{
-return constUnwrapDocument()-loader()-writer()-encoding();
+return constUnwrapDocument()-encoding();
}
WebURL WebDocument::openSearchDescriptionURL() const
Modified: trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp (94815 => 94816)
--- trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp 2011-09-08 22:56:16 UTC (rev 94815)
+++ trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp 2011-09-08 23:03:46 UTC (rev 94816)
@@ -169,7 +169,7 @@
// Get encoding info.
String xmlEncoding = param-document-xmlEncoding();
if (xmlEncoding.isEmpty())
-xmlEncoding = param-document-loader()-writer()-encoding();
+xmlEncoding = param-document-encoding();
if (xmlEncoding.isEmpty())
xmlEncoding = UTF8Encoding().name();
result.append(?xml version=\);
Modified: trunk/Source/WebKit/chromium/src/WebSearchableFormData.cpp (94815 => 94816)
--- trunk/Source/WebKit/chromium/src/WebSearchableFormData.cpp 2011-09-08 22:56:16 UTC (rev 94815)
+++ trunk/Source/WebKit/chromium/src/WebSearchableFormData.cpp 2011-09-08 23:03:46 UTC (rev 94816)
@@ -66,7 +66,7 @@
}
if (!form-document()-loader())
return;
-*encoding = TextEncoding(form-document()-loader()-writer()-encoding());
+*encoding = TextEncoding(form-document()-encoding());
}
// Returns true if the submit request results in an HTTP URL.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (94815 => 94816)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-08 22:56:16 UTC (rev 94815)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-08 23:03:46 UTC (rev 94816)
@@ -1680,10 +1680,11 @@
if (!m_page.get())
return WebString();
+// FIXME: Is this check needed?
if (!m_page-mainFrame()-document()-loader())
return WebString();
-return
[webkit-changes] [94817] trunk/Source/WebCore
Title: [94817] trunk/Source/WebCore
Revision 94817
Author aba...@webkit.org
Date 2011-09-08 16:15:48 -0700 (Thu, 08 Sep 2011)
Log Message
Second attempt to fix Chromium build.
* dom/Document.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94816 => 94817)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 23:03:46 UTC (rev 94816)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 23:15:48 UTC (rev 94817)
@@ -1,3 +1,9 @@
+2011-09-08 Adam Barth aba...@webkit.org
+
+Second attempt to fix Chromium build.
+
+* dom/Document.h:
+
2011-09-08 Oliver Hunt oli...@apple.com
Use bump allocator for initial property storage
Modified: trunk/Source/WebCore/dom/Document.h (94816 => 94817)
--- trunk/Source/WebCore/dom/Document.h 2011-09-08 23:03:46 UTC (rev 94816)
+++ trunk/Source/WebCore/dom/Document.h 2011-09-08 23:15:48 UTC (rev 94817)
@@ -365,11 +365,13 @@
String readyState() const;
String defaultCharset() const;
-
+
String inputEncoding() const { return Document::encoding(); }
String charset() const { return Document::encoding(); }
String characterSet() const { return Document::encoding(); }
+String encoding() const;
+
void setCharset(const String);
void setContent(const String);
@@ -1126,8 +1128,6 @@
virtual double minimumTimerInterval() const;
-String encoding() const;
-
void updateTitle(const StringWithDirection);
void updateFocusAppearanceTimerFired(TimerDocument*);
void updateBaseURL();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94818] trunk/Source/WebKit2
Title: [94818] trunk/Source/WebKit2 Revision 94818 Author mr...@apple.com Date 2011-09-08 16:29:57 -0700 (Thu, 08 Sep 2011) Log Message rdar://problem/9742393 Spell checking a text area causes the page to reload Ensure that m_pendingLearnOrIgnoreWordMessageCount is incremented when we use executeEditCommand to ignore a word. This will ensure that WebPageProxy::ignoreWord is expecting to be called, and will not turn around and terminate the web process. Reviewed by Anders Carlsson. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::executeEditCommand): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (94817 => 94818) --- trunk/Source/WebKit2/ChangeLog 2011-09-08 23:15:48 UTC (rev 94817) +++ trunk/Source/WebKit2/ChangeLog 2011-09-08 23:29:57 UTC (rev 94818) @@ -1,3 +1,16 @@ +2011-09-08 Mark Rowe mr...@apple.com + +rdar://problem/9742393 Spell checking a text area causes the page to reload + +Ensure that m_pendingLearnOrIgnoreWordMessageCount is incremented when we use +executeEditCommand to ignore a word. This will ensure that WebPageProxy::ignoreWord +is expecting to be called, and will not turn around and terminate the web process. + +Reviewed by Anders Carlsson. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::executeEditCommand): + 2011-09-08 Sam Weinig s...@webkit.org Remove accidentally committed typo. Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (94817 => 94818) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-09-08 23:15:48 UTC (rev 94817) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-09-08 23:29:57 UTC (rev 94818) @@ -726,6 +726,10 @@ if (!isValid()) return; +DEFINE_STATIC_LOCAL(String, ignoreSpellingCommandName, (ignoreSpelling)); +if (commandName == ignoreSpellingCommandName) +++m_pendingLearnOrIgnoreWordMessageCount; + process()-send(Messages::WebPage::ExecuteEditCommand(commandName), m_pageID); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94819] trunk/Source/WebKit/chromium
Title: [94819] trunk/Source/WebKit/chromium Revision 94819 Author aba...@webkit.org Date 2011-09-08 16:30:53 -0700 (Thu, 08 Sep 2011) Log Message Another attempt to fix the Chromium build. (Missed one.) * src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::serialize): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (94818 => 94819) --- trunk/Source/WebKit/chromium/ChangeLog 2011-09-08 23:29:57 UTC (rev 94818) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-08 23:30:53 UTC (rev 94819) @@ -1,5 +1,12 @@ 2011-09-08 Adam Barth aba...@webkit.org +Another attempt to fix the Chromium build. (Missed one.) + +* src/WebPageSerializerImpl.cpp: +(WebKit::WebPageSerializerImpl::serialize): + +2011-09-08 Adam Barth aba...@webkit.org + Attempt to fix Chromium build. We can just grab the encoding from the document. * src/ContextMenuClientImpl.cpp: Modified: trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp (94818 => 94819) --- trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp 2011-09-08 23:29:57 UTC (rev 94818) +++ trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp 2011-09-08 23:30:53 UTC (rev 94819) @@ -509,7 +509,7 @@ didSerialization = true; -String encoding = document-loader()-writer()-encoding(); +String encoding = document-encoding(); const TextEncoding textEncoding = encoding.isEmpty() ? UTF8Encoding() : TextEncoding(encoding); String directoryName = url == mainURL ? m_localDirectoryName : ; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94820] trunk/Source/WebCore
Title: [94820] trunk/Source/WebCore
Revision 94820
Author a...@apple.com
Date 2011-09-08 16:35:09 -0700 (Thu, 08 Sep 2011)
Log Message
REGRESSION (r66874): Missing RefPtr in ScriptController
https://bugs.webkit.org/show_bug.cgi?id=67748
Reviewed by Adam Barth.
* bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/ScriptControllerBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94819 => 94820)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 23:30:53 UTC (rev 94819)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 23:35:09 UTC (rev 94820)
@@ -1,3 +1,12 @@
+2011-09-08 Alexey Proskuryakov a...@apple.com
+
+REGRESSION (r66874): Missing RefPtr in ScriptController
+https://bugs.webkit.org/show_bug.cgi?id=67748
+
+Reviewed by Adam Barth.
+
+* bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
+
2011-09-08 Adam Barth aba...@webkit.org
Second attempt to fix Chromium build.
Modified: trunk/Source/WebCore/bindings/ScriptControllerBase.cpp (94819 => 94820)
--- trunk/Source/WebCore/bindings/ScriptControllerBase.cpp 2011-09-08 23:30:53 UTC (rev 94819)
+++ trunk/Source/WebCore/bindings/ScriptControllerBase.cpp 2011-09-08 23:35:09 UTC (rev 94820)
@@ -67,6 +67,8 @@
bool wasInExecuteScript = m_inExecuteScript;
m_inExecuteScript = true;
+RefPtrFrame protect(m_frame); // Script execution can destroy the frame, and thus the ScriptController.
+
ScriptValue result = evaluate(sourceCode);
if (!wasInExecuteScript) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94821] trunk/Source/WebCore
Title: [94821] trunk/Source/WebCore Revision 94821 Author le...@chromium.org Date 2011-09-08 16:48:58 -0700 (Thu, 08 Sep 2011) Log Message [chromium] KURL::copy doesn't produce something usable on another thread. https://bugs.webkit.org/show_bug.cgi?id=67809 Reviewed by Adam Barth. No new functionality exposed so no new test. This was caught by testing code: the thread sanitizer run in Chromium (http://code.google.com/p/chromium/issues/detail?id=93708). * platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::copyTo): Clear out the invalid String so that it will not be used on another thread. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/KURLGoogle.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94820 => 94821) --- trunk/Source/WebCore/ChangeLog 2011-09-08 23:35:09 UTC (rev 94820) +++ trunk/Source/WebCore/ChangeLog 2011-09-08 23:48:58 UTC (rev 94821) @@ -1,3 +1,17 @@ +2011-09-08 David Levin le...@chromium.org + +[chromium] KURL::copy doesn't produce something usable on another thread. +https://bugs.webkit.org/show_bug.cgi?id=67809 + +Reviewed by Adam Barth. + +No new functionality exposed so no new test. This was caught by testing code: the thread +sanitizer run in Chromium (http://code.google.com/p/chromium/issues/detail?id=93708). + +* platform/KURLGoogle.cpp: +(WebCore::KURLGooglePrivate::copyTo): Clear out the invalid String so that it will +not be used on another thread. + 2011-09-08 Alexey Proskuryakov a...@apple.com REGRESSION (r66874): Missing RefPtr in ScriptController Modified: trunk/Source/WebCore/platform/KURLGoogle.cpp (94820 => 94821) --- trunk/Source/WebCore/platform/KURLGoogle.cpp 2011-09-08 23:35:09 UTC (rev 94820) +++ trunk/Source/WebCore/platform/KURLGoogle.cpp 2011-09-08 23:48:58 UTC (rev 94821) @@ -284,6 +284,7 @@ dest-m_utf8 = CString(m_utf8.data(), m_utf8.length()); dest-m_utf8IsASCII = m_utf8IsASCII; dest-m_stringIsValid = false; +dest-m_string = String(); // Clear the invalid string to avoid cross thread ref counting. } String KURLGooglePrivate::componentString(const url_parse::Component comp) const ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94823] trunk/Source/WebCore
Title: [94823] trunk/Source/WebCore
Revision 94823
Author t...@chromium.org
Date 2011-09-08 17:50:09 -0700 (Thu, 08 Sep 2011)
Log Message
Cleanup of switch statements with default cases
https://bugs.webkit.org/show_bug.cgi?id=67808
Reviewed by Adam Barth.
No new tests, just a small refactoring.
* page/WebKitAnimation.cpp:
(WebCore::WebKitAnimation::fillMode):
* platform/audio/Distance.cpp:
(WebCore::DistanceEffect::gain):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/WebKitAnimation.cpp
trunk/Source/WebCore/platform/audio/Distance.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94822 => 94823)
--- trunk/Source/WebCore/ChangeLog 2011-09-09 00:34:59 UTC (rev 94822)
+++ trunk/Source/WebCore/ChangeLog 2011-09-09 00:50:09 UTC (rev 94823)
@@ -1,3 +1,17 @@
+2011-09-08 Tony Chang t...@chromium.org
+
+Cleanup of switch statements with default cases
+https://bugs.webkit.org/show_bug.cgi?id=67808
+
+Reviewed by Adam Barth.
+
+No new tests, just a small refactoring.
+
+* page/WebKitAnimation.cpp:
+(WebCore::WebKitAnimation::fillMode):
+* platform/audio/Distance.cpp:
+(WebCore::DistanceEffect::gain):
+
2011-09-08 Eric Seidel e...@webkit.org
[BiDi] Add support for the BDI element
Modified: trunk/Source/WebCore/page/WebKitAnimation.cpp (94822 => 94823)
--- trunk/Source/WebCore/page/WebKitAnimation.cpp 2011-09-09 00:34:59 UTC (rev 94822)
+++ trunk/Source/WebCore/page/WebKitAnimation.cpp 2011-09-09 00:50:09 UTC (rev 94823)
@@ -94,17 +94,15 @@
switch (m_keyframeAnimation-animation()-fillMode()) {
case AnimationFillModeNone:
return FILL_NONE;
-break;
case AnimationFillModeForwards:
return FILL_FORWARDS;
-break;
case AnimationFillModeBackwards:
return FILL_BACKWARDS;
-break;
-default:
+case AnimationFillModeBoth:
return FILL_BOTH;
-break;
}
+ASSERT_NOT_REACHED();
+return FILL_BOTH;
}
void WebKitAnimation::pause()
Modified: trunk/Source/WebCore/platform/audio/Distance.cpp (94822 => 94823)
--- trunk/Source/WebCore/platform/audio/Distance.cpp 2011-09-09 00:34:59 UTC (rev 94822)
+++ trunk/Source/WebCore/platform/audio/Distance.cpp 2011-09-09 00:50:09 UTC (rev 94823)
@@ -60,17 +60,13 @@
switch (m_model) {
case ModelLinear:
return linearGain(distance);
-break;
case ModelInverse:
return inverseGain(distance);
-break;
case ModelExponential:
return exponentialGain(distance);
-break;
-
-default:
-return 0.0;
}
+ASSERT_NOT_REACHED();
+return 0.0;
}
double DistanceEffect::linearGain(double distance)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94824] trunk/Source/WebCore
Title: [94824] trunk/Source/WebCore Revision 94824 Author ad...@chromium.org Date 2011-09-08 18:14:50 -0700 (Thu, 08 Sep 2011) Log Message Always zero-out m_sortedTextBoxesPosition to avoid uninitialized read in TextIterator https://bugs.webkit.org/show_bug.cgi?id=67810 Reviewed by Tony Chang. Reported as a valgrind failure in http://crbug.com/84777. No possible change in behavior, so no tests. The unitialized read could never have an impact: if (m_sortedTextBoxesPosition + 1 m_sortedTextBoxes.size()) ... Since m_sortedTextBoxes.size() will be zero here if m_sortedTextBoxesPosition is uninitialized, and they're both unsigned, so no possible value of m_sortedTextBoxesPosition could be 0. * editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/TextIterator.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94823 => 94824) --- trunk/Source/WebCore/ChangeLog 2011-09-09 00:50:09 UTC (rev 94823) +++ trunk/Source/WebCore/ChangeLog 2011-09-09 01:14:50 UTC (rev 94824) @@ -1,3 +1,24 @@ +2011-09-08 Adam Klein ad...@chromium.org + +Always zero-out m_sortedTextBoxesPosition to avoid uninitialized read in TextIterator +https://bugs.webkit.org/show_bug.cgi?id=67810 + +Reviewed by Tony Chang. + +Reported as a valgrind failure in http://crbug.com/84777. + +No possible change in behavior, so no tests. The unitialized read +could never have an impact: + + if (m_sortedTextBoxesPosition + 1 m_sortedTextBoxes.size()) ... + +Since m_sortedTextBoxes.size() will be zero here if +m_sortedTextBoxesPosition is uninitialized, and they're both unsigned, +so no possible value of m_sortedTextBoxesPosition could be 0. + +* editing/TextIterator.cpp: +(WebCore::TextIterator::TextIterator): + 2011-09-08 Tony Chang t...@chromium.org Cleanup of switch statements with default cases Modified: trunk/Source/WebCore/editing/TextIterator.cpp (94823 => 94824) --- trunk/Source/WebCore/editing/TextIterator.cpp 2011-09-09 00:50:09 UTC (rev 94823) +++ trunk/Source/WebCore/editing/TextIterator.cpp 2011-09-09 01:14:50 UTC (rev 94824) @@ -253,6 +253,7 @@ , m_remainingTextBox(0) , m_firstLetterText(0) , m_lastCharacter(0) +, m_sortedTextBoxesPosition(0) , m_emitsCharactersBetweenAllVisiblePositions(false) , m_entersTextControls(false) , m_emitsTextWithoutTranscoding(false) @@ -272,6 +273,7 @@ , m_textLength(0) , m_remainingTextBox(0) , m_firstLetterText(0) +, m_sortedTextBoxesPosition(0) , m_emitsCharactersBetweenAllVisiblePositions(behavior TextIteratorEmitsCharactersBetweenAllVisiblePositions) , m_entersTextControls(behavior TextIteratorEntersTextControls) , m_emitsTextWithoutTranscoding(behavior TextIteratorEmitsTextsWithoutTranscoding) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94825] trunk/Source/WebCore
Title: [94825] trunk/Source/WebCore Revision 94825 Author aba...@webkit.org Date 2011-09-08 18:25:42 -0700 (Thu, 08 Sep 2011) Log Message DocumentWriter::deprecatedFrameEncoding doesn't need to refert to Settings https://bugs.webkit.org/show_bug.cgi?id=67812 Reviewed by Eric Seidel. The one caller of this function does this work already. * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::deprecatedFrameEncoding): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentWriter.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94824 => 94825) --- trunk/Source/WebCore/ChangeLog 2011-09-09 01:14:50 UTC (rev 94824) +++ trunk/Source/WebCore/ChangeLog 2011-09-09 01:25:42 UTC (rev 94825) @@ -1,3 +1,15 @@ +2011-09-08 Adam Barth aba...@webkit.org + +DocumentWriter::deprecatedFrameEncoding doesn't need to refert to Settings +https://bugs.webkit.org/show_bug.cgi?id=67812 + +Reviewed by Eric Seidel. + +The one caller of this function does this work already. + +* loader/DocumentWriter.cpp: +(WebCore::DocumentWriter::deprecatedFrameEncoding): + 2011-09-08 Adam Klein ad...@chromium.org Always zero-out m_sortedTextBoxesPosition to avoid uninitialized read in TextIterator Modified: trunk/Source/WebCore/loader/DocumentWriter.cpp (94824 => 94825) --- trunk/Source/WebCore/loader/DocumentWriter.cpp 2011-09-09 01:14:50 UTC (rev 94824) +++ trunk/Source/WebCore/loader/DocumentWriter.cpp 2011-09-09 01:25:42 UTC (rev 94825) @@ -254,8 +254,7 @@ if (m_decoder m_decoder-encoding().isValid()) return m_decoder-encoding().name(); -Settings* settings = m_frame-settings(); -return settings ? settings-defaultTextEncodingName() : String(); +return String(); } void DocumentWriter::setDocumentWasLoadedAsPartOfNavigation() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94826] trunk/Source/WebKit/gtk
Title: [94826] trunk/Source/WebKit/gtk
Revision 94826
Author dba...@webkit.org
Date 2011-09-08 18:29:35 -0700 (Thu, 08 Sep 2011)
Log Message
2011-09-08 Daniel Bates dba...@webkit.org
Fix the GTK build after http://trac.webkit.org/changeset/94810
(https://bugs.webkit.org/show_bug.cgi?id=67807).
* webkit/webkitwebview.cpp:
(webkit_web_view_get_encoding): Substitute DocumentWriter::deprecatedFrameEncoding() for
DocumentWriter::encoding().
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (94825 => 94826)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-09-09 01:25:42 UTC (rev 94825)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-09-09 01:29:35 UTC (rev 94826)
@@ -1,3 +1,12 @@
+2011-09-08 Daniel Bates dba...@webkit.org
+
+Fix the GTK build after http://trac.webkit.org/changeset/94810
+(https://bugs.webkit.org/show_bug.cgi?id=67807).
+
+* webkit/webkitwebview.cpp:
+(webkit_web_view_get_encoding): Substitute DocumentWriter::deprecatedFrameEncoding() for
+DocumentWriter::encoding().
+
2011-09-06 Ryosuke Niwa rn...@webkit.org
Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (94825 => 94826)
--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-09-09 01:25:42 UTC (rev 94825)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-09-09 01:29:35 UTC (rev 94826)
@@ -4531,7 +4531,7 @@
const gchar* webkit_web_view_get_encoding(WebKitWebView* webView)
{
g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), NULL);
-String encoding = core(webView)-mainFrame()-document()-loader()-writer()-encoding();
+String encoding = core(webView)-mainFrame()-document()-loader()-writer()-deprecatedFrameEncoding();
if (encoding.isEmpty())
return 0;
webView-priv-encoding = encoding.utf8();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94829] trunk
Title: [94829] trunk
Revision 94829
Author commit-qu...@webkit.org
Date 2011-09-08 19:57:39 -0700 (Thu, 08 Sep 2011)
Log Message
Test how HTMLAnchorElement.getParameter reacts to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66522
Patch by Mark Pilgrim pilg...@chromium.org on 2011-09-08
Reviewed by Adam Barth.
* LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Added.
* LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html: Added.
Modified Paths
trunk/ChangeLog
Added Paths
trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt
trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html
Diff
Modified: trunk/ChangeLog (94828 => 94829)
--- trunk/ChangeLog 2011-09-09 02:40:09 UTC (rev 94828)
+++ trunk/ChangeLog 2011-09-09 02:57:39 UTC (rev 94829)
@@ -1,3 +1,13 @@
+2011-09-08 Mark Pilgrim pilg...@chromium.org
+
+Test how HTMLAnchorElement.getParameter reacts to too few arguments
+https://bugs.webkit.org/show_bug.cgi?id=66522
+
+Reviewed by Adam Barth.
+
+* LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Added.
+* LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html: Added.
+
2011-09-08 Varun Jain varunj...@google.com
Implement double tap detection in GestureRecognizerChromium
Added: trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt (0 => 94829)
--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt 2011-09-09 02:57:39 UTC (rev 94829)
@@ -0,0 +1,10 @@
+Test calling getParameter without required arguments.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS a.getParameter() threw exception TypeError: Not enough arguments.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html (0 => 94829)
--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html 2011-09-09 02:57:39 UTC (rev 94829)
@@ -0,0 +1,21 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script
+description('Test calling getParameter without required arguments.');
+
+var a = document.createElement('a');
+
+shouldThrow(a.getParameter());
+
+var successfullyParsed = true;
+/script
+script src=""
+/body
+/html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94830] branches/chromium/874/Source/WebCore/rendering/RenderScrollbar.cpp
Title: [94830] branches/chromium/874/Source/WebCore/rendering/RenderScrollbar.cpp
Revision 94830
Author infe...@chromium.org
Date 2011-09-08 20:19:44 -0700 (Thu, 08 Sep 2011)
Log Message
Merge 94690 - Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.
BUG=95552
Review URL: http://codereview.chromium.org/7787021
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderScrollbar.cpp
Diff
Modified: branches/chromium/874/Source/WebCore/rendering/RenderScrollbar.cpp (94829 => 94830)
--- branches/chromium/874/Source/WebCore/rendering/RenderScrollbar.cpp 2011-09-09 02:57:39 UTC (rev 94829)
+++ branches/chromium/874/Source/WebCore/rendering/RenderScrollbar.cpp 2011-09-09 03:19:44 UTC (rev 94830)
@@ -195,7 +195,8 @@
if (newThickness != oldThickness) {
setFrameRect(IntRect(x(), y(), isHorizontal ? width() : newThickness, isHorizontal ? newThickness : height()));
-owningRenderer()-setChildNeedsLayout(true);
+if (RenderBox* box = owningRenderer())
+box-setChildNeedsLayout(true);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94831] trunk/Source/WebCore
Title: [94831] trunk/Source/WebCore
Revision 94831
Author commit-qu...@webkit.org
Date 2011-09-08 20:20:59 -0700 (Thu, 08 Sep 2011)
Log Message
Release the reference to the HTMLPlugInElement's script object, when the element is removed from the document. This breaks a cyclical reference that would otherwise cause the element to be retained until the document is torn down.
https://bugs.webkit.org/show_bug.cgi?id=66181
Patch by James Weatherall w...@chromium.org on 2011-09-08
Reviewed by Anders Carlsson.
No new tests - no functional change.
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::removedFromDocument):
* html/HTMLPlugInElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLPlugInElement.cpp
trunk/Source/WebCore/html/HTMLPlugInElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94830 => 94831)
--- trunk/Source/WebCore/ChangeLog 2011-09-09 03:19:44 UTC (rev 94830)
+++ trunk/Source/WebCore/ChangeLog 2011-09-09 03:20:59 UTC (rev 94831)
@@ -1,3 +1,16 @@
+2011-09-08 James Weatherall w...@chromium.org
+
+Release the reference to the HTMLPlugInElement's script object, when the element is removed from the document. This breaks a cyclical reference that would otherwise cause the element to be retained until the document is torn down.
+https://bugs.webkit.org/show_bug.cgi?id=66181
+
+Reviewed by Anders Carlsson.
+
+No new tests - no functional change.
+
+* html/HTMLPlugInElement.cpp:
+(WebCore::HTMLPlugInElement::removedFromDocument):
+* html/HTMLPlugInElement.h:
+
2011-09-08 Daniel Bates dba...@webkit.org
XSS filter bypass via non-standard URL encoding
Modified: trunk/Source/WebCore/html/HTMLPlugInElement.cpp (94830 => 94831)
--- trunk/Source/WebCore/html/HTMLPlugInElement.cpp 2011-09-09 03:19:44 UTC (rev 94830)
+++ trunk/Source/WebCore/html/HTMLPlugInElement.cpp 2011-09-09 03:20:59 UTC (rev 94831)
@@ -81,6 +81,18 @@
HTMLFrameOwnerElement::detach();
}
+void HTMLPlugInElement::removedFromDocument()
+{
+#if ENABLE(NETSCAPE_PLUGIN_API)
+if (m_NPObject) {
+_NPN_ReleaseObject(m_NPObject);
+m_NPObject = 0;
+}
+#endif
+
+HTMLFrameOwnerElement::removedFromDocument();
+}
+
PassScriptInstance HTMLPlugInElement::getInstance()
{
Frame* frame = document()-frame();
Modified: trunk/Source/WebCore/html/HTMLPlugInElement.h (94830 => 94831)
--- trunk/Source/WebCore/html/HTMLPlugInElement.h 2011-09-09 03:19:44 UTC (rev 94830)
+++ trunk/Source/WebCore/html/HTMLPlugInElement.h 2011-09-09 03:20:59 UTC (rev 94831)
@@ -57,7 +57,7 @@
HTMLPlugInElement(const QualifiedName tagName, Document*);
virtual void detach();
-
+virtual void removedFromDocument();
virtual bool mapToEntry(const QualifiedName attrName, MappedAttributeEntry result) const;
virtual void parseMappedAttribute(Attribute*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94832] trunk
Title: [94832] trunk
Revision 94832
Author sulli...@chromium.org
Date 2011-09-08 21:03:21 -0700 (Thu, 08 Sep 2011)
Log Message
Crashes in WebCore::InsertNodeBeforeCommand constructor.
https://bugs.webkit.org/show_bug.cgi?id=67763
Reviewed by Ryosuke Niwa.
Source/WebCore:
Changes editableRootForPosition() to use the position's containerNode instead of deprecatedNode so that
positions which are before or after a given node cannot return that node as the editable root.
Test: editing/inserting/insert-paragraph-selection-outside-contenteditable.html
* editing/htmlediting.cpp:
(WebCore::editableRootForPosition): use containerNode instead of deprecatedNode.
LayoutTests:
Tests for crash when the selection is outside the contenteditable node.
* editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt: Added.
* editing/inserting/insert-paragraph-selection-outside-contenteditable.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/htmlediting.cpp
Added Paths
trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt
trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94831 => 94832)
--- trunk/LayoutTests/ChangeLog 2011-09-09 03:20:59 UTC (rev 94831)
+++ trunk/LayoutTests/ChangeLog 2011-09-09 04:03:21 UTC (rev 94832)
@@ -1,3 +1,15 @@
+2011-09-08 Annie Sullivan sulli...@chromium.org
+
+Crashes in WebCore::InsertNodeBeforeCommand constructor.
+https://bugs.webkit.org/show_bug.cgi?id=67763
+
+Reviewed by Ryosuke Niwa.
+
+Tests for crash when the selection is outside the contenteditable node.
+
+* editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt: Added.
+* editing/inserting/insert-paragraph-selection-outside-contenteditable.html: Added.
+
2011-09-08 Daniel Bates dba...@webkit.org
XSS filter bypass via non-standard URL encoding
Added: trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt (0 => 94832)
--- trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt 2011-09-09 04:03:21 UTC (rev 94832)
@@ -0,0 +1,3 @@
+This test ensures that WebKit does not crash or edit the content when the selection is outside of the contenteditable area.
+
+PASS
Added: trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable.html (0 => 94832)
--- trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable.html (rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable.html 2011-09-09 04:03:21 UTC (rev 94832)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+body
+meter id=root contenteditablespan id=wrapperxxx/span/meter
+
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var originalContent = root.outerHTML;
+var sel = window.getSelection();
+sel.setPosition(document.getElementById(wrapper), 1);
+document.execCommand(InsertParagraph, false, null);
+var editedContent = root.outerHTML;
+root.style.display = 'none'; // Remove from output.
+
+document.writeln('This test ensures that WebKit does not crash or edit the content when the selection is outside of the contenteditable area.brbr');
+document.writeln(originalContent == editedContent ? 'PASS' : 'FAIL: expected ' + originalContent + ' but was changed to ' + editedContent);
+ /script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (94831 => 94832)
--- trunk/Source/WebCore/ChangeLog 2011-09-09 03:20:59 UTC (rev 94831)
+++ trunk/Source/WebCore/ChangeLog 2011-09-09 04:03:21 UTC (rev 94832)
@@ -1,3 +1,18 @@
+2011-09-08 Annie Sullivan sulli...@chromium.org
+
+Crashes in WebCore::InsertNodeBeforeCommand constructor.
+https://bugs.webkit.org/show_bug.cgi?id=67763
+
+Reviewed by Ryosuke Niwa.
+
+Changes editableRootForPosition() to use the position's containerNode instead of deprecatedNode so that
+positions which are before or after a given node cannot return that node as the editable root.
+
+Test: editing/inserting/insert-paragraph-selection-outside-contenteditable.html
+
+* editing/htmlediting.cpp:
+(WebCore::editableRootForPosition): use containerNode instead of deprecatedNode.
+
2011-09-08 James Weatherall w...@chromium.org
Release the reference to the HTMLPlugInElement's script object, when the element is removed from the document. This breaks a cyclical reference that would otherwise cause the element to be retained until the document is torn down.
[webkit-changes] [94833] trunk/LayoutTests
Title: [94833] trunk/LayoutTests Revision 94833 Author u...@chromium.org Date 2011-09-08 22:39:36 -0700 (Thu, 08 Sep 2011) Log Message Unreviewed, update chromium test expectations. * platform/chromium/test_expectations.txt: add webaudio/sample-accurate-scheduling.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94832 => 94833) --- trunk/LayoutTests/ChangeLog 2011-09-09 04:03:21 UTC (rev 94832) +++ trunk/LayoutTests/ChangeLog 2011-09-09 05:39:36 UTC (rev 94833) @@ -1,3 +1,9 @@ +2011-09-08 Fumitoshi Ukai u...@chromium.org + +Unreviewed, update chromium test expectations. + +* platform/chromium/test_expectations.txt: add webaudio/sample-accurate-scheduling.html + 2011-09-08 Annie Sullivan sulli...@chromium.org Crashes in WebCore::InsertNodeBeforeCommand constructor. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94832 => 94833) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-09 04:03:21 UTC (rev 94832) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-09 05:39:36 UTC (rev 94833) @@ -3720,3 +3720,5 @@ BUG_ABARTH WIN : svg/as-background-image/svg-as-background-1.html = PASS IMAGE BUG_ABARTH WIN : svg/as-background-image/svg-as-background-3.html = PASS IMAGE + +BUGCR95972 WIN DEBUG : webaudio/sample-accurate-scheduling.html = CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94834] trunk/LayoutTests
Title: [94834] trunk/LayoutTests Revision 94834 Author u...@chromium.org Date 2011-09-08 22:52:10 -0700 (Thu, 08 Sep 2011) Log Message Unreviewed, update chromium test expectations. * platform/chromium/test_expectations.txt: chromium/compositing/zoom-animator-scale-test missing on leopard gpu Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94833 => 94834) --- trunk/LayoutTests/ChangeLog 2011-09-09 05:39:36 UTC (rev 94833) +++ trunk/LayoutTests/ChangeLog 2011-09-09 05:52:10 UTC (rev 94834) @@ -2,6 +2,12 @@ Unreviewed, update chromium test expectations. +* platform/chromium/test_expectations.txt: chromium/compositing/zoom-animator-scale-test missing on leopard gpu + +2011-09-08 Fumitoshi Ukai u...@chromium.org + +Unreviewed, update chromium test expectations. + * platform/chromium/test_expectations.txt: add webaudio/sample-accurate-scheduling.html 2011-09-08 Annie Sullivan sulli...@chromium.org Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94833 => 94834) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-09 05:39:36 UTC (rev 94833) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-09 05:52:10 UTC (rev 94834) @@ -235,6 +235,7 @@ // We don't ship compositing on Leopard. WONTFIX SKIP GPU GPU-CG LEOPARD : compositing = PASS TIMEOUT FAIL WONTFIX SKIP GPU GPU-CG LEOPARD : platform/chromium/compositing = PASS TIMEOUT FAIL +WONTFIX SKIP GPU GPU-CG LEOPARD : platform/chromium/compositing/zoom-animator-scale-test.html = MISSING WONTFIX SKIP GPU GPU-CG LEOPARD : animations/3d = PASS TIMEOUT FAIL WONTFIX MAC WIN : platform/chromium-linux = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94746] trunk/Tools
Title: [94746] trunk/Tools
Revision 94746
Author mdela...@apple.com
Date 2011-09-08 00:05:15 -0700 (Thu, 08 Sep 2011)
Log Message
Add standalone script that filters the output of build-webkit to be more human-readable
https://bugs.webkit.org/show_bug.cgi?id=44081
Reviewed by Daniel Bates.
* Scripts/filter-build-webkit: Added. Just need to feed it the output of
a build script (e.g. build-webkit) and it spits out a prettier version.
* Scripts/VCSUtils.pm: Refactored possiblyColored out of run-api-tests into VCSUtils.
* Scripts/run-api-tests: Now includes VCSUtils to use possiblyColored
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
trunk/Tools/Scripts/run-api-tests
Added Paths
trunk/Tools/Scripts/filter-build-webkit
Diff
Modified: trunk/Tools/ChangeLog (94745 => 94746)
--- trunk/Tools/ChangeLog 2011-09-08 04:31:48 UTC (rev 94745)
+++ trunk/Tools/ChangeLog 2011-09-08 07:05:15 UTC (rev 94746)
@@ -1,3 +1,15 @@
+2011-09-07 Matthew Delaney mdela...@apple.com
+
+Add standalone script that filters the output of build-webkit to be more human-readable
+https://bugs.webkit.org/show_bug.cgi?id=44081
+
+Reviewed by Daniel Bates.
+
+* Scripts/filter-build-webkit: Added. Just need to feed it the output of
+a build script (e.g. build-webkit) and it spits out a prettier version.
+* Scripts/VCSUtils.pm: Refactored possiblyColored out of run-api-tests into VCSUtils.
+* Scripts/run-api-tests: Now includes VCSUtils to use possiblyColored
+
2011-09-07 Noel Gordon noel.gor...@gmail.com
Add myself to committers.py
Modified: trunk/Tools/Scripts/VCSUtils.pm (94745 => 94746)
--- trunk/Tools/Scripts/VCSUtils.pm 2011-09-08 04:31:48 UTC (rev 94745)
+++ trunk/Tools/Scripts/VCSUtils.pm 2011-09-08 07:05:15 UTC (rev 94746)
@@ -37,6 +37,7 @@
use File::Basename;
use File::Spec;
use POSIX;
+use Term::ANSIColor qw(colored);
BEGIN {
use Exporter ();
@@ -72,6 +73,7 @@
parseFirstEOL
parsePatch
pathRelativeToSVNRepositoryRootForPath
+possiblyColored
prepareParsedPatch
removeEOL
runPatchCommand
@@ -410,6 +412,17 @@
return $path;
}
+sub possiblyColored($$)
+{
+my ($colors, $string) = @_;
+
+if (-t STDOUT) {
+return colored([$colors], $string);
+} else {
+return $string;
+}
+}
+
sub adjustPathForRecentRenamings($)
{
my ($fullPath) = @_;
Added: trunk/Tools/Scripts/filter-build-webkit (0 => 94746)
--- trunk/Tools/Scripts/filter-build-webkit (rev 0)
+++ trunk/Tools/Scripts/filter-build-webkit 2011-09-08 07:05:15 UTC (rev 94746)
@@ -0,0 +1,202 @@
+#!/usr/bin/perl -w
+
+# Copyright (C) 2011 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+# Filters the output of build-webkit into a more human-readable format.
+
+use strict;
+use warnings;
+
+use CGI qw(escapeHTML);
+use File::Basename;
+use FindBin;
+use lib $FindBin::Bin;
+use Getopt::Long;
+use VCSUtils;
+
+use constant {
+STYLE_PLAIN = 0,
+STYLE_HEADER = 1,
+STYLE_SUCCESS = 2,
+STYLE_ALERT = 3,
+
+HTML_HEADER =HTMLHEADER,
+html
+head
+titleBuild Log/title
+style
+body { font-family: Monaco, monospace; font-size: 10px; color: #666; line-height: 1.5em; }
+h2 { margin: 1.5em 0 0 0; font-size: 1.0em; font-weight: bold; color: blue; }
+p { margin: 0; padding-left: 1.5em; border-left: 3px solid #fff; }
+p.alert { border-left-color: red; color: red; margin: 1.5em 0 0 0; }
+p.alert + p { margin: 1.5em 0 0 0; }
+p.alert + p.alert { margin: 0; }
+
[webkit-changes] [94747] branches/chromium/874/Source/WebKit/chromium/src/ WebPluginContainerImpl.cpp
Title: [94747] branches/chromium/874/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
Revision 94747
Author aba...@webkit.org
Date 2011-09-08 00:30:25 -0700 (Thu, 08 Sep 2011)
Log Message
Merge 94721 - FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent
https://bugs.webkit.org/show_bug.cgi?id=61810
Reviewed by Eric Seidel.
Fix this crash as suggested by Darin Fisher in
https://bugs.webkit.org/show_bug.cgi?id=61810#c21. This patch does not
include the test requested by Alexey Proskuryakov in
https://bugs.webkit.org/show_bug.cgi?id=61810#c6. I would really much
rather include a test with this patch, but my attempts to write a test
have failed. :(
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::loadFrameRequest):
TBR=aba...@webkit.org
Review URL: http://codereview.chromium.org/7846013
Modified Paths
branches/chromium/874/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
Diff
Modified: branches/chromium/874/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (94746 => 94747)
--- branches/chromium/874/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2011-09-08 07:05:15 UTC (rev 94746)
+++ branches/chromium/874/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2011-09-08 07:30:25 UTC (rev 94747)
@@ -386,7 +386,7 @@
void WebPluginContainerImpl::loadFrameRequest(const WebURLRequest request, const WebString target, bool notifyNeeded, void* notifyData)
{
Frame* frame = m_element-document()-frame();
-if (!frame)
+if (!frame || !frame-loader()-documentLoader())
return; // FIXME: send a notification in this case?
if (notifyNeeded) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94749] trunk/Source/WebCore
Title: [94749] trunk/Source/WebCore
Revision 94749
Author ca...@chromium.org
Date 2011-09-08 01:55:43 -0700 (Thu, 08 Sep 2011)
Log Message
2011-09-07 Andrey Kosyakov ca...@chromium.org
Web Inspector: trying to scroll mouse wheel when in TextViewer's gutter pane causes EventException::DISPATCH_REQUEST_ERR
https://bugs.webkit.org/show_bug.cgi?id=67715
Reviewed by Yury Semikhatsky.
- avoid exception on attempt to dispatch an event that is being dispatched by cloning the event.
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.forwardWheelEvent):
(WebInspector.TextViewer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextViewer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (94748 => 94749)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 08:55:32 UTC (rev 94748)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 08:55:43 UTC (rev 94749)
@@ -1,3 +1,16 @@
+2011-09-07 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: trying to scroll mouse wheel when in TextViewer's gutter pane causes EventException::DISPATCH_REQUEST_ERR
+https://bugs.webkit.org/show_bug.cgi?id=67715
+
+Reviewed by Yury Semikhatsky.
+
+- avoid exception on attempt to dispatch an event that is being dispatched by cloning the event.
+
+* inspector/front-end/TextViewer.js:
+(WebInspector.TextViewer.forwardWheelEvent):
+(WebInspector.TextViewer):
+
2011-09-07 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94674 and r94689.
Modified: trunk/Source/WebCore/inspector/front-end/TextViewer.js (94748 => 94749)
--- trunk/Source/WebCore/inspector/front-end/TextViewer.js 2011-09-08 08:55:32 UTC (rev 94748)
+++ trunk/Source/WebCore/inspector/front-end/TextViewer.js 2011-09-08 08:55:43 UTC (rev 94749)
@@ -51,9 +51,17 @@
this.element.appendChild(this._gutterPanel.element);
// Forward mouse wheel events from the unscrollable gutter to the main panel.
-this._gutterPanel.element.addEventListener(mousewheel, function(e) {
-this._mainPanel.element.dispatchEvent(e);
-}.bind(this), false);
+function forwardWheelEvent(event)
+{
+var clone = document.createEvent(WheelEvent);
+clone.initWebKitWheelEvent(event.wheelDeltaX, event.wheelDeltaY,
+ event.view,
+ event.screenX, event.screenY,
+ event.clientX, event.clientY,
+ event.ctrlKey, event.altKey, event.shiftKey, event.metaKey);
+this._mainPanel.element.dispatchEvent(clone);
+}
+this._gutterPanel.element.addEventListener(mousewheel, forwardWheelEvent.bind(this), false);
this.element.addEventListener(dblclick, this._doubleClick.bind(this), true);
this.element.addEventListener(keydown, this._handleKeyDown.bind(this), false);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94748] trunk/LayoutTests
Title: [94748] trunk/LayoutTests Revision 94748 Author loi...@chromium.org Date 2011-09-08 01:55:32 -0700 (Thu, 08 Sep 2011) Log Message 2011-09-08 Ilya Tikhonovsky loi...@chromium.org Unreviewed. Rebaselines for chromium. * platform/chromium-cg-mac-leopard/fast/css/line-after-floating-div-expected.png: Added. * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png: * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Removed. * platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Added. * platform/chromium-linux/fast/css/line-after-floating-div-expected.png: * platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Added. * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added. * platform/chromium-win/fast/css/line-after-floating-div-expected.png: * platform/chromium-win/fast/css/line-after-floating-div-expected.txt: * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Added. * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Added. * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png trunk/LayoutTests/platform/chromium-linux/fast/css/line-after-floating-div-expected.png trunk/LayoutTests/platform/chromium-win/fast/css/line-after-floating-div-expected.png trunk/LayoutTests/platform/chromium-win/fast/css/line-after-floating-div-expected.txt trunk/LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/line-after-floating-div-expected.png trunk/LayoutTests/platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png trunk/LayoutTests/platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png trunk/LayoutTests/platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94747 => 94748) --- trunk/LayoutTests/ChangeLog 2011-09-08 07:30:25 UTC (rev 94747) +++ trunk/LayoutTests/ChangeLog 2011-09-08 08:55:32 UTC (rev 94748) @@ -1,3 +1,21 @@ +2011-09-08 Ilya Tikhonovsky loi...@chromium.org + +Unreviewed. Rebaselines for chromium. + +* platform/chromium-cg-mac-leopard/fast/css/line-after-floating-div-expected.png: Added. +* platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png: +* platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Removed. +* platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Added. +* platform/chromium-linux/fast/css/line-after-floating-div-expected.png: +* platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Added. +* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added. +* platform/chromium-win/fast/css/line-after-floating-div-expected.png: +* platform/chromium-win/fast/css/line-after-floating-div-expected.txt: +* platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Added. +* platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Added. +* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: +* platform/chromium/test_expectations.txt: + 2011-09-07 Ben Wells benwe...@chromium.org Fix typo in test_expectations introduced with r94725 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94747 => 94748) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 07:30:25 UTC (rev 94747) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 08:55:32 UTC (rev 94748) @@ -3053,7 +3053,7 @@ BUGCR79917 LINUX WIN : tables/mozilla/marvin/backgr_simple-table-row.html = IMAGE BUGCR79917 LINUX WIN : tables/mozilla/marvin/backgr_simple-table.html = IMAGE BUGCR79917 LINUX WIN : tables/mozilla/marvin/tables_style.html = IMAGE -BUGCR79917 LINUX WIN : tables/mozilla_expected_failures/bugs/bug2479-5.html = IMAGE +BUGCR79917 LINUX : tables/mozilla_expected_failures/bugs/bug2479-5.html = IMAGE BUGCR79917 LINUX WIN : tables/mozilla_expected_failures/marvin/backgr_border-table-cell.html = IMAGE BUGCR79917 LINUX WIN : tables/mozilla_expected_failures/marvin/backgr_border-table-column-group.html =
[webkit-changes] [94750] trunk/LayoutTests
Title: [94750] trunk/LayoutTests
Revision 94750
Author o...@webkit.org
Date 2011-09-08 03:11:26 -0700 (Thu, 08 Sep 2011)
Log Message
Gardening: add missing result after: r94710.
https://bugs.webkit.org/show_bug.cgi?id=67768
Patch by Oliver Varga voli...@inf.u-szeged.hu on 2011-09-08
Reviewed by Zoltan Herczeg.
* platform/qt/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/qt/fast/text/hyphenate-limit-lines-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/fast/text/hyphenate-limit-lines-expected.png
trunk/LayoutTests/platform/qt/fast/text/hyphenate-limit-lines-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94749 => 94750)
--- trunk/LayoutTests/ChangeLog 2011-09-08 08:55:43 UTC (rev 94749)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 10:11:26 UTC (rev 94750)
@@ -1,3 +1,13 @@
+2011-09-08 Oliver Varga voli...@inf.u-szeged.hu
+
+Gardening: add missing result after: r94710.
+https://bugs.webkit.org/show_bug.cgi?id=67768
+
+Reviewed by Zoltan Herczeg.
+
+* platform/qt/fast/text/hyphenate-limit-lines-expected.png: Added.
+* platform/qt/fast/text/hyphenate-limit-lines-expected.txt: Added.
+
2011-09-08 Ilya Tikhonovsky loi...@chromium.org
Unreviewed. Rebaselines for chromium.
Added: trunk/LayoutTests/platform/qt/fast/text/hyphenate-limit-lines-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/text/hyphenate-limit-lines-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/fast/text/hyphenate-limit-lines-expected.txt (0 => 94750)
--- trunk/LayoutTests/platform/qt/fast/text/hyphenate-limit-lines-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/text/hyphenate-limit-lines-expected.txt 2011-09-08 10:11:26 UTC (rev 94750)
@@ -0,0 +1,115 @@
+layer at (0,0) size 784x1304
+ RenderView at (0,0) size 784x600
+layer at (0,0) size 784x1304
+ RenderBlock {HTML} at (0,0) size 784x1304
+RenderBody {BODY} at (8,8) size 768x584
+ RenderBlock (floating) {DIV} at (4,0) size 202x648 [border: (1px solid #ADD8E6)]
+RenderText {#text} at (1,1) size 200x646
+ text run at (1,1) width 200: also the division
+ text run at (1,35) width 200: of the mind into
+ text run at (1,69) width 200: the rational,
+ text run at (1,103) width 200: concupiscent, and
+ text run at (1,137) width 94: irascible
+ text run at (1,171) width 200: elements, or of
+ text run at (1,205) width 200: pleasures and
+ text run at (1,239) width 200: desires into
+ text run at (1,273) width 200: necessary and
+ text run at (1,307) width 162: unnecessary\x{2014}
+ text run at (1,341) width 200: these and other
+ text run at (1,375) width 200: great forms of
+ text run at (1,409) width 200: thought are all of
+ text run at (1,443) width 67: them
+ text run at (68,443) width 133: to be found
+ text run at (1,477) width 200: in the Republic,
+ text run at (1,511) width 200: and were
+ text run at (1,545) width 200: probably first
+ text run at (1,579) width 200: invented by
+ text run at (1,613) width 65: Plato.
+ RenderBlock (floating) {DIV} at (214,0) size 202x648 [border: (1px solid #ADD8E6)]
+RenderText {#text} at (1,1) size 200x646
+ text run at (1,1) width 200: also the division
+ text run at (1,35) width 200: of the mind into
+ text run at (1,69) width 200: the rational,
+ text run at (1,103) width 200: concupiscent, and
+ text run at (1,137) width 94: irascible
+ text run at (1,171) width 200: elements, or of
+ text run at (1,205) width 200: pleasures and
+ text run at (1,239) width 200: desires into
+ text run at (1,273) width 200: necessary and
+ text run at (1,307) width 162: unnecessary\x{2014}
+ text run at (1,341) width 200: these and other
+ text run at (1,375) width 200: great forms of
+ text run at (1,409) width 200: thought are all of
+ text run at (1,443) width 67: them
+ text run at (68,443) width 133: to be found
+ text run at (1,477) width 200: in the Republic,
+ text run at (1,511) width 200: and were
+ text run at (1,545) width 200: probably first
+ text run at (1,579) width 200: invented by
+ text run at (1,613) width 65: Plato.
+ RenderBlock (floating) {DIV} at (424,0) size 202x648 [border: (1px solid #ADD8E6)]
+RenderText {#text} at (1,1) size 200x646
+ text run at (1,1) width 200: also the division
+ text run at (1,35) width 200: of the mind into
+ text run at (1,69) width 200: the rational,
+
[webkit-changes] [94751] trunk/LayoutTests
Title: [94751] trunk/LayoutTests Revision 94751 Author o...@webkit.org Date 2011-09-08 03:16:49 -0700 (Thu, 08 Sep 2011) Log Message [Qt] fast/css/line-after-floating-div.html fails https://bugs.webkit.org/show_bug.cgi?id=67772 Patch by Oliver Varga voli...@inf.u-szeged.hu on 2011-09-08 Reviewed by Csaba Osztrogonác. * platform/qt/Skipped: Skip it until fix. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94750 => 94751) --- trunk/LayoutTests/ChangeLog 2011-09-08 10:11:26 UTC (rev 94750) +++ trunk/LayoutTests/ChangeLog 2011-09-08 10:16:49 UTC (rev 94751) @@ -1,5 +1,14 @@ 2011-09-08 Oliver Varga voli...@inf.u-szeged.hu +[Qt] fast/css/line-after-floating-div.html fails +https://bugs.webkit.org/show_bug.cgi?id=67772 + +Reviewed by Csaba Osztrogonác. + +* platform/qt/Skipped: Skip it until fix. + +2011-09-08 Oliver Varga voli...@inf.u-szeged.hu + Gardening: add missing result after: r94710. https://bugs.webkit.org/show_bug.cgi?id=67768 Modified: trunk/LayoutTests/platform/qt/Skipped (94750 => 94751) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-08 10:11:26 UTC (rev 94750) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-08 10:16:49 UTC (rev 94751) @@ -2410,3 +2410,7 @@ fast/multicol/positive-leading.html fast/multicol/overflow-unsplittable.html fast/multicol/overflow-across-columns.html + +# new test introduced in r94696, but fails on Qt. +# https://bugs.webkit.org/show_bug.cgi?id=67772 +fast/css/line-after-floating-div.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94752] trunk/LayoutTests
Title: [94752] trunk/LayoutTests Revision 94752 Author loi...@chromium.org Date 2011-09-08 04:36:55 -0700 (Thu, 08 Sep 2011) Log Message 2011-09-08 Ilya Tikhonovsky loi...@chromium.org Unreviewed rebaseline for chromium. * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png: * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Table-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/feComponentTransfer-Table-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (94751 => 94752) --- trunk/LayoutTests/ChangeLog 2011-09-08 10:16:49 UTC (rev 94751) +++ trunk/LayoutTests/ChangeLog 2011-09-08 11:36:55 UTC (rev 94752) @@ -1,3 +1,10 @@ +2011-09-08 Ilya Tikhonovsky loi...@chromium.org + +Unreviewed rebaseline for chromium. + +* platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png: +* platform/chromium-cg-mac/svg/custom/feComponentTransfer-Table-expected.png: + 2011-09-08 Oliver Varga voli...@inf.u-szeged.hu [Qt] fast/css/line-after-floating-div.html fails Modified: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/feComponentTransfer-Table-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94753] trunk/LayoutTests
Title: [94753] trunk/LayoutTests Revision 94753 Author o...@webkit.org Date 2011-09-08 05:07:06 -0700 (Thu, 08 Sep 2011) Log Message [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode https://bugs.webkit.org/show_bug.cgi?id=52810 * platform/qt/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg, because it fails on 64 bit. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94752 => 94753) --- trunk/LayoutTests/ChangeLog 2011-09-08 11:36:55 UTC (rev 94752) +++ trunk/LayoutTests/ChangeLog 2011-09-08 12:07:06 UTC (rev 94753) @@ -1,3 +1,10 @@ +2011-09-08 Csaba Osztrogonác o...@webkit.org + +[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode +https://bugs.webkit.org/show_bug.cgi?id=52810 + +* platform/qt/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg, because it fails on 64 bit. + 2011-09-08 Ilya Tikhonovsky loi...@chromium.org Unreviewed rebaseline for chromium. Modified: trunk/LayoutTests/platform/qt/Skipped (94752 => 94753) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-08 11:36:55 UTC (rev 94752) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-08 12:07:06 UTC (rev 94753) @@ -2014,6 +2014,7 @@ svg/W3C-SVG-1.1/extend-namespace-01-f.svg svg/W3C-SVG-1.1/painting-marker-03-f.svg svg/W3C-SVG-1.1/paths-data-03-f.svg +svg/W3C-SVG-1.1-SE/filters-image-05-f.svg svg/W3C-SVG-1.1-SE/types-dom-05-b.svg svg/W3C-SVG-1.1/struct-frag-02-t.svg svg/W3C-SVG-1.1/struct-frag-03-t.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94755] trunk
Title: [94755] trunk
Revision 94755
Author commit-qu...@webkit.org
Date 2011-09-08 05:58:17 -0700 (Thu, 08 Sep 2011)
Log Message
Unreviewed, rolling out r94695.
http://trac.webkit.org/changeset/94695
https://bugs.webkit.org/show_bug.cgi?id=67776
Hitting an assertion on Snow Leopard, Qt, GTK (Requested by
Zoltan on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-08
Source/WebCore:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionedFloatsNeedRelayout):
(WebCore::RenderBlock::layoutPositionedObjects):
LayoutTests:
* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Removed.
* fast/block/positioning/absolute-layout-after-image-load.html: Removed.
* fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Removed.
* fast/block/positioning/positioned-float-layout-after-image-load.html: Removed.
* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Removed.
* fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Removed Paths
trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt
trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html
trunk/LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load-expected.txt
trunk/LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load.html
trunk/LayoutTests/fast/block/positioning/resources/absolute-layout-after-image-load-2.html
trunk/LayoutTests/fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94754 => 94755)
--- trunk/LayoutTests/ChangeLog 2011-09-08 12:15:53 UTC (rev 94754)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 12:58:17 UTC (rev 94755)
@@ -1,3 +1,19 @@
+2011-09-08 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r94695.
+http://trac.webkit.org/changeset/94695
+https://bugs.webkit.org/show_bug.cgi?id=67776
+
+Hitting an assertion on Snow Leopard, Qt, GTK (Requested by
+Zoltan on #webkit).
+
+* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Removed.
+* fast/block/positioning/absolute-layout-after-image-load.html: Removed.
+* fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Removed.
+* fast/block/positioning/positioned-float-layout-after-image-load.html: Removed.
+* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Removed.
+* fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Removed.
+
2011-09-08 Csaba Osztrogonác o...@webkit.org
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
Deleted: trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt (94754 => 94755)
--- trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt 2011-09-08 12:15:53 UTC (rev 94754)
+++ trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load-expected.txt 2011-09-08 12:58:17 UTC (rev 94755)
@@ -1,3 +0,0 @@
-
-[1]
-SUCCESS
Deleted: trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html (94754 => 94755)
--- trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html 2011-09-08 12:15:53 UTC (rev 94754)
+++ trunk/LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html 2011-09-08 12:58:17 UTC (rev 94755)
@@ -1,21 +0,0 @@
-html
-head
-script
-if (window.layoutTestController) {
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
- }
-
-// https://bugs.webkit.org/show_bug.cgi?id=54611
-// When navigating to absolute-layout-after-image-load-2.html#anchor1 directly, the anchor should be positioned below
-// the image on first load. The test is sensitive to caching of the image, so you should reload
-// absolute-layout-after-image-load-2.html#anchor1 if testing manually.
-
-function test(){
-setTimeout(location.assign(resources/absolute-layout-after-image-load-2.html#anchor1),0);
-}
-/script
-/head
-body _onload_=test();
-/body/html
-
Deleted: trunk/LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load-expected.txt (94754 => 94755)
--- trunk/LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load-expected.txt 2011-09-08 12:15:53 UTC (rev 94754)
+++ trunk/LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load-expected.txt 2011-09-08 12:58:17 UTC (rev 94755)
@@ -1,3 +0,0 @@
-
-[1]
-SUCCESS
Deleted: trunk/LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load.html
[webkit-changes] [94756] trunk/LayoutTests
Title: [94756] trunk/LayoutTests Revision 94756 Author o...@webkit.org Date 2011-09-08 06:44:19 -0700 (Thu, 08 Sep 2011) Log Message [Qt][Mac] Unreviewed gardening. * platform/qt-mac/Skipped: Skip a new failing test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94755 => 94756) --- trunk/LayoutTests/ChangeLog 2011-09-08 12:58:17 UTC (rev 94755) +++ trunk/LayoutTests/ChangeLog 2011-09-08 13:44:19 UTC (rev 94756) @@ -1,3 +1,9 @@ +2011-09-08 Csaba Osztrogonác o...@webkit.org + +[Qt][Mac] Unreviewed gardening. + +* platform/qt-mac/Skipped: Skip a new failing test. + 2011-09-08 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r94695. Modified: trunk/LayoutTests/platform/qt-mac/Skipped (94755 => 94756) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-09-08 12:58:17 UTC (rev 94755) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-09-08 13:44:19 UTC (rev 94756) @@ -5081,3 +5081,6 @@ fast/borders/border-image-longhand.html fast/borders/border-image-scaled.html fast/borders/border-image-side-reduction.html + +# Qt specific results were added by r94750, but they fail on Qt-Mac platform +fast/text/hyphenate-limit-lines.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94757] trunk/Source
Title: [94757] trunk/Source
Revision 94757
Author abe...@webkit.org
Date 2011-09-08 06:52:04 -0700 (Thu, 08 Sep 2011)
Log Message
[Qt] Build fails with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67778
Reviewed by Csaba Osztrogonác.
Source/ThirdParty/ANGLE:
* src/compiler/glslang_lex.cpp: Regenerate with generate_glslang_lexer.sh using a newer flex
to suppress warning and fix the build when using [-Werror=unused-result]
Source/WebCore:
No new tests needed.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::resizeEdgeTiles): Remove unused contentsRect variable
which's usage was removed in r94681 to fix the build with [-Werror=unused-but-set-variable].
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (94756 => 94757)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2011-09-08 13:44:19 UTC (rev 94756)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2011-09-08 13:52:04 UTC (rev 94757)
@@ -1,3 +1,13 @@
+2011-09-08 Andras Becsi andras.be...@nokia.com
+
+[Qt] Build fails with strict compiler
+https://bugs.webkit.org/show_bug.cgi?id=67778
+
+Reviewed by Csaba Osztrogonác.
+
+* src/compiler/glslang_lex.cpp: Regenerate with generate_glslang_lexer.sh using a newer flex
+to suppress warning and fix the build when using [-Werror=unused-result]
+
2011-08-12 Mark Rowe mr...@apple.com
Be more forward-looking in the choice of compiler.
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp (94756 => 94757)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp 2011-09-08 13:44:19 UTC (rev 94756)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp 2011-09-08 13:52:04 UTC (rev 94757)
@@ -859,6 +859,10 @@
void yyset_lineno (int line_number ,yyscan_t yyscanner );
+int yyget_column (yyscan_t yyscanner );
+
+void yyset_column (int column_no ,yyscan_t yyscanner );
+
YYSTYPE * yyget_lval (yyscan_t yyscanner );
void yyset_lval (YYSTYPE * yylval_param ,yyscan_t yyscanner );
@@ -909,7 +913,7 @@
/* This used to be an fputs(), but since the string might contain NUL's,
* we now use fwrite().
*/
-#define ECHO fwrite( yytext, yyleng, 1, yyout )
+#define ECHO do { if (fwrite( yytext, yyleng, 1, yyout )) {} } while (0)
#endif
/* Gets input and stuffs it into buf. number of characters read, or YY_NULL,
@@ -920,7 +924,7 @@
if ( YY_CURRENT_BUFFER_LVALUE-yy_is_interactive ) \
{ \
int c = '*'; \
- int n; \
+ unsigned n; \
for ( n = 0; n max_size \
(c = getc( yyin )) != EOF c != '\n'; ++n ) \
buf[n] = (char) c; \
Modified: trunk/Source/WebCore/ChangeLog (94756 => 94757)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 13:44:19 UTC (rev 94756)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 13:52:04 UTC (rev 94757)
@@ -1,3 +1,16 @@
+2011-09-08 Andras Becsi andras.be...@nokia.com
+
+[Qt] Build fails with strict compiler
+https://bugs.webkit.org/show_bug.cgi?id=67778
+
+Reviewed by Csaba Osztrogonác.
+
+No new tests needed.
+
+* platform/graphics/TiledBackingStore.cpp:
+(WebCore::TiledBackingStore::resizeEdgeTiles): Remove unused contentsRect variable
+which's usage was removed in r94681 to fix the build with [-Werror=unused-but-set-variable].
+
2011-09-08 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94695.
Modified: trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp (94756 => 94757)
--- trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp 2011-09-08 13:44:19 UTC (rev 94756)
+++ trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp 2011-09-08 13:52:04 UTC (rev 94757)
@@ -340,7 +340,6 @@
bool TiledBackingStore::resizeEdgeTiles()
{
-IntRect contentsRect = this-contentsRect();
bool wasResized = false;
VectorTile::Coordinate tilesToRemove;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94758] trunk/Source/WebCore
Title: [94758] trunk/Source/WebCore
Revision 94758
Author apav...@chromium.org
Date 2011-09-08 06:58:27 -0700 (Thu, 08 Sep 2011)
Log Message
Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken
https://bugs.webkit.org/show_bug.cgi?id=67711
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._registerShortcuts):
(WebInspector.ConsoleView.prototype._promptKeyDown):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (94757 => 94758)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 13:52:04 UTC (rev 94757)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 13:58:27 UTC (rev 94758)
@@ -1,3 +1,15 @@
+2011-09-08 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken
+https://bugs.webkit.org/show_bug.cgi?id=67711
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView.prototype._consoleCleared):
+(WebInspector.ConsoleView.prototype._registerShortcuts):
+(WebInspector.ConsoleView.prototype._promptKeyDown):
+
2011-09-08 Andras Becsi andras.be...@nokia.com
[Qt] Build fails with strict compiler
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (94757 => 94758)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-09-08 13:52:04 UTC (rev 94757)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-09-08 13:58:27 UTC (rev 94758)
@@ -489,14 +489,14 @@
this._shortcuts = {};
var shortcut = WebInspector.KeyboardShortcut;
-var shortcutK = shortcut.makeDescriptor(k, WebInspector.KeyboardShortcut.Modifiers.Meta);
-// This case requires a separate bound function as its isMacOnly property should not be shared among different shortcut handlers.
-var clearConsoleHandler = this._requestClearMessages.bind(this);
-this._shortcuts[shortcutK.key] = clearConsoleHandler;
-this._shortcuts[shortcutK.key].isMacOnly = true;
+if (WebInspector.isMac()) {
+var shortcutK = shortcut.makeDescriptor(k, WebInspector.KeyboardShortcut.Modifiers.Meta);
+this._shortcuts[shortcutK.key] = this._requestClearMessages.bind(this);
+}
+
var shortcutL = shortcut.makeDescriptor(l, WebInspector.KeyboardShortcut.Modifiers.Ctrl);
-this._shortcuts[shortcutL.key] = clearConsoleHandler;
+this._shortcuts[shortcutL.key] = this._requestClearMessages.bind(this);
var section = WebInspector.shortcutsScreen.section(WebInspector.UIString(Console));
var keys = WebInspector.isMac() ? [ shortcutK.name, shortcutL.name ] : [ shortcutL.name ];
@@ -537,11 +537,9 @@
var shortcut = WebInspector.KeyboardShortcut.makeKeyFromEvent(event);
var handler = this._shortcuts[shortcut];
if (handler) {
-if (!this._shortcuts[shortcut].isMacOnly || WebInspector.isMac()) {
-handler();
-event.preventDefault();
-return;
-}
+handler();
+event.preventDefault();
+return;
}
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94760] trunk
Title: [94760] trunk
Revision 94760
Author podivi...@chromium.org
Date 2011-09-08 08:05:35 -0700 (Thu, 08 Sep 2011)
Log Message
Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=67647
1) Implement RawSourceCode.setFormatted that allows toggling pretty-print mode on the fly without resetting everything.
2) Add RawSourceCode unit tests.
3) Remove source mapping listeners and console messages from presentation model (they live in RawSourceCode now).
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/raw-source-code.html
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
LayoutTests:
* inspector/debugger/raw-source-code-expected.txt: Added.
* inspector/debugger/raw-source-code.html: Added.
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-file.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/script-formatter.html
trunk/LayoutTests/inspector/debugger/source-file.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/SourceFile.js
Added Paths
trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt
trunk/LayoutTests/inspector/debugger/raw-source-code.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94759 => 94760)
--- trunk/LayoutTests/ChangeLog 2011-09-08 14:46:01 UTC (rev 94759)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 15:05:35 UTC (rev 94760)
@@ -1,3 +1,19 @@
+2011-09-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
+https://bugs.webkit.org/show_bug.cgi?id=67647
+
+1) Implement RawSourceCode.setFormatted that allows toggling pretty-print mode on the fly without resetting everything.
+2) Add RawSourceCode unit tests.
+3) Remove source mapping listeners and console messages from presentation model (they live in RawSourceCode now).
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/raw-source-code-expected.txt: Added.
+* inspector/debugger/raw-source-code.html: Added.
+* inspector/debugger/script-formatter.html:
+* inspector/debugger/source-file.html:
+
2011-09-08 Cary Clark carycl...@google.com
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Added: trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt (0 => 94760)
--- trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt 2011-09-08 15:05:35 UTC (rev 94760)
@@ -0,0 +1,17 @@
+Tests RawSourceCode class.
+
+
+Running: testScriptWithoutResource
+
+Running: testHTMLWithPendingResource
+
+Running: testHTMLWithFinishedResource
+
+Running: testContentEdited
+
+Running: testForceUpdateSourceMapping
+
+Running: testFormattingWithFinishedResource
+
+Running: testFormattingWithPendingResource
+
Property changes on: trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/debugger/raw-source-code.html (0 => 94760)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html (rev 0)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-09-08 15:05:35 UTC (rev 94760)
@@ -0,0 +1,346 @@
+html
+head
+script src=""
+
+script
+
+function test()
+{
+function createScriptMock(url, startLine, startColumn, isContentScript, source)
+{
+var lineCount = source.lineEndings().length;
+var endLine = startLine + lineCount - 1;
+var endColumn = lineCount === 1 ? startColumn + source.length : source.length - source.lineEndings()[lineCount - 2];
+var script = new WebInspector.Script(null, url, startLine, startColumn, endLine, endColumn, undefined, undefined, isContentScript);
+
[webkit-changes] [94762] trunk
Title: [94762] trunk
Revision 94762
Author podivi...@chromium.org
Date 2011-09-08 09:38:22 -0700 (Thu, 08 Sep 2011)
Log Message
Web Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=67717
Source/WebCore:
Listen to SourceMappingUpdated event instead of using createSourceMappingIfNeeded.
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
* inspector/front-end/SourceFile.js:
LayoutTests:
Merge source-file.html into raw-source-code.html.
Reviewed by Yury Semikhatsky.
* inspector/debugger/raw-source-code.html:
* inspector/debugger/source-file.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/SourceFile.js
Removed Paths
trunk/LayoutTests/inspector/debugger/source-file.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94761 => 94762)
--- trunk/LayoutTests/ChangeLog 2011-09-08 16:03:40 UTC (rev 94761)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 16:38:22 UTC (rev 94762)
@@ -1,3 +1,15 @@
+2011-09-07 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
+https://bugs.webkit.org/show_bug.cgi?id=67717
+
+Merge source-file.html into raw-source-code.html.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/raw-source-code.html:
+* inspector/debugger/source-file.html: Removed.
+
2011-09-08 Cary Clark carycl...@google.com
Unreviewed; removed one erroneous baseline (Skia on Mac)
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (94761 => 94762)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-09-08 16:03:40 UTC (rev 94761)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-09-08 16:38:22 UTC (rev 94762)
@@ -80,6 +80,25 @@
throw Unexpected SourceMappingUpdated event.;
}
+function createRawLocation(lineNumber, columnNumber)
+{
+return { lineNumber: lineNumber, columnNumber: columnNumber };
+}
+
+function checkRawLocation(script, lineNumber, columnNumber, location)
+{
+InspectorTest.assertEquals(script.scriptId, location.scriptId);
+InspectorTest.assertEquals(lineNumber, location.lineNumber);
+InspectorTest.assertEquals(columnNumber, location.columnNumber);
+}
+
+function checkUILocation(uiSourceCode, lineNumber, columnNumber, location)
+{
+InspectorTest.assertEquals(uiSourceCode, location.uiSourceCode);
+InspectorTest.assertEquals(lineNumber, location.lineNumber);
+InspectorTest.assertEquals(columnNumber, location.columnNumber);
+}
+
InspectorTest.runTestSuite([
function testScriptWithoutResource(next)
{
@@ -91,6 +110,8 @@
InspectorTest.assertEquals(foo.js, uiSourceCode.url);
InspectorTest.assertEquals(true, uiSourceCode.isContentScript);
InspectorTest.assertEquals(rawSourceCode, uiSourceCode.rawSourceCode);
+checkUILocation(uiSourceCode, 0, 5, rawSourceCode.rawLocationToUILocation(createRawLocation(0, 5)));
+checkRawLocation(script, 0, 10, rawSourceCode.uiLocationToRawLocation(0, 10));
uiSourceCode.requestContent(didRequestContent);
function didRequestContent(mimeType, content)
@@ -134,8 +155,8 @@
function testHTMLWithFinishedResource(next)
{
-var script1 = createScriptMock(index.html, 0, 10, false, script source 1);
-var script2 = createScriptMock(index.html, 0, 45, false, script source 2);
+var script1 = createScriptMock(index.html, 1, 10, false, script source 1);
+
[webkit-changes] [94763] trunk/LayoutTests
Title: [94763] trunk/LayoutTests Revision 94763 Author jap...@chromium.org Date 2011-09-08 09:56:06 -0700 (Thu, 08 Sep 2011) Log Message 2011-09-08 Nate Chapin jap...@chromium.org Unreviewed, chromium expectations tweaks. * platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (94762 => 94763) --- trunk/LayoutTests/ChangeLog 2011-09-08 16:38:22 UTC (rev 94762) +++ trunk/LayoutTests/ChangeLog 2011-09-08 16:56:06 UTC (rev 94763) @@ -1,3 +1,10 @@ +2011-09-08 Nate Chapin jap...@chromium.org + +Unreviewed, chromium expectations tweaks. + +* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2011-09-07 Pavel Podivilov podivi...@chromium.org Web Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94762 => 94763) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 16:38:22 UTC (rev 94762) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-08 16:56:06 UTC (rev 94763) @@ -2660,7 +2660,7 @@ // Accelerated 2d for mac isn't supported yet, so SKIP this test for now. BUGCR74979 SKIP MAC GPU GPU-CG : media/video-canvas-alpha.html = IMAGE -BUGWK67116 GPU DEBUG : compositing/layer-creation/overflow-scroll-overlap.html = PASS TEXT +BUGWK67116 GPU GPU-CG DEBUG : compositing/layer-creation/overflow-scroll-overlap.html = PASS TEXT // Skip test test since this test uses layoutTestController.display() // that needs to be implemented for GPU @@ -2697,7 +2697,6 @@ BUGWK54322 SNOWLEOPARD : svg/custom/animate-path-discrete.svg = IMAGE BUGWK54322 SNOWLEOPARD : svg/W3C-SVG-1.1/coords-viewattr-01-b.svg = IMAGE+TEXT BUGWK54322 SNOWLEOPARD : svg/zoom/text/zoom-coords-viewattr-01-b.svg = IMAGE+TEXT -BUGWK54322 SNOWLEOPARD : tables/mozilla_expected_failures/bugs/bug85016.html = IMAGE BUGWK54322 SNOWLEOPARD : tables/mozilla/core/bloomberg.html = IMAGE BUGWK54322 SNOWLEOPARD : tables/mozilla/core/misc.html = IMAGE BUGWK54322 SNOWLEOPARD : tables/mozilla/core/row_span.html = IMAGE @@ -3642,8 +3641,8 @@ BUGWK66394 LINUX DEBUG : fast/canvas/webgl/data-view-crash.html = PASS CRASH -BUGWK66417 WIN LEOPARD : fast/text/midword-break-before-surrogate-pair-2.html = IMAGE+TEXT -BUGWK66417 SNOWLEOPARD : fast/text/midword-break-before-surrogate-pair-2.html = IMAGE +BUGWK66417 WIN : fast/text/midword-break-before-surrogate-pair-2.html = IMAGE+TEXT +BUGWK66417 MAC : fast/text/midword-break-before-surrogate-pair-2.html = IMAGE BUGWK66417 LINUX : fast/text/midword-break-before-surrogate-pair-2.html = IMAGE+TEXT TIMEOUT BUGWK66419 : http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html = TEXT Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94761] trunk/LayoutTests
Title: [94761] trunk/LayoutTests Revision 94761 Author carycl...@google.com Date 2011-09-08 09:03:40 -0700 (Thu, 08 Sep 2011) Log Message Unreviewed; removed one erroneous baseline (Skia on Mac) * platform/chromium-mac/fast/frames/lots-of-objects-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94760 => 94761) --- trunk/LayoutTests/ChangeLog 2011-09-08 15:05:35 UTC (rev 94760) +++ trunk/LayoutTests/ChangeLog 2011-09-08 16:03:40 UTC (rev 94761) @@ -1,3 +1,9 @@ +2011-09-08 Cary Clark carycl...@google.com + +Unreviewed; removed one erroneous baseline (Skia on Mac) + +* platform/chromium-mac/fast/frames/lots-of-objects-expected.txt: Removed. + 2011-09-06 Pavel Podivilov podivi...@chromium.org Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode. Deleted: trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt (94760 => 94761) --- trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt 2011-09-08 15:05:35 UTC (rev 94760) +++ trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt 2011-09-08 16:03:40 UTC (rev 94761) @@ -1 +0,0 @@ - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94764] trunk/LayoutTests
Title: [94764] trunk/LayoutTests
Revision 94764
Author rn...@webkit.org
Date 2011-09-08 10:09:31 -0700 (Thu, 08 Sep 2011)
Log Message
Rebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=67781
Unreviewed rebaseline for Mac.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94763 => 94764)
--- trunk/LayoutTests/ChangeLog 2011-09-08 16:56:06 UTC (rev 94763)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 17:09:31 UTC (rev 94764)
@@ -1,3 +1,13 @@
+2011-09-08 Ryosuke Niwa rn...@webkit.org
+
+Rebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
+https://bugs.webkit.org/show_bug.cgi?id=67781
+
+Unreviewed rebaseline for Mac.
+
+* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
+* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
+
2011-09-08 Nate Chapin jap...@chromium.org
Unreviewed, chromium expectations tweaks.
Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt (0 => 94764)
--- trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt 2011-09-08 17:09:31 UTC (rev 94764)
@@ -0,0 +1,170 @@
+layer at (0,0) size 480x360
+ RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+ RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (10,15) size 420x280
+ RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGResourceFilter {filter} [id=default] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMinYMinMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMidYMinMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMaxYMinMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMinYMidMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMidYMidMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMaxYMidMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMinYMaxMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMidYMaxMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMaxYMaxMeet] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMinYMinSlice] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMidYMinSlice] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMaxYMinSlice] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMinYMidSlice] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMidYMidSlice] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+RenderSVGResourceFilter {filter} [id=xMaxYMidSlice] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ [feImage image-size=100x100]
+
[webkit-changes] [94765] trunk/LayoutTests
Title: [94765] trunk/LayoutTests Revision 94765 Author a...@apple.com Date 2011-09-08 10:18:32 -0700 (Thu, 08 Sep 2011) Log Message Some cookie related tests fail on Lion https://bugs.webkit.org/show_bug.cgi?id=67674 Reviewed by Mark Rowe. Use private browsing mode to work around a CFNetwork issue where these tests can affect each other's results. This should not affect their behavior in any other way. * http/tests/security/cookies/third-party-cookie-blocking-main-frame.html: * http/tests/security/cookies/third-party-cookie-blocking-user-action.html: * http/tests/security/cookies/third-party-cookie-blocking.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html Diff Modified: trunk/LayoutTests/ChangeLog (94764 => 94765) --- trunk/LayoutTests/ChangeLog 2011-09-08 17:09:31 UTC (rev 94764) +++ trunk/LayoutTests/ChangeLog 2011-09-08 17:18:32 UTC (rev 94765) @@ -1,3 +1,17 @@ +2011-09-08 Alexey Proskuryakov a...@apple.com + +Some cookie related tests fail on Lion +https://bugs.webkit.org/show_bug.cgi?id=67674 + +Reviewed by Mark Rowe. + +Use private browsing mode to work around a CFNetwork issue where these tests can affect each +other's results. This should not affect their behavior in any other way. + +* http/tests/security/cookies/third-party-cookie-blocking-main-frame.html: +* http/tests/security/cookies/third-party-cookie-blocking-user-action.html: +* http/tests/security/cookies/third-party-cookie-blocking.html: + 2011-09-08 Ryosuke Niwa rn...@webkit.org Rebaseline filters-image-05-f.svg expected output (text) for SnowLeopard. Modified: trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html (94764 => 94765) --- trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html 2011-09-08 17:09:31 UTC (rev 94764) +++ trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html 2011-09-08 17:18:32 UTC (rev 94765) @@ -6,6 +6,12 @@ layoutTestController.waitUntilDone(); layoutTestController.dumpAsText(); layoutTestController.dumpChildFramesAsText(); + +// Start with a clean state, as otherwise an expired cookie for this domain could affect behavior with CFNetwork. +// Can be removed once rdar://problem/10080130 is fixed. +if (layoutTestController.setPrivateBrowsingEnabled) +layoutTestController.setPrivateBrowsingEnabled(true); + layoutTestController.setAlwaysAcceptCookies(false); } Modified: trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html (94764 => 94765) --- trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html 2011-09-08 17:09:31 UTC (rev 94764) +++ trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html 2011-09-08 17:18:32 UTC (rev 94765) @@ -6,6 +6,12 @@ layoutTestController.waitUntilDone(); layoutTestController.dumpAsText(); layoutTestController.dumpChildFramesAsText(); + +// Start with a clean state, as otherwise an expired cookie for this domain could affect behavior with CFNetwork. +// Can be removed once rdar://problem/10080130 is fixed. +if (layoutTestController.setPrivateBrowsingEnabled) +layoutTestController.setPrivateBrowsingEnabled(true); + layoutTestController.setAlwaysAcceptCookies(false); } Modified: trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html (94764 => 94765) --- trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html 2011-09-08 17:09:31 UTC (rev 94764) +++ trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html 2011-09-08 17:18:32 UTC (rev 94765) @@ -6,6 +6,12 @@ layoutTestController.waitUntilDone(); layoutTestController.dumpAsText(); layoutTestController.dumpChildFramesAsText(); + +// Start with a clean state, as otherwise an expired cookie for this domain could affect behavior with CFNetwork. +// Can be removed once rdar://problem/10080130 is fixed. +if (layoutTestController.setPrivateBrowsingEnabled) +layoutTestController.setPrivateBrowsingEnabled(true); + layoutTestController.setAlwaysAcceptCookies(false); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94766] trunk/Source/WebCore
Title: [94766] trunk/Source/WebCore
Revision 94766
Author rn...@webkit.org
Date 2011-09-08 10:41:48 -0700 (Thu, 08 Sep 2011)
Log Message
Make bindings tests quiet after r94701.
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94765 => 94766)
--- trunk/Source/WebCore/ChangeLog 2011-09-08 17:18:32 UTC (rev 94765)
+++ trunk/Source/WebCore/ChangeLog 2011-09-08 17:41:48 UTC (rev 94766)
@@ -1,3 +1,20 @@
+2011-09-08 Ryosuke Niwa rn...@webkit.org
+
+Make bindings tests quiet after r94701.
+
+* bindings/scripts/test/JS/JSTestInterface.cpp:
+* bindings/scripts/test/JS/JSTestInterface.h:
+(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
+* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
+(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+* bindings/scripts/test/JS/JSTestObj.h:
+(WebCore::JSTestObjPrototype::JSTestObjPrototype):
+* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
+(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
+
2011-09-07 Pavel Podivilov podivi...@chromium.org
Web Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (94765 => 94766)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2011-09-08 17:18:32 UTC (rev 94765)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2011-09-08 17:41:48 UTC (rev 94766)
@@ -133,7 +133,7 @@
#undef THUNK_GENERATOR
static JSC_CONST_HASHTABLE HashTable JSTestInterfacePrototypeTable = { 1, 0, JSTestInterfacePrototypeTableValues, 0 };
-const ClassInfo JSTestInterfacePrototype::s_info = { TestInterfacePrototype, JSC::JSObjectWithGlobalObject::s_info, JSTestInterfacePrototypeTable, 0 };
+const ClassInfo JSTestInterfacePrototype::s_info = { TestInterfacePrototype, JSC::JSNonFinalObject::s_info, JSTestInterfacePrototypeTable, 0 };
JSObject* JSTestInterfacePrototype::self(ExecState* exec, JSGlobalObject* globalObject)
{
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h (94765 => 94766)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h 2011-09-08 17:18:32 UTC (rev 94765)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h 2011-09-08 17:41:48 UTC (rev 94766)
@@ -26,7 +26,7 @@
#include JSDOMBinding.h
#include TestInterface.h
#include runtime/JSGlobalObject.h
-#include runtime/JSObjectWithGlobalObject.h
+#include runtime/JSObject.h
#include runtime/ObjectPrototype.h
namespace WebCore {
@@ -62,9 +62,9 @@
JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, TestInterface*);
TestInterface* toTestInterface(JSC::JSValue);
-class JSTestInterfacePrototype : public JSC::JSObjectWithGlobalObject {
+class JSTestInterfacePrototype : public JSC::JSNonFinalObject {
public:
-typedef JSC::JSObjectWithGlobalObject Base;
+typedef JSC::JSNonFinalObject Base;
static JSC::JSObject* self(JSC::ExecState*, JSC::JSGlobalObject*);
static JSTestInterfacePrototype* create(JSC::JSGlobalData globalData, JSC::JSGlobalObject* globalObject, JSC::Structure* structure)
{
@@ -78,7 +78,7 @@
}
private:
-JSTestInterfacePrototype(JSC::JSGlobalData globalData, JSC::JSGlobalObject* globalObject,
