/Expressions.scala (line 336)
<https://reviews.apache.org/r/45499/#comment192605>
Can you pls follow sql syntax for [asc, desc] - similiar to
https://msdn.microsoft.com/en-us/library/ms188385.aspx . Would be familiar with
users. Also ASC could be made optional
- Suma Shivaprasad
On April 14, 2016
/GremlinQuery.scala (line 386)
<https://reviews.apache.org/r/45499/#comment192609>
we would also need to take care of limit and order by in withPath
expressions
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> ---
> On April 15, 2016, 4:45 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 336
> > <https://reviews.apache.org/r/45499/diff/7/?file=1344372#file1344372line336>
> >
> > Can you pls follow sql syn
/Expressions.scala (line 333)
<https://reviews.apache.org/r/45499/#comment192612>
pls add to documentaion in search.twiki
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically gener
/GremlinQuery.scala (line 347)
<https://reviews.apache.org/r/45499/#comment192616>
this var could be renamed from count to something else since its a bit
confusing..since its the end offset if I am correct?
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta
n this?
- Suma Shivaprasad
On April 14, 2016, 3:24 p.m., Hemanth Yamijala wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
(line 59)
<https://reviews.apache.org/r/45929/#comment192631>
what is the expected behaviour in unclean shutdown case when lock is not
cleared? Is this an ephemeral node that will be cleared automatically?
- Suma Shivaprasad
On April 14, 2016, 3:24 p.m., Hemanth Yamijala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46011/#review129179
---
Ship it!
Ship It!
- Suma Shivaprasad
On April 15, 2016, 4
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
4c7ac70
client/src/main/java/org/apache/atlas/AtlasClient.java 22a1726
Diff: https://reviews.apache.org/r/46409/diff/
Testing
---
Added tests in HiveHookIT
Thanks,
Suma Shivaprasad
/diff/
Testing
---
Added tests in HiveHookIT
Thanks,
Suma Shivaprasad
(line 92)
<https://reviews.apache.org/r/45929/#comment193157>
We need to add some documentation for this as part of Installation docs?.
- Suma Shivaprasad
On April 18, 2016, 6:31 p.m., Hemanth Yamijala wrote:
>
> ---
> On April 15, 2016, 6:31 p.m., Suma Shivaprasad wrote:
> > webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java, line 59
> > <https://reviews.apache.org/r/45929/diff/3/?file=1344552#file1344552line59>
> >
> > what is the expected behaviour in u
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45929/#review129663
---
Ship it!
Ship It!
- Suma Shivaprasad
On April 18, 2016, 6
> On April 15, 2016, 5:24 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 333
> > <https://reviews.apache.org/r/45499/diff/7/?file=1344372#file1344372line333>
> >
> > pls add to documentaion in se
/GremlinQuery.scala (line 128)
<https://reviews.apache.org/r/45499/#comment193166>
Code is duplicated . Can you pls consolidate in one class?
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> ---
> This is a
/GremlinEvaluator.scala (line
126)
<https://reviews.apache.org/r/45499/#comment193167>
instead of null, pls make the scala Option Some/None
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> ---
> This is a
/GraphBackedDiscoveryServiceTest.java
(line 256)
<https://reviews.apache.org/r/45499/#comment193168>
pls add one query with order by limit and withpath
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> ---
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46409/#review129681
-------
On April 19, 2016, 9:29 p.m., Suma Shivaprasad wrote:
>
>
tps://reviews.apache.org/r/45499/#comment193311>
Why is it necessary to use in backquote. Didnt understand that part?
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e
tps://reviews.apache.org/r/45499/#comment193319>
can you pls change asce to sortOrder
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
tps://reviews.apache.org/r/45499/#comment193321>
pls change ofset to offsetValue
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/
Testing
---
Added tests in HiveHookIT
Thanks,
Suma Shivaprasad
xed
it by replacing with old DB instance
- Suma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46409/#review129681
-------
On
me.
> >
> > I am trying to understand why Step 1 is required. Is it to take care of
> > situations where the old table did not exist before in Atlas?
>
> Suma Shivaprasad wrote:
> Yes its required to create old table stat
Thanks,
Suma Shivaprasad
Thanks,
Suma Shivaprasad
Thanks,
Suma Shivaprasad
tps://reviews.apache.org/r/45499/#comment193970>
should be sortOrder
- Suma Shivaprasad
On April 20, 2016, 9:22 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review130975
---
Ship it!
Ship It!
- Suma Shivaprasad
On April 23, 2016, 12
b0d4c5c
Diff: https://reviews.apache.org/r/46922/diff/
Testing
---
Added tests in HIveHookIT.testInsertIntoTempTable.
Thanks,
Suma Shivaprasad
-application.properties a343a20
Diff: https://reviews.apache.org/r/46922/diff/
Testing
---
Added tests in HIveHookIT.testInsertIntoTempTable.
Thanks,
Suma Shivaprasad
ing in maping the graph to
type twice. We could try Titan caching as well?
- Suma Shivaprasad
On May 4, 2016, 10:58 a.m., Hemanth Yamijala wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On May 4, 2016, 3:33 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java,
> > line 56
> > <https://reviews.apache.org/r/46943/diff/2/?file=1370654#file1370654line56>
> >
> > Does it make
)
<https://reviews.apache.org/r/46731/#comment195990>
would be better to keep the result consistent for all CRUD operations and
standardize as EntityResult
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS
)
<https://reviews.apache.org/r/46731/#comment195992>
This will cause some users an UI to break rt?. would be better to send a
mail out to atlas-dev
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -
(line 64)
<https://reviews.apache.org/r/46731/#comment195994>
why do we need String comparision here and not direct quals which would be
faster?
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> ---
/EntityNotificationImpl.java
(line 95)
<https://reviews.apache.org/r/46731/#comment195996>
traits null check is missing . Could lead to NPE ? Also would be better to
split to make it more readable
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS
typesystem/src/main/resources/atlas-application.properties a343a20
Diff: https://reviews.apache.org/r/46922/diff/
Testing
---
Added tests in HIveHookIT.testInsertIntoTempTable.
Thanks,
Suma Shivaprasad
/
Testing
---
Added tests in HIveHookIT.testInsertIntoTempTable.
Thanks,
Suma Shivaprasad
/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
eae3063
Diff: https://reviews.apache.org/r/47107/diff/
Testing
---
Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT
Thanks,
Suma Shivaprasad
/Constants.java (line 70)
<https://reviews.apache.org/r/47111/#comment196509>
rename to getInternalAttribute?
- Suma Shivaprasad
On May 9, 2016, 8:02 a.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail.
/Constants.java (line 69)
<https://reviews.apache.org/r/47111/#comment196510>
move this as well to TypesUtil?
- Suma Shivaprasad
On May 9, 2016, 8:02 a.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47111/#review132331
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 9, 2016, 8:02
> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363301#file1363301line579>
> >
> > would be better to keep the result consistent
> On May 5, 2016, 10:05 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 66
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363302#file1363302line66>
> >
> > why do we need String comparision here and
/HBaseTestUtils.java
(line 40)
<https://reviews.apache.org/r/46731/#comment196514>
why is this removed?
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail.
135/#comment196719>
can we take solr version from pom instead
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
135/#comment196721>
will this take care of a similiar fix that Shwetha did to not download if
it already exists. If not, can we add that here?
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
135/#comment196723>
can we take hbase verion from pom instead of hardcoding pls
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/47135/#comment196724>
pls rename to create_solr_collection
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/47135/#comment196726>
what is the use of this config?
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/47135/#comment196725>
will these env vars be set by AMBARI configs?
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/47135/#comment196730>
shouldnt this be solr5
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tps://reviews.apache.org/r/47135/#comment196728>
we should comment the elastic search entries to avoid confusion
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically gener
er and see how we can handle this. The same goes for
replica
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/DeleteHandler.java
(line 284)
<https://reviews.apache.org/r/46905/#comment196773>
the same case should be taken care of for maps?
- Suma Shivaprasad
On May 3, 2016, 8:26 p.m., David Kantor wrote:
>
> ---
> This is a
- HiveAStREwriteTest and IT asserttions in HiveHookIT
Thanks,
Suma Shivaprasad
> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote:
> > distro/src/bin/atlas_config.py, line 102
> > <https://reviews.apache.org/r/47135/diff/1/?file=1377049#file1377049line102>
> >
> > if this config is changed by a user through Ambari, we need to hand
> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote:
> > distro/src/bin/atlas_config.py, line 102
> > <https://reviews.apache.org/r/47135/diff/1/?file=1377049#file1377049line102>
> >
> > if this config is changed by a user through Ambari, we need to hand
/HiveLineageService.java
(lines 65 - 66)
<https://reviews.apache.org/r/47225/#comment197270>
while we are anyways doing this, should we rename HiveLineageService to
DataSetLineageService
- Suma Shivaprasad
On May 11, 2016, 9:21 a.m., Shwetha GS
/HiveLineageService.java
(line 146)
<https://reviews.apache.org/r/47225/#comment197271>
rename to DataSetLineageQuery and remove all hive specific references ?
- Suma Shivaprasad
On May 11, 2016, 9:21 a.m., Shwetha GS wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46905/#review132979
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 11, 2016, 11:15
--------
On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47107/
> -
s://reviews.apache.org/r/47107/#review132845
---
On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote:
>
> ---
> This is an automatically generated e-mail.
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47107/#review132845
-------
On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote:
>
>
cdf6049
webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
bc02f90
Diff: https://reviews.apache.org/r/47107/diff/
Testing
---
Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT
Thanks,
Suma Shivaprasad
/atlas/web/resources/HiveLineageJerseyResourceIT.java
bc02f90
Diff: https://reviews.apache.org/r/47107/diff/
Testing
---
Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT
Thanks,
Suma Shivaprasad
-----
On May 13, 2016, 7:20 a.m., Suma Shivaprasad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47107/
>
: https://reviews.apache.org/r/47107/diff/
Testing
---
Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT
Thanks,
Suma Shivaprasad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/#review133548
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 17, 2016, 8:15
/HiveHook.java (line
311)
<https://reviews.apache.org/r/47638/#comment198814>
pls change var name from nameChanged to nameNotModified.
- Suma Shivaprasad
On May 20, 2016, 6:42 a.m., Vimal Sharma wrote:
>
> ---
> This is a
/DefaultMetadataService.java
(line 427)
<https://reviews.apache.org/r/46731/#comment199115>
if this needs to be fixed, pls raise a jira
- Suma Shivaprasad
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> ---
> This is an automatica
/DeleteHandler.java
(line 312)
<https://reviews.apache.org/r/46731/#comment199116>
why is the check for isComposite removed? Can you pls explain?
- Suma Shivaprasad
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> ---
/EntityJerseyResourceIT.java
(line 74)
<https://reviews.apache.org/r/46731/#comment199118>
pls add asserts for update test cases as well for updated entities
- Suma Shivaprasad
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> ---
> On May 23, 2016, 5:02 a.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java,
> > line 318
> > <https://reviews.apache.org/r/46731/diff/3/?file=1387706#file1387706line318>
> >
> > why is the
/HiveHook.java (line
381)
<https://reviews.apache.org/r/47638/#comment199460>
Can we overload this function instead of making it null?
- Suma Shivaprasad
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> ---
> This is a
/HiveHookIT.java
(line 742)
<https://reviews.apache.org/r/47638/#comment199461>
can you pls add a test with column position changed as well
- Suma Shivaprasad
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134618
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 23, 2016, 6:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134619
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 24, 2016, 7:34
/DeleteHandler.java
(line 196)
<https://reviews.apache.org/r/47841/#comment199827>
with this is there any way to delete singleton traits if no references
exist to that trait?
- Suma Shivaprasad
On May 25, 2016, 6:54 p.m., Shwetha GS
/TypedInstanceToGraphMapper.java
(line 661)
<https://reviews.apache.org/r/47841/#comment199831>
if there any way to support trait attribute updates by its type for
singleton traits ?
- Suma Shivaprasad
On May 25, 2016, 6:54 p.m., Shwetha GS
e? Any reason
this was done?
- Suma Shivaprasad
On May 25, 2016, 6:41 p.m., Vimal Sharma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On May 26, 2016, 3:25 a.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java,
> > line 345
> > <https://reviews.apache.org/r/47638/diff/2-3/?file=1391379#file1391379line345>
> >
> > its better t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review135160
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 26, 2016, 6:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48050/#review135675
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 30, 2016, 6:07
/GraphHelper.java
(line 440)
<https://reviews.apache.org/r/47658/#comment201012>
thyis method can be modified since a IConstructableType.fieldMapping is
already available and we can just do a check for IConstructableType else throw
exception?
- Suma Shivaprasad
On June 2, 2016, 1:
/TypedInstanceToGraphMapper.java
(line 783)
<https://reviews.apache.org/r/47658/#comment201148>
do we need the HashSet since contains and all will both O(n)
- Suma Shivaprasad
On June 3, 2016, 1:55 p.m., David Kantor wrote:
>
> --
/TypedInstanceToGraphMapper.java
(line 441)
<https://reviews.apache.org/r/47658/#comment201149>
for map types, can we check if the reverseAttributeName is set on the map
type and remove it if set else ignore?
- Suma Shivaprasad
On June 3, 2016, 1:55 p.m., David Kantor
> On June 3, 2016, 11:29 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java,
> > line 443
> > <https://reviews.apache.org/r/47658/diff/5/?file=1405688#file1405688line443>
> >
> >
> On June 3, 2016, 11:25 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java,
> > line 785
> > <https://reviews.apache.org/r/47658/diff/5/?file=1405688#file1405688line785>
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48452/#review136754
---
Ship it!
Ship It!
- Suma Shivaprasad
On June 9, 2016, 12:41
changes looks good to me.
- Suma Shivaprasad
On June 9, 2016, 10:30 a.m., Hemanth Yamijala wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Hi all,
As part of changes in ATLAS-542 to make attribute names consistent across
Datasets and Process inherited types, "name" will represent shorter name
and "qualifiedName" will represent the fully qualified unique name which
uniquely idenitifies the entity. One of the attribute names that
pri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48280/#review137355
---
Ship it!
Ship It!
- Suma Shivaprasad
On June 13, 2016, 4:35
/resources/EntityResource.java
0713d30
Diff: https://reviews.apache.org/r/48939/diff/
Testing
---
Existing tests modified to query with new qualified name. Need to add tests for
INSERT INTO TABLE
Thanks,
Suma Shivaprasad
INTO TABLE
Thanks,
Suma Shivaprasad
INSERT INTO TABLE
Thanks,
Suma Shivaprasad
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48939/#review138534
---
On June 20, 2016, 4 a.m., Suma Shivaprasad wrote:
>
> -
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48939/#review138554
---
On June 20, 2016, 4 a.m., Suma Shivaprasad wrote:
>
>
sit:
https://reviews.apache.org/r/48939/#review138565
---
On June 20, 2016, 4 a.m., Suma Shivaprasad wrote:
>
> ---
> This is an automatically generated e-mail. To re
1 - 100 of 1928 matches
Mail list logo
