Re: Redirecting http://hg.mozilla.org/ to https://

I have two extra suggestions for added security benefits: 1. In order to ensure that clients that support CSP will never attempt to contact the HTTP version of the site for fetching any subresources that may still point to http:, please make sure to serve the |Content-Security-Policy: upgrade-inse

Re: Changing the representation of rectangles in platform code

On 2017-02-11 3:27 AM, ISHIKAWA,chiaki wrote: > On 2017/02/11 7:07, Botond Ballo wrote: >> On Fri, Feb 10, 2017 at 3:45 PM, Milan Sreckovic >> wrote: >>> First step needs to happen completely before the second step does, so I >>> guess the danger is that we start and give up before we get to step

Re: Intent to implement and ship: only allow Flash on HTTP/HTTPS sites

On 2017-02-10 7:51 PM, 段垚 wrote: > > > 在 2017/2/11 2:26, t...@ritter.vg 写道: >> On Friday, 10 February 2017 08:32:27 UTC-6, Benjamin Smedberg wrote: >>> I thought I enumerated the harm at first, but I'll elaborate a little. >>> >>> 1) Flash doesn't know about and breaks our "current and subdirect

Re: Intent to implement and ship: only allow Flash on HTTP/HTTPS sites

On 2017-02-13 11:50 AM, 段垚 wrote: > > > 在 2017/2/14 0:24, Ehsan Akhgari 写道: >> On 2017-02-10 7:51 PM, 段垚 wrote: >>> >>> 在 2017/2/11 2:26, t...@ritter.vg 写道: >>>> On Friday, 10 February 2017 08:32:27 UTC-6, Benjamin Smedberg wrote: >>>

Re: Tool for converting C++ standard library naming style to Gecko naming style?

On 2017-02-16 7:41 AM, Henri Sivonen wrote: > Is there some kind of tool, similar to ./mach clang-format for > whitespace, that changes identifies from C++ standard library style to > Gecko style? > > I.e. foo becomes Foo, foo_bar becomes FooBar and arguments and members > get prefixed with a and

Re: Intent to unship: xml:base attribute

On 2017-02-16 1:51 AM, Xidorn Quan wrote: > Tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=903372 > > Summary: > * It has been removed from the spec years ago. > * No other browser supports it. > * We pay performance penalty for it. > * It makes things trickier for stylo to handle URL

Re: Intent to unship: xml:base attribute

On 2017-02-16 6:06 PM, Xidorn Quan wrote: > On Fri, Feb 17, 2017, at 01:38 AM, Ehsan Akhgari wrote: >> On 2017-02-16 1:51 AM, Xidorn Quan wrote: >>> Tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=903372 >>> >>> Summary: >>> * It has been re

Re: Intent to ship: WebVR on Windows in Release

Hi Kearwood, I and a few other engineers have been studying the performance of Firefox for several weeks now as part of the Quantum Flow project and one of the serious performance issues that we have been finding in various parts of the browser have been synchronous IPC messages sent from the cont

Re: Intent to ship: WebVR on Windows in Release

thread / queue.. Would this > make sense? > My first suggestion is to gather some profiles of some WebVR test runs to get a better sense of what the current situation looks like. Still it seems to me that we shouldn't have any sync IPC on the path of the DOM APIs that are exposed to

Re: Is there a way to improve partial compilation times?

On 2017-03-07 2:49 PM, Eric Rahm wrote: > I often wonder if unified builds are making things slower for folks who use > ccache (I assume one file changing would mean a rebuild for the entire > unified chunk), I'm not sure if there's a solution to that but it would be > interesting to see if compili

Re: Is there a way to improve partial compilation times?

On 2017-03-08 6:40 AM, James Graham wrote: > On 08/03/17 11:11, Frederik Braun wrote: >> On 08.03.2017 01:17, Ralph Giles wrote: >>> I second Jeff's point about building with icecream[1]. If you work in >>> an office with a build farm, or near a fast desktop machine you can >>> pass jobs to, this m

Re: Heads Up: /storage upgraded from version 1.0 to 2.0

On 2017-03-07 8:02 PM, Ben Kelly wrote: > On Tue, Mar 7, 2017 at 6:09 PM, Xidorn Quan wrote: > >>> This major version change is downgrade-incompatible, so IndexedDB and >>> DOM cache won't work in an older version if their profile has been >>> upgraded. >>> IndexedDB is also used internally, so s

Re: Is there a way to improve partial compilation times?

On 2017-03-08 5:12 PM, Steve Fink wrote: > On 03/08/2017 06:21 AM, Ehsan Akhgari wrote: >> On 2017-03-07 2:49 PM, Eric Rahm wrote: >>> I often wonder if unified builds are making things slower for folks >>> who use >>> ccache (I assume one file changing

Re: Is there a way to improve partial compilation times?

On 2017-03-08 11:31 AM, Simon Sapin wrote: > On 08/03/17 15:24, Ehsan Akhgari wrote: >> What we did in the Toronto office was walked to people who ran Linux on >> their desktop machines and installed the icecream server on their >> computer. I suggest you do the same in Lond

Quantum Flow Engineering Newsletter #1

Hi everyone, A while ago a number of engineers including myself started to look into a performance project that turned into Quantum Flow. The focus of the project is finding and prioritising the issues across the browser so we will need help from many of you to get them fixed. I’m planning to wr

Please write good commit messages before asking for code review

I review a large number of patches on a typical day, and usually I have to spend a fair amount of time to just understand what the patch is doing. As the patch author, you can do a lot to help make this easier by *writing better commit messages*. Starting now, I'm going to try out a new practice

Re: Please write good commit messages before asking for code review

On 2017-03-09 5:07 PM, Andrew McCreight wrote: > On Thu, Mar 9, 2017 at 1:55 PM, Nicholas Alexander > wrote: > >> On Thu, Mar 9, 2017 at 1:48 PM, Boris Zbarsky wrote: >> >>> On 3/9/17 4:35 PM, Eric Rescorla wrote: >>> I'm in favor of good commit messages, but I would note that current m-c >

Re: Please write good commit messages before asking for code review

On 2017-03-09 5:35 PM, Mike Hommey wrote: > On Thu, Mar 09, 2017 at 02:46:53PM -0500, Ehsan Akhgari wrote: >> I review a large number of patches on a typical day, and usually I have to >> spend a fair amount of time to just understand what the patch is doing. As >> the patch

Re: Please write good commit messages before asking for code review

On 2017-03-09 5:48 PM, Eric Rescorla wrote: > > > On Thu, Mar 9, 2017 at 2:43 PM, Ben Kelly <mailto:bke...@mozilla.com>> wrote: > > On Thu, Mar 9, 2017 at 5:35 PM, Mike Hommey <mailto:m...@glandium.org>> wrote: > > > On Thu, Mar 09, 201

Re: Please write good commit messages before asking for code review

On 2017-03-09 6:03 PM, L. David Baron wrote: > On Friday 2017-03-10 07:46 +0900, Mike Hommey wrote: >> I'd argue some of this commit message should actually be in the >> code comment. > > Yes. The commit message should be largely about *change* (how this > revision of code is different from earli

Re: The future of commit access policy for core Firefox

On 2017-03-09 6:51 PM, Justin Dolske wrote: > Similar to "r+ with fixes" are cases where a patch (or patch series) > requires reviews from a multitude of people. Which means variable delays in > getting reviews, during which things may slightly bitrot or be trivially > modified based on feedback fr

Re: New requirement: New processes need AWSY support before landing

On 2017-03-10 4:38 PM, Brad Lassey wrote: > Hi all, > We seem to be taking advantage of our multi-process capabilities more and > more these days. In order to fully understand the memory impact of these > changes, any new process type needs to be fully supported by AWSY (Are We > Slim Yet) prior

Re: The future of commit access policy for core Firefox

On 2017-03-11 9:23 AM, smaug via governance wrote: > On 03/11/2017 08:23 AM, Nicholas Nethercote wrote: >> On Sat, Mar 11, 2017 at 2:23 PM, smaug via governance < >> governa...@lists.mozilla.org> wrote: >>> >>> I'd be ok to do a quick r+ if interdiff was working well. >> >> Depending on the relativ

Re: The future of commit access policy for core Firefox

On 2017-03-12 4:53 PM, smaug wrote: > On 03/12/2017 10:40 PM, Ehsan Akhgari wrote: >> On 2017-03-11 9:23 AM, smaug via governance wrote: >>> On 03/11/2017 08:23 AM, Nicholas Nethercote wrote: >>>> On Sat, Mar 11, 2017 at 2:23 PM, smaug via governance < >>

Re: What are the differences between a profile in Safe Mode, and a clean profile?

On Mon, Mar 13, 2017 at 2:10 PM, Botond Ballo wrote: > Over time, I have encountered a number of (what I assume are) Firefox bugs > that: > > - Reproduce in my default profile, even in Safe Mode > - Do not reproduce in a clean profile > > Since they do not reproduce in a clean profile, I have

Re: Intent to ship: IntersectionObserver API

On 2017-03-15 8:14 AM, Michael de Boer wrote: > Hi Tobias, > > Very exciting! This is a _very_ welcome addition to the family of Web APIs, > IMHO. > > I’m curious about the performance characteristics for consumers of this API: > how does it scale in respect to > 1. The amount of observers acti

Quantum Flow Engineering Newsletter #2

Hi everyone, This past week was another busy week chasing down performance issues in Firefox. We managed to knock out a few issues, get closer to close out a couple of really high impact ones, and are making good progress on starting to get performance data from telemetry which will hopefully all

Re: Quantum Flow Engineering Newsletter #2

On Thu, Mar 16, 2017 at 11:07 AM, Ehsan Akhgari wrote: > > Now, on to the credits section. I’d like to take a moment to recognize > the work of the following individuals who have helped with various aspects > of the Quantum Flow project. Thank you very much for your help this

Re: Quantum Flow Engineering Newsletter #2

On Thu, Mar 16, 2017 at 4:27 PM, Kris Maglione wrote: > On Thu, Mar 16, 2017 at 11:07:19AM -0400, Ehsan Akhgari wrote: > >> This is why a while ago we decided to disallow the addition of new >> synchronous IPC messages by default (bug 1336919) to avoid programmers >> ad

Re: Third Party Library Alert Service

We have library imports that are forks, for example dom/media/webaudio/blink, as the README file explains. That should probably be removed from that list. On 2017-03-17 2:30 PM, Tom Ritter wrote: > As part of a broader initiative to perform a security review of the > third party libraries we use,

Re: Tracking bug for removals after XPCOM extensions are no more?

On 2017-03-16 2:29 PM, Bobby Holley wrote: > On Thu, Mar 16, 2017 at 11:23 AM, R Kent James wrote: > >> On 3/15/2017 3:51 PM, Benjamin Smedberg wrote: >> >>> after Firefox 57 when >>> Webextensions are the only extensions, if our product no longer needs some >>> functionality (and it's "API"), le

Re: Switching to async/await from Task.jsm/yield

On 2017-03-16 6:29 PM, Dave Townsend wrote: > For a long time now we've been writing JS code that waits for promises > using Task.jsm and generator functions. Recently though the JS team > added support for the JS standard way of doing this, async/await: > https://developer.mozilla.org/en-US/docs/W

Posthumous intent to unship: experimental createImageBitmap() overload accepting ArrayBuffer and ArrayBufferView arguments

Last night, we were informed of security vulnerabilities in the implementation of an experimental extension to createImageBitmap() accepting ArrayBuffer and ArrayBufferView arguments which, as it turns out, was accidentally shipped in bug 1141979. After careful examination it became clear that the

Re: Preferences::RegisterCallback and variants will now do exact, not prefix, matches

On 2017-03-21 10:40 PM, Boris Zbarsky wrote: > On 3/21/17 4:34 PM, Eric Rahm wrote: >> This doesn't affect the behavior of |Preferences::AddStrongObserver| >> which >> does prefix matching, correct? > > That's correct. Same for AddWeakObserver. > > It's a little harder to misuse because it doesn

Quantum Flow Engineering Newsletter #3

Hi everyone, Another week, another Quantum Flow engineering newsletter! We have a lot to cover, so let me get started. Michael Layzell is getting really close on his work on bug 1346415 in order to collect native stacks from Background Hang

Re: Faster gecko builds with IceCC on Mac and Linux

On Thu, Mar 23, 2017 at 7:51 PM, Jeff Gilbert wrote: > I'm interested to find out how the new Ryzen chips do. It should fit > their niche well. I have one at home now, so I'll test when I get a > chance. > Ryzen currently on Linux implies no rr, so beware of that. > On Wed, Jul 6, 2016 at 12:0

Re: Future of out-of-tree spell checkers?

On Wed, Mar 22, 2017 at 11:50 AM, Jeff Muizelaar wrote: > On Wed, Mar 22, 2017 at 11:08 AM, Henri Sivonen > wrote: > > > > dlopening libvoikko, if installed, and having thin C++ glue code > > in-tree seems much simpler, except maybe for sandboxing. What are the > > sandboxing implications of dlo

Re: Future of out-of-tree spell checkers?

On 2017-03-24 4:20 AM, Henri Sivonen wrote: > On Fri, Mar 24, 2017 at 2:38 AM, Ehsan Akhgari > wrote: >> On Wed, Mar 22, 2017 at 11:50 AM, Jeff Muizelaar >> wrote: >>> >>> On Wed, Mar 22, 2017 at 11:08 AM, Henri Sivonen >>> wrote: >>>>

Re: Future of out-of-tree spell checkers?

ince I doubt that MoCo will prioritize supporting a whole new spell checking backend for 2 new languages, but I think we can do a lot to help. > On Fri, Mar 24, 2017 at 6:20 AM, Ehsan Akhgari <mailto:ehsan.akhg...@gmail.com>> wrote: > > On 2017-03-24 4:20 AM, Henri Sivonen wro

Re: Cost of "duplicating" (or "worse") large parts of web-platform-tests

On 2017-03-20 2:19 PM, Anne van Kesteren wrote: > web-platform-tests has a nice feature which generates a bunch of > boilerplate for you for dedicated worker tests and tests that can be > run both in a window and a dedicated worker: > > http://web-platform-tests.org/writing-tests/testharness.htm

Re: Third Party Library Alert Service

On 2017-03-18 3:22 PM, Daniel Veditz wrote: > On Fri, Mar 17, 2017 at 3:26 PM, Ehsan Akhgari <mailto:ehsan.akhg...@gmail.com>> wrote: > > We have library imports that are forks, for example > ​ ​ > dom/media/webaudio/blink, as the README file explains. That

Re: Switching to async/await from Task.jsm/yield

On 2017-03-17 7:41 PM, Kris Maglione wrote: > On Fri, Mar 17, 2017 at 07:30:46PM -0400, Ehsan Akhgari wrote: >> Have we measured the performance of our async/await implementation? I >> think we should definitely do some extensive testing of the performance >> of any new

Re: Proper way to return nsresult from Rust before Stylo is mandatory?

On 2017-03-17 10:08 AM, Michael Layzell wrote: > I don't think we have any particularity good tools for this right now. A > while ago I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1320179 to > add a separate crate like the nsstring crate which provides the nsresult > bindings. If we are star

Re: Proper way to return nsresult from Rust before Stylo is mandatory?

Mar 26, 2017 at 11:26 PM, Ehsan Akhgari <mailto:ehsan.akhg...@gmail.com>> wrote: > > On 2017-03-17 10:08 AM, Michael Layzell wrote: > > I don't think we have any particularity good tools for this right now. A > > while ago I filed https://

Re: Intent to change editor newline behavior

On 2017-04-04 7:55 AM, Aryeh Gregor wrote: > On Mon, Apr 3, 2017 at 11:39 PM, Benjamin Smedberg > wrote: >> >> I'd like to encourage you to set up a test plan for this. My impression of >> the risk profile of this work is that we could easily break some really >> important use-cases, and it's li

Re: Intent to change editor newline behavior

On Tue, Apr 4, 2017 at 11:31 AM, Aryeh Gregor wrote: > On Tue, Apr 4, 2017 at 5:57 PM, Ehsan Akhgari > wrote: > > I don't own this module any more, so this isn't my call to make, but if > > I had to choose what to do here, I would probably either choose to not > &

Re: Intent to change editor newline behavior

On 2017-04-05 7:27 AM, Aryeh Gregor wrote: > On Wed, Apr 5, 2017 at 3:12 AM, Ehsan Akhgari wrote: >> Exactly. We can hypothesize either way, but we certainly can't know easily >> without getting some data first. But unfortunately it's not possible to >> collect

Re: Enabling Pointer Events in Firefox (desktop) Nightly on Mac and Linux

On 2017-04-05 5:44 PM, Tom Ritter wrote: > On Wed, Apr 5, 2017 at 12:29 PM, Aryeh Gregor wrote: >> On Wed, Apr 5, 2017 at 7:34 PM, Tom Ritter wrote: >>> It looks like this exposes pointerType, which reveals whether the user >>> is using a mouse, pen, or touch input. >>> >>> It also exposes detail

Re: Enabling Pointer Events in Firefox (desktop) Nightly on Mac and Linux

On Thu, Apr 6, 2017 at 12:57 AM, L. David Baron wrote: > On Thursday 2017-04-06 00:33 -0400, Ehsan Akhgari wrote: > > In general, I should also say that designing features with > > fingerprinting in mind is *extremely* difficult and takes a lot of > > effort on the part o

Re: Intent to change editor newline behavior

On 2017-04-06 7:51 AM, Aryeh Gregor wrote: > On Wed, Apr 5, 2017 at 11:22 PM, Daniel Veditz wrote: >> One line or a thousand isn't the point; building, release and update >> testing, and shipping 90 locales times 6 platforms is a huge amount work. If >> we have a pref and break something we can ba

Quantum Flow Engineering Newsletter #4

Hi everyone, As promised (with a day of delay), here is an update on what happened in the last two weeks on making Firefox faster as part of the Quantum Flow project. Last week we had a big work week at the Mozilla Toronto office. Many members of the various teams were attending and the week was

Re: Tier 3 win64 ASan builds on try

Indeed, thanks Ting-Yu and everyone else who finally made this happen. This is extremely valuable, especially for Gecko developers who work on security sensitive bugs, as they can now use address sanitizer on Windows similarly to other major OSes that we support! On 2017-04-07 4:25 PM, Kan-Ru Chen

Re: Tier 3 win64 ASan builds on try

On 2017-04-10 12:47 AM, Chris Pearce wrote: > On Friday, April 7, 2017 at 2:11:32 PM UTC+12, Ting-Yu Chou wrote: >> Just a heads up that now we have win64 ASan builds on try. The try format: >> >> try: -b o -p win64-asan -u none -t none >> >> Bug 1347793 is tracking the failed tests on taskcluste

Quantum Flow Engineering Newsletter #5

Hi everyone, Another week full of performance related updates quickly went by, I'd like to share a few of them. We're almost mid-April, about 3 weeks after I shared my first update on our progress battling our sync I

Re: Welcome new HTML Parser peer

On 2017-04-13 3:55 AM, Henri Sivonen wrote: > William Chen made the largest change to the HTML Parser since the > initial landing of the current HTML parser by adding support for HTML > templates and, since then, has been reviewing HTML Parser changes for > a long time now. > > I'm pleased to anno

Re: Future of out-of-tree spell checkers?

Linux case. It's the same situation with > e.g. PulseAudio and Gtk anyway.) It is also untrusted and unsigned code and can cause security and unstability issues. We have done a lot of work to remove all such code from our parent process. I don't think it's useful to make an ana

Re: A reminder about commit messages: they should be useful

On 2017-04-18 12:30 AM, Mike Hommey wrote: >> I've yet to see that to happen. What is crucial is fast way to browse >> through the blame in time. So commit messages should be short and >> descriptive. Telling what and why. (I very often need to go back to CVS era >> code). I won't spend time readin

Re: Quantum Flow Engineering Newsletter #5

On 2017-04-18 1:53 PM, Justin Dolske wrote: > > > On Tue, Apr 18, 2017 at 1:19 AM, Jack Moffitt > wrote: > > > Another really nice effort that is starting to unfold and I'm super > excited > > about is the new Photon performance project > >

Re: Future of out-of-tree spell checkers?

On 2017-04-18 2:38 AM, Henri Sivonen wrote: > On Sat, Apr 15, 2017 at 8:06 PM, Ehsan Akhgari > wrote: >> On 2017-03-27 3:30 AM, Henri Sivonen wrote: >>> 2) We couldn't trigger a libvoikko autoupdate on Windows/Mac if there >>> was a crasher bug in the libra

Quantum Flow Engineering Newsletter #6

Hi everyone, I would like to share some updates about some of the ongoing performance related work. We have started looking at the native stack traces that are submitted through telemetry from the Background Hang Reports that take more than 8 seconds. (We were hoping to have been able to reduce

Re: Quantum Flow Engineering Newsletter #6

eryone who keeps making it better. Nick On Fri, Apr 21, 2017 at 4:25 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: Hi everyone, I would like to share some updates about some of the ongoing performance related work. We have started looking at the native stack

Re: Ambient Light Sensor API

On 04/24/2017 06:04 PM, Martin Thomson wrote: I think that 60Hz is too high a rate for this. I suggest that we restrict this to top-level, foreground, and secure contexts. Note that foreground is a necessary precondition for the attack, so that restriction doesn't really help here. Critically,

Re: Ambient Light Sensor API

On 04/25/2017 10:25 AM, Andrew Overholt wrote: On Tue, Apr 25, 2017 at 9:35 AM, Eric Rescorla wrote: Going back to Jonathan's (I think) question. Does anyone use this at all in the field? Chrome's usage metrics say <= 0.0001% of page loads: https://www.chromestatus.com/metrics/feature/popula

Re: Ambient Light Sensor API

<http://evil.com> for further >> processing? >> How it is possible for evil.com <http://evil.com> to get access to protected resources? >> >> On Tue, Apr 25, 2017 at 8:04 PM, Ehsan Akhgari mailto:ehsan.akhg...@

Re: Ambient Light Sensor API

hat have an event handler for this or some such which bug 1359124 was filed for. On Wed, Apr 26, 2017 at 5:28 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 04/25/2017 08:26 PM, Salvador de la Puente wrote: So the risk is not that high since if the image

Re: Future of out-of-tree spell checkers?

On 04/26/2017 07:02 AM, Henri Sivonen wrote: On Tue, Apr 25, 2017 at 9:02 PM, Bill McCloskey wrote: On Tue, Apr 25, 2017 at 5:41 AM, Henri Sivonen wrote: What problem did you mean to address by code signing? The reason I suggested code signing is because loading libvoikko would provide an ea

Quantum Flow Engineering Newsletter #7

Hi everyone, It's time for another quick update about the recent Quantum Flow work. I want to start by shedding some light into the performance of synchronous IPC caused by JavaScript. Here is a breakdown report

Re: Ambient Light Sensor API

On 04/27/2017 08:09 AM, Frederik Braun wrote: On 27.04.2017 13:56, smaug wrote: On 04/25/2017 04:38 PM, Ehsan Akhgari wrote: On 04/24/2017 06:04 PM, Martin Thomson wrote: I think that 60Hz is too high a rate for this. I suggest that we restrict this to top-level, foreground, and secure

Quantum Flow Engineering Newsletter #8

Hi everyone, I hope you are still not tired of reading these! :-) If not, time for another quick update about the ongoing performance related work. There are two important changes that have landed in Nightly. The first one is that Nightly (on Windows 32-bit builds) sends native stacktraces wit

Re: Future of out-of-tree spell checkers?

(Sorry for the continued laggy responses here...) On 04/27/2017 03:38 AM, Henri Sivonen wrote: For a while we've been trying to make it difficult for semi-legit-but-not-quite-malware parties to load crappy code into Firefox (I'm thinking of crappy antivirus software, adware, etc.). Removing bi

Re: Mixing nsresult and Result code

I think these seem like valuable additions to nscore.h. It would be helpful to extend these facilities that would allow more code to use the Result-based programming model. (I'm not too much of a fan of the NS_TRY name, but can't think of a better name myself... :/ ) On 05/07/2017 03:34 PM

Re: Notification() deprecation question

AFAIK this was discussed at the spec level in https://github.com/whatwg/notifications/issues/26 and the conclusion was to *not* deprecate the construcutor for the non-persistent notifications. Perhaps something has changed afterwards? On 05/08/2017 03:09 AM, Chris Mills wrote: Hi there, I

Re: Running mochitest on packaged builds with the sandbox

Hi Alex, Apologies for hijacking the thread, but since you asked, right now debugging mochitest that you want to get some logging out of with a sandboxed content process is super painful. I last hit it when I was debugging a memory leak which typically requires getting refcount leak logs and

Re: Running mochitest on packaged builds with the sandbox

and it is only then when they start to search for relevant documentation in a place related to sandboxing. Now let's go back to discussing the actual topic of the thread. Thanks for indulging the momentary digression from the topic at hand. :-) Cheers, Ehsan Cheers, Alex On Tue,

Re: Intent to ship: SharedArrayBuffer and Atomics

On 05/11/2017 09:09 AM, Lars Hansen wrote: On Thu, May 11, 2017 at 3:00 PM, Bobby Holley wrote: On Thu, May 11, 2017 at 2:48 PM, Lars Hansen wrote: On Thu, May 11, 2017 at 10:55 AM, Martin Thomson wrote: On Thu, May 11, 2017 at 5:57 PM, Lars Hansen wrote: We do think there are archite

Quantum Flow Engineering Newsletter #9

Hi everyone, It's been 10 weeks since I have started writing these newsletters (the number in the title isn't an off by one error, there was a one week hiatus due to a work week!). We still have quite a bit of work ahead of us, but we have also accomplished a good amount. Finding a good metric f

Re: Intent to Ship throttling of tracking timeouts

On Thu, May 11, 2017 at 11:32 PM, Bill McCloskey wrote: > On Thu, May 11, 2017 at 8:12 PM, Boris Zbarsky wrote: > > > On 5/11/17 10:30 PM, Eric Shepherd (Sheppy) wrote: > > > >> So part of private browsing and not a developer-facing feature, then? > >> > > > > No, as I understand this is being a

Re: Quantum Flow Engineering Newsletter #9

On 05/12/2017 12:29 PM, Tom Ritter wrote: On Fri, May 12, 2017 at 1:27 AM, Ehsan Akhgari wrote: I realized we haven't had a performance mini-story for a while -- I sort of dropped the ball on that. Running over this bug made me want to talk about a pretty well known sort of slowness

Re: Have you run 'mach bootstrap' lately?

On 05/12/2017 06:59 PM, Dustin Mitchell wrote: Yep, this caused problems in automation (we ended up setting I_PREFER_A_SUBOPTIMAL_MERCURIAL_EXPERIENCE_THANK_YOu or whatever the env var was). I agree that a quick warn-and-continue would be fine. Especially for git users. ;-) Speaking of naggin

Re: Gecko Profiler Win64 stability

I secretly demoed this today in a live demo tutorial demonstrating the Gecko Profiler over Vidyo on the latest Win64 Nightly. Thanks for improving things so much, David! On 05/18/2017 03:04 PM, David Major wrote: Hi, The Gecko Profiler used to be notoriously unstable on 64-bit Windows. (If

Quantum Flow Engineering Newsletter #10

Hi everyone, Let's start this week's updates with looking at the ongoing efforts to improve the usefulness of the background hang reports data. With Ben Miroglio's help, we confirmed that we aren't blowing up telemetry ping si

Re: Improving visibility of compiler warnings

On 05/19/2017 02:44 PM, Gregory Szorc wrote: `mach build` attempts to parse compiler warnings to a persisted "database." You can view a list of compiler warnings post build by running `mach warnings-list`. The intent behind this feature was to make it easier to find and fix compiler warnings. Aft

Re: Improving visibility of compiler warnings

On 05/25/2017 02:14 PM, Gregory Szorc wrote: On Thu, May 25, 2017 at 5:31 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: What was the motivation behind this change? Was there a complaint from a significant number of developers about it being difficult fixing co

Quantum Flow Engineering Newsletter #11

Hi everyone, Keeping track of ongoing progress and how much more work different areas need is important. I've found the new Firefox Health Dashboards that Harald Kirschner and the team have worked on extremely helpful. You can see the status of the ongoing work

Re: Linux builds now default to -O2 instead of -Os

On 06/01/2017 08:51 PM, Mike Hommey wrote: Hi, For some reason, the default when building on Linux had stayed -Os. I just landed a change[1] to this default to now use -O2 instead (on autoland at the moment). This is going to give better performance to local builds (although that might make the

Re: Intent to unship: window.showModalDialog

There was some recent activity around this in https://bugzilla.mozilla.org/show_bug.cgi?id=840640. Tim, what's the latest status on this? Are you still working on it? On 06/08/2017 09:08 AM, Mike Taylor wrote: On 6/7/17 5:23 PM, Blake Kaplan wrote: 3 years ago (!) sicking commented in bug

Quantum Flow Engineering Newsletter #12

Hi everyone, It has been a few weeks since I have given an update about our progress on reducing the amount of slow synchronous IPC messages that we send across our processes. This hasn't been because there hasn't been a lot to talk about, quite to the contrary, so much great work has happened he

Re: Changing .idl files

On 06/14/2017 09:02 AM, Benjamin Smedberg wrote: On Tue, Jun 13, 2017 at 8:40 PM, Nicholas Nethercote wrote: (3) Do extensions use it? If so, changing it probably isn't possible. This can be imperfectly determined by searching through addons/ in DXR. There is no rule that we can't break old-

Quantum Flow Engineering Newsletter #13

Hi everyone, I'm back with some more updates on another week worth of work on improving various performance aspects of Firefox. Similar to the past weeks, Speedometer remains a big focus area for performance work. In addition to the many already

Re: Shipping Headless Firefox on Linux

On 06/15/2017 04:37 PM, Nathan Froyd wrote: On Thu, Jun 15, 2017 at 2:02 PM, Brendan Dahl wrote: Headless will run less of the platform specific widget code and I don't recommend using it for platform specific testing. It is targeted more at web developers and testing regular content pages. The

Re: Shipping Headless Firefox on Linux

On 06/16/2017 10:31 AM, Dan Mosedale wrote: 2017-06-16 6:22 GMT-07:00 Ehsan Akhgari <mailto:ehsan.akhg...@gmail.com>>: On 06/15/2017 04:37 PM, Nathan Froyd wrote: Would it be feasible to use headless mode for mochitests (or reftests, etc. etc.)? Ru

Re: Errors found by cppcheck

Is it possible to run cppcheck in a mode where we select which checks it runs? If yes, we could look at the list of true positives that people have found (and continue to find) in bug 1370292 and create an opt-in set of checks that rare valuable ones to have turned on by default, and leave the

Re: Using the accesskey attribute with HTML elements in browser chrome

On 06/19/2017 04:28 PM, Brian Grinstead wrote: I was wondering what would need to be done in order to use the accesskey attribute on HTML elements in the browser chrome. Here are some of the differences between the attribute in HTML and XUL that I've found so far: 1) In XUL (https://developer

Re: Profiling nightlies on Mac - what tools are used?

On 06/20/2017 08:34 AM, Nathan Froyd wrote: There is some kind of interaction with the underlying machine (see comment 104 in said bug, where the binaries perform identically on a local machine, but differently on infrastructure), but we haven't tracked that down yet. From comment 104 it seems th

Re: Errors found by cppcheck

n here is a good one. We have used a similar mechanism to run valgrind for example and it has worked successfully in the past. I wonder if this is something that Sylvestre's team would be interested to take a look at? Cheers, Ehsan On Sun, Jun 18, 2017 at 3:08 PM, Ehsan Akhgari mailto:e

Re: Profiling nightlies on Mac - what tools are used?

On 06/20/2017 12:28 PM, Nathan Froyd wrote: On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari wrote: On 06/20/2017 08:34 AM, Nathan Froyd wrote: There is some kind of interaction with the underlying machine (see comment 104 in said bug, where the binaries perform identically on a local machine

Re: Using the accesskey attribute with HTML elements in browser chrome

On 06/20/2017 04:36 PM, Brian Grinstead wrote: On Jun 19, 2017, at 6:58 PM, Ehsan Akhgari wrote: On 06/19/2017 04:28 PM, Brian Grinstead wrote: I was wondering what would need to be done in order to use the accesskey attribute on HTML elements in the browser chrome. Here are some of the

Re: Profiling nightlies on Mac - what tools are used?

On 06/20/2017 04:42 PM, Gregory Szorc wrote: On Tue, Jun 20, 2017 at 10:28 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 06/20/2017 12:28 PM, Nathan Froyd wrote: On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com&g

Re: Profiling nightlies on Mac - what tools are used?

On 06/21/2017 06:19 AM, Chris Cooper wrote: On Tuesday, June 20, 2017 at 1:28:50 PM UTC-4, Ehsan Akhgari wrote: My understanding is that the slowdown cannot be reproduced on local developer machines, but can be reproduced on loaner machines from infra. Huh. That's interesting and even

Re: Intent to unship: HTML scoped style sheets (

On 06/20/2017 01:20 AM, Cameron McCormack wrote: On Tue, Jun 20, 2017, at 01:08 PM, Jared Wein wrote: We use a scoped stylesheet for styling the popup for [1]. We chose this route to limit performance impact as well as limit our temporary stylesheet from affecting other parts of the browser UI.

  1   2   3   4   5   6   7   8   9   10   >