Re: [PATCH 2/2] drm/vmwgfx: Use the linux DMA api to get valid device addresses of pages

2013-11-04 Thread Daniel Vetter
ct list_head *desc_pages) > + int gmr_id, dma_addr_t desc_dma) > { > - struct page *page; > - > - if (unlikely(list_empty(desc_pages))) > - return; > - > - page = list_entry(desc_pages->next, struct page, lru); >

Re: [PATCH] fbcon: fix locking harder

2013-01-25 Thread Daniel Vetter
ruct fb_info *info, > * > * Maps a virtual console @unit to a frame buffer device > * @newidx. > + * > + * This should be called with the console lock held. > */ > static int set_con2fb_map(int unit, int newidx, int user) > { What about throwing a WARN_CONSOLE_UNLOCKE

Re: regression(?) 3.3-rc4 -> 3.3-rc5: drm intel hangs

2012-02-28 Thread Daniel Vetter
> Dri-devel mailing list > Dri-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/dri-devel > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.

[SPAM] [PATCH 1/3] drm: kill drm_agp_chipset_flush

2010-04-14 Thread Daniel Vetter
rather gross amount of fragile code duplication between these two parts of the kernel intel graphics driver. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_agpsupport.c |7 --- drivers/gpu/drm/i915/i915_gem.c |8 include/drm/drmP.h |1 - 3 files

[SPAM] [PATCH 2/3] drm: drop return value of drm_free_agp

2010-04-14 Thread Daniel Vetter
No caller (rightly) cares about it, so drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_memory.c |4 ++-- include/drm/drmP.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index

[SPAM] [PATCH 3/3] drm: kill agp indirection mess

2010-04-14 Thread Daniel Vetter
There's no point in jumping through two indirections. So kill one and call the kernels agp functions directly. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_agpsupport.c | 40 +++-- drivers/gpu/drm/drm_memory.c | 12 ++ include/drm/d

[SPAM] [PATCH 0/3] clean up drm agp

2010-04-14 Thread Daniel Vetter
next on it (due to my make-gem-embeddable work). Tested on my agp rv570 and my i945 with no ill effects. Please review and merge. Thanks, Daniel Daniel Vetter (3): drm: kill drm_agp_chipset_flush drm: drop return value of drm_free_agp drm: kill agp indirection mess drivers/gpu/drm/drm_ag

[SPAM] Re: [PATCH 0/6] make gem_object embedable and convert i915 driver

2010-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2010 at 10:51:20AM -0700, Eric Anholt wrote: > On Fri, 9 Apr 2010 21:05:03 +0200, Daniel Vetter > wrote: > > Daniel Vetter (6): > > drm: extract drm_gem_object_init > > drm: free core gem object from driver callbacks > > drm/i915: introduce i

[SPAM] Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?

2010-04-12 Thread Daniel Vetter
ritecount: -1 > > [ 1878.986496] iint_free: opencount: -1 > > [ 1878.993205] ehci_hcd :00:1d.7: PCI INT A disabled > > [ 1879.649836] PM: suspend of devices complete after 719.812 msecs > > [ 1879.676555] PM: late suspend of devices complete after 26.714 msecs > > [

[PATCH 4/6] drm/i915: embed the gem object into drm_i915_gem_object

2010-04-09 Thread Daniel Vetter
Just embed it and adjust the pointers, No other changes (that's for later patches). Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i915_gem.c | 58 +++--- 2 files changed, 30 insertions(+), 29 deletions(-)

[PATCH 0/6] make gem_object embedable and convert i915 driver

2010-04-09 Thread Daniel Vetter
Comments on the patches and my future plans highly welcome. Yours, Daniel Daniel Vetter (6): drm: extract drm_gem_object_init drm: free core gem object from driver callbacks drm/i915: introduce i915_gem_alloc_object drm/i915: embed the gem object into drm_i915_gem_object drm/i915: don't

[PATCH 5/6] drm/i915: don't use ->driver_private anymore

2010-04-09 Thread Daniel Vetter
Thanks to the to_intel_bo helper, this change is rather trivial. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |2 +- drivers/gpu/drm/i915/i915_gem.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu

[PATCH 2/6] drm: free core gem object from driver callbacks

2010-04-09 Thread Daniel Vetter
When drivers embed the core gem object into their own structures, they'll have to do this. Temporarily this results in an ugly kfree(gem_obj); in every gem driver. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_gem.c | 10 +++--- drivers/gpu/drm/i915/i915_

[PATCH 6/6] drm/i915: drop pointer to drm_gem_object

2010-04-09 Thread Daniel Vetter
Luckily the change is quite a little bit less invasive than I've feared. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_debugfs.c | 15 +++ drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/i915_gem.c | 21 ++--- driver

[PATCH 3/6] drm/i915: introduce i915_gem_alloc_object

2010-04-09 Thread Daniel Vetter
Just preparation, no functional change. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |2 ++ drivers/gpu/drm/i915/i915_gem.c | 12 +--- drivers/gpu/drm/i915/intel_display.c |2 +- drivers/gpu/drm/i915/intel_fb.c |2 +- drivers/gpu/drm/i915

[PATCH 1/6] drm: extract drm_gem_object_init

2010-04-09 Thread Daniel Vetter
This function can be used by drivers who allocate the drm gem object on their own. No functional change in here, just preparation. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_gem.c | 39 +-- include/drm/drmP.h|2 ++ 2 files changed, 31

Re: regression in 2.6.32-rc1 [KMS, I915] git-bisected

2010-03-14 Thread Daniel Vetter
for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > -- > ___ > Dri-devel mailing list > Dri-devel@lists.sourceforge.net >

Re: [PATCH 0/5] clean up radeon_asic.h v2

2010-03-12 Thread Daniel Vetter
serve as a warning sign that there's likely a layering violation ahead. After all, generic code should not muck around in the asic private stuff. Unconditionally including radeon_asic.h therefore runs counter to the bigger idea behind my patches. Cheers, Daniel -- Dan

[PATCH 2/5] drm/radeon: move asic structs to radeon_asic.c

2010-03-11 Thread Daniel Vetter
With these static structs gone, radeon_asic.h is a real header file and can be used as such. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_asic.c | 487 + drivers/gpu/drm/radeon/radeon_asic.h | 489 -- 2 files

[PATCH 1/5] drm/radeon: create radeon_asic.c

2010-03-11 Thread Daniel Vetter
And move asic init plus a few related functions from radeon_device.c to it. This file will hold all the asic structures in the future, but atm they're still stuck in radeon_asic.h. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/Makefile|2 +- drivers/gpu/drm/radeon/rad

[PATCH 5/5] drm/radeon: collect r100 asic related declarations in radeon_asic.h

2010-03-11 Thread Daniel Vetter
This just an example to show what radeon_asic.h might be good for. Before Jerome kills it ;) Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon.h | 47 -- drivers/gpu/drm/radeon/radeon_asic.h | 52 +++-- 2 files

[PATCH 0/5] clean up radeon_asic.h v2

2010-03-11 Thread Daniel Vetter
is is just an example to convince Jerome that radeon_asic.h might not be totally useless ;) Again, comments higly welcome. Yours, Daniel Daniel Vetter (5): drm/radeon: create radeon_asic.c drm/radeon: move asic structs to radeon_asic.c drm/radeon: unconfuse return value of radeon

[PATCH 3/5] drm/radeon: unconfuse return value of radeon_asic->clear_surface_reg

2010-03-11 Thread Daniel Vetter
No one cares about it, so set it to void. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon.h |2 +- drivers/gpu/drm/radeon/radeon_asic.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon

[PATCH 4/5] drm/radeon: include radeon_asic.h in the asic specific files

2010-03-11 Thread Daniel Vetter
In essence this creates a home for all asic specific declarations in radeon_asic.h Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/evergreen.c |1 + drivers/gpu/drm/radeon/r100.c |1 + drivers/gpu/drm/radeon/r200.c |1 + drivers/gpu/drm/radeon/r300.c |1

Re: [PATCH 00/14] cleanup radeon_asic.h

2010-03-11 Thread Daniel Vetter
s to diverge by accident. Well, this is exactly what I'm trying to fix here. atm radeon_asic.h contains static struct definitions (i.e. should be a C file) and is therefore included only exactly _once_. And contains tons of declarations for the functions it uses. Which are actually in one case n

Re: [PATCH 00/14] cleanup radeon_asic.h

2010-03-11 Thread Daniel Vetter
Ok, convinced. I'll respin the patch series along your idea (creating radeon_asic.c) and resend. Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- Download Intel® Parallel Studio Eval Try

Re: [PATCH 00/14] cleanup radeon_asic.h

2010-03-11 Thread Daniel Vetter
On Thu, Mar 11, 2010 at 04:46:01PM +0100, Jerome Glisse wrote: > On Thu, Mar 11, 2010 at 02:06:02PM +0100, Daniel Vetter wrote: > > Hi all, > > > > This patch pile moves the "static struct radeon_asic " definitions > > form radeon_asic.h into the asic-spec

Re: [PATCH 00/14] cleanup radeon_asic.h

2010-03-11 Thread Daniel Vetter
is makes code-reading easier. Of course, as someone who has just started to look at the radeon drm, I'm biased ;) - there was no .c file around where they'd fit. Creating a new radeon_asic.c file would be another option of course. If you think that's much better, I could respin

[PATCH 05/14] drm/radoen: move rs400 asic struct to rs400.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_asic.h | 38 +- drivers/gpu/drm/radeon/rs400.c | 72 ++ 2 files changed, 73 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_asic.h

[PATCH 04/14] drm/radeon: move r420 asic struct to r420.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/r420.c| 75 ++ drivers/gpu/drm/radeon/radeon_asic.h | 39 +- 2 files changed, 77 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/radeon/r420.c b

[PATCH 08/14] drm/radoen: move rv515 asic struct to rv515.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_asic.h | 38 +- drivers/gpu/drm/radeon/rv515.c | 72 ++ 2 files changed, 73 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_asic.h

[PATCH 12/14] drm/radoen: move evergreen asic struct to evergreen.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/evergreen.c | 43 ++ drivers/gpu/drm/radeon/radeon_asic.h | 35 +-- 2 files changed, 44 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH 03/14] drm/radeon: move r300 asic structs to r300.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/r300.c| 105 ++ drivers/gpu/drm/radeon/radeon_asic.h | 76 + 2 files changed, 107 insertions(+), 74 deletions(-) diff --git a/drivers/gpu/drm/radeon/r300.c

[PATCH 06/14] drm/radoen: move rs600 asic struct to rs600.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_asic.h | 39 + drivers/gpu/drm/radeon/rs600.c | 63 ++ 2 files changed, 64 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH 11/14] drm/radoen: move rv770 asic struct to rv770.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_asic.h | 37 +--- drivers/gpu/drm/radeon/rv770.c | 65 ++ 2 files changed, 66 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_asic.h

[PATCH 14/14] drm/radeon: include radeon_asic.h in .c

2010-03-11 Thread Daniel Vetter
And kill the temporary function declarations. Also drop a few unnecessary forward declarations. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/evergreen.c | 12 +- drivers/gpu/drm/radeon/r100.c|1 + drivers/gpu/drm/radeon/r200.c| 35

[PATCH 00/14] cleanup radeon_asic.h

2010-03-11 Thread Daniel Vetter
70. Comments higly welcome. Yours, Daniel Daniel Vetter (14): drm/radoen: move r100 asic struct to r100.c drm/radoen: move r200 asic struct to r200.c drm/radeon: move r300 asic structs to r300.c drm/radeon: move r420 asic struct to r420.c drm/radoen: move rs400 asic struct to rs400.c drm

[PATCH 10/14] drm/radoen: move r600 asic struct to r600.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/r600.c| 43 ++ drivers/gpu/drm/radeon/radeon_asic.h | 37 + 2 files changed, 44 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600

[PATCH 01/14] drm/radoen: move r100 asic struct to r100.c

2010-03-11 Thread Daniel Vetter
.c To accomplish this, the declarations for a few shared functions had to be moved from radeon_asic.h to radeon.h. They'll move back when this cleanup is complete. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/r100.c| 38 drivers/gpu/drm/r

[PATCH 07/14] drm/radoen: move rs690 asic struct to rs690.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_asic.h | 38 +- drivers/gpu/drm/radeon/rs690.c | 72 ++ 2 files changed, 73 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_asic.h

[PATCH 13/14] drm/radoen: unconfuse return value of radeon_asic->clear_surface_reg

2010-03-11 Thread Daniel Vetter
No one cares about it, so set it to void. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon.h |2 +- drivers/gpu/drm/radeon/radeon_asic.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon

[PATCH 09/14] drm/radoen: move r520 asic struct to r520.c

2010-03-11 Thread Daniel Vetter
Like for r200. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/r520.c| 77 ++ drivers/gpu/drm/radeon/radeon_asic.h | 40 +- 2 files changed, 79 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/radeon/r520.c b

[PATCH 02/14] drm/radoen: move r200 asic struct to r200.c

2010-03-11 Thread Daniel Vetter
Like for the r100. Because radeon_asic.h is not yet usable as a header file, I had to copy a few shared function declarations into r200.c. Yes, this is ugly but not actually worse than current state. And it'll all be gone when this header untangling is done. Signed-off-by: Daniel V

Re: [patch] i915: fix small leak on error path

2010-03-06 Thread Daniel Vetter
Oh, dang. Thanks for catching this. Eric, please merge. Cc: sta...@kernel.org (for .33) Reviewed-by: Daniel Vetter On Sat, Mar 06, 2010 at 02:05:39PM +0300, Dan Carpenter wrote: > We should free "params" before returning. > > Signed-off-by: Dan Carpenter > > diff --g

Re: [PATCH 2/2] Use drm_gem_object_[handle_]unreference_unlocked where possible

2010-02-09 Thread Daniel Vetter
> kfree(params); Just move the drm_gem_object_unreference before the mutex_unlock calls, make more sense that way, IMHO. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- The Planet:

Re: [PATCH 1/2] drm: introduce drm_gem_object_[handle_]unreference_unlocked

2010-02-09 Thread Daniel Vetter
d calls the new > ->gem_free_object_unlocked entry point if available, and > otherwise just takes struct_mutex and just calls ->gem_free_object Why not add a BUG_ON(!mutex_is_locked(&dev->struct_mutex)) to drm_gem_object_unreference to catch wrong api by occasional drm hackers like me? -

Re: [BISECTED] drm: random hang since 620f378 "drm: prune modes when ..."

2009-12-13 Thread Daniel Vetter
ulmck.livejournal.com/14639.html Happy Hunting, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- Return on Information: Google Enterprise Search pays you back Get the facts. ht

Re: [Intel-gfx] [PATCH] drm/i915: overlay: kill one more unnecessary uninterruptible sleep

2009-10-13 Thread Daniel Vetter
On Thu, Oct 08, 2009 at 10:11:40AM -0700, Eric Anholt wrote: > On Sun, 2009-10-04 at 15:00 +0200, Daniel Vetter wrote: > > I've simply overlooked one case in the conversion to interruptible > > sleeps. Rectify this. > > > > Also delete a leftover debug printk.

[PATCH] drm/i915: overlay: kill one more unnecessary uninterruptible sleep

2009-10-04 Thread Daniel Vetter
I've simply overlooked one case in the conversion to interruptible sleeps. Rectify this. Also delete a leftover debug printk. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_overlay.c | 17 +++-- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/dr

Re: [Intel-gfx] [PATCH 0/8] drmmode overlay support v3

2009-10-04 Thread Daniel Vetter
On Fri, Oct 02, 2009 at 02:38:46PM -0700, Eric Anholt wrote: > On Tue, 2009-09-15 at 22:57 +0200, Daniel Vetter wrote: > OK, I've finally pulled this for -next, with a bit of hand resolving of > conflicts. I debated, because of the somewhat unusual series of adding > the ring s

[PATCH 5/8] [drm/i915] fully switch off overlay when not in use

2009-09-15 Thread Daniel Vetter
Now that the cache flushing of the memory based overlay regs works, we can safely switch off the overlay. Beforehand it was only disabled (like in userspace). Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_overlay.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff

[PATCH 2/8] [drm/i915]: add i915_lp_ring_sync helper

2009-09-15 Thread Daniel Vetter
. Also replace a magic 0 with the symbolic constant (and kill the then superflous comment) while I was looking at the code. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i915_gem.c | 51 +++--- include/drm

[PATCH 6/8] [drm/i915] implement fastpath for overlay flip waiting

2009-09-15 Thread Daniel Vetter
As long as the gpu can keep up, neither the cpu (waiting for gpu) nore the gpu (waiting for vblank to do an overlay flip) stalls. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |3 ++ drivers/gpu/drm/i915/i915_gem.c |4 +- drivers/gpu/drm/i915/intel_drv.h

[PATCH 8/8] [drm/i915] kill i915_lp_ring_sync

2009-09-15 Thread Daniel Vetter
It's not needed anymore. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/i915_gem.c | 18 -- 2 files changed, 0 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h

[PATCH 3/8] [drm/i915]: kill superflous IS_I855 macro

2009-09-15 Thread Daniel Vetter
It is identical to I85X. Use that one instead. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/intel_display.c |4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915

[PATCH 1/8] [drm]: make drm_mode_object_find typesafe

2009-09-15 Thread Daniel Vetter
I've wasted half a day hunting a bug that could easily be spotted by gcc. Prevent this from reoccurring. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_crtc.c |3 ++- include/drm/drm_crtc.h |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gp

[PATCH 7/8] [drm/i915] implement interruptible sleeps in the overlay code

2009-09-15 Thread Daniel Vetter
's just an unkillable X in addition to a black screen. BUG() about it and explain in the code. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 17 +++- drivers/gpu/drm/i915/intel_drv.h |9 ++- drivers/gpu/drm/i915/intel_overlay.c | 167 +++-

[PATCH 4/8] [drm/i915] implement drmmode overlay support v4

2009-09-15 Thread Daniel Vetter
e...@gmail.com (on a 865G) Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_dma.c |7 + drivers/gpu/drm/i915/i915_drv.h |4 + drivers/gpu/drm/i915/i915_reg.h |5 + drivers/gpu/drm/i915/intel_display.c | 26 +- drivers

[PATCH 0/8] drmmode overlay support v3

2009-09-15 Thread Daniel Vetter
Hi all, Latest version of my overlay kms work. I've added the new stuff as separated patches for easier testing in case something blows up. Please review. Thanks, Daniel Daniel Vetter (8): [drm]: make drm_mode_object_find typesafe [drm/i915]: add i915_lp_ring_sync helper [drm/i915]:

Re: [PATCH 2/5] [drm/i915]: require_pipe_a helper functions

2009-09-14 Thread Daniel Vetter
he overlay. Looks like I've missed yet another cache flush. I've hacked up a fix which seems to work, here, but I'd like to give it some more testing. Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mo

[PATCH 3/5] [drm/i915]: add i915_lp_ring_sync helper

2009-09-11 Thread Daniel Vetter
. Also replace a magic 0 with the symbolic constant (and kill the then superflous comment) while I was looking at the code. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i915_gem.c | 51 +++--- include/drm

[PATCH 4/5] [drm/i915]: kill superflous IS_I855 macro

2009-09-11 Thread Daniel Vetter
It is identical to I85X. Use that one instead. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/intel_display.c |4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915

[PATCH 5/5] [drm/i915] implement drmmode overlay support v3

2009-09-11 Thread Daniel Vetter
my side. This fixes fullscreen playback. Changes since v2: - add underrun detection as spec'ed for i965. - flush caches properly, fixing visual corruptions. Tested-By: diego.abele...@gmail.com (on a 865G) Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/Makefile|1 + driver

[PATCH 0/5] kms overlay support v2

2009-09-11 Thread Daniel Vetter
I've tried to summarize the outcomes of various discussion in the changelog. Please review and consider for .32. Thanks, Daniel Daniel Vetter (5): [drm]: make drm_mode_object_find typesafe [drm/i915]: require_pipe_a helper functions [drm/i915]: add i915_lp_ring_sync helper [drm/i9

[PATCH 2/5] [drm/i915]: require_pipe_a helper functions

2009-09-11 Thread Daniel Vetter
These will be used to ensure that the clock of pipe a is running when the overlay is switched on. Programming logic more or less directly ported over from userspace. Also export the already existing helper function drm_encoder_crtc_ok. Signed-off-by: Daniel Vetter --- drivers/gpu/drm

[PATCH 1/5] [drm]: make drm_mode_object_find typesafe

2009-09-11 Thread Daniel Vetter
I've wasted half a day hunting a bug that could easily be spotted by gcc. Prevent this from reoccurring. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_crtc.c |3 ++- include/drm/drm_crtc.h |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gp

Re: [PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-09-02 Thread Daniel Vetter
ng DMA/whater that's efficient). > > ... > >Fine. I'll just push this then as a device ioctl to bring usable video on > >8xx to kms. > > OK, > Thanks, > > Thomas Thanks, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

Re: [PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-09-01 Thread Daniel Vetter
some nice support for executing untrusted batchbuffers, so no monsterous checker/relocater/munger already present. -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: 079 365 57 48 -- Let Crystal Reports handle the reporting

Re: [PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-09-01 Thread Daniel Vetter
is a delicate dance is needed, carefully sync with the crtc output state. So at least on intel, some overlay support on the kernel side is needed to at least prevent race conditions that may hang the chip. > Alex Yours, Daniel -- Daniel Vetter Mail: dan..

Re: [PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-09-01 Thread Daniel Vetter
er on gallium thing work we probably need to extend the DRI2 proto such that X can work as an arbiter for the overlay. > > ... > >btw: I don't think we can sketch out a common interface before we have a > >second > >implementation to go pattern hunting. > OK. We&#

Re: [PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-08-31 Thread Daniel Vetter
On Mon, Aug 31, 2009 at 02:15:15PM +0200, Stephane Marchesin wrote: > 2009/8/31 Thomas Hellström : > > Daniel Vetter wrote: > > > > ... > >> In conclusion I don't think a common ioctl is worth it. But sharing some > >> code and infrastructure

Re: [PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-08-31 Thread Daniel Vetter
ther chipset. But I don't really count on that, because at least radeon has textured video for all it's chips. > /Thomas Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- Let

[PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-08-31 Thread Daniel Vetter
let's leave it at this for the moment. I left some dummy functions as infrastructure. Changes since v1: - fix off-by-one misconception on my side. This fixes fullscreen playback. Tested-By: diego.abele...@gmail.com (on a 865G) Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/Mak

[PATCH 5/6] [drm/i915]: add i915_lp_ring_sync helper

2009-08-11 Thread Daniel Vetter
. Also replace a magic 0 with the symbolic constant (and kill the then superflous comment) while I was looking at the code. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i915_gem.c | 51 +++--- include/drm

[PATCH 2/6] [drm/i915] remove open-coded drm_mode_object_find

2009-08-11 Thread Daniel Vetter
And clean up a small whitespace goof-up in the same function, while I was looking at it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 20 1 files changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b

[PATCH 3/6] [drm/i915]: modeset: always set intel_crtc->dpms_mode

2009-08-11 Thread Daniel Vetter
... by moving the assignment up. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index bb59356..818c703 100644 --- a

[PATCH 0/6] kernel modsetting support for intel overlay

2009-08-11 Thread Daniel Vetter
ger than 1024. - patches 1, 4, 5 change drm-generic code. - the ioctl interface is intel-only. Anyone (radeon devs?) working on another overlay implementation/interested in sharing code? Yours, Daniel PS: I'll post the ddx part shortly to intel-gfx. Daniel Vetter (6): [drm]: make drm_m

[PATCH 6/6] [drm/i915] implement drmmode overlay support

2009-08-11 Thread Daniel Vetter
ns as infrastructure. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_dma.c |7 + drivers/gpu/drm/i915/i915_drv.h |4 + drivers/gpu/drm/i915/i915_reg.h |5 + drivers/gpu/drm/i915/intel_display.c | 26 +- driver

[PATCH 1/6] [drm]: make drm_mode_object_find typesafe

2009-08-11 Thread Daniel Vetter
I've wasted half a day hunting a bug that could easily be spotted by gcc. Prevent this from reoccurring. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_crtc.c |3 ++- include/drm/drm_crtc.h |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gp

[PATCH 4/6] [drm/i915]: require_pipe_a helper functions

2009-08-11 Thread Daniel Vetter
These will be used to ensure that the clock of pipe a is running when the overlay is switched on. Programming logic more or less directly ported over from userspace. Also export the already existing helper function drm_encoder_crtc_ok. Signed-off-by: Daniel Vetter --- drivers/gpu/drm

[PATCH] radeon: Compat fix for latest kernels (> 2.6.29-rc2)

2009-03-02 Thread Daniel Vetter
I2C_HW_B_RADEON got deleted from include/linux/i2c-id.h in v2.6.29-rc2-15-g1745522. Signed-off-by: Daniel Vetter --- linux-core/radeon_reg.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/linux-core/radeon_reg.h b/linux-core/radeon_reg.h index 8698e86..434f271

Re: + drivers-gpu-drm-i915-intel_lvdsc-fix-locking-snafu.patch added to -mm tree

2009-02-04 Thread Daniel Vetter
ands. But kernel modesetting for the framebuffer console always works, so YMMV. -Daniel -- Daniel Vetter E-Mail: daniel.vet...@ffwll.ch Tel.: +41 (0)79 365 57 48 -- Create and Deploy Rich Internet Apps outside the browser wi

Re: + drivers-gpu-drm-i915-intel_lvdsc-fix-locking-snafu.patch added to -mm tree

2009-02-03 Thread Daniel Vetter
ton wrote: > > > (cc's added) > > > > On Sat, 31 Jan 2009 16:25:08 +0100 Daniel Vetter wrote: > > > > > On Thu, Jan 29, 2009 at 01:48:25PM -0800, Andrew Morton wrote: > > > > On Thu, 29 Jan 2009 13:24:17 -0800 > > > > Jesse Barnes

Re: + drivers-gpu-drm-i915-intel_lvdsc-fix-locking-snafu.patch added to -mm tree

2009-02-03 Thread Daniel Vetter
ion? Nope. Like the previous issue it only happens when I run-time enable kernel modesetting (with # modprobe i915 modeset=1), which is not the default. I'm gonna open a new bz entry with all the details (and all