[FFmpeg-devel] [PATCH v8] lavf: palettized QuickTime video in Matroska

Forgot to remove an av_free(). Patch explanation follows: Palettized QuickTime video in Matroska has hitherto not been recognized whatsoever, and the "palette" used has been completely random. The patch for matroskadec.c fixes this issue by adding a palette side data packet in

[FFmpeg-devel] [PATCH] avcodec/on2avc: Fix stability issues with scale_tab generation

From: Michael Niedermayer This also simplifies the code the resulting values are binary identical to what pow(10, i/10.0) produces --- libavcodec/on2avc.c | 37 - 1 file changed, 4 insertions(+), 33 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

On Sat, Dec 26, 2015 at 06:37:31PM -0800, Ganesh Ajjanagadde wrote: > On Sat, Dec 26, 2015 at 6:19 PM, Michael Niedermayer > wrote: > > On Sat, Dec 26, 2015 at 05:23:55PM -0800, Ganesh Ajjanagadde wrote: > >> On Sat, Dec 26, 2015 at 4:20 PM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH v8] lavf: palettized QuickTime video in Matroska

On Sun, Dec 27, 2015 at 11:44 AM, Mats Peterson wrote: > > Since the ff_get_qtpalette() function has to parse the video sample > description in two different ways, i.e. 1) by using the in-memory > private data when called from matroskadec.c, and 2) by reading

Re: [FFmpeg-devel] [PATCH v8] lavf: palettized QuickTime video in Matroska

On 12/27/2015 12:10 PM, Hendrik Leppkes wrote: On Sun, Dec 27, 2015 at 11:44 AM, Mats Peterson wrote: Since the ff_get_qtpalette() function has to parse the video sample description in two different ways, i.e. 1) by using the in-memory private data when

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

On 12/27/2015 10:30 AM, Hendrik Leppkes wrote: On Sun, Dec 27, 2015 at 4:42 AM, Mats Peterson wrote: On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

On 12/27/2015 10:38 AM, Mats Peterson wrote: On 12/27/2015 10:30 AM, Hendrik Leppkes wrote: On Sun, Dec 27, 2015 at 4:42 AM, Mats Peterson wrote: On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

Hi, On Thu, Dec 24, 2015 at 1:32 PM, Ganesh Ajjanagadde wrote: > In the standard library, these are functions. We should match it; there > is no reason for these to be macros. > > While at it, add some trivial comments for readability and correct an > incorrect (at

Re: [FFmpeg-devel] [PATCH] avcodec/on2avc: Fix stability issues with scale_tab generation

On Sun, Dec 27, 2015 at 07:40:53AM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Dec 27, 2015 at 6:02 AM, Michael Niedermayer > wrote: > > > +for (i = 0; i < 20; i++) > > +c->scale_tab[i] = ceil(ff_exp10(i * 0.1) * 16 - 0.01) / 32; > > for (; i < 128; i++)

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

On Sun, Dec 27, 2015 at 5:38 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 24, 2015 at 1:32 PM, Ganesh Ajjanagadde > wrote: >> >> In the standard library, these are functions. We should match it; there >> is no reason for these to be macros. >> >>

Re: [FFmpeg-devel] [PATCH] avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

On Sun, Dec 27, 2015 at 7:32 PM, Jan Ehrhardt wrote: > Andreas Cadhalpun in gmane.comp.video.ffmpeg.devel (Tue, 27 Oct 2015 > 22:52:27 +0100): >>> On Tue, Oct 27, 2015 at 9:58 PM, Andreas Cadhalpun diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

On 27.12.2015 20:10, Hendrik Leppkes wrote: > Invalid timebases have a zero numerator, not denominator. A timebase with zero numerator is probably invalid, but a timebase with zero denominator is not even well defined. So this comment doesn't seem quite right. > Fixes a integer divison by zero.

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

On 27.12.2015 20:43, Hendrik Leppkes wrote: > On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun > wrote: >> On 27.12.2015 20:10, Hendrik Leppkes wrote: >>> Invalid timebases have a zero numerator, not denominator. >> >> A timebase with zero numerator is probably

Re: [FFmpeg-devel] [PATCH] avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

Andreas Cadhalpun in gmane.comp.video.ffmpeg.devel (Tue, 27 Oct 2015 22:52:27 +0100): >> On Tue, Oct 27, 2015 at 9:58 PM, Andreas Cadhalpun >>> diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v >>> index e90aef7..a00a309 100644 >>> --- a/libavformat/libavformat.v >>> +++

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun wrote: > On 27.12.2015 20:10, Hendrik Leppkes wrote: >> Invalid timebases have a zero numerator, not denominator. > > A timebase with zero numerator is probably invalid, but a timebase > with zero denominator is

[FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

Removed the 'stsd' variable from ff_get_qtpalette() in qtpalette.c. Updated the doxy documentation for ff_get_qtpalette() accordingly. Description of patch follows: Palettized QuickTime video in Matroska has hitherto not been recognized whatsoever, and the "palette" used has been completely

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

On Sun, Dec 27, 2015 at 4:31 AM, Ronald S. Bultje wrote: > Hi, > > On Sat, Dec 26, 2015 at 8:23 PM, Ganesh Ajjanagadde > wrote: >> >> On Sat, Dec 26, 2015 at 4:20 PM, Ganesh Ajjanagadde >> wrote: >> > On Sat, Dec 26, 2015 at 4:08 PM, James

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

On Sun, Dec 27, 2015 at 08:00:52AM -0800, Ganesh Ajjanagadde wrote: > On Sun, Dec 27, 2015 at 4:31 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Sat, Dec 26, 2015 at 8:23 PM, Ganesh Ajjanagadde > > wrote: > >> > >> On Sat, Dec 26, 2015 at 4:20 PM, Ganesh

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

On Sun, Dec 27, 2015 at 8:14 AM, Michael Niedermayer wrote: > On Sun, Dec 27, 2015 at 08:00:52AM -0800, Ganesh Ajjanagadde wrote: >> On Sun, Dec 27, 2015 at 4:31 AM, Ronald S. Bultje wrote: >> > Hi, >> > >> > On Sat, Dec 26, 2015 at 8:23 PM, Ganesh

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hls: Remember to free HLSContext::headers

On Sun, Dec 27, 2015 at 12:21:44PM +, Joel Holdsworth wrote: > --- > libavformat/hls.c | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

Hi, On Sun, Dec 27, 2015 at 11:32 AM, Ganesh Ajjanagadde wrote: > I guess you and Ronald are unhappy with what I did to fix the broken > change. Overall, seems like simple miscommunication, and everything is > back to normal here. Back-to-normal sounds about right :) Ronald

Re: [FFmpeg-devel] [PATCH 1/3] avformat/http: Added http_proxy option

On Sun, Dec 27, 2015 at 12:21:43PM +, Joel Holdsworth wrote: > --- > libavformat/http.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you

Re: [FFmpeg-devel] [PATCH] avcodec/on2avc: Fix stability issues with scale_tab generation

On Sun, Dec 27, 2015 at 7:44 AM, Michael Niedermayer wrote: > On Sun, Dec 27, 2015 at 07:40:53AM -0500, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Dec 27, 2015 at 6:02 AM, Michael Niedermayer >> wrote: >> >> > +for (i = 0; i < 20; i++) >> > +

[FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

Invalid timebases have a zero numerator, not denominator. Fixes a integer divison by zero. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 19f3f0a..33295ed 100644 --- a/libavcodec/utils.c +++

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: Added http_proxy support

On Sun, Dec 27, 2015 at 12:21:45PM +, Joel Holdsworth wrote: > --- > libavformat/hls.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

On Sun, Dec 27, 2015 at 9:03 PM, Andreas Cadhalpun wrote: > On 27.12.2015 20:43, Hendrik Leppkes wrote: >> On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun >> wrote: >>> On 27.12.2015 20:10, Hendrik Leppkes wrote: Invalid

Re: [FFmpeg-devel] [PATCH] avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

On 27.12.2015 19:32, Jan Ehrhardt wrote: > Andreas Cadhalpun in gmane.comp.video.ffmpeg.devel (Tue, 27 Oct 2015 > 22:52:27 +0100): >>> On Tue, Oct 27, 2015 at 9:58 PM, Andreas Cadhalpun diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v index e90aef7..a00a309 100644

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

On 27.12.2015 21:13, Hendrik Leppkes wrote: > On Sun, Dec 27, 2015 at 9:03 PM, Andreas Cadhalpun > wrote: >> On 27.12.2015 20:43, Hendrik Leppkes wrote: >>> On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun >>> wrote: On

[FFmpeg-devel] ffplay: insertion point of the auto rotation filter - Github ticket #141

Hi Michael, The patch you committed seems to break the cropping to even width / height as required by SDL overlay code. Also there can be a use case for inserting the auto rotation filter after the user provided filter chain as well. (e,g, deinterlacing). I don't think we can make everyone

[FFmpeg-devel] [PATCH 1/2] lavfi/af_anequalizer: replace pow(10, x) by ff_exp10(x)

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_anequalizer.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_anequalizer.c b/libavfilter/af_anequalizer.c index e45c108..d7b5b6c 100644 ---

[FFmpeg-devel] [PATCH 2/2] lavfi/af_anequalizer: replace pow(x, -2) by 1/(x*x)

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_anequalizer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_anequalizer.c b/libavfilter/af_anequalizer.c index d7b5b6c..649c0b9 100644 --- a/libavfilter/af_anequalizer.c +++

Re: [FFmpeg-devel] [PATCH]ffserver: Cast time_t value when using it in a format string.

Looks good. On 12/22/2015 12:40 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch should fix ticket #5103. > > Please comment, Carl Eugen > > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 02:56 AM, Mats Peterson wrote: On 12/28/2015 01:24 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: +memcpy(st->codec->extradata, matroska->palette, +AVPALETTE_SIZE); As said, please remove this, you must not fix MPlayer issues in FFmpeg.

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

Bumping up this thread (latest patch attached) Happy holidays ! Eran 0001-mov-support-cenc-common-encryption.patch Description: 0001-mov-support-cenc-common-encryption.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] Write correct creation time of new ASF

--- libavformat/asfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfenc.c b/libavformat/asfenc.c index 32b726b..9bb439a 100644 --- a/libavformat/asfenc.c +++ b/libavformat/asfenc.c @@ -428,7 +428,7 @@ static int asf_write_header1(AVFormatContext *s, int64_t

[FFmpeg-devel] [PATCH 2/2] x86/vf_stereo3d: make ff_anaglyph_sse4 work on x86_32

Signed-off-by: James Almer --- libavfilter/x86/vf_stereo3d.asm| 47 +++--- libavfilter/x86/vf_stereo3d_init.c | 2 +- 2 files changed, 45 insertions(+), 4 deletions(-) diff --git a/libavfilter/x86/vf_stereo3d.asm

[FFmpeg-devel] [PATCH 1/2] x86/vf_stereo3d: optimize register usage

Signed-off-by: James Almer --- libavfilter/x86/vf_stereo3d.asm | 164 +--- 1 file changed, 86 insertions(+), 78 deletions(-) diff --git a/libavfilter/x86/vf_stereo3d.asm b/libavfilter/x86/vf_stereo3d.asm index 94a0473..29a8c56 100644 ---

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

Michael Niedermayer niedermayer.cc> writes: > Patch splited in move and matroska part > i removed this memcpy() for now from what i > commited as there is clearly no consenus on it I would really have appreciated a real review: Apart from the unrelated audio fix a significant part of the

[FFmpeg-devel] [PATCH] lavf/matroskadec.c: Copy QuickTime palette to extradata

I still insist on copying the QuickTime palette to extradata in matroskadec.c, since it's currently needed for MPlayer to use the correct palette. As I have explained so many times before, MPlayer, for some inexplicable reason, currently adds *another* palette side data packet *after* the one

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 04:12 AM, Mats Peterson wrote: On 12/28/2015 04:10 AM, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: Patch splited in move and matroska part i removed this memcpy() for now from what i commited as there is clearly no consenus on it I would really have

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 04:10 AM, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: Patch splited in move and matroska part i removed this memcpy() for now from what i commited as there is clearly no consenus on it I would really have appreciated a real review: Apart from the

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 02:58 AM, Mats Peterson wrote: On 12/28/2015 02:56 AM, Mats Peterson wrote: On 12/28/2015 01:24 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: +memcpy(st->codec->extradata, matroska->palette, +AVPALETTE_SIZE); As said, please remove

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 03:21 AM, Mats Peterson wrote: On 12/28/2015 03:16 AM, Michael Niedermayer wrote: On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: +memcpy(st->codec->extradata, matroska->palette, +AVPALETTE_SIZE);

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 01:24 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: +memcpy(st->codec->extradata, matroska->palette, +AVPALETTE_SIZE); As said, please remove this, you must not fix MPlayer issues in FFmpeg. (The issue in MPlayer does not exist but that

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote: > Mats Peterson ffmpeg.org> writes: > > > +memcpy(st->codec->extradata, matroska->palette, > > +AVPALETTE_SIZE); > > As said, please remove this, > you must not fix MPlayer > issues in FFmpeg. this is

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 03:27 AM, Mats Peterson wrote: On 12/28/2015 03:21 AM, Mats Peterson wrote: On 12/28/2015 03:16 AM, Michael Niedermayer wrote: On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: +memcpy(st->codec->extradata,

Re: [FFmpeg-devel] [PATCH] Write correct creation time of new ASF

Thanks for the patch. Le septidi 7 nivôse, an CCXXIV, Vadim Belov a écrit : > -file_time = 0; > +file_time = time(NULL); Exposing the system time unconditionally has been rejected in the past due to security considerations. Regards, -- Nicolas George signature.asc Description:

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

Mats Peterson ffmpeg.org> writes: > +memcpy(st->codec->extradata, matroska->palette, > +AVPALETTE_SIZE); As said, please remove this, you must not fix MPlayer issues in FFmpeg. (The issue in MPlayer does not exist but that doesn't matter on this mailing list.) Carl

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 03:16 AM, Michael Niedermayer wrote: On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: +memcpy(st->codec->extradata, matroska->palette, +AVPALETTE_SIZE); As said, please remove this, you must not

Re: [FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

On 12/28/2015 04:10 AM, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: Patch splited in move and matroska part i removed this memcpy() for now from what i commited as there is clearly no consenus on it I would really have appreciated a real review: Apart from the

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

On Thu, 24 Dec 2015 19:52:21 +0100 Hendrik Leppkes wrote: > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : > > > > In the standard library, these are functions. We should match it; there > > is no reason for these to be macros. > > > > While at