Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
Hi Goktug,
Being said that, rest assured, I wouldn't -1 for just not using it.
Good, good--sorry if I got a b
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
Hi Colin, the only approach in selecting classes is that these are what I'd
used so far, plus a few others.
F
Colin Alworth has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
What is the thinking for the remaining 10%-ish of widgets - all of the cell
widgets (except CellPanel), remaining
Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
The part that I'm not comfortable with is, you can exactly have the same
effect with the current state.
Yes yo
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
doesn't fit into current IsXXX because if it was you wouldn't need
IsWidget2 :)
My take is that it's just bec
Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
I thought "IsXXX" just meant "we really wanted to name this interface
just 'XXX', but that name was already take
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
I went ahead and removed HasStyle, as it was a distraction. I also added
more methods to IsElement.
--
To vie
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3231
to look at the new patch set (#8).
Change subject: Add interfaces for widgets.
..
Add interfaces for widgets
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 7:
Okay, I think this is ready for another cursory review--I'm still mulling
about how to do the javadocs.
Also,
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 7:
Replying to Goktug...
consistent naming convention throughout the SDKs
Agreed, of course. I see what you mean
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(9 comments)
File user/src/com/google/gwt/dom/client/HasSty
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3231
to look at the new patch set (#7).
Change subject: Add interfaces for widgets.
..
Add interfaces for widgets
Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(1 comment)
1. It is very important to use consistent naming convention throughout the
SDKs. IsXXX previously u
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(1 comment)
Hey guys, thanks for the comments. I'm out of town for a few days, but so
far they all make sense-
Colin Alworth has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(4 comments)
File user/src/com/google/gwt/dom/client/HasStyle.
Thomas Broyer has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(4 comments)
I've only looked at a few files.
File user/src/c
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3231
to look at the new patch set (#6).
Change subject: Add interfaces for widgets.
..
Add interfaces for widgets
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3231
to look at the new patch set (#5).
Change subject: Add interfaces for widgets.
..
Add interfaces for widgets
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3231
to look at the new patch set (#4).
Change subject: Add interfaces for widgets.
..
Add interfaces for widgets
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3231
to look at the new patch set (#3).
Change subject: Add interfaces for widgets.
..
Add interfaces for widgets
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3231
to look at the new patch set (#2).
Change subject: Add interfaces for widgets.
..
Add interfaces for widgets
Daniel Kurka has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 1:
(4 comments)
just a few nits so far
File user/src/com/google/g
22 matches
Mail list logo