Re: [ANNOUNCE] haproxy-2.4.11

2022-01-12 Thread Willy Tarreau
On Wed, Jan 12, 2022 at 10:53:05AM +0100, Tim Düsterhus wrote: > Willy, > > On 1/7/22 5:11 PM, Willy Tarreau wrote: > > Oh, and as discussed a few days ago, since nobody objected, I'll mark 1.7 > > end-of-life. There's not even a relevant fix for it in queue, let&#

Re: [PATCH] hash: add support for consistent (hashing) 2x algorithm

2022-01-12 Thread Willy Tarreau
Hi Davide, sorry for the long delay, but your initial message was sent the day before the release and just after the second one we got derailed by a number of pending issues then that got lost in the noise. Anyway. On Wed, Dec 01, 2021 at 04:49:53PM +0100, Davide Pucci wrote: > From d856de9813854

Re: [PATCH] CI: cache for OT libs

2022-01-12 Thread Willy Tarreau
Hi Ilya, On Thu, Jan 13, 2022 at 11:44:08AM +0500, ??? wrote: > Hello, > > I've figured out how to use CI caches. > if that will work for some time, I'll do the same for SSL libs. Ah, quite interesting, thank you. While I can't judge for the first part but I trust your tests on it, I'd

Re: [PATCH] CI: cache for OT libs

2022-01-13 Thread Willy Tarreau
On Thu, Jan 13, 2022 at 01:13:27PM +0500, ??? wrote: > ??, 13 ???. 2022 ?. ? 12:07, Willy Tarreau : > > > Hi Ilya, > > > > On Thu, Jan 13, 2022 at 11:44:08AM +0500, ??? wrote: > > > Hello, > > > > > > I've figured out how

Re: [EXTERNAL] [PATCH] BUILD/MINOR fix solaris build with clang

2022-01-17 Thread Willy TARREAU
On Thu, Jan 13, 2022 at 07:20:57PM +, David CARLIER wrote: > Hi, > > here a little patch for solaris based systems. Thanks David, now applied. By the way, just out of curiosity, what do you use nowadays to build on Solaris ? Willy

Re: [EXTERNAL] [PATCH] MEDIUM: pool monitor memory pressure on macOs

2022-01-17 Thread Willy TARREAU
Hi David, On Sat, Jan 08, 2022 at 07:30:24PM +, David CARLIER wrote: > Hi > > Here a proposal to monitor memory pressure level on macOs to then > trigger pools trimming when it is critical. > > Cheers. > > thanks. > > > From 6b93fc00168a4e6ff80609ceb64582fea8d96ca0 Mon Sep 17 00:00:00 200

Re: [EXTERNAL] [PATCH] BUILD/MINOR fix solaris build with clang

2022-01-17 Thread Willy TARREAU
On Mon, Jan 17, 2022 at 05:38:46PM +, David CARLIER wrote: > Mostly gcc 7.5 and clang 9 nowadays. Sorry I was not clear :-) I meant, do you build on an old Sun, in an x86 VM, with a real Solaris or an OpenSolaris (or some variant) etc. I used to keep my old Sun working for a while because SPA

Re: [PATCH] BUG/MEDIUM: server: avoid changing healthcheck ctx with set server ssl

2022-01-18 Thread Willy Tarreau
On Mon, Jan 17, 2022 at 07:46:24PM +0100, William Dauchy wrote: > Hello Christopher, > > On Wed, Jan 12, 2022 at 12:45 PM William Dauchy wrote: > > my approach was to say: > > - remove the implicit behavior > > - then work on the missing commands for the health checks > > Do you think we can con

Re: 2.0.26 breaks authentication

2022-01-18 Thread Willy Tarreau
On Tue, Jan 18, 2022 at 07:04:00PM +0100, Lukas Tribus wrote: > On Mon, 17 Jan 2022 at 19:37, wrote: > > > > Hi > > > > Configuration uses 'no option http-use-htx' in defaults because of case > > insensitivity. > > Statistics path haproxy?stats is behind simple username/password and > > both crede

Re: 2.0.26 breaks authentication

2022-01-18 Thread Willy Tarreau
On Wed, Jan 19, 2022 at 04:52:54AM +0100, Willy Tarreau wrote: > On Tue, Jan 18, 2022 at 07:04:00PM +0100, Lukas Tribus wrote: > > On Mon, 17 Jan 2022 at 19:37, wrote: > > > > > > Hi > > > > > > Configuration uses 'no option http-use-ht

Re: [PATCH] BUILD: refactor OpenTracing build script

2022-01-18 Thread Willy Tarreau
On Sat, Jan 15, 2022 at 02:33:12PM +0500, ??? wrote: > Hello, > > as we agreed to keep scripts/build-ot.sh. Let's reuse it in CI. Now merged, thanks Ilya! Willy

Re: [PATCH] BUG/MEDIUM: server: avoid changing healthcheck ctx with set server ssl

2022-01-19 Thread Willy Tarreau
On Wed, Jan 19, 2022 at 03:24:44PM +0100, William Lallemand wrote: > On Tue, Jan 18, 2022 at 12:07:21PM +0100, Willy Tarreau wrote: > > > > On Mon, Jan 17, 2022 at 07:46:24PM +0100, William Dauchy wrote: > > > Hello Christopher, > > > > > > On Wed, Jan

Re: 2.0.26 breaks authentication

2022-01-25 Thread Willy Tarreau
On Tue, Jan 25, 2022 at 10:51:55AM +, vk...@xvidservices.com wrote: > On 2022-01-19 06:36, Willy Tarreau wrote: > > After a few more tests I've now merged the patch and closed the bug. I > > might release 2.0.27 today as time permits unless we find other things > >

Re: [PATCH] CI: introduce caching for ssl libs (except BoringSSL, QUICTLS)

2022-01-25 Thread Willy Tarreau
On Sat, Jan 22, 2022 at 12:07:37AM +0500, ??? wrote: > Hello, > > this patch introduces github actions cache for SSL libs. > hope it will save couple of minutes. Merged, thanks Ilya! Willy

Re: [PATCH] BUILD/MEDIUM: debug haiku build fix

2022-01-25 Thread Willy Tarreau
Hi David, On Tue, Jan 25, 2022 at 10:40:57AM +, David CARLIER wrote: > From 575cdb49b8fa923bdd44fe08a7068681e38ffe71 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Tue, 25 Jan 2022 10:37:59 + > Subject: [PATCH] BUILD/MINOR: debug haiku build fix. > > O_ASYNC fcntl flag equivalent

Re: [PATCH] BUILD/MEDIUM: debug haiku build fix

2022-01-25 Thread Willy Tarreau
On Tue, Jan 25, 2022 at 06:08:51PM +0500, ??? wrote: > https://github.com/haproxy/haproxy/runs/4935746464?check_suite_focus=true OK it also breaks on cygwin, definitely not portable :-) It should be fixed now, I've added the required ifdef. Thank you both! Willy

[ANNOUNCE] haproxy-2.0.27

2022-01-26 Thread Willy Tarreau
variable in tlskeys_list_get_next() William Lallemand (4): MINOR: cli: "show version" displays the current process version BUG/MEDIUM: mworker/cli: crash when trying to access an old PID in prompt mode BUG/MINOR: cli: fix _getsocks with musl libc BUG/MEDIUM: mwor

Re: [PATCH 1/3] deviceatlas update new service addition

2022-01-27 Thread Willy Tarreau
Hi David, finally back to your patches. There are very minor things but I'm not going to modify them without your consent since they're signed-off. > From eae56a44d3bf51f8e92f66baef25f2a417f837ce Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 21 Jan 2022 20:46:40 + > Subject: [P

Re: [PATCH 2/3]: deviceatlas addon update

2022-01-27 Thread Willy Tarreau
On Fri, Jan 21, 2022 at 09:04:25PM +, David Carlier wrote: > Second patch of the patchset concerning the update of the addon itself. > From d541d8dfd8aa0290625b3824bd6b44d2861e997f Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 21 Jan 2022 20:51:20 + > Subject: [PATCH 2/3] ME

Re: [PATCH 3/3]: deviceatlas update doc and build changes.

2022-01-27 Thread Willy Tarreau
On Fri, Jan 21, 2022 at 09:05:18PM +, David Carlier wrote: > From e3f520ebd4f23fe42a1068ee2d9b42fd529241e8 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 21 Jan 2022 20:57:27 + > Subject: [PATCH 3/3] MEDIUM: deviceatlas doc and build update. "MEDIUM: da: doc and build for n

Re: Seeking for help about regression test

2022-01-27 Thread Willy Tarreau
Hi, On Thu, Jan 27, 2022 at 01:08:51PM +, ? ?? wrote: > Hi, > > We are a team from China that looking forward to use haproxy in newly > designed operating system and check if haproxy is running well on it, for > research using. From Github we can see many regression test examples, it is > det

Re: [PATCH 1/3] deviceatlas update new service addition

2022-01-27 Thread Willy Tarreau
On Thu, Jan 27, 2022 at 06:34:23PM +, David Carlier wrote: > Hi willy and thanks for the review. Indeed I forgot about the dummy part, > changes present in the last patch. Thank you. I had to swap the last two patches so that it always builds, but that's OK this way, so I've now merged it. Wi

Re: [PATCH] REGTESTS: Remove REQUIRE_VERSION=1.8 from all tests

2022-01-29 Thread Willy Tarreau
On Fri, Jan 28, 2022 at 06:09:20PM +0100, Tim Duesterhus wrote: > HAProxy 1.8 is the lowest supported version, thus this always matches. Applied, thanks Tim! Willy

Re: [PATCH] CI: Consistently use actions/checkout@v2

2022-01-29 Thread Willy Tarreau
On Fri, Jan 28, 2022 at 11:01:07PM +0500, ??? wrote: > Ack from me > > On Fri, Jan 28, 2022, 10:45 PM Tim Duesterhus wrote: > > > v2 is the current version of the checkout action and faster than v1. Applied as well, thank you both! Willy

Re: Per-client queue for rate limiting?

2022-01-30 Thread Willy Tarreau
On Sun, Jan 30, 2022 at 09:18:00AM +0100, Orlando Della Casa wrote: > I'd like to put a rate limit on incoming HTTP requests, but without sending > 429 errors. Instead, requests beyond the limit should be put into a queue > from which they are processed at a speed that respects the rate limit. It's

Re: Observing low test-suite coverage

2022-01-30 Thread Willy Tarreau
Hi Hugo, On Tue, Jan 25, 2022 at 12:13:16PM +, Hugo Lefeuvre wrote: > Hi! > > As part of research project, my colleagues and myself are measuring the > test-suite coverage of HAProxy using gcov. We found the coverage numbers to > be relatively low compared to other major cloud applications, c

[ANNOUNCE] haproxy-2.6-dev1

2022-02-01 Thread Willy Tarreau
: don't pop the lua stack when getting headers DOC: management: mark "set server ssl" as deprecated CLEANUP: mworker: simplify mworker_free_child() BUG/MINOR: mworker: fix a FD leak of a sockpair upon a failed reload MINOR: mworker: set the master side of ipc_fd

Re: [PATCH] CI: enable QUIC for Coverity scan

2022-02-11 Thread Willy Tarreau
On Sat, Feb 05, 2022 at 10:14:54AM +0500, ??? wrote: > gentle ping Now merged, thanks Ilya and sorry for the delay (being really busy on a particuarly annoying bug). Willy

Re: [EXTERNAL] Re: [PATCH]: thread basic solaris support

2022-02-14 Thread Willy TARREAU
On Mon, Feb 14, 2022 at 08:11:14AM +, David CARLIER wrote: > ping :) Sorry David, my tree is currently full of debugging code and functions with guts hanging out, which is why I tend to postpone merging of non- critical stuff. I'll take care of it soon though. Thanks, Willy

[ANNOUNCE] haproxy-2.5.2

2022-02-16 Thread Willy Tarreau
n't pop the lua stack when getting headers DOC: management: mark "set server ssl" as deprecated BUG/MINOR: mworker: does not add the -sf in wait mode BUG/MINOR: mworker: does not erase the pidfile upon reload BUG/MINOR: httpclient/cli: display junk c

[ANNOUNCE] haproxy-2.4.13

2022-02-16 Thread Willy Tarreau
empty HTX buffer BUG/MEDIUM: cli: Never wait for more data on client shutdown David Carlier (1): BUILD/MINOR: fix solaris build with clang. William Dauchy (1): BUG/MEDIUM: server: avoid changing healthcheck ctx with set server ssl William Lallemand (1): BUG/MINOR: mworker: d

Re: [ANNOUNCE] haproxy-2.5.2

2022-02-16 Thread Willy Tarreau
Hi Vincent, On Wed, Feb 16, 2022 at 07:08:38PM +0100, Vincent Bernat wrote: > ? 16 February 2022 16:27 +01, Willy Tarreau: > > > Maybe that would even be a nice improvement for distros to provide these > > by default starting with 2.6 or maybe even 2.5. > > Why not e

Re: [ANNOUNCE] haproxy-2.5.2

2022-02-16 Thread Willy Tarreau
On Wed, Feb 16, 2022 at 09:57:45PM +0100, Christian Ruppert wrote: > On 2022-02-16 19:08, Vincent Bernat wrote: > > ? 16 February 2022 16:27 +01, Willy Tarreau: > > > > > Maybe that would even be a nice improvement for distros to provide > > > these > >

Re: [ANNOUNCE] haproxy-2.5.2

2022-02-16 Thread Willy Tarreau
On Thu, Feb 17, 2022 at 07:57:30AM +0100, Vincent Bernat wrote: > ? 16 February 2022 22:15 +01, Willy Tarreau: > > > That's exactly the sense behind the word "maybe" above, to open the > > discussion :-) Those with large buffers can definitely see a > >

Re: [PATCH] BUG/MINOR: mailers: negotiate SMTP, not ESMTP

2022-02-17 Thread Willy Tarreau
On Thu, Feb 17, 2022 at 03:40:51PM +0100, Lukas Tribus wrote: > As per issue #1552 the mailer code currently breaks on ESMTP multiline > responses. Let's negotiate SMTP instead. Merged, thank you Lukas! Willy

Re: [PATCH]: DOC: Fix usage/examples of deprecated ACLs

2022-02-23 Thread Willy Tarreau
On Sun, Feb 20, 2022 at 11:25:09PM +0100, Christian Ruppert wrote: > Hey, > > attached a patch to fix some examples and references, still using or > pointing to deprecated variants. Oops, indeed! Thanks for this, Christian, now merged! Willy

More dynamic debugging [was: [ANNOUNCE] haproxy-2.5.2]

2022-02-23 Thread Willy Tarreau
Hi, On Wed, Feb 16, 2022 at 10:26:08PM +0100, Willy Tarreau wrote: > Maybe we'll figure reasonable ways to turn some options to dynamic > in the future (thinking about what's done with pools, I'm pretty sure > that would be possible for almost half of the options, this w

Re: [PATCH] MINOR: sample: Add srv_rtt server round trip time sample

2022-02-25 Thread Willy Tarreau
Hi Alex, On Thu, Feb 24, 2022 at 03:03:59AM +0100, Aleksandar Lazic wrote: > Hi. > > Here the first patch for feature request "New Balancing algorithm (Peak) EWMA > #1570" Note, I don't think it is needed for this algo as long as we instead use measured response time and/or health check time. B

Re: [PATCH] MINOR: sample: Add srv_rtt server round trip time sample

2022-02-25 Thread Willy Tarreau
On Fri, Feb 25, 2022 at 03:39:02PM +0100, Aleksandar Lazic wrote: > > > diff --git a/reg-tests/sample_fetches/srv_rtt.vtc > > > b/reg-tests/sample_fetches/srv_rtt.vtc > > > new file mode 100644 > > > index 0..c0ad0cbae > > > --- /dev/null > > > +++ b/reg-tests/sample_fetches/srv_rtt.vtc >

[ANNOUNCE] haproxy-2.6-dev2

2022-02-25 Thread Willy Tarreau
timeout BUG/MINOR: httpclient/lua: missing pop for new timeout parameter DOC: httpclient/lua: fix the type of the dst parameter Willy Tarreau (57): BUG/MEDIUM: pools: ensure items are always large enough for the pool_cache_item BUG/MINOR: pools: always flush pools about to be

Re: [PATCH 1/2] CLEANUP: connection: Indicate unreachability to the compiler in conn_recv_proxy

2022-02-28 Thread Willy Tarreau
On Fri, Feb 25, 2022 at 09:44:26PM +0100, Tim Duesterhus wrote: > Transform the unreachability comment into a call to `my_unreachable()` to > allow > the compiler from benefitting from it. > > see d1b15b6e9b4d4d378a6169929a86f25b95eafc57 > see 615f81eb5ad3e8c691901db8ce3e6a4a6b6efa49 Note: I adj

Re: ACL execution order, short circuit behaviour?

2022-02-28 Thread Willy Tarreau
Hi Alex, On Mon, Feb 28, 2022 at 02:36:51PM +, Lais, Alexander wrote: > Dear all, > > I'm trying to understand, how ACL chains, e.g. for `http-request deny` are > executed, and whether they support short-circuit. > > > Example: > > acl1: ip in particular range > acl2: comple regex match w

Re: [PATCH] MINOR: queue: Replace if() + abort() with BUG_ON()

2022-03-01 Thread Willy Tarreau
On Mon, Feb 28, 2022 at 07:16:31PM +0100, Tim Duesterhus wrote: > see 5cd4bbd7a ("BUG/MAJOR: threads/queue: Fix thread-safety issues on the > queues management") Merged, thanks Tim! Willy

[ANNOUNCE] haproxy-2.2.21

2022-03-02 Thread Willy Tarreau
github actions: -Wno-deprecated-declarations with OpenSSL 3.0.0 CI: github: switch to OpenSSL 3.0.0 BUG/MINOR: tools: url2sa reads ipv4 too far Willy Tarreau (17): MEDIUM: cli: yield between each pipelined command MINOR: channel: add new function co_getdelim() to support

Re: [PATCH] BUILD/MEDIUM kFreeBSD build fix

2022-03-04 Thread Willy Tarreau
On Fri, Mar 04, 2022 at 03:59:27PM +, David CARLIER wrote: > Hi, > > here the patch related to the GH issue #1555. Thank you David, now merged! Willy

Re: [EXT] Re: [EXT] Re: Regarding the new dark mode dashboard in 2.5

2022-03-08 Thread Willy Tarreau
Hi guys, On Tue, Mar 08, 2022 at 01:46:50PM +, Marno Krahmer wrote: > Hey Tim, > > I added a reference to the GitHub issue to the second line of the commit > message. Too late, I took the one you posted on the issue and that Ciprian confirmed. No big deal anyway. Cheers, Willy

Re: [PATCH] BUILD/MEDIUM: FreeBSD < 14 build fix

2022-03-08 Thread Willy Tarreau
On Tue, Mar 08, 2022 at 02:51:26PM +, David CARLIER wrote: > Hi to (re)close #1555. :-) Thanks for the quick fix David. I've copied a piece of the error output into the commit message as it's always helpful for those facing build breakage. Now merged, and if this time it's OK I'll backport i

Re: CI caching improvement

2022-03-08 Thread Willy Tarreau
Hi William, On Tue, Mar 08, 2022 at 04:06:45PM +0100, William Lallemand wrote: > Hello, > > The attached patch implements a somehow ugly way to cache the VTest > binary, basically it gets the commit ID by doing a curl of the > master.patch on the github URL. > > It allows to save ~8s per matrix

Re: CI caching improvement

2022-03-08 Thread Willy Tarreau
Hi Tim, On Tue, Mar 08, 2022 at 04:17:00PM +0100, Tim Düsterhus wrote: > William > > On 3/8/22 16:06, William Lallemand wrote: > > Also, I'm wondering if we could also cache the build of HAProxy, you > > could think that weird, but in fact it will help relaunch the tests when > > one is failing,

Re: CI caching improvement

2022-03-08 Thread Willy Tarreau
On Tue, Mar 08, 2022 at 04:40:40PM +0100, Tim Düsterhus wrote: > > > Please don't. You always want to run a clean build, otherwise you're going > > > to get super-hard-to-debug failures if some object file is accidentally > > > taken from the cache instead of a clean build. > > > > What risk are y

Re: [EXT] [EXT] Re: Regarding the new dark mode dashboard in 2.5

2022-03-08 Thread Willy Tarreau
Hi Thierry, On Tue, Mar 08, 2022 at 08:23:20PM +0100, Thierry Fournier wrote: > > > On 8 Mar 2022, at 14:52, Willy Tarreau wrote: > > > > Hi guys, > > > > On Tue, Mar 08, 2022 at 01:46:50PM +, Marno Krahmer wrote: > >> Hey Tim, > >>

Re: [PATCH 0/6] 'ist'ify members of struct proxy

2022-03-08 Thread Willy Tarreau
Hi Tim, On Sat, Mar 05, 2022 at 12:52:39AM +0100, Tim Duesterhus wrote: > Willy, > Christopher, > > find a series that converts a few members of `struct proxy` into ists. All > of them have already been converted into ists when operating on them, so > directly storing them as ists makes that code

Re: Always add "reason"

2022-03-11 Thread Willy Tarreau
Hi Marco, On Thu, Mar 03, 2022 at 12:26:09PM +0100, Marco Corte wrote: > Hi! > > I can add a "reason phrase" to a response based on the HTTP status like > this: > > http-response set-status 200 reason OK if { status eq 200 } > > Is there any way to add the reason phrase for a set of codes witho

Re: Peers using heavily single cpu core

2022-03-11 Thread Willy Tarreau
Hi Maciej, On Fri, Mar 04, 2022 at 01:10:37PM +0100, Maciej Zdeb wrote: > Hi, > > I'm experiencing high CPU usage on a single core, idle drops below 40% > while other cores are at 80% idle. Peers cluster is quite big (12 servers, > each server running 12 threads) and is used for synchronization o

[ANNOUNCE] haproxy-2.6-dev3

2022-03-11 Thread Willy Tarreau
oxy: Store monitor_uri as a `struct ist` MINOR: proxy: Store fwdfor_hdr_name as a `struct ist` MINOR: proxy: Store orgto_hdr_name as a `struct ist` MEDIUM: proxy: Store server_id_hdr_name as a `struct ist` CLEANUP: fcgi: Replace memcpy() on ist by istcat() CLEANUP: fcgi:

Re: [ANNOUNCE] haproxy-2.6-dev3

2022-03-11 Thread Willy Tarreau
Hi Tim, On Fri, Mar 11, 2022 at 07:24:42PM +0100, Tim Düsterhus wrote: > Willy, > > On 3/11/22 19:05, Willy Tarreau wrote: > > So unless anyone has extremely good insights about this or wants to > > share some return of experience from the field about similar issues, >

Re: Peers using heavily single cpu core

2022-03-11 Thread Willy Tarreau
On Fri, Mar 11, 2022 at 10:19:09PM +0100, Maciej Zdeb wrote: > Hi Willy, > > Thank you for such useful info! I've checked the worst HAProxy nodes and on > every such node all outgoing peers connections are run on the same thread: (...) Indeed. I was pretty sure we were setting them to any thread o

Re: [PATCH 0/6] 'ist'ify members of struct proxy

2022-03-15 Thread Willy Tarreau
Hi Tim, On Fri, Mar 11, 2022 at 09:15:48PM +0100, Tim Düsterhus wrote: > Yeah, I've attempted to look into the Coccinelle patches in the Linux kernel > sources, but I agree that many of those are very complex :-) > > Do you happen to know where we could ask for assistance with making the > necess

Re: [PATCH 0/4] Using Coccinelle the right way

2022-03-21 Thread Willy Tarreau
Hi Tim, On Tue, Mar 15, 2022 at 01:11:04PM +0100, Tim Duesterhus wrote: > Willy, > > I wanted to build a simple reproducer for the "ist in struct" issue to post > on the Coccinelle list and found that it worked if all structs are defined > in the same .c file. Searching the list archives then rev

Re: [PATCH] REGTESTS: Do not use REQUIRE_VERSION for HAProxy 2.5+

2022-03-21 Thread Willy Tarreau
On Mon, Mar 21, 2022 at 09:25:28AM +0100, Tim Düsterhus wrote: > Willy, > > On 3/11/22 22:46, Tim Duesterhus wrote: > > Introduced in: > > > > 0657b9338 MINOR: stream: add "last_rule_file" and "last_rule_line" samples > > I believe you missed this one. Indeed, for an unknown reason it was marke

[ANNOUNCE] haproxy-2.6-dev4

2022-03-26 Thread Willy Tarreau
t header BUILD: httpclient: fix build without SSL BUG/MINOR: server/ssl: free the SNI sample expression BUG/MINOR: httpclient: only check co_data() instead of HTTP_MSG_DATA BUG/MINOR: httpclient: process the response when received before the end of the request BUG

Re: [PATCH] DOC: reflect H2 timeout changes

2022-03-26 Thread Willy Tarreau
On Sat, Mar 26, 2022 at 08:43:48PM +0100, Lukas Tribus wrote: > Reverts 75df9d7a7 ("DOC: explain HTTP2 timeout behavior") since H2 > connections now respect "timeout http-keep-alive". > > If commit 15a4733d5d ("BUG/MEDIUM: mux-h2: make use of http-request > and keep-alive timeouts") is backported,

Re: [ANNOUNCE] haproxy-2.6-dev4

2022-03-26 Thread Willy Tarreau
On Sat, Mar 26, 2022 at 08:49:14PM +0100, Lukas Tribus wrote: > Hello Willy, > > On Sat, 26 Mar 2022 at 10:22, Willy Tarreau wrote: > > A change discussed around previous announce was made in the H2 mux: the > > "timeout http-keep-alive" and "timeout http-req

Re: [ANNOUNCE] haproxy-2.6-dev4

2022-03-30 Thread Willy Tarreau
Hi Tim, On Wed, Mar 30, 2022 at 09:14:42PM +0200, Tim Düsterhus wrote: > Willy, > > On 3/26/22 10:22, Willy Tarreau wrote: > > be the last LTS version with this. I'm interested in opinions and feedback > > about this. And the next question will obviously be "h

Re: [ANNOUNCE] haproxy-2.6-dev4

2022-03-31 Thread Willy Tarreau
Hi Alex, On Sat, Mar 26, 2022 at 08:30:56PM +0100, Aleksandar Lazic wrote: > I fully agree with "using DNS for service discovery is a disaster." and the > DNS > was the easiest way in the past for service discovery. > > A possible solution could be that there is a registration API in HAProxy whi

Re: [PATCH] hash: add support for consistent (hashing) 2x algorithm

2022-03-31 Thread Willy Tarreau
Hi Davide, It seems I missed your response last time. On Fri, Feb 18, 2022 at 04:47:29PM +0100, Davide Pucci wrote: > > I'm having a number of questions about the motivations behind this > > design, because I'm seeing a certain number of fundamental issues this > > will cause and am not sure abou

Re: Peers using heavily single cpu core

2022-03-31 Thread Willy Tarreau
Hi Maciej, On Wed, Mar 16, 2022 at 12:21:59PM +0100, Maciej Zdeb wrote: > Hi Willy, > did you find anything? I forgot about it after switching to plenty of other topics since :-( > I've made some "session shutdown" tests. With simple configuration > (attached) it is very easy to reproduce a situ

Re: Peers using heavily single cpu core

2022-03-31 Thread Willy Tarreau
On Thu, Mar 31, 2022 at 11:56:13AM +0200, Willy Tarreau wrote: > > I've made some "session shutdown" tests. With simple configuration > > (attached) it is very easy to reproduce a situation when "shutdown session" > > works only for the first time.

Re: [PATCH] DOC: remove double blanks in confiuration.txt

2022-03-31 Thread Willy Tarreau
On Wed, Mar 30, 2022 at 12:19:48AM +0200, Aleksandar Lazic wrote: > Hi. > > This patch removes some double blanks. Applied, thank you Alex! Willy

Re: [PATCH] CI: update OpenSSL from 3.0.1 to 3.0.2

2022-03-31 Thread Willy Tarreau
On Sun, Mar 27, 2022 at 12:02:23PM +0500, ??? wrote: > Hello, > > minor openssl update in CI. Applied, thank you Ilya! Willy

Re: [PATCH] MINOR: sample: converter: Add add_item converter

2022-03-31 Thread Willy Tarreau
Nikola, thanks for your contribution. I agree with Tim's points, and that's a good indicator of the quality of your patch, since all of this is purely cosmetic :-) I do have one minor cosmetic comment to add here: +static int sample_conv_add_item(const struct arg *arg_p, struct sample *smp, voi

Re: Peers using heavily single cpu core

2022-04-01 Thread Willy Tarreau
On Fri, Apr 01, 2022 at 08:58:43AM +0200, Maciej Zdeb wrote: > Hi Willy, > Thanks for the patch! Now I'll be able to rebalance peers connections > manually. Do you know why so many of them are landing on the same thread? I seem to remember a discussion about this in the past and that the conclusio

Re: Peers using heavily single cpu core

2022-04-01 Thread Willy Tarreau
On Fri, Apr 01, 2022 at 11:23:34AM +0200, Maciej Zdeb wrote: > > I remember mentioning something about trying to change this in the future. > > For outgoing connections I think we could try to figure where peers > > connections are and always use one least represented thread. > > > If I understand

Re: [PATCH] MINOR: sample: converter: Add add_item converter

2022-04-01 Thread Willy Tarreau
Hi Nikola, On Fri, Apr 01, 2022 at 04:08:20PM +0200, Nikola Sale wrote: > Hi, > > Thank you Tim and Willy for your quick and detailed feedback. I'll continue > working on the patch at the earliest convenience. OK! > In the meantime, I'd like to further discuss some points: > > - The square brac

Re: [PATCH] MINOR: sample: converter: Add add_item converter

2022-04-03 Thread Willy Tarreau
Hi Nikola, On Sun, Apr 03, 2022 at 10:34:11PM +0200, Nikola Sale wrote: > Hi, > > Thanks Tim. Here is the updated patch with the version fix in add_item.vtc > ready for Willy to review. Reviewed and now merged since I had nothing to add :-) Thank you! Willy

Re: Peers using heavily single cpu core

2022-04-07 Thread Willy Tarreau
Hi Maciej, On Wed, Apr 06, 2022 at 11:17:44AM +0200, Maciej Zdeb wrote: > Hi Willy, > > I've managed to implement the easy part (attached patches). Thanks for this! I'm having a minor comment on the 3rd patch, see at the end. > However this is > not enough to get it to work properly. I'm stuck

Re: Peers using heavily single cpu core

2022-04-07 Thread Willy Tarreau
On Thu, Apr 07, 2022 at 11:50:33AM +0200, Willy Tarreau wrote: > And in an ideal world, the applet's init code could be the one responsible > for creating its stream. Historically it wasn't even possible because both > contexts were strongly tied. But with the changes Christophe

Re: Mailing domain is vulnerable and email can be spoofable due Vulnerable DMARC Record

2022-04-07 Thread Willy Tarreau
Hello, On Sat, Apr 02, 2022 at 03:46:58AM +0500, Arslan Kabeer wrote: > Hello Team, > I am a security researcher and I founded this vulnerability. > I just sent a forged email to my email address that appears to originate > from haproxy@formilux.org > I was able to do this because of the followin

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-07 Thread Willy Tarreau
Hi Miroslav! On Thu, Apr 07, 2022 at 01:12:19PM +0200, Miroslav Zagorac wrote: > Hello all, > > I am sending you a set of patches that return the ability to use > haproxy variables to transfer opentracing context. > Thanks. I'm having just a few minor questions (and I'll eventually complete the

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-07 Thread Willy Tarreau
On Thu, Apr 07, 2022 at 07:15:21PM +0200, Miroslav Zagorac wrote: > On 07.04.2022 18:27, Willy Tarreau wrote: > > Hi Miroslav! > > > > Hello Willi, > > at first I would generally say that I did not think that some of these > patches could be backported to older ver

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Willy Tarreau
On Thu, Apr 07, 2022 at 08:33:10PM +0200, Miroslav Zagorac wrote: > On 07.04.2022 20:02, Willy Tarreau wrote: > > No, really, do not bother doing that. Just tell me which ones are bug > > fixes that need to be backported, as we'll backport them the usual way > > as part

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Willy Tarreau
Hi Miroslav, On Fri, Apr 08, 2022 at 11:01:49AM +0200, Miroslav Zagorac wrote: > Hello Willy, > > the attachment contains patches for haproxy branches 2.4 and 2.[56]. > > Branch 2.4 does not have several patches because they are not > applicable to it. The numbering has stayed the same, so you

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Willy Tarreau
On Fri, Apr 08, 2022 at 03:36:30PM +0200, Miroslav Zagorac wrote: > Hello Willy, > > today I tested the operation speed of the opentracing module on branch 2.4 > and 2.5 several times and unfortunately I can't confirm what I wrote > yesterday (that the operation speed is almost doubled). > > The

Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Willy Tarreau
On Fri, Apr 08, 2022 at 04:04:07PM +0200, Miroslav Zagorac wrote: > > - 0014-MAJOR-opentracing-reenable-usage-of-vars-to-transmit.patch > >=> while I'm fine for 2.6, I'm really not for 2.5 without a big > > compelling reason. It's a feature addition, not a bug fix. > > Either there

Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Willy Tarreau
On Fri, Apr 08, 2022 at 04:45:46PM +0200, Miroslav Zagorac wrote: > On 08.04.2022 16:24, Willy Tarreau wrote: > > My concern is essentially this one: is there any risk that a 2.5 user > > currently using opentracing would be hit by a bug introduced with this > > patch ? T

Re: QUIC and HTTP/3

2022-04-09 Thread Willy Tarreau
On Sat, Apr 09, 2022 at 09:21:31AM +0500, ??? wrote: > there are missing bits ... > https://github.com/haproxy/haproxy/blob/master/INSTALL#L392 Yep and it does work, as I've applied it as-is two weeks ago and it worked. Shawn, however, please use the latest 2.6-dev for QUIC. A lot of pro

[ANNOUNCE] haproxy-2.6-dev5

2022-04-09 Thread Willy Tarreau
: ssl: ca-file @system-ca loads the system trusted CA DOC: configuration: add the ca-file changes BUG/MINOR: ssl: handle X509_get_default_cert_dir() returning NULL MINOR: httpclient: enable request buffering MEDIUM: httpclient: enable l7-retry BUG/MINOR: httpclient: end callba

Re: [PATCH 1/2] CI: Update to actions/checkout@v3

2022-04-10 Thread Willy Tarreau
On Sat, Apr 09, 2022 at 10:08:41PM +0200, Tim Duesterhus wrote: > No functional change, but we should keep this current. (...) both patches applied, thank you Tim! Willy

Re: [PATCH] doc: adjust QUICTLS part

2022-04-10 Thread Willy Tarreau
On Sun, Apr 10, 2022 at 12:14:23PM +0500, ??? wrote: > Hello, > > small fix for guide how to build QUICTLS Applied, thank you Ilya! Willy

Re: QUIC and HTTP/3

2022-04-10 Thread Willy Tarreau
Hi Shawn, responding to all your messages at once. On Sun, Apr 10, 2022 at 04:16:55PM -0600, Shawn Heisey wrote: > On 4/9/2022 3:30 AM, Willy Tarreau wrote: > > I'd encourage you to place QUIC in a separate haproxy process. > > I have this working. > > On another sy

Re: [PATCH 1/1]: BUILD/MEDIUM: tcp_sample porting get_tcp_info to macOs

2022-04-10 Thread Willy Tarreau
Hi David, On Sat, Apr 09, 2022 at 02:44:54PM +0100, David CARLIER wrote: > Hi, > > here a patch proposal to port a subset of the get_tcp_info samples to macOs. Thanks, that's quite interesting, but I really don't like the reordering of the functions to try to group between OSes, for me this is a

Re: [PATCH 1/1]: pool UAF pools ID setting on Linux 5.17 and onwards.

2022-04-10 Thread Willy Tarreau
Hi David, On Sun, Apr 10, 2022 at 10:51:27AM +0100, David CARLIER wrote: > From 7f599d96c248ea6b7a67168ea68b31470c08b61d Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Sun, 10 Apr 2022 10:47:16 +0100 > Subject: [PATCH] BUILD/MEDIUM: pool UAF's pool set an id on Linux 5.17 and > onwards.

Re: Possible bug in stats page dark mode

2022-04-10 Thread Willy Tarreau
On Sun, Apr 10, 2022 at 12:25:54PM -0600, Shawn Heisey wrote: > On the dark mode stats page served by version 2.6-dev5, the frontend or > backend description is grey text on a white background.  It's very hard to > read. Ah indeed, a "th.desc" entry was missing to replace the background, now fixed

Re: [PATCH] CI: cirrus: update freebsd image to the actual 13.0 version

2022-04-11 Thread Willy Tarreau
On Mon, Apr 11, 2022 at 11:02:04PM +0500, ??? wrote: > From: Ilya Shipitsin > Date: Mon, 11 Apr 2022 22:25:35 +0500 > Subject: [PATCH] CI: cirrus: switch to FreeBSD-13.0 > > we use outdated FreeBSD-12.2, which is outdated, let us update > to the actual release Ah cool, I noticed it was

Re: HTTP/3 -- POST requests not working

2022-04-11 Thread Willy Tarreau
Hi Shawn, On Mon, Apr 11, 2022 at 01:05:21PM -0600, Shawn Heisey wrote: > On 4/11/22 12:16, Shawn Heisey wrote: > > Two different browsers have the same problem, so I am currently > > speculating that it's an issue with haproxy or apache.  I think I can > > install nginx without too much trouble .

Re: [ANNOUNCE] haproxy-2.6-dev5

2022-04-11 Thread Willy Tarreau
On Tue, Apr 12, 2022 at 11:07:09AM +0500, ??? wrote: > Hello, > > can we pay some attention to cppcheck findings before 2.6 ? > https://github.com/haproxy/haproxy/issues/1184 > > I found cppcheck somewhat useful (and somewhat noisy as well, but cppcheck > folks are really friendly on fix

Re: QUIC and HTTP/3

2022-04-11 Thread Willy Tarreau
On Mon, Apr 11, 2022 at 06:10:30AM -0600, Shawn Heisey wrote: > On 4/10/2022 11:32 PM, Willy Tarreau wrote: > > Interesting, and not much surprising, given that SSL is handled a bit > > differently. I suspect we'll see other funny stuff. By the way, if you're > &g

Re: [PATCH 1/1]: BUILD/MEDIUM: tcp_sample porting get_tcp_info to macOs

2022-04-15 Thread Willy Tarreau
Hi David, Done reviewing/editing/testing/merging both patches now. Thanks! Willy

[ANNOUNCE] haproxy-2.6-dev6

2022-04-16 Thread Willy Tarreau
0 Tim Duesterhus (2): CI: Update to actions/checkout@v3 CI: Update to actions/cache@v3 William Lallemand (2): BUILD: ssl: add USE_ENGINE and disable the openssl engine by default CI: github actions: disable -Wno-deprecated Willy Tarreau (45): CLEANUP: connection: redu

Re: [ANNOUNCE] haproxy-2.6-dev6

2022-04-16 Thread Willy Tarreau
Hi Ilya, On Sat, Apr 16, 2022 at 10:08:58PM +0500, ??? wrote: > ??, 16 ???. 2022 ?. ? 19:07, Willy Tarreau : > > > Hi, > > > > HAProxy 2.6-dev6 was released on 2022/04/16. It added 150 new commits > > after version 2.6-dev5. > > > > can we s

<    1   2   3   4   5   6   7   8   9   10   >