[jira] [Commented] (FLINK-8979) Extend Kafka end-to-end tests to run with different versions

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416907#comment-16416907 ] ASF GitHub Bot commented on FLINK-8979: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #5778: [FLINK-8979] (part 1) Make Kafka end-to-end tests ...

2018-03-27 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5778 [FLINK-8979] (part 1) Make Kafka end-to-end tests not embarrassingly parallel ## What is the purpose of the change This PR improves the behaviour test coverage of Kafka end-to-end tests by

[jira] [Resolved] (FLINK-8941) SpanningRecordSerializationTest fails on Travis

2018-03-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8941. -- Resolution: Fixed Fixed via master: 39be1996e461bbeec148bf34a2f92cedeccf59ab a148492e142c7f62cbd

[jira] [Resolved] (FLINK-9057) NPE in CreditBasedSequenceNumberingViewReader when cancelling before initilization was complete

2018-03-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9057. -- Resolution: Fixed Fixed via master: f486a3fd6ed80b67e8eeed9245ad37b6b0be740b 1.5.0: f1df310814b6

[jira] [Commented] (FLINK-9057) NPE in CreditBasedSequenceNumberingViewReader when cancelling before initilization was complete

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416867#comment-16416867 ] ASF GitHub Bot commented on FLINK-9057: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8941) SpanningRecordSerializationTest fails on Travis

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416868#comment-16416868 ] ASF GitHub Bot commented on FLINK-8941: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8415) Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416869#comment-16416869 ] ASF GitHub Bot commented on FLINK-8415: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-8415) Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()

2018-03-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8415. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via master: dc0f344f3c345765a59fcce60841fa56

[GitHub] flink pull request #5724: [FLINK-8415] Unprotected access to recordsToSend i...

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5724 ---

[GitHub] flink pull request #5747: [FLINK-9057][network] fix an NPE when cleaning up ...

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5747 ---

[GitHub] flink pull request #5709: [FLINK-8941][network][serializer] improve Spanning...

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5709 ---

[GitHub] flink issue #5776: [FLINK-8708] Unintended integer division in StandaloneThr...

2018-03-27 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5776 cc @tillrohrmann ---

[jira] [Commented] (FLINK-7897) Consider using nio.Files for file deletion in TransientBlobCleanupTask

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416807#comment-16416807 ] ASF GitHub Bot commented on FLINK-7897: --- Github user yanghua commented on the issue:

[GitHub] flink issue #5777: [FLINK-7897] Consider using nio.Files for file deletion i...

2018-03-27 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5777 cc @tillrohrmann ---

[jira] [Commented] (FLINK-8708) Unintended integer division in StandaloneThreadedGenerator

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416808#comment-16416808 ] ASF GitHub Bot commented on FLINK-8708: --- Github user yanghua commented on the issue:

[jira] [Commented] (FLINK-8794) When using BucketingSink, it happens that one of the files is always in the [.in-progress] state

2018-03-27 Thread yanxiaobin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416734#comment-16416734 ] yanxiaobin commented on FLINK-8794: --- thanks! indeed so.  Enable consistent-view can caus

[jira] [Updated] (FLINK-9077) flip6 cluster framework doesn't work on mesos

2018-03-27 Thread Renjie Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renjie Liu updated FLINK-9077: -- Priority: Blocker (was: Major) > flip6 cluster framework doesn't work on mesos > --

[jira] [Commented] (FLINK-7897) Consider using nio.Files for file deletion in TransientBlobCleanupTask

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416625#comment-16416625 ] ASF GitHub Bot commented on FLINK-7897: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #5777: [FLINK-7897] Consider using nio.Files for file del...

2018-03-27 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/5777 [FLINK-7897] Consider using nio.Files for file deletion in TransientBlobCleanupTask ## What is the purpose of the change *This pull request use `nio.Files.delete` method to make the delete

[jira] [Commented] (FLINK-8708) Unintended integer division in StandaloneThreadedGenerator

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416585#comment-16416585 ] ASF GitHub Bot commented on FLINK-8708: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #5776: [FLINK-8708] Unintended integer division in Standa...

2018-03-27 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/5776 [FLINK-8708] Unintended integer division in StandaloneThreadedGenerator ## What is the purpose of the change *This pull request fixed unintended integer division in StandaloneThreadedGenera

[jira] [Commented] (FLINK-9033) Replace usages of deprecated TASK_MANAGER_NUM_TASK_SLOTS

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416550#comment-16416550 ] ASF GitHub Bot commented on FLINK-9033: --- Github user yew1eb commented on a diff in t

[GitHub] flink pull request #5731: [FLINK-9033][config] Replace usages of deprecated ...

2018-03-27 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5731#discussion_r177616520 --- Diff: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala --- @@ -23,7 +23,7 @@ import java.io._ import akka.actor.Ac

[jira] [Created] (FLINK-9100) Shadow/Hide password from configuration that is logged to log file

2018-03-27 Thread JIRA
Szymon Szczypiński created FLINK-9100: - Summary: Shadow/Hide password from configuration that is logged to log file Key: FLINK-9100 URL: https://issues.apache.org/jira/browse/FLINK-9100 Project: F

[jira] [Commented] (FLINK-9061) S3 checkpoint data not partitioned well -- causes errors and poor performance

2018-03-27 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416271#comment-16416271 ] Jamie Grier commented on FLINK-9061: [~StephanEwen] I don't know if the s3a-based conn

[jira] [Comment Edited] (FLINK-9061) S3 checkpoint data not partitioned well -- causes errors and poor performance

2018-03-27 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416254#comment-16416254 ] Jamie Grier edited comment on FLINK-9061 at 3/27/18 9:13 PM: -

[jira] [Commented] (FLINK-9061) S3 checkpoint data not partitioned well -- causes errors and poor performance

2018-03-27 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416254#comment-16416254 ] Jamie Grier commented on FLINK-9061: Yeah, so I completely agree that should be a 503

[jira] [Resolved] (FLINK-9090) Replace UUID.randomUUID with more efficient PRNG

2018-03-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved FLINK-9090. --- Resolution: Later I did a quick search but haven't found one on the hot path. > Replace UUID.randomUUID with

[jira] [Commented] (FLINK-8809) Decrease maximum value of DirectMemory at default config

2018-03-27 Thread Kirill A. Korinskiy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416225#comment-16416225 ] Kirill A. Korinskiy commented on FLINK-8809: [~greghogan] yes, I discovered th

[jira] [Commented] (FLINK-8809) Decrease maximum value of DirectMemory at default config

2018-03-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416137#comment-16416137 ] Greg Hogan commented on FLINK-8809: --- Will a restricted {{MaxDirectMemorySize}} prevent a

[jira] [Commented] (FLINK-9099) Failing allocated slots not noticed

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416128#comment-16416128 ] ASF GitHub Bot commented on FLINK-9099: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...

2018-03-27 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5775#discussion_r177544954 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java --- @@ -465,6 +464,58 @@ public void testSchedu

[jira] [Commented] (FLINK-9099) Failing allocated slots not noticed

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416126#comment-16416126 ] ASF GitHub Bot commented on FLINK-9099: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...

2018-03-27 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5775#discussion_r177544459 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java --- @@ -465,6 +464,58 @@ public void testSchedu

[GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...

2018-03-27 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5775#discussion_r177544274 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java --- @@ -465,6 +464,58 @@ public void testSchedu

[jira] [Commented] (FLINK-9099) Failing allocated slots not noticed

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416124#comment-16416124 ] ASF GitHub Bot commented on FLINK-9099: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-9099) Failing allocated slots not noticed

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416123#comment-16416123 ] ASF GitHub Bot commented on FLINK-9099: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...

2018-03-27 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5775#discussion_r177543886 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -659,7 +660,7 @@ public void disconnectResourceManager()

[jira] [Commented] (FLINK-9033) Replace usages of deprecated TASK_MANAGER_NUM_TASK_SLOTS

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416104#comment-16416104 ] ASF GitHub Bot commented on FLINK-9033: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #5731: [FLINK-9033][config] Replace usages of deprecated ...

2018-03-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5731#discussion_r177536243 --- Diff: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala --- @@ -23,7 +23,7 @@ import java.io._ import akka.actor

[jira] [Commented] (FLINK-9090) Replace UUID.randomUUID with more efficient PRNG

2018-03-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416063#comment-16416063 ] Greg Hogan commented on FLINK-9090: --- Could you point to a case where use of {{UUID.rando

[jira] [Comment Edited] (FLINK-9090) Replace UUID.randomUUID with more efficient PRNG

2018-03-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415910#comment-16415910 ] Greg Hogan edited comment on FLINK-9090 at 3/27/18 6:30 PM: Wh

[jira] [Updated] (FLINK-9090) Replace UUID.randomUUID with more efficient PRNG

2018-03-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9090: -- Summary: Replace UUID.randomUUID with more efficient PRNG (was: Replace UUID.randomUUID with deterministic PRNG

[jira] [Commented] (FLINK-9090) Replace UUID.randomUUID with deterministic PRNG

2018-03-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416034#comment-16416034 ] Ted Yu commented on FLINK-9090: --- The main goal is to avoid single JVM wide lock, rather than

[jira] [Commented] (FLINK-8620) Enable shipping custom artifacts to BlobStore and accessing them through DistributedCache

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415990#comment-16415990 ] ASF GitHub Bot commented on FLINK-8620: --- Github user dawidwys commented on the issue

[GitHub] flink issue #5580: [FLINK-8620] Enable shipping custom files to BlobStore an...

2018-03-27 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/5580 @zentol I've rebased this PR. Feel free to review whenever you find a while. ---

[jira] [Assigned] (FLINK-9082) Submission with higher parallelism than task slots fails with TimeoutException

2018-03-27 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou reassigned FLINK-9082: - Assignee: Sihua Zhou > Submission with higher parallelism than task slots fails with TimeoutExcep

[jira] [Commented] (FLINK-8740) Job-level metrics lost during job re-submission in HA mode

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415934#comment-16415934 ] ASF GitHub Bot commented on FLINK-8740: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5755: [FLINK-8740] [metrics] Create new JobManagerJobMet...

2018-03-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5755#discussion_r177497889 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -165,7 +166,7 @@ private final BlobServer blobServer;

[jira] [Commented] (FLINK-9090) Replace UUID.randomUUID with deterministic PRNG

2018-03-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415910#comment-16415910 ] Greg Hogan commented on FLINK-9090: --- Why the need to be deterministic (and user configur

[jira] [Comment Edited] (FLINK-8836) Duplicating a KryoSerializer does not duplicate registered default serializers

2018-03-27 Thread Christopher Ng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415826#comment-16415826 ] Christopher Ng edited comment on FLINK-8836 at 3/27/18 3:51 PM:

[jira] [Commented] (FLINK-8836) Duplicating a KryoSerializer does not duplicate registered default serializers

2018-03-27 Thread Christopher Ng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415826#comment-16415826 ] Christopher Ng commented on FLINK-8836: --- [~StephanEwen] i asked on the Kryo mailing

[jira] [Commented] (FLINK-8973) End-to-end test: Run general purpose job with failures in standalone mode

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415818#comment-16415818 ] ASF GitHub Bot commented on FLINK-8973: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5750: [FLINK-8973] [E2E] HA end-to-end test with StateMachineEx...

2018-03-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5750 Hi @walterddr, I addressed most of your comments. Feel free to have another look. ---

[GitHub] flink pull request #:

2018-03-27 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/commit/3a61ea47922280e15f462ca3cdc0c367047bde24#commitcomment-28293221 @twalthr I think this broke the build. At least locally, I get a RAT license failure. ``` 1 Unknown Licenses ***

[jira] [Commented] (FLINK-8910) Introduce automated end-to-end test for local recovery (including sticky scheduling)

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415806#comment-16415806 ] ASF GitHub Bot commented on FLINK-8910: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #5676: [FLINK-8910][tests] Automated end-to-end test for ...

2018-03-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5676#discussion_r177468202 --- Diff: flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java --- @@ -0,0 +1,451 @@ +/*

[jira] [Assigned] (FLINK-8980) End-to-end test: BucketingSink

2018-03-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-8980: --- Assignee: Timo Walther (was: Florian Schmidt) > End-to-end test: BucketingSink > ---

[GitHub] flink pull request #5755: [FLINK-8740] [metrics] Create new JobManagerJobMet...

2018-03-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5755#discussion_r177466102 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobManagerJobMetricGroupFactory.java --- @@ -0,0 +1,46 @@

[jira] [Commented] (FLINK-8740) Job-level metrics lost during job re-submission in HA mode

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415799#comment-16415799 ] ASF GitHub Bot commented on FLINK-8740: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-8740) Job-level metrics lost during job re-submission in HA mode

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415794#comment-16415794 ] ASF GitHub Bot commented on FLINK-8740: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #5755: [FLINK-8740] [metrics] Create new JobManagerJobMetricGrou...

2018-03-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5755 @zentol, I've addressed your comments and updated the PR accordingly. ---

[jira] [Updated] (FLINK-8968) Fix native resource leak caused by ReadOptions

2018-03-27 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-8968: -- Priority: Blocker (was: Major) > Fix native resource leak caused by ReadOptions >

[jira] [Commented] (FLINK-9064) Add Scaladocs link to documentation

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415789#comment-16415789 ] ASF GitHub Bot commented on FLINK-9064: --- Github user yanghua commented on the issue:

[GitHub] flink issue #5773: [FLINK-9064] Add Scaladocs link to documentation

2018-03-27 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5773 cc @tillrohrmann , it seems the travis build failed is not unrelated with this PR's change. ---

[jira] [Closed] (FLINK-9062) As the Chinese government closed its visit to Google(GFW),the drop-down menu about document on the home page (https://flink.apache.org/) doesn't work .

2018-03-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-9062. --- Resolution: Fixed > As the Chinese government closed its visit to Google(GFW),the drop-down menu > ab

[jira] [Commented] (FLINK-9062) As the Chinese government closed its visit to Google(GFW),the drop-down menu about document on the home page (https://flink.apache.org/) doesn't work .

2018-03-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415786#comment-16415786 ] Timo Walther commented on FLINK-9062: - Fixed in flink-web: f0107ae87834f40a2a9ce025df6

[jira] [Commented] (FLINK-8335) Upgrade hbase connector dependency to 1.4.1

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415784#comment-16415784 ] ASF GitHub Bot commented on FLINK-8335: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5488: [FLINK-8335] [hbase] Upgrade hbase connector dependency t...

2018-03-27 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5488 @zhangminglei You are right, the dependencies should have been excluded back then. But better to fix later than never ;-) For the dependencies to exclude, it is hard to find that out. I w

[jira] [Assigned] (FLINK-9062) As the Chinese government closed its visit to Google(GFW),the drop-down menu about document on the home page (https://flink.apache.org/) doesn't work .

2018-03-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-9062: --- Assignee: Timo Walther > As the Chinese government closed its visit to Google(GFW),the drop-d

[jira] [Resolved] (FLINK-9093) If Google can't be accessed,the document can't be use

2018-03-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-9093. - Resolution: Fixed Fix Version/s: 1.3.4 1.4.3 1.5.0 Fi

[jira] [Commented] (FLINK-8335) Upgrade hbase connector dependency to 1.4.1

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415740#comment-16415740 ] ASF GitHub Bot commented on FLINK-8335: --- Github user greghogan commented on the issu

[GitHub] flink issue #5488: [FLINK-8335] [hbase] Upgrade hbase connector dependency t...

2018-03-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5488 I haven't looked at the changelog but HBase 1.4.2 was released a few weeks ago. ---

[jira] [Commented] (FLINK-9093) If Google can't be accessed,the document can't be use

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415729#comment-16415729 ] ASF GitHub Bot commented on FLINK-9093: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5770: [FLINK-9093][document] add a backup js,in case of ...

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5770 ---

[jira] [Commented] (FLINK-8415) Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415692#comment-16415692 ] ASF GitHub Bot commented on FLINK-8415: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #5724: [FLINK-8415] Unprotected access to recordsToSend in LongR...

2018-03-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5724 Changes look good to me @yanghua. Merging this PR. ---

[jira] [Commented] (FLINK-9093) If Google can't be accessed,the document can't be use

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415684#comment-16415684 ] ASF GitHub Bot commented on FLINK-9093: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8941) SpanningRecordSerializationTest fails on Travis

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415688#comment-16415688 ] ASF GitHub Bot commented on FLINK-8941: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #5709: [FLINK-8941][network][serializer] improve SpanningRecordS...

2018-03-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5709 Alright. Thanks for your contribution @NicoK and the review @pnowojski. Merging this PR. ---

[GitHub] flink issue #5770: [FLINK-9093][document] add a backup js,in case of can't a...

2018-03-27 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5770 Thank you @Matrix42. I will merge this to the recent release branches. ---

[jira] [Resolved] (FLINK-9067) End-to-end test: Stream SQL query with failure and retry

2018-03-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-9067. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in 1.6.0: 6c37b15721af3a84fb3ac0de14486a9e9843

[jira] [Commented] (FLINK-8740) Job-level metrics lost during job re-submission in HA mode

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415665#comment-16415665 ] ASF GitHub Bot commented on FLINK-8740: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5755: [FLINK-8740] [metrics] Create new JobManagerJobMet...

2018-03-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5755#discussion_r177436964 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobManagerJobMetricGroupFactory.java --- @@ -0,0 +1,46 @@ +/*

[jira] [Commented] (FLINK-8973) End-to-end test: Run general purpose job with failures in standalone mode

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415664#comment-16415664 ] ASF GitHub Bot commented on FLINK-8973: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #5750: [FLINK-8973] [E2E] HA end-to-end test with StateMa...

2018-03-27 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5750#discussion_r177436350 --- Diff: flink-end-to-end-tests/test-scripts/common.sh --- @@ -59,9 +162,42 @@ function start_cluster { done } +function jm_watchdog() {

[jira] [Commented] (FLINK-9067) End-to-end test: Stream SQL query with failure and retry

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415657#comment-16415657 ] ASF GitHub Bot commented on FLINK-9067: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5759: [FLINK-9067] [e2eTests] Add StreamSQLTestProgram a...

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5759 ---

[jira] [Commented] (FLINK-8740) Job-level metrics lost during job re-submission in HA mode

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415655#comment-16415655 ] ASF GitHub Bot commented on FLINK-8740: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-9067) End-to-end test: Stream SQL query with failure and retry

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415653#comment-16415653 ] ASF GitHub Bot commented on FLINK-9067: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #5755: [FLINK-8740] [metrics] Create new JobManagerJobMet...

2018-03-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5755#discussion_r17742 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobManagerJobMetricGroupFactory.java --- @@ -0,0 +1,46 @@

[GitHub] flink pull request #5759: [FLINK-9067] [e2eTests] Add StreamSQLTestProgram a...

2018-03-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5759#discussion_r177433238 --- Diff: flink-end-to-end-tests/test-scripts/test_streaming_sql.sh --- @@ -0,0 +1,43 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...

2018-03-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5775 [FLINK-9099] Assign Execution to LogicalSlot when slot is assigned to Execution ## What is the purpose of the change In order to fail fast if an allocated slot is released by the SlotP

[jira] [Commented] (FLINK-9099) Failing allocated slots not noticed

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415640#comment-16415640 ] ASF GitHub Bot commented on FLINK-9099: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-9070) Improve performance of RocksDBMapState.clear()

2018-03-27 Thread Truong Duc Kien (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415609#comment-16415609 ] Truong Duc Kien commented on FLINK-9070: So here's my idea for RocksDBMapState.cle

[jira] [Commented] (FLINK-9067) End-to-end test: Stream SQL query with failure and retry

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415583#comment-16415583 ] ASF GitHub Bot commented on FLINK-9067: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-9067) End-to-end test: Stream SQL query with failure and retry

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415581#comment-16415581 ] ASF GitHub Bot commented on FLINK-9067: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-9067) End-to-end test: Stream SQL query with failure and retry

2018-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415582#comment-16415582 ] ASF GitHub Bot commented on FLINK-9067: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #5759: [FLINK-9067] [e2eTests] Add StreamSQLTestProgram a...

2018-03-27 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5759#discussion_r177416467 --- Diff: flink-end-to-end-tests/test-scripts/test_streaming_sql.sh --- @@ -0,0 +1,43 @@ +#!/usr/bin/env bash +##

[GitHub] flink pull request #5759: [FLINK-9067] [e2eTests] Add StreamSQLTestProgram a...

2018-03-27 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5759#discussion_r177416632 --- Diff: flink-end-to-end-tests/flink-stream-sql-test/pom.xml --- @@ -0,0 +1,126 @@ + + +http://maven.apache.org/POM/4.0.0"; +xml

  1   2   >