[GitHub] [lucene-solr] dweiss commented on pull request #1721: LUCENE-9439: match region highlighter components

2020-08-12 Thread GitBox
dweiss commented on pull request #1721: URL: https://github.com/apache/lucene-solr/pull/1721#issuecomment-673296232 I will split the original issue into two - one adjusting Matches API slightly and the other with highlighter components on top of that API; I'll provide some more high-level

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

2020-08-12 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176793#comment-17176793 ] Gautam Worah commented on LUCENE-9450: -- Thanks for reviewing the PR. Based on feed

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-08-12 Thread GitBox
gautamworah96 commented on a change in pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r469727743 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -323,8 +323,10 @@ public Face

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1743: Gradual naming convention enforcement.

2020-08-12 Thread GitBox
dweiss commented on a change in pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#discussion_r469724935 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/VerifyTestClassNamingConvention.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the A

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1743: Gradual naming convention enforcement.

2020-08-12 Thread GitBox
dweiss commented on a change in pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#discussion_r469724710 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/VerifyTestClassNamingConvention.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the A

[GitHub] [lucene-solr] dweiss commented on pull request #1721: LUCENE-9439: match region highlighter components

2020-08-12 Thread GitBox
dweiss commented on pull request #1721: URL: https://github.com/apache/lucene-solr/pull/1721#issuecomment-673287936 I think it's best explained by looking at the code, David. It's really tiny. Take a look at the tests and then dig into the class that retrieves offsets from matches - the re

[jira] [Commented] (SOLR-14702) Remove Master and Slave from Code Base and Docs

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176780#comment-17176780 ] David Smiley commented on SOLR-14702: - Thanks everyone! I'm late to the comment part

[jira] [Comment Edited] (SOLR-14730) Build new SolrJ APIs without concrete classes like NamedList/Map

2020-08-12 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176777#comment-17176777 ] Noble Paul edited comment on SOLR-14730 at 8/13/20, 5:51 AM: -

[jira] [Commented] (SOLR-14730) Build new SolrJ APIs without concrete classes like NamedList/Map

2020-08-12 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176777#comment-17176777 ] Noble Paul commented on SOLR-14730: --- This API will live side-by-side with the existing

[jira] [Commented] (SOLR-14730) Build new SolrJ APIs without concrete classes like NamedList/Map

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176775#comment-17176775 ] David Smiley commented on SOLR-14730: - I assume 9x only due to API breaks? Is this m

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2020-08-12 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176774#comment-17176774 ] Atri Sharma commented on SOLR-13350: I have been bringing this up to date and fixing

[GitHub] [lucene-solr] dsmiley commented on pull request #1721: LUCENE-9439: match region highlighter components

2020-08-12 Thread GitBox
dsmiley commented on pull request #1721: URL: https://github.com/apache/lucene-solr/pull/1721#issuecomment-673267859 Can a description be posted somewhere (e.g. description of this PR; it's blank) describing this highlighter? I specifically wonder how it positions itself relative to the o

[jira] [Commented] (SOLR-14687) Make child/parent query parsers natively aware of _nest_path_

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176768#comment-17176768 ] David Smiley commented on SOLR-14687: - I'm glad to see you are tackling this, Hoss!

[GitHub] [lucene-solr] atris commented on pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-12 Thread GitBox
atris commented on pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-673261051 @madrob Any further thoughts on this? This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (LUCENE-9373) Allow FunctionMatchQuery to customize matchCost of TwoPhaseIterator

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9373: - Attachment: LUCENE-9373.patch Assignee: David Smiley Status: Open (was: Open) > A

[jira] [Commented] (SOLR-14712) Standardize internal Solr-to-Solr RPC API

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176763#comment-17176763 ] David Smiley commented on SOLR-14712: - The to-be-replaced with is gorgeous! Thanks No

[jira] [Updated] (SOLR-14712) Standardize internal Solr-to-Solr RPC API

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14712: Summary: Standardize internal Solr-to-Solr RPC API (was: Standardize RPC calls in Solr) > Standar

[jira] [Comment Edited] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-12 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176231#comment-17176231 ] Mark Robert Miller edited comment on SOLR-14636 at 8/13/20, 4:58 AM: --

[jira] [Commented] (LUCENE-9373) Allow FunctionMatchQuery to customize matchCost of TwoPhaseIterator

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176757#comment-17176757 ] David Smiley commented on LUCENE-9373: -- Thanks for the patch [~Maxim Glazkov] !  I

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176750#comment-17176750 ] ASF subversion and git services commented on SOLR-14680: Commit 0

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176746#comment-17176746 ] ASF subversion and git services commented on SOLR-14680: Commit 8

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176747#comment-17176747 ] ASF subversion and git services commented on SOLR-14680: Commit 3

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176742#comment-17176742 ] ASF subversion and git services commented on SOLR-14680: Commit d

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176743#comment-17176743 ] ASF subversion and git services commented on SOLR-14680: Commit f

[jira] [Updated] (SOLR-14712) Standardize RPC calls in Solr

2020-08-12 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14712: -- Labels: clean-api (was: ) > Standardize RPC calls in Solr > - > >

[GitHub] [lucene-solr] noblepaul merged pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-12 Thread GitBox
noblepaul merged pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176735#comment-17176735 ] David Smiley commented on LUCENE-8776: -- I really like the relatively new offset ord

[jira] [Resolved] (SOLR-14748) Correct SSL/Auth startup warning

2020-08-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14748. Fix Version/s: 8.7 master (9.0) Resolution: Fixed > Correct SSL/A

[jira] [Commented] (SOLR-14748) Correct SSL/Auth startup warning

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176732#comment-17176732 ] ASF subversion and git services commented on SOLR-14748: Commit 5

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-12 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176729#comment-17176729 ] Mark Robert Miller commented on SOLR-14636: --- Thanks [~ichattopadhyaya], you hav

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-12 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176702#comment-17176702 ] Mark Robert Miller commented on SOLR-14636: --- Sorry about that delay - I didn’t

[jira] [Commented] (SOLR-14687) Make child/parent query parsers natively aware of _nest_path_

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176681#comment-17176681 ] ASF subversion and git services commented on SOLR-14687: Commit 3

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176680#comment-17176680 ] ASF subversion and git services commented on SOLR-14383: Commit 3

[GitHub] [lucene-solr] anshumg commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class

2020-08-12 Thread GitBox
anshumg commented on pull request #1744: URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-673180596 The annotation usage is correct, however I haven't taken a look at the code itself to validate if it's meant to be single threaded or not. Perhaps other folks who've been in

[jira] [Commented] (SOLR-5986) Don't allow runaway queries from harming Solr cluster health or search performance

2020-08-12 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176669#comment-17176669 ] Anshum Gupta commented on SOLR-5986: Not at the time. I think there was some value tha

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-12 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176664#comment-17176664 ] Mark Robert Miller commented on SOLR-14636: --- Hey [~markus17], I was hoping to h

[jira] [Commented] (SOLR-14748) Correct SSL/Auth startup warning

2020-08-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176638#comment-17176638 ] ASF subversion and git services commented on SOLR-14748: Commit a

[jira] [Resolved] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-12 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-13412. --- Resolution: Won't Fix After discussion, adding a pre-packaged Luke app with Solr isn't a good

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-12 Thread GitBox
mayya-sharipova commented on pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#issuecomment-673129734 @jimczi Thank you for the initial feedback. I tried to address it, can you please continue the review -

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-12 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469568119 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringDocLeafComparator.java ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apac

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-12 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469566632 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldValueHitQueue.java ## @@ -121,7 +121,7 @@ protected boolean lessThan(final En

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-12 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469565524 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ## @@ -68,10 +68,12 @@ public int compareValues(T f

[jira] [Commented] (LUCENE-9457) Why is Kuromoji tokenization throughput bimodal?

2020-08-12 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176609#comment-17176609 ] Michael McCandless commented on LUCENE-9457: {quote}It's one of those things

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1743: Gradual naming convention enforcement.

2020-08-12 Thread GitBox
mikemccand commented on a change in pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#discussion_r469551162 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/VerifyTestClassNamingConvention.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to t

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-12 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176607#comment-17176607 ] Michael McCandless commented on LUCENE-8626: Ahh thanks [~dweiss], yeah +1 f

[GitHub] [lucene-solr] mikemccand commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-12 Thread GitBox
mikemccand commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-673112665 Awesome, thanks @s1monw! I will try to have a look soon. I kicked off beasting of all Lucene (core + modules) tests with this change ... no failures yet after 31 iterat

[jira] [Commented] (SOLR-5986) Don't allow runaway queries from harming Solr cluster health or search performance

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176591#comment-17176591 ] David Smiley commented on SOLR-5986: [~anshum] did you consider _removing_ Solr's use

[jira] [Commented] (LUCENE-8319) A Time-limiting collector that works with CollectorManagers

2020-08-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176585#comment-17176585 ] David Smiley commented on LUCENE-8319: -- Note that there is also ExitableDirectoryRe

[GitHub] [lucene-solr] s1monw commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-12 Thread GitBox
s1monw commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-673088302 @mikemccand @msokolov @msfroh I pushed a new and slightly more complex but afaik correct approach to do the merge during getReader. Would be great to get some feedback. I thi

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-12 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176578#comment-17176578 ] Dawid Weiss commented on LUCENE-8626: - bq. 1) do the renaming at once I pushed the

[jira] [Commented] (LUCENE-9457) Why is Kuromoji tokenization throughput bimodal?

2020-08-12 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176574#comment-17176574 ] Dawid Weiss commented on LUCENE-9457: - It's one of those things that are exciting to

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

2020-08-12 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176561#comment-17176561 ] Gautam Worah commented on LUCENE-9450: -- Thanks for the feedback [~mikemccand] ! Un

[jira] [Commented] (LUCENE-9457) Why is Kuromoji tokenization throughput bimodal?

2020-08-12 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176559#comment-17176559 ] Michael McCandless commented on LUCENE-9457: Yeah that is one possible theor

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-12 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176557#comment-17176557 ] Michael McCandless commented on LUCENE-8626: {quote}I'm myself more of a suf

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-12 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176555#comment-17176555 ] Dawid Weiss commented on LUCENE-9439: - It does, doesn't it? I am in favor of your su

[jira] [Commented] (LUCENE-9447) Make BEST_COMPRESSION compress more aggressively?

2020-08-12 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176554#comment-17176554 ] Michael McCandless commented on LUCENE-9447: +1 to simply switch to bigger d

[jira] [Created] (SOLR-14748) Correct SSL/Auth startup warning

2020-08-12 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-14748: -- Summary: Correct SSL/Auth startup warning Key: SOLR-14748 URL: https://issues.apache.org/jira/browse/SOLR-14748 Project: Solr Issue Type: Improvement

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-12 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r469455229 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-12 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r469455229 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-12 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r469452206 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-12 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r469449162 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-12 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176524#comment-17176524 ] Roman commented on LUCENE-8776: --- [~simonw] no doubt that the decisions are not always easy

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-12 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r469447213 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[jira] [Deleted] (SOLR-14745) CLONE - Hannah Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14745: > CLONE - Hannah Zacharski > > > Key: SOLR-14

[jira] [Deleted] (SOLR-14747) CLONE - Michael Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14747: > CLONE - Michael Zacharski > - > > Key: SOLR-

[jira] [Deleted] (SOLR-14746) Michael Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14746: > Michael Zacharski > - > > Key: SOLR-14746 >

[jira] [Deleted] (SOLR-14744) Hannah Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14744: > Hannah Zacharski > > > Key: SOLR-14744 >

[jira] [Commented] (SOLR-10317) Solr Nightly Benchmarks

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176507#comment-17176507 ] Ishan Chattopadhyaya commented on SOLR-10317: - bq. Ishan ChattopadhyayaDavid

[jira] [Commented] (SOLR-10317) Solr Nightly Benchmarks

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176506#comment-17176506 ] Ishan Chattopadhyaya commented on SOLR-10317: - Thanks for the feedback, [~mdr

[jira] [Updated] (SOLR-14747) CLONE - Michael Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14747: -- Description: Hannah Slaughter Zacharski > CLONE - Michael Zacharski > -

[jira] [Updated] (SOLR-14746) Michael Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14746: -- Description: Hannah Slaughter Zacharski > Michael Zacharski > -

[jira] [Updated] (SOLR-14747) CLONE - Michael Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14747: -- Attachment: 992CAFDB-165C-45BC-8F43-67450A77AE3E.jpeg > CLONE - Michael

[jira] [Updated] (SOLR-14746) Michael Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14746: -- Attachment: 5677B1CD-335A-4883-A97F-A1D8EE26CC17.jpeg > Michael Zachars

[jira] [Created] (SOLR-14747) CLONE - Michael Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14747: - Summary: CLONE - Michael Zacharski Key: SOLR-14747 URL: https://issues.apache.org/jira/browse/SOLR-14747 Project: Solr Issue Type:

[jira] [Created] (SOLR-14746) Michael Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14746: - Summary: Michael Zacharski Key: SOLR-14746 URL: https://issues.apache.org/jira/browse/SOLR-14746 Project: Solr Issue Type: Wish

[jira] [Commented] (SOLR-10317) Solr Nightly Benchmarks

2020-08-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176504#comment-17176504 ] Mike Drob commented on SOLR-10317: -- Ishan, I tried to use the benchmarking framework yo

[jira] [Updated] (SOLR-14745) CLONE - Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14745: -- Attachment: 08C5783A-84BE-4AFC-BC36-F71D844CCB91.jpeg Status: Op

[jira] [Updated] (SOLR-14745) CLONE - Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14745: -- Attachment: 08292BE4-FC7D-46DE-9918-05DBDDA49EC5.tiff Status: Op

[jira] [Updated] (SOLR-14745) CLONE - Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14745: -- Attachment: 272C4C18-0404-43FA-8FBF-1C60A67E6CAB.jpeg Fix

[jira] [Updated] (SOLR-14745) CLONE - Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14745: -- Attachment: D2A3C4E2-516F-48D4-A1DE-2F58D9DA7220.jpeg Status: Op

[jira] [Updated] (SOLR-14744) Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14744: -- Labels: LeaderElector (was: LeaderElector l) > Hannah Zacharski >

[jira] [Updated] (SOLR-14744) Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14744: -- Labels: LeaderElector l (was: ) > Hannah Zacharski >

[jira] [Created] (SOLR-14745) CLONE - Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14745: - Summary: CLONE - Hannah Zacharski Key: SOLR-14745 URL: https://issues.apache.org/jira/browse/SOLR-14745 Project: Solr Issue Type: W

[jira] [Updated] (SOLR-14744) Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hannah Slaughter Zacharski updated SOLR-14744: -- Attachment: BF53BDD5-3F2A-4CA4-8EC0-5B92A8582E9B.jpeg > Hannah Zacharsk

[jira] [Created] (SOLR-14744) Hannah Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14744: - Summary: Hannah Zacharski Key: SOLR-14744 URL: https://issues.apache.org/jira/browse/SOLR-14744 Project: Solr Issue Type: Wish

[jira] [Deleted] (SOLR-14742) Katarzyna Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14742: > Katarzyna Zacharski > --- > > Key: SOLR-14742 >

[jira] [Deleted] (SOLR-14741) CLONE - Boone Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14741: > CLONE - Boone Zacharski > --- > > Key: SOLR-1474

[jira] [Deleted] (SOLR-14743) CLONE - Katarzyna Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14743: > CLONE - Katarzyna Zacharski > --- > > Key: S

[jira] [Deleted] (SOLR-14740) Boone Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14740: > Boone Zacharski > --- > > Key: SOLR-14740 >

[jira] [Resolved] (SOLR-14151) Make schema components load from packages

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-14151. - Fix Version/s: 8.7 Resolution: Fixed > Make schema components load from pa

[jira] [Comment Edited] (SOLR-14597) Advanced Query Parser

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176494#comment-17176494 ] Ishan Chattopadhyaya edited comment on SOLR-14597 at 8/12/20, 5:14 PM:

[jira] [Created] (SOLR-14743) CLONE - Katarzyna Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14743: - Summary: CLONE - Katarzyna Zacharski Key: SOLR-14743 URL: https://issues.apache.org/jira/browse/SOLR-14743 Project: Solr Issue Type

[jira] [Created] (SOLR-14742) Katarzyna Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14742: - Summary: Katarzyna Zacharski Key: SOLR-14742 URL: https://issues.apache.org/jira/browse/SOLR-14742 Project: Solr Issue Type: Wish

[jira] [Commented] (SOLR-14597) Advanced Query Parser

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176494#comment-17176494 ] Ishan Chattopadhyaya commented on SOLR-14597: - I think we should build separa

[jira] [Created] (SOLR-14741) CLONE - Boone Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14741: - Summary: CLONE - Boone Zacharski Key: SOLR-14741 URL: https://issues.apache.org/jira/browse/SOLR-14741 Project: Solr Issue Type: Wi

[jira] [Created] (SOLR-14740) Boone Zacharski

2020-08-12 Thread Hannah Slaughter Zacharski (Jira)
Hannah Slaughter Zacharski created SOLR-14740: - Summary: Boone Zacharski Key: SOLR-14740 URL: https://issues.apache.org/jira/browse/SOLR-14740 Project: Solr Issue Type: Wish

[jira] [Deleted] (SOLR-14739) CLONE - Lena Slaughter

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14739: > CLONE - Lena Slaughter > -- > > Key: SOLR-14739

[jira] [Deleted] (SOLR-14732) Lena Slaughter

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14732: > Lena Slaughter > -- > > Key: SOLR-14732 >

[jira] [Deleted] (SOLR-14737) Michael Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14737: > Michael Zacharski > - > > Key: SOLR-14737 >

[jira] [Deleted] (SOLR-14738) CLONE - Mosby Zacharski

2020-08-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya deleted SOLR-14738: > CLONE - Mosby Zacharski > --- > > Key: SOLR-1473

  1   2   >