showuon commented on code in PR #14355:
URL: https://github.com/apache/kafka/pull/14355#discussion_r1333917895
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -0,0 +1,790 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
[
https://issues.apache.org/jira/browse/KAFKA-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767850#comment-17767850
]
Francois Visconte commented on KAFKA-15414:
---
[~showuon] It's working now with
showuon commented on code in PR #14355:
URL: https://github.com/apache/kafka/pull/14355#discussion_r1333901289
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -0,0 +1,790 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767818#comment-17767818
]
Luke Chen commented on KAFKA-15481:
---
Thanks for the suggestion! [~ben.manes]!
> Concu
github-actions[bot] commented on PR #13315:
URL: https://github.com/apache/kafka/pull/13315#issuecomment-1730754906
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
kamalcph commented on PR #14407:
URL: https://github.com/apache/kafka/pull/14407#issuecomment-1730747471
@clolov @divijvaidya @showuon @satishd
Test failures are unrelated. Please take another look!
--
This is an automated message from the Apache Git Service.
To respond to the mess
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1333739561
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##
@@ -141,11 +77,25 @@ public T addAndGet(final
CompletableApplicati
jolshan commented on PR #14422:
URL: https://github.com/apache/kafka/pull/14422#issuecomment-1730508946
Looks like we broke the callback timing test, but the tests otherwise looked
better. I will rerun
--
This is an automated message from the Apache Git Service.
To respond to the message,
CalvinConfluent commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1333694211
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apach
kirktrue commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333675817
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberAssignmentReconciler.java:
##
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Foun
cmccabe commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1333666762
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -1028,6 +1028,10 @@ class ControllerApis(
def handleDescribeCluster(request: RequestChannel.Request):
cmccabe commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1333666076
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4009,12 +4134,11 @@ void handleFailure(Throwable throwable) {
@Override
kirktrue commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333659148
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableBackgroundEvent.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Softwar
kirktrue commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333657687
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -237,4 +253,64 @@ public void
updateAssignment(ConsumerGroupHea
kirktrue commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333654590
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberAssignmentReconciler.java:
##
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Foun
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1333629206
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,287 @@
+/*
+ * Licensed to the Apache Software Foundati
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333628852
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -237,4 +253,64 @@ public void
updateAssignment(ConsumerGroupHear
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1333624789
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java:
##
@@ -79,6 +80,9 @@ public int hashCode() {
@Override
public S
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1333624789
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java:
##
@@ -79,6 +80,9 @@ public int hashCode() {
@Override
public S
jeffkbkim commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1333554676
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -523,9 +526,63 @@ public
CompletableFuture> groupsByTopicPa
lianetm commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1333620613
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##
@@ -141,11 +77,25 @@ public T addAndGet(final
CompletableApplication
lianetm commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1333617066
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegate.
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1333616692
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegat
lianetm commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1333613388
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -217,29 +98,33 @@ public void run() {
}
}
lianetm commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1333605133
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -16,197 +16,78 @@
*/
package org.apache.kafka.clients.consum
lianetm commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1333599432
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -16,197 +16,78 @@
*/
package org.apache.kafka.clients.consum
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333583458
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -237,4 +253,64 @@ public void
updateAssignment(ConsumerGroupHear
tooptoop4 commented on PR #14192:
URL: https://github.com/apache/kafka/pull/14192#issuecomment-1730273682
đŸ¦—
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
lianetm commented on PR #14413:
URL: https://github.com/apache/kafka/pull/14413#issuecomment-1730248257
Thanks for the review @kirktrue! All comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rreddy-22 commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r199585
##
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala:
##
@@ -283,7 +292,61 @@ class CoordinatorLoaderImplTest {
minOneMessage
rreddy-22 commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1333554128
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
rreddy-22 commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1333553371
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
rreddy-22 commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1333553371
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
rreddy-22 commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r1333546302
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -14,43 +14,62 @@
* See the License for the specific language governing pe
CalvinConfluent commented on code in PR #14053:
URL: https://github.com/apache/kafka/pull/14053#discussion_r1333490449
##
core/src/main/scala/kafka/cluster/Replica.scala:
##
@@ -98,14 +103,20 @@ class Replica(val brokerId: Int, val topicPartition:
TopicPartition) extends Log
[
https://issues.apache.org/jira/browse/KAFKA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767689#comment-17767689
]
ASF GitHub Bot commented on KAFKA-15483:
mumrah commented on PR #548:
URL: https
mumrah commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1333463150
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4009,12 +4134,11 @@ void handleFailure(Throwable throwable) {
@Override
dajac opened a new pull request, #14422:
URL: https://github.com/apache/kafka/pull/14422
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
rreddy-22 commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1333402026
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
rreddy-22 commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1333402026
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
rreddy-22 commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r199585
##
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala:
##
@@ -283,7 +292,61 @@ class CoordinatorLoaderImplTest {
minOneMessage
[
https://issues.apache.org/jira/browse/KAFKA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767651#comment-17767651
]
ASF GitHub Bot commented on KAFKA-15483:
satishd commented on PR #548:
URL: http
[
https://issues.apache.org/jira/browse/KAFKA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767650#comment-17767650
]
ASF GitHub Bot commented on KAFKA-15483:
satishd commented on code in PR #548:
U
lihaosky closed pull request #13846: KAFKA-15022: [1/N] add configs to control
rack aware assignment
URL: https://github.com/apache/kafka/pull/13846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767645#comment-17767645
]
Ben Manes commented on KAFKA-15481:
---
Excellent investigation! You are correct, using a
divijvaidya commented on PR #14419:
URL: https://github.com/apache/kafka/pull/14419#issuecomment-1729951729
> @divijvaidya Don't forget to do this same change under `kafka-site` as
well.
Thank you for the reminder. TBH I had forgot about it đŸ˜³
Created the PR at https://github.c
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r155626
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Softwar
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r153596
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -79,6 +100,7 @@ public void
clearBufferedDataForUnassignedPartitions(Collect
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r153029
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Goyal reassigned KAFKA-15169:
---
Assignee: Arpit Goyal (was: Lan Ding)
> Add tests for RemoteIndexCache
> -
[
https://issues.apache.org/jira/browse/KAFKA-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767639#comment-17767639
]
Arpit Goyal commented on KAFKA-15169:
-
[~divijvaidya] [~isding_l] [~satish.duggana]
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r149057
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ErrorEventHandler.java:
##
@@ -22,13 +22,18 @@
import java.util.Queue;
public class ErrorEven
rreddy-22 commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r148886
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -90,4 +90,29 @@ void validateOffsetFetch(
int memberEpoch,
l
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r145949
##
checkstyle/import-control.xml:
##
@@ -205,6 +205,10 @@
+
Review Comment:
is the extra line intentional?
--
This is an automated message fro
Ritika Muduganti created KAFKA-15484:
Summary: Implement general uniform broker side assignor
Key: KAFKA-15484
URL: https://issues.apache.org/jira/browse/KAFKA-15484
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-14515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritika Muduganti updated KAFKA-14515:
-
Summary: Implement optimized uniform broker side assignor (was: Implement
uniform broke
[
https://issues.apache.org/jira/browse/KAFKA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-15483:
--
Assignee: David Arthur
> Update metrics documentation for the new metrics implemented
[
https://issues.apache.org/jira/browse/KAFKA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767638#comment-17767638
]
Satish Duggana commented on KAFKA-15483:
[~mumrah] Assigning it to you as you ra
rreddy-22 commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r131492
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -849,6 +853,46 @@ public void validateOffsetFetch(
}
rreddy-22 commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r129945
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -262,6 +267,45 @@ public HeartbeatResponseData genericGroupHea
rreddy-22 commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r127696
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -90,4 +90,29 @@ void validateOffsetFetch(
int memberEpoch,
l
rreddy-22 commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r127696
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -90,4 +90,29 @@ void validateOffsetFetch(
int memberEpoch,
l
rreddy-22 commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r126880
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -90,4 +90,29 @@ void validateOffsetFetch(
int memberEpoch,
l
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r124044
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,56 +19,91 @@
import org.apache.kafka.common.message.Consum
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r121553
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,56 +19,91 @@
import org.apache.kafka.common.message.Consum
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r114252
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,56 +19,91 @@
import org.apache.kafka.common.message.Consum
rreddy-22 commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r100713
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -14,43 +14,62 @@
* See the License for the specific language governing pe
rreddy-22 commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r1333298950
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -14,43 +14,62 @@
* See the License for the specific language governing pe
[
https://issues.apache.org/jira/browse/KAFKA-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-14960.
-
Fix Version/s: 3.7.0
Resolution: Fixed
merged the PR to trunk.
> Metadata Request Manager and li
junrao merged PR #14386:
URL: https://github.com/apache/kafka/pull/14386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333212830
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -237,4 +253,64 @@ public void
updateAssignment(ConsumerGroupHear
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333187091
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -237,4 +253,64 @@ public void
updateAssignment(ConsumerGroupHear
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333166590
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -237,4 +253,64 @@ public void
updateAssignment(ConsumerGroupHear
dajac commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1333162337
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -849,6 +853,46 @@ public void validateOffsetFetch(
}
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333144301
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberAssignmentReconciler.java:
##
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Found
jolshan commented on PR #14402:
URL: https://github.com/apache/kafka/pull/14402#issuecomment-1729672777
Maybe we should file a JIRA to investigate. đŸ˜…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mumrah opened a new pull request, #14421:
URL: https://github.com/apache/kafka/pull/14421
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1333122605
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberAssignmentReconciler.java:
##
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Found
Nickstery opened a new pull request, #14420:
URL: https://github.com/apache/kafka/pull/14420
Exception allows the plugin to notify Kafka an API operation in progress was
interrupted as a result of task cancellation, which can happen under changes
such as leadership migration or topic deleti
dajac commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r1333051894
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -14,43 +14,62 @@
* See the License for the specific language governing permis
[ https://issues.apache.org/jira/browse/KAFKA-15417 ]
Victor van den Hoven deleted comment on KAFKA-15417:
--
was (Author: victorvandenhoven):
The before/after for the joinSpuriousLookBackTimeMs in the left/right join node
were flipped i
dajac commented on PR #14402:
URL: https://github.com/apache/kafka/pull/14402#issuecomment-1729476773
@jolshan I just found similar failures in another PR:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14418/1/tests.
That seems to indicate that the issue
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1729435287
Hi Team, can we look into this PR as the KIP-942 has been adopted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
yashmayya commented on code in PR #14412:
URL: https://github.com/apache/kafka/pull/14412#discussion_r1332848023
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilderTest.java:
##
@@ -223,38 +208,9 @@ public void shouldThrowNullPointerIf
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767490#comment-17767490
]
Divij Vaidya commented on KAFKA-15481:
--
[~ben.manes] your expert thoughts on best w
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767489#comment-17767489
]
Divij Vaidya edited comment on KAFKA-15481 at 9/21/23 10:05 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767489#comment-17767489
]
Divij Vaidya commented on KAFKA-15481:
--
> And in `RemoteIndexCache#remove`, we can
[
https://issues.apache.org/jira/browse/KAFKA-15463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767452#comment-17767452
]
Yevgeny edited comment on KAFKA-15463 at 9/21/23 10:00 AM:
---
so
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767487#comment-17767487
]
Divij Vaidya commented on KAFKA-15481:
--
You are right, but you are assuming that re
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767486#comment-17767486
]
Luke Chen commented on KAFKA-15481:
---
After re-reading the suggestion in Caffeine
[doc
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767485#comment-17767485
]
Luke Chen commented on KAFKA-15481:
---
About the solution to change to sync way, I have
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767484#comment-17767484
]
Divij Vaidya commented on KAFKA-15481:
--
> the issue is because we time gap between
divijvaidya commented on code in PR #14412:
URL: https://github.com/apache/kafka/pull/14412#discussion_r1332776819
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilderTest.java:
##
@@ -223,38 +208,9 @@ public void shouldThrowNullPointer
[
https://issues.apache.org/jira/browse/KAFKA-15463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767452#comment-17767452
]
Yevgeny edited comment on KAFKA-15463 at 9/21/23 9:34 AM:
--
some
divijvaidya commented on PR #14419:
URL: https://github.com/apache/kafka/pull/14419#issuecomment-1729209212
Merged into trunk and `3.6`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
divijvaidya merged PR #14419:
URL: https://github.com/apache/kafka/pull/14419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767483#comment-17767483
]
Luke Chen commented on KAFKA-15481:
---
Nice find, [~divijvaidya]! So, the issue is becau
satishd commented on code in PR #14419:
URL: https://github.com/apache/kafka/pull/14419#discussion_r1332742687
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -777,7 +777,7 @@ public class StreamsConfig extends AbstractConfig {
@SuppressWarnings(
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767472#comment-17767472
]
Divij Vaidya commented on KAFKA-15481:
--
FYI [~satishd] [~Kamal C] [~christo_lolov]
[
https://issues.apache.org/jira/browse/KAFKA-15463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767452#comment-17767452
]
Yevgeny edited comment on KAFKA-15463 at 9/21/23 8:52 AM:
--
some
1 - 100 of 113 matches
Mail list logo