Re: Improvements to \offset (issue 15850044)

On 2013/10/23 14:36:41, dak wrote: Fixing the proposal should be all the action needed. OK, new patch set uploaded. https://codereview.appspot.com/15850044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinf

Re: Improvements to \offset (issue 15850044)

https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly#newcode722 ly/music-functions-init.ly:722: (make-music 'Music))) Hmm... Shouldn't the return her

Re: Improvements to \offset (issue 15850044)

On 2013/10/22 14:27:28, david.nalesnik wrote: On 2013/10/22 14:26:10, david.nalesnik wrote: > Please review. Unfortunately, I'm getting the old chunk mismatch error when I attempt to see the side-by-side diffs. Is there a way to correct this without re-uploading the patch set? I went ah

Re: Improvements to \offset (issue 15850044)

On 2013/10/22 14:26:10, david.nalesnik wrote: Please review. Unfortunately, I'm getting the old chunk mismatch error when I attempt to see the side-by-side diffs. Is there a way to correct this without re-uploading the patch set? https://codereview.appspot.com/15850044/ _

Improvements to \offset (issue 15850044)

Reviewers: , Message: Please review. Description: Improvements to \offset Property can be specified with or without #' prefix. Directed tweaks are possible. Regtest: --remove #' prefix before property names --remove unnecessary # before numbers --add example showing directed tweaks Revise do

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/10/20 16:15:56, dak wrote: On 2013/10/20 15:51:57, david.nalesnik wrote: > https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm > File scm/music-functions.scm (right): > > https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm#newcode2118 > scm

Re: Add the command \offset to LilyPond (issue 8647044)

https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm#newcode2118 scm/music-functions.scm:2118: (let* ((immutable (ly:grob-basic-properties grob)) I just noticed so

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

On 2013/10/19 17:56:28, t.daniels_treda.co.uk wrote: From: > https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely#newcode4396 >> Documentation/notation/changing-defaults.itely:4396: >> Should there be a warning about

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely#newcode4362 Documentation/notation/ch

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

On 2013/10/19 09:50:43, Trevor Daniels wrote: LGTM with a couple of nitpicks and a query (although I haven't tried a make doc to check the appearance of the examples). At first I was a little concerned about the explanations in what is supposed to be a _reference_ manual, but in this case I th

Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)

On 2013/10/19 09:00:31, janek wrote: 2013/10/19 : > I cannot review _and_ comment inline, when I click on side-by-sdie diffs > I get 'error chunk mismatch'. Does anyone else? me too. Yes, I also get "error: old chunk mismatch" and this happens to me when I try to view the side-by-sides of

Add documentation for the music function \alterBroken to the NR. (issue 15060044)

Reviewers: , Message: Please review. Description: Add documentation for the music function \alterBroken to the NR. Issue 3458: Document \alterBroken Please review this at https://codereview.appspot.com/15060044/ Affected files (+104, -0 lines): Documentation/notation/changing-defaults.ite

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/10/07 14:10:09, dak wrote: On 2013/10/06 01:15:12, david.nalesnik wrote: > There is a major problem with this patch set which I don't know how to address. > > The examples below represent my efforts to test the effects of multiple > applications of \offset. You can see that some a

Re: Add the command \offset to LilyPond (issue 8647044)

https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly File input/regression/offsets.ly (right): https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly#newcode31 input/regression/offsets.ly:31: On 2013/10/07 14:10:32, dak wrote: Spurious space in ot

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/10/06 06:06:40, lemzwerg wrote: LGTM. Maybe you can somewhere add a sentence like Note that \tweak and friends provide absolute positioning, not relative. to the documentation. It took me a while to recognize the difference. OK--will do. (I just made some changes to the Ri

Re: Add the command \offset to LilyPond (issue 8647044)

https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly File input/regression/offsets.ly (right): https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode5 input/regression/offsets.ly:5: the @code{\\offset} command. These properties are limited t

Re: Add the command \offset to LilyPond (issue 8647044)

https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm File scm/c++.scm (right): https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm#newcode30 scm/c++.scm:30: (every number-pair? x))) On 2013/04/23 20:24:57, dak wrote: Isn't it dangerous to call "every" on something that is not

Fwd: implementing roman numeral harmonic analysis?

**Arghh** This should have gone to -devel in the first place! -- Forwarded message -- From: David Nalesnik Date: Thu, Sep 5, 2013 at 8:09 AM Subject: Fwd: implementing roman numeral harmonic analysis? To: markpole...@yahoo.com, lilypond-user [Janek--sorry about the duplicate

Re: PATCHES: Countdown – August 2nd – 06:00 GMT

&colspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified> > Enhancement > David Nalesnik Push Patch: input/regression/scheme-text-spanner.ly: fix > problem with constants > > > > > I don't

Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)

https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly File input/regression/scheme-text-spanner.ly (right): https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode117 input/regression/scheme-text-spanner.ly:117: (event-drul

Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)

> Instead, complete-grob-entry (or whatever it was > called) > needs to be changed in order to work non-destructively. It does not > make sense to do this separately from the original code. OK, I won't bother yet with add-grob-definition here, but I wonder: if I use copy-tree on a literal expre

Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)

On 2013/07/23 20:16:24, dak wrote: On 2013/07/23 20:05:40, david.nalesnik wrote: > > I hesitate to do something like the following! > > #(add-grob-definition > 'SchemeTextSpanner > (list > (cons > 'bound-details > (list [...] No, that's nonsensical. Instead, complete-grob-

Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)

On 2013/07/23 15:06:51, dak wrote: On 2013/07/23 13:52:13, david.nalesnik wrote: > Sorry, replied a bit hastily! [...] > I've thought some more about the issue of trying to change constants elsewhere > in the file. > > Specifically, regarding the addition of the new grob description to

Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)

On 2013/07/23 13:27:49, dak wrote: On 2013/07/23 13:05:47, david.nalesnik wrote: > On 2013/07/23 12:31:25, dak wrote: > > Frankly, just throw out the crap event-drul and current-event, and instead use > > event-start and event-stop instead of (car event-drul) and (cdr event-drul). > OK, wil

Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)

Thank you, David. https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly File input/regression/scheme-text-spanner.ly (right): https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28 input/regression/scheme-text-spanner.ly

input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)

Reviewers: , Message: Please review. Thanks, David Description: input/regression/scheme-text-spanner.ly: fix problem with constants The file `input/regression/scheme-text-spanner.ly' assigns a constant pair to the variable `event-drul' and subsequently attempts to modify the pair. This can le

Re: adding markup-commands \oval and \ellipse (issue 11427044)

LGTM Thanks for adding these, Harm. https://codereview.appspot.com/11427044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: problem with constants in scheme-text-spanner.ly

On Mon, Jul 22, 2013 at 2:02 PM, David Kastrup wrote: > David Nalesnik writes: > > (set! all-grob-descriptions (sort all-grob-descriptions alist > is perfectly fine since it does not touch the original list. sort! > however would be a problem. > > In a similar vein, comple

Re: problem with constants in scheme-text-spanner.ly

On Mon, Jul 22, 2013 at 12:06 PM, David Kastrup wrote: > David Nalesnik writes: > > > All spanners appear when I replace the variable definition > > (event-drul '(() . ())) > > > > with > > > > (cons (list) (list)) > > > > and later (l

problem with constants in scheme-text-spanner.ly

Hi, Attached is a version of the regression test scheme-text-spanner.ly which shows that problems arise when the engraver is used simultaneously in different contexts. I've smply created a StaffGroup in which both Staff contexts contain the same material as in the original reg test. You can see

Re: Add the command \offset to LilyPond (issue 8647044)

https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm#newcode2103 scm/music-functions.scm:2103: ; head of the alist. We reverse the alist so our search will return O

Re: Add the command \offset to LilyPond (issue 8647044)

David, Thank you for your reviews. It will take me some time to make the changes you propose, so I've changed the status of the patch to "needs work". https://codereview.appspot.com/8647044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/04/23 19:38:09, dak wrote: On 2013/04/23 19:03:18, david.nalesnik wrote: > On 2013/04/23 13:14:23, janek wrote: > > anyway, this patch LTGM. > > Thanks, Janek! > > The patch has passed countdown, but in view of the fact that a stable release is > on the horizon, it may not be appropriat

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/04/23 13:14:23, janek wrote: anyway, this patch LTGM. Thanks, Janek! The patch has passed countdown, but in view of the fact that a stable release is on the horizon, it may not be appropriate to push it at this time. On the other hand, an argument for pushing it right away might be to

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/04/13 21:39:40, janek wrote: There's one thing that puzzles me. Current syntax is \offset property offset-value grob-name I understand that grob-name is at the end because it's optional, and we want to omit it when we're using \offset as a tweak. However, i find this syntax awkwa

Re: Add the command \offset to LilyPond (issue 8647044)

I've considerably shortened the regtests, removing redundancies and unnecessary line breaks. Thanks for the comments! https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly File input/regression/offsets.ly (right): https://codereview.appspot.com/8647044/diff/1/input/regressi

Add the command \offset to LilyPond (issue 8647044)

Reviewers: , Message: Please review. Thanks, David Description: Add the command \offset to LilyPond The ability to offset default values of various properties would be a useful enhancement of LilyPond. Currently, this is possible for the property 'control-points using the \shape command. The

Re: Issue 2924: Doc: \startMeasureCount and \stopMeasureCount needs documenting (issue 7678047)

Thank you all for the reviews! https://codereview.appspot.com/7678047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCHES: Countdown - for March 26th 19:00GMT

l%3APatch-review&sort=modified%20patch&colspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified> > Documentation > David Nalesnik Push Doc: \startMeasureCount and \stopMeasureCount needs > documenting > > > > >

Re: Issue 2924: Doc: \startMeasureCount and \stopMeasureCount needs documenting (issue 7678047)

On 2013/03/17 10:35:40, PhilEHolmes wrote: I've not tested the snippets, but otherwise the patch LGTM. I'm assuming the only files you actually created were the ones in snippets/new/ - the rest came from makelsr and make doc? Yes, exactly. https://codereview.appspot.com/7678047/ __

Re: make doc fails

Julien, On Sat, Mar 16, 2013 at 7:31 PM, Julien Rioux wrote: > On 16/03/2013 6:27 PM, David Nalesnik wrote: > >> /usr/bin/python -tt >> /home/david/lilypond-git/**scripts/build/create-weblinks-**itexi.py > >> out-www/weblinks.itexi >> make[3]: *** No rule to mak

Issue 2924: Doc: \startMeasureCount and \stopMeasureCount needs documenting (issue 7678047)

Reviewers: , Message: Please review. Thanks! David Description: Issue 2924: Doc: \startMeasureCount and \stopMeasureCount needs documenting The following patch is a preliminary step towards documenting the Measure_counter_engraver added in version 2.17.7. The patch consists of two snippets, t

make doc fails

Hi all, I'm attempting to put two snippets dealing with the measure counter up for review, but I'm running into problems when I run make doc. Here's the tail end of the terminal output: make[3]: Entering directory `/home/david/lilypond-git/build/Documentation/cs' /usr/bin/python -tt /home/david/

Re: i'm back - hopefully.

2013/2/12 Janek Warchoł : > > Hi all, > > > > i hope to get back to lilypond hacking now. I miss it a lot... > Welcome back, Janek! --David ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

Harm-- This looks great! Thank you for the 'full-length option. I can't be alone in hating lines ending with incomplete dashes. All I have is a suggestion or two, and some quibbles. Besides what I've pointed out inline, I should mention that I got a number of whitespace errors when I applied

Re: Allows for easier creation of many Lilypond objects via Scheme. (issue 7009047)

On Mon, Dec 24, 2012 at 7:22 AM, m...@mikesolomon.org wrote: > On 24 déc. 2012, at 10:36, d...@gnu.org wrote: > > On 2012/12/24 07:28:17, mike7 wrote: > > On 24 déc. 2012, at 01:10, mailto:d...@gnu.org wrote: > > >> All of this is absolutely devastatingly horrible code that is not >> reconcilable

Re: Aleatoric / modern notation

On Sat, Dec 8, 2012 at 7:21 PM, David Nalesnik wrote: [...] > > Trying to work out the problem, I've done a little rewriting so I'll > include the engraver here. You can just substitute this in the > problematic file. > Well, I did break something. Here's the

Re: Aleatoric / modern notation

On Mon, Dec 10, 2012 at 11:30 PM, David Kastrup wrote: > The behavior is undefined if I remember correctly: an error is not > guaranteed by the standard. I think Guilev2 will produce an error, but > LilyPond is still at Guilev1. OK, thanks! -David _

Re: Aleatoric / modern notation

David, On Sun, Dec 9, 2012 at 12:34 AM, David Kastrup wrote: > David Nalesnik writes: > >> It turns out that the my definition of event-drul as '(() . ()) was >> the problem. I substituted (cons '() '()) and everything works just >> fine...even with

Re: Aleatoric / modern notation

Hi again, On Sat, Dec 8, 2012 at 7:21 AM, David Nalesnik wrote: > Hi Jeffrey, > > I'm copying this to the list since I myself am not sure about something here. > > On Sat, Dec 8, 2012 at 5:13 AM, Jeffrey Trevino > wrote: >> Hi David, >> >> Thank

Re: Aleatoric / modern notation

Hi Jeffrey, I'm copying this to the list since I myself am not sure about something here. On Sat, Dec 8, 2012 at 5:13 AM, Jeffrey Trevino wrote: > Hi David, > > Thanks for revising this more for me. I really appreciate your efforts, and > I will take a look at this asap and write back. For my le

Re: new markup-comand `draw-dashed-line´ was: lilypond-user Digest, Vol 119, Issue 90

Hi Harm, On Thu, Nov 1, 2012 at 9:57 AM, Thomas Morley wrote: > Hi David (N), > > attached my first try. > > If the markup-property full-length is set #t, some calculations ensure > that no space occurs at line-end/begin. Some dashes will only be > partly visible, but I think its ok. > In additi

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

Thank you--I am a bit worried! Speaking of "patch," when I run git format-patch I get six separate patches. Is there any way to compress them into one so this is more convenient for you? -David https://codereview.appspot.com/6730044/ ___ lilypond-de

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

David, I don't mind making the changes, but I'm running into some problems. I used git pull -r before making a patch set and uploading to rietveld, but looking over the patch set there I see that other changes have found their way in--including your check-grob-path function. I'm probably making

Change \alterBroken interface to match that of other tweak/overrides (issue 6784063)

LGTM! Thanks very much for doing this, David. https://codereview.appspot.com/6784063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

On 2012/10/24 20:28:36, janek wrote: On Wed, Oct 24, 2012 at 4:10 PM, wrote: > Also, should we include > > Measure_counter_engraver > > in the Staff context by default? > > (it'd make documenting it simpler in the @lilypond if nothing else :) ) +1 from me :) Janek

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

Thanks for your review, Janek! https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly File input/regression/measure-counter-broken.ly (right): https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly#newcode6 input/regres

Re: problem uploading a patch

Julien, On Wed, Oct 17, 2012 at 9:25 AM, Julien Rioux wrote: > $ git cl issue 0 > > to reset (remove any association to a Rietveld issue) > > $ git cl upload origin/master > > to upload (given that the branch is no longer associated to a Rietveld > issue, it will create a new Rietveld issue) >

Re: problem uploading a patch

David, On Wed, Oct 17, 2012 at 8:04 AM, David Kastrup wrote: > David Nalesnik writes: > >> Julien, >> >> On Wed, Oct 17, 2012 at 1:33 AM, Julien Rioux >> wrote: >>> On 16/10/2012 4:36 PM, David Nalesnik wrote: >>>> >>>> david@d

Issue 2445: Add measure counter to LilyPond (issue 6730044)

Reviewers: , Message: Please review. Thanks! -David Description: Issue 2445: Add measure counter to LilyPond This patch allows the user to number groups of successive measures, which is useful as an aid to the performer in keeping track of repetitions. There is no requirement that the counted

Re: problem uploading a patch

Julien, On Wed, Oct 17, 2012 at 1:33 AM, Julien Rioux wrote: > On 16/10/2012 4:36 PM, David Nalesnik wrote: >> >> david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue >> 2445 >> Issue number: 2445 (http://codereview.appspot.com/2445) > > >

Re: problem uploading a patch

David, On Wed, Oct 17, 2012 at 12:44 AM, David Kastrup wrote: > Try git rebase origin first I tried this, and this is what happened: david@david-desktop ~/lilypond-git (dev/measure_counter)$ git rebase origin fatal: Needed a single revision invalid upstream origin Should I try something like

Re: problem uploading a patch

Hi Phil. > david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445 > Issue number: 2445 (http://codereview.appspot.com/2445) > david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl upload > Unable to determine default branch to diff against. > Either pass complete "g

Re: problem uploading a patch

Hi Phil, On Tue, Oct 16, 2012 at 3:11 PM, Phil Holmes [...] > If you have a record of changes you've made, then I tend to use > >git reset --hard origin/master > which takes you back to the current state of master, and then >git am your.patch > > which applies the patch you have. Follow

problem uploading a patch

Hi, I'm trying to upload a patch created in a branch to Rietveld, but I seem to be creating an unholy mess. I attempted to run git-cl upload master within my branch, but I end up with a huge list of recent commits not my own. The same thing happened when I ran git format-patch master and earlier

Re: Naming _another_ lacking puzzle piece

On Sat, Oct 13, 2012 at 8:29 AM, David Kastrup wrote: [...] > > \override Accidental color = #green > \override Accidental color = #red > \push\override Accidental color = #blue > [...] > \revert Accidental color > > or, if you prefer > \override Accidental color = #green > \override Accidental c

Re: Naming _another_ lacking puzzle piece

On Sat, Oct 13, 2012 at 8:15 AM, David Kastrup wrote: > David Nalesnik writes: >> >> Buildup of unwanted data or no, it would be useful to be able to write >> something like >> >> \toLast Accidental #'color >> >> to restore the previous overri

Re: Naming _another_ lacking puzzle piece

On Sat, Oct 13, 2012 at 6:39 AM, David Kastrup wrote: > "Phil Holmes" writes: > >> Surely this points to the pop operation in \override as being at >> fault? If \override was simply push, rather than pop-push then the >> code above would seem to work as intended. > > Sure. The idea presumably w

Re: Still alive

On Thu, Oct 11, 2012 at 6:11 PM, Valentin Villenave wrote: > On Tue, Oct 9, 2012 at 8:19 AM, m...@mikesolomon.org > wrote: >> Just a quick ping to let you know that I'm not dead - I've been swamped w/ >> work recently and just got engaged so I'm planning out a wedding (w00t!). > Congratulations

Re: [GLISS] turning strings to symbols (was: Issue 2883)

David, On Thu, Oct 11, 2012 at 1:27 PM, David Kastrup wrote: [...] > But the _point_ of the _invasive_ patch and convert-ly rules was to get > feedback about what people think about a language change that > essentially makes it unnecessary for users to write symbols like #'xxx > or to even know

Re: LilyPond 2.17.4 released

On Mon, Oct 8, 2012 at 7:19 AM, Joseph Rushton Wakeling wrote: > - > This version contains work in progress. You will have access to the very > latest features, but some may be incomplete, and you may encounter bugs and > crashes. If you require a stable version of Li

Re: Doc: improve documentation of Bézier curves (2858) (issue 6561064)

LGTM. And thanks again for doing this! -David https://codereview.appspot.com/6561064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: improve documentation of Bézier curves (2858) (issue 6561064)

Trevor-- This looks great to me. I like the reordering, and I think the explanations are very clear. I've tweaked the curves a little in the examples (do what you like with my suggestions!), but otherwise: LGTM. https://codereview.appspot.com/6561064/diff/6001/Documentation/notation/changing

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

On 2012/10/03 15:17:26, dak wrote: [...] and I am currently immersed in parser work to make the Context.GrobName thing fly. Thank you very much for working on this! I am looking forward to being able to fix the mess at the beginning of \alterBroken (and a general offsetting function I hope

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

On 2012/10/03 13:57:25, dak wrote: [...] To those suggestions let me answer with the famous answer to the question "Mr Gandhi, what do you think of Western civilization?", namely with "I would consider it a good idea." Oh, for just one zinger like that... So the best I think I can do at

Allow \shape to tweak music, swap its arguments (issue 6585052)

LGTM https://codereview.appspot.com/6585052/diff/1/input/regression/shape-other-curves.ly File input/regression/shape-other-curves.ly (right): https://codereview.appspot.com/6585052/diff/1/input/regression/shape-other-curves.ly#newcode18 input/regression/shape-other-curves.ly:18: \override Phra

Re: Doc: improve documentation of Bézier curves (2858) (issue 6561064)

Trevor-- Thank you so much for taking this on! I've been pecking at documenting this for awhile, but got hung up on finding the perfect examples... What you have is clearer than what I cam up with. https://codereview.appspot.com/6561064/diff/1/Documentation/notation/changing-defaults.itely Fil

Re: [GLISS] turn xxx.yyy into ("xxx" "yyy")

On Wed, Sep 12, 2012 at 3:38 AM, David Kastrup wrote: [...] > > Basically, if a music function wants to provide a shorthand for an > override, not being able to specify an optional context is a nuisance. > I currently have just the same problem writing a \hide function that is > supposed to be a

Re: installing needed file within LilyDev

Phil, On Sun, Sep 9, 2012 at 10:24 AM, Phil Holmes wrote: > I suspect this might be relevant: > > http://code.google.com/p/lilypond/issues/detail?id=2742 > Piece of cake! Thank you very much, David ___ lilypond-devel mailing list lilypond-devel@gnu.

installing needed file within LilyDev

Hi all, I'm trying to compile the latest master within LilyDev, and I'm running into a problem when I try to prepare the build directory. I get the following error: ERROR: Please install required programs: lh CTAN package (texlive-lang-cyrillic or texlive-texmf-fonts) Can someone give me point

Re: push patch for issue 2679

On Tue, Jul 24, 2012 at 12:57 PM, David Kastrup wrote: > > "Phil Holmes" writes: > > > BTW - apologies for top-posting and that, but my Windows email system > > takes your mails as HTML and does this with them. > > His mails contain HTML and plain text as alternatives, and Gnus (which I > use as

Re: push patch for issue 2679

Phil, On Tue, Jul 24, 2012 at 12:07 PM, Phil Holmes wrote: > ** > Pushed as > f7085cf9b2ff111b7d30c8a59e367c771a7e3c52. > Patchy is now running. > Thank you very much for doing this! -

Re: push patch for issue 2679

On Tue, Jul 24, 2012 at 12:05 PM, David Kastrup wrote: > David Nalesnik writes: > > > Arggh...sorry for making a hash of this :( > > By the way, you aren't. You are dealing with flexible and powerful > tools in action, and keeping up surprisingly well. That's t

Re: push patch for issue 2679

David, On Tue, Jul 24, 2012 at 11:50 AM, David Kastrup wrote: > David Nalesnik writes: > > > On Tue, Jul 24, 2012 at 11:34 AM, Graham Percival > > wrote: > > > > On Tue, Jul 24, 2012 at 05:26:01PM +0100, Phil Holmes wrote: > > > I'd be

Re: push patch for issue 2679

e problems > that you discovered, we can only use it as a reviewing tool, not a > patch management tool. > > David Nalesnik should send you the file he gets from > git format-patch, after he fixed all merge conflicts etc. > Arggh...sorry for making a hash of this :( Hopefu

Re: push patch for issue 2679

> OK, I succeeded in doing this and uploaded a new patch set. I'm going to > redo this now as I see I failed to delete two newlines... > > OK, all should be well now. Patch corrected. -David ___ lilypond-devel mailing list lilypond-devel@gnu.org https:

Re: push patch for issue 2679

David, > > > Is there any reason I can't manually remove the markers for the merge > > conflict, namely the lines: > > > > <<< HEAD > > > > === > > > Function for overriding broken spanners > > If the result is the intended result, sure. You are getting the merge > conflict beca

Re: push patch for issue 2679

David, > > > > So, in this case, would I do something like: > > > > git pull -r > > > > then submit a new patch set? > > That's probably the easiest way. You'll likely get a merge conflict > with instructions. Personally, I use Emacs and > > M-x smerge-ediff RET > > on the problematic file(s) f

Re: push patch for issue 2679

On Tue, Jul 24, 2012 at 8:56 AM, David Kastrup wrote: > "Phil Holmes" writes: > > > I get the patch fails to apply - presumably because > > music-functions.scm has been updated twice since the patch was > > created? Does this mean it needs rebasing, or somesuch? > > Likely. So, in this case,

push patch for issue 2679

Hi, I don't have push ability, so would someone who does please push my patch for issue 2679 ("Add function for overriding broken spanners to LilyPond") for me? Thanks so much, David ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.g

Re: Add function for overriding broken spanners to LilyPond. (issue 6397054)

David, This use of \default for skipping optional arguments even in end > position may appear a bit contrived. > > However, \key \default and \mark \default existed (hardwired in the > parser) even before music functions ever heard of optional arguments, so > I consider it an accomplishment to hav

Re: Add function for overriding broken spanners to LilyPond. (issue 6397054)

> 2012/7/18 Janek Warchoł : >> (however, it would be even more awesome if it was one general function >> for all purposes ;) ) Considering this some more, I think it's best at the moment to restrict the function to spanners. The expanded function encompassing spanners and breakable items ap

Re: Add function for overriding broken spanners to LilyPond. (issue 6397054)

David, On Fri, Jul 20, 2012 at 12:38 AM, David Kastrup wrote: > David Nalesnik writes: > > > David, > > > > Why does this have to be a list? Why not just make it two > > separate > > arguments? > > > > If, for wha

Re: Add function for overriding broken spanners to LilyPond. (issue 6397054)

David, Why does this have to be a list? Why not just make it two separate > arguments? > > If, for whatever reason, you really really really have this information > in a two-element list called whatever, you can still write > > \once \alterBroken "Staff.BarLine" #'color #@whatever > > It certainl

Re: Add function for overriding broken spanners to LilyPond. (issue 6397054)

Hi Janek, The only thing that > worries me is the indentation - there are some tabs used and > Frescobaldi displays them wrong (i suppose you meant 1 tab to be equal > to 4 spaces, not 8). > Oops! Usually I remember to convert tabs to spaces (and trim whitespace from the ends of lines), but not

Re: Add function for overriding broken spanners to LilyPond. (issue 6397054)

On Wed, Jul 18, 2012 at 3:18 PM, David Kastrup wrote: > Thomas Morley writes: > > > 2012/7/18 Janek Warchoł : > >> On Wed, Jul 18, 2012 at 8:18 PM, Thomas Morley > >> wrote: > >>> 2012/7/18 Janek Warchoł : > I haven't seen it before - looks awesome :) > (however, it would be even more

Re: Add function for overriding broken spanners to LilyPond. (issue 6397054)

Hi Janek, On Wed, Jul 18, 2012 at 12:22 AM, Janek Warchoł wrote: > On Wed, Jul 18, 2012 at 12:43 AM, wrote: > > The function will override unbroken spanners, but it will ignore > > non-spanners with a warning. > > What about things like clef change at a line break - is it possible to > override

Add function for overriding broken spanners to LilyPond. (issue 6397054)

Reviewers: , Description: Add function for overriding broken spanners to LilyPond. The music function \alterBroken is intended to facilitate overrides applied independently to the pieces of broken spanners--one of the perennial difficulties faced by users of LilyPond (addressed in Extending 2.6:

Re: utf-8-strings

Hi Harm, On Tue, Jul 10, 2012 at 3:07 PM, Thomas Morley < thomasmorle...@googlemail.com> wrote: > > (2) The code using the regexp library does not work with windows so > far (perhaps never). > Unfortunately, I'm still having no luck with Windows XP. (@David Kastrup: thank you for your suggestion

Re: utf-8-strings

On Sun, Jul 8, 2012 at 6:21 PM, Thomas Morley wrote: > 2012/7/9 David Kastrup : > > David Nalesnik writes: > > > >> On Sun, Jul 8, 2012 at 8:00 AM, David Kastrup wrote: > >> > >> > >> Thomas Morley writes: > >&

<    1   2   3   4   5   >