Hi to all, I have a hard drive encrypted using the gnome disk utility
and it is formated with with btrfs and GUID, the problem started when
moving a 4gb file to other disk it stooped saying input output error I
think, then when I tried to access it I entered the password to
decrypt and it now says
810d4rk wrote (ao):
> Hi to all, I have a hard drive encrypted using the gnome disk utility
> and it is formated with with btrfs and GUID, the problem started when
> moving a 4gb file to other disk it stooped saying input output error I
> think, then when I tried to access it I entered the password
On Sat, Nov 12, 2011 at 01:24:57AM +0100, Amedee Van Gasse wrote:
> On 02-06-11 01:20, Hugo Mills wrote:
> >Unless the traffic gets too high-volume, or unless someone
> >important objects, I'm going to suggest that bug reports should go to
> >this list for now (cc'd me, if you like). Note that
On Tue, Nov 22, 2011 at 08:12:43PM -0500, Phillip Susi wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 11/18/2011 10:50 AM, Phillip Susi wrote:
> > This is a nice little tool. The one suggestion that I have is that
> > it display the actual chunks and where they are located. It s
I've been using btrfs for two months now. Every day between 02:00 and
08:00 I rsync some 300GB data (milions of files) to btrfs device and
then make snapshot. Next day i rsync again 300GG little changed (rsync
"in place"). First days it worked perfectly. Then loadavg (sys load)
started to rise. Now
On Wed, 23 Nov 2011 15:43:14 +0100
"krz...@gmail.com " wrote:
> I've been using btrfs for two months now. Every day between 02:00 and
> 08:00 I rsync some 300GB data (milions of files) to btrfs device and
> then make snapshot. Next day i rsync again 300GG little changed (rsync
> "in place"). Firs
Yes, yesterday I've umouted partition and re-mounted it. Nothing has
changed this night.
You can look at my load graphs here:
http://img42.imageshack.us/img42/4661/33737291.png
http://img210.imageshack.us/img210/2742/46527625.png
On the second one blue is SYS load. I bet you can reasily spot time
I see that this high sys load and loadavg did not appear gradualy. It
appeared first time about 7 days ago and were present every backup,
every night since then.
During backup top shows higher cpu load on
4216 root 20 0 000 R 20.3 0.0 284:25.83 btrfs-delayed-m
4222 root
On Thu, Nov 17, 2011 at 03:26:17PM +0800, Li Zefan wrote:
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index 8c32434..89cc54e 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> +static int trim_no_bitmap(struct btrfs_block_group_cache *blo
Hiya,
yes, you'll probably think that is crazy, but after observing
better performance with btrfs in some work loads on md RAID5
than btrfs builtin RAID10, I thought I'd try btrfs on zfs
(in-kernel, not fuse) zvol (on raidz) just for a laugh.
While this procedure worked for ext4 and xfs, for btrf
On Nov 22, 2011, at 10:02 PM, Fajar A. Nugraha wrote:
> On Wed, Nov 23, 2011 at 12:33 PM, Blair Zajac wrote:
>> Hello,
>>
>> I'm trying btrfs in a VirtualBox VM running Ubuntu 11.10 with kernel 3.0.0.
>> Running fsck I get a message with "err is 1".
>
>> Does this mean there's an error? Is
On 11/23/2011 9:43 AM, krz...@gmail.com wrote:
What all those btrfs benchmark does not tell you that its performance
decreases (sys load increases) with growing size of btree. Creating
btrfs filesystem is instantaneous because initial tree is just
nothing...
While something is clearly wrong, th
Hiya,
is there any recommendation out there to setup a btrfs FS on top
of hardware or software raid5 or raid6 wrt stripe/stride alignment?
>From mkfs.btrfs, it doesn't look like there's much that can be
adjusted that would help, and what I'm asking might not even
make sense for btrfs but I though
On Nov 23, 2011, at 9:04 AM, Stephane CHAZELAS wrote:
> Hiya,
>
> is there any recommendation out there to setup a btrfs FS on top
> of hardware or software raid5 or raid6 wrt stripe/stride alignment?
Isn't the advantage of having btrfs do all the raiding itself so one gets the
checksums? If
Hallo, Blair,
Du meintest am 23.11.11:
>> I can't answer that, but I can tell you that fsck for btrfs right
>> now is almost useless. It can't fix anyting.
> Thank you, I've read that fsck doesn't fix anything. I was curious
> if doing the scrub would resolve it.
I had tried ... about 4 Tbyte
On Wed, Nov 23, 2011 at 6:33 AM, Hugo Mills wrote:
> On Sat, Nov 12, 2011 at 01:24:57AM +0100, Amedee Van Gasse wrote:
>> On 02-06-11 01:20, Hugo Mills wrote:
>> > Unless the traffic gets too high-volume, or unless someone
>> >important objects, I'm going to suggest that bug reports should go t
On 23.11.2011 18:32, Helmut Hullen wrote:
> One big problem of btrfs seems to be: you can't see on which partition/
> disk the defect sector (or something else) may be
A recent kernel (3.2, still rc) will tell you the byte number when an
error occurs, and also give the the opportunity to resolve
2011-11-23, 09:08(-08), Blair Zajac:
>
> On Nov 23, 2011, at 9:04 AM, Stephane CHAZELAS wrote:
>
>> Hiya,
>>
>> is there any recommendation out there to setup a btrfs FS on top
>> of hardware or software raid5 or raid6 wrt stripe/stride alignment?
>
> Isn't the advantage of having btrfs do all the
Hallo, Jan,
Du meintest am 23.11.11:
>> One big problem of btrfs seems to be: you can't see on which
>> partition/ disk the defect sector (or something else) may be
> A recent kernel (3.2, still rc) will tell you the byte number when an
> error occurs, and also give the the opportunity to resolv
> dd that backup disk to another disk, so you have a backup of your
> backup, and work with that.
OK.
> You can also post the dmesg output you get when you mount the broken
> filesystem, and ask the experts if it might be worth to try experimental
> btrfs.fsck on it.
dmesg does not output anythi
There were extra spaces around some of the arguments in the man
page for mkfs.
---
man/mkfs.btrfs.8.in | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in
index 432db1b..542e6cf 100644
--- a/man/mkfs.btrfs.8.in
+++
---
man/mkfs.btrfs.8.in |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in
index 542e6cf..25e817b 100644
--- a/man/mkfs.btrfs.8.in
+++ b/man/mkfs.btrfs.8.in
@@ -12,6 +12,7 @@ mkfs.btrfs \- create an btrfs filesystem
[ \fB\-M\fP\f
On Wed, Nov 23, 2011 at 04:25:30PM -0500, Phillip Susi wrote:
> There were extra spaces around some of the arguments in the man
> page for mkfs.
Please resend with Signed-off-by: tag, and it would be helpful to
prepend the subject with eg. btrfs-progs.
thanks,
david
--
To unsubscribe from this li
I've rebooted server and run backup to btrfs partition again. It seems
that problem is gone, high sys load does not occur now. So it is some
bug in btrfs... Before reboot server had 30 days uptime so its really
not much.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
t
Here's my current error handling patchset, against Chris's current
for-linus branch.
As before, it's almost all in preparation for actual error handling.
After a chat with Chris last week about some of the bits I thought
might be contentious, I went ahead with the next step and converted
struct ex
btrfs_insert_root is just a wrapper for btrfs_insert_item. Just return
the error directly.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/root-tree.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
index f409990..1fd93d6 10
run_scheduled_bios has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/volumes.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -127,7 +127,7
btrfs_destroy_pending_snapshots has no error conditions and should
return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -53,7 +53,7 @@ static void btrfs_destroy_order
add_excluded_extent has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent-tree.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -206,15 +206,14 @@ block_group_ca
btrfs_free_fs_root has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |3 +--
fs/btrfs/disk-io.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2733,7 +2733,7 @@ int write_ctr
btrfs_add_ordered_operation has no error conditions and should return void
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ordered-data.c | 11 ---
fs/btrfs/ordered-data.h |6 +++---
2 files changed, 7 insertions(+), 10 deletions(-)
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-d
btrfs_destroy_ordered_extents has no error conditions and should return
void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -50,7 +50,7 @@ static void free_fs_root(struct b
del_fs_roots has no error conditions and should return void
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2764,7 +2764,7 @@ static void free_fs_root(struct btrfs_ro
kfr
btrfs_add_ordered_sum has no error conditions and should return void
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ordered-data.c |7 +++
fs/btrfs/ordered-data.h |6 +++---
2 files changed, 6 insertions(+), 7 deletions(-)
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -2
btrfs_destroy_ordered_operations has no error conditions and should
return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -49,7 +49,7 @@ static void end_workqueue_fn(s
btrfs_run_ordered_operations has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ordered-data.c |4 +---
fs/btrfs/ordered-data.h |2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -
__btrfs_remove_ordered_extent has no error conditions and should return
void. Once that happens, btrfs_remove_ordered_extent has no error
conditions can can also return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ordered-data.c | 15 +--
fs/btrfs/ordered-data.h |2 +-
2 f
btrfs_wait_ordered_range has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ordered-data.c |3 +--
fs/btrfs/ordered-data.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -610,7
Now that btrfs_truncate_item returns void, there are no more error
conditions in update_inline_extent_backref and it should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent-tree.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
--- a/fs/btrfs/exte
btrfs_extend_item has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c |7 +++
fs/btrfs/ctree.h |5 +++--
fs/btrfs/dir-item.c|5 ++---
fs/btrfs/extent-tree.c |5 ++---
fs/btrfs/file-item.c |2 +-
fs/btrfs/inod
btrfs_truncate_item has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c | 11 +--
fs/btrfs/ctree.h |8
fs/btrfs/dir-item.c|4 ++--
fs/btrfs/extent-tree.c |3 +--
fs/btrfs/file-item.c |4 ++--
fs/bt
end_compressed_writeback has no error conditions and should return
void. Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/compression.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compr
btrfs_put_ordered_extent has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ordered-data.c |3 +--
fs/btrfs/ordered-data.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -392,7
copy_for_split has no error conditions and should return void. We
return 0 from split_leaf instead of ret since ret would have been
set using the return value from copy_for_split which would have been 0.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c | 19 ---
1 files chan
btrfs_wait_ordered_extents has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ordered-data.c |5 ++---
fs/btrfs/ordered-data.h |4 ++--
fs/btrfs/transaction.c |3 +--
3 files changed, 5 insertions(+), 7 deletions(-)
--- a/fs/btrfs/ordered-data
clear_extent_buffer_dirty has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |3 +--
fs/btrfs/extent_io.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/extent_i
Now that the delayed ref code uses mempools, allocations can't fail,
and there are no more error conditions to report.
This patch makes the following functions return void:
- btrfs_alloc_reserved_file_extent
- btrfs_add_delayed_tree_ref
- btrfs_add_delayed_data_ref
- btrfs_add_delayed_exten
Now that process_func can't return an error, __btrfs_mod_ref has no more
error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c | 30 ++
fs/btrfs/ctree.h |8
fs/btrfs/extent-tree.c | 34 +++-
__unlock_for_delalloc has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
check_page_locked has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -1817,1
btrfs_cleanup_fs_uuids has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/volumes.c |3 +--
fs/btrfs/volumes.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/volumes.c
+++ b
__btrfs_mod_ref's process_func function pointer calls btrfs_free_extent
and btrfs_inc_extent_ref, which now both return only 0. This patches
makes them return void and eliminates the error condition in
__btrfs_mod_ref.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.h | 16 ---
clean_tree_block has no error conditions and should return void. Its
callers already ignore the error codes.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |5 ++---
fs/btrfs/disk-io.h |4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/b
btrfs_free_extent has no error conditions, but is used via process_func
in __btrfs_mod_ref which requires it to return an int.
This patch cleans up the callers to eliminate error handling that will
never be used. The next patch makes both btrfs_free_extent and the other
function used via proc
This patch converts the delayed ref code to use slab cache-backed mempools
for allocating its nodes.
The allocations happen deep in the call path where error recovery is
impossible.
By using mempools, we ensure that the allocations can't fail. Each
mempool keeps a page of structures availab
btrfs_inc_extent_ref has no error conditions, but is used via
process_func in __btrfs_mod_ref which requires it to return an int.
This patch cleans up the callers to eliminate error handling that will
never be used. A later patch in this series makes both
btrfs_inc_extent_ref and the other fu
add_delayed_data_ref has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/delayed-ref.c | 17 +++--
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c
index 3ae2401..b004960 100644
---
insert_ptr has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c | 46 +-
1 files changed, 13 insertions(+), 33 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index c605fb3..2604ec4 100644
-
Correctness fix: The kfree calls in the add_delayed_* functions free
the node that's passed into it, but the node is a member of another
structure. It works because it's always the first member of the
containing structure, but it should really be using the containing
structure itself.
Signed-
add_delayed_ref_head has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/delayed-ref.c | 29 ++---
1 files changed, 10 insertions(+), 19 deletions(-)
diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c
index 125cf76..caa9a
setup_items_for_insert now has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c | 26 ++
fs/btrfs/ctree.h |8
fs/btrfs/delayed-inode.c |6 ++
3 files changed, 16 insertions(+), 24 deletion
With fixup_low_keys now returning void, there are no error conditions
for del_ptr to report so it should return void. We set ret = 0 explicitly
in btrfs_del_items but I'm not convinced that the error handling code
already there is correct.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c |
fixup_low_keys has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.c | 39 +++
1 files changed, 11 insertions(+), 28 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 011cab3..dedd3a1 100644
---
In submit_extent_page, there's a visually noisy if statement that, in
the midst of other conditions, does the tree dependency for tree->ops
and tree->ops->merge_bio_hook before calling it, and then another
condition afterwards. If an error is returned from merge_bio_hook,
there's no way to cat
add_delayed_tree_ref has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/delayed-ref.c | 15 ++-
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c
index caa9ade..3ae2401 100644
--- a/
btrfs_run_defrag_inodes has no error conditions and should return
void. Its callers already ignore the error codes anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.h |2 +-
fs/btrfs/file.c |3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/ctree.h
+++ b/fs/
This pushes failures from the submit_bio_hook callbacks,
btrfs_submit_bio_hook and btree_submit_bio_hook into the callers, including
callers of submit_one_bio where it catches the failures with BUG_ON.
It also pushes up through the ->readpage_io_failed_hook to
end_bio_extent_writepage where t
This patch pushes kmalloc errors up to the caller and BUGs in the caller.
The BUG_ON for duplicate reloc tree root insertion is replaced with a
panic explaining the issue.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/relocation.c | 22 --
1 file changed, 16 insertions(+), 6
btrfs_submit_bio_hook currently calls btrfs_bio_wq_end_io in either case
of an if statement that determines one of the arguments.
This patch moves the function call outside of the if statement and uses it
to only determine the different argument. This allows us to catch an
error in one place
setup_inline_extent_backref has no error conditions and should return
void. We set ret = 0 explicitly in insert_inline_extent_backref since
it would have been set using the return value, which would have been 0.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent-tree.c | 23 +++
btrfs_set_block_group_rw has no error conditions and should return
void. Its callers already ignore the error codes anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.h |4 ++--
fs/btrfs/extent-tree.c |3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
--- a/fs/btrfs/ct
btrfs_destroy_delalloc_inodes has no error conditions and should return
void. Its callers already ignore the error codes anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
btrfs_prepare_extent_commit has no error conditions and should return
void. Its callers already ignore the error codes anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.h |4 ++--
fs/btrfs/extent-tree.c |3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
--- a/fs/btrfs
__setup_root has no error conditions and should return void. Its callers
already ignore the error codes anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1058,10 +1
btrfs_init_compress doesn't have any failure conditions, so return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/compression.c |3 +--
fs/btrfs/compression.h |2 +-
fs/btrfs/super.c |5 +
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/btrfs/compression.
btrfs_invalidate_inodes has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.h |2 +-
fs/btrfs/inode.c |3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 7d90a9c..e8f0689 100644
--- a
btrfs_end_log_trans has no error conditions and should return void.
Its callers ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/tree-log.c |3 +--
fs/btrfs/tree-log.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/tree-log.c b/fs/b
btrfs_requeue_work has no error conditions and should return void.
Its callers ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/async-thread.c |7 ++-
fs/btrfs/async-thread.h |2 +-
2 files changed, 3 insertions(+), 6 deletions(-)
--- a/fs/btrfs/async-thread.
run_ordered_completions has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/async-thread.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-th
wait_for_writer has no error conditions and should return void. Its
callers already ignore the error codes anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/tree-log.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 2c
btrfs_queue_worker has no error conditions and should return void.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/async-thread.c | 14 --
fs/btrfs/async-thread.h |2 +-
2 files changed, 5 insertions(+), 11 deletions(-)
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@
schedule_bio has no error conditions and should return void. Its callers
already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/volumes.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -3268,7 +3268,7 @@
btrfs_stop_workers has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/async-thread.c |3 +--
fs/btrfs/async-thread.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/async-thr
check_page_uptodate has no error conditions and should return void. Its
callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -1805
wait_on_state has no error conditions and should return void. Its callers
already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -621,8 +6
wait_extent_bit has no error conditions and should return void. Its
callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |3 +--
fs/btrfs/extent_io.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/extent_io.c
+++ b/
All of the callers of try_lock_extent call it with gfp_t == GFP_NOFS.
This patch simplifies the call sites by calling clear_extent_bit with
GFP_NOFS from try_lock_extent itself.
Since the extent io code will probably never be used outside of a file
system, this is generally ok. If there are
fill_device_from_item has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/volumes.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -3513,7 +
check_page_writeback has no error conditions and should return void.
Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -1
btrfs_close_extra_devices has no error conditions and should return
void. Its callers already ignore the error code anyway.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/volumes.c |3 +--
fs/btrfs/volumes.h |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--- a/fs/btrfs/volumes.c
++
The *_state functions can only return 0 or -EEXIST. This patch addresses
the cases where those functions returning -EEXIST represent a locking
failure. It handles them by panicking with an appropriate error message.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c | 58 +
btrfs_update_root BUG's when it can't alloc a path, yet it can recover
from a search error. This patch returns -ENOMEM instead.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/ctree.h |7 ---
fs/btrfs/root-tree.c |4 +++-
2 files changed, 7 insertions(+), 4 deletions(-)
--- a/fs/btrf
btrfs_pin_extent looks up a block group and then calls pin_down_extent
with it. If the lookup fails, it should return -ENOENT to allow callers
to handle the error condition. For the three existing callers, it is
a logic error if the lookup fails and a panic will occur.
Signed-off-by: Jeff Maho
Commit cb1b69f4 (Btrfs: forced readonly when btrfs_drop_snapshot() fails)
made btrfs_drop_snapshot return void because there were no callers checking
the return value. That is the wrong order to handle error propogation since
the caller will have no idea that an error has occured and continue on
as
find_and_setup_root BUGs when it encounters an error from
btrfs_find_last_root, which can occur if a path can't be allocated.
This patch pushes it up to its callers where it is already handled.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/disk-io.c | 11 ++-
1 file changed, 6 insertion
This patch handles btrfs_start_transaction failures that don't occur
in a loop and are obvious to simply push up. In all cases except the
mark_garbage_root case, the error is already handled by BUG_ON in the
caller.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent-tree.c |6 +-
fs/btr
set_range_writeback has no error conditions and should return void.
Its callers already ignore the error code anyway.
There are internal error conditions but they are fatal and will cause
a panic.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c |8 +---
1 file changed, 5 insert
clear_extent_bit can fail with -ENOMEM for a specific case but will BUG
on other memory allocation failures.
This patch returns -ENOMEM for memory allocation failures and handles them
with BUG_ON in callers which don't handle it already.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c
pin_down_extent performs some operations which can't fail and then calls
set_extent_dirty, which has two failure cases via set_extent_bit:
1) Return -EEXIST if exclusive bits are set
- Since it doesn't use any exclusive bits, this failure case can't
occur.
2) Return -ENOMEM if memory
Now that allocations that are allowed to sleep can't fail,
convert_extent_bit has no more error conditions and we can assume the
return value will be 0 and return void to callers.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/extent_io.c | 18 ++
fs/btrfs/extent_io.h |4 ++--
1 - 100 of 130 matches
Mail list logo