Control Framework Roadmap

2010-04-07 Thread Hans Verkuil
OK, the discussion in response to my RFC was very enlightening. Based on that I decided on the following roadmap: 1) Remove the sysfs code from the framework for the time being. It is not necessary for the first version. What I would like to do is to take another good look at the data structures

Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Mauro Carvalho Chehab
David Härdeman wrote: > drivers/media/IR/ir-raw-event.c is currently written with the assumption > that all "raw" hardware will generate events only on state change (i.e. > when a pulse or space starts). > > However, some hardware (like mceusb, probably the most popular IR receiver > out there)

Re: RFC: exposing controls in sysfs

2010-04-07 Thread Mike Isely
On Wed, 7 Apr 2010, Mike Isely wrote: > > Backwards compatibility is very important and thus any kind of new > interface deserves a lot of forethought to ensure that choices are made > in the present that people will regret in the future. Making an "in the present that people will NOT (!!) r

Re: RFC: exposing controls in sysfs

2010-04-07 Thread Mike Isely
On Wed, 7 Apr 2010, Hans Verkuil wrote: [...] > > Perhaps we should just not do this in sysfs at all but in debugfs? We have a > lot more freedom there. No requirement of one-value-per-file, and if we need > to we can change things in the future. It would actually be easier to issue > ioctl c

Re: RFC: exposing controls in sysfs

2010-04-07 Thread Mike Isely
On Thu, 8 Apr 2010, hermann pitton wrote: > Hi, > > Am Mittwoch, den 07.04.2010, 20:50 +0200 schrieb Lars Hanisch: > > Am 06.04.2010 16:33, schrieb Mike Isely: > [snip] > > >> > > >> Mike, do you know of anyone actively using that additional information? > > > > > > Yes. > > > > > > The VDR proje

Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Andy Walls
On Wed, 2010-04-07 at 22:18 +0200, David Härdeman wrote: > drivers/media/IR/ir-raw-event.c is currently written with the assumption > that all "raw" hardware will generate events only on state change (i.e. > when a pulse or space starts). > > However, some hardware (like mceusb, probably the mo

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Andy Walls
On Wed, 2010-04-07 at 13:42 +0200, David Härdeman wrote: > On Wed, Apr 07, 2010 at 06:20:07AM -0400, Andy Walls wrote: > > On Tue, 2010-04-06 at 11:26 -0300, Mauro Carvalho Chehab wrote: > > > I won't comment every single bits of the change, since we're more > > > interested on the conceptual > >

Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Jon Smirl
On Wed, Apr 7, 2010 at 4:18 PM, David Härdeman wrote: > drivers/media/IR/ir-raw-event.c is currently written with the assumption > that all "raw" hardware will generate events only on state change (i.e. > when a pulse or space starts). > > However, some hardware (like mceusb, probably the most pop

[PATCH] TM6000: Fix code which cause memory corruption

2010-04-07 Thread Bee Hock Goh
code was doing malloc when buf is null causing memory corruption. The analog part is still pretty much broken but at least fixing this will stop it from crashing the machine when streamon. Signed-off-by: Bee Hock Goh diff -r 7c0b887911cf linux/drivers/staging/tm6000/tm6000-video.c --- a/linux/dri

Re: RFC: exposing controls in sysfs

2010-04-07 Thread hermann pitton
Hi, Am Mittwoch, den 07.04.2010, 20:50 +0200 schrieb Lars Hanisch: > Am 06.04.2010 16:33, schrieb Mike Isely: [snip] > >> > >> Mike, do you know of anyone actively using that additional information? > > > > Yes. > > > > The VDR project at one time implemented a plugin to directly interface > > to

Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Jon Smirl
On Wed, Apr 7, 2010 at 4:18 PM, David Härdeman wrote: > o Not sent using quilt...Mauro, does it still trip up your MUA? Try Stacked git (stg). Stacked git is quilt rewritten specifically for git. http://www.procode.org/stgit/ I have been using it for kernel patches for over four years. So far no

Re: [PATCH] em28xx: fix locks during dvb init sequence - was: Re: V4L-DVB drivers and BKL

2010-04-07 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Wed, Apr 7, 2010 at 4:07 PM, Mauro Carvalho Chehab > At first glance, this looks really promising. I will have to look at > this in more detail when I have access to the source code (I'm at the > office right now). Ok. Please test it when you have some time, for me

[RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
drivers/media/IR/ir-raw-event.c is currently written with the assumption that all "raw" hardware will generate events only on state change (i.e. when a pulse or space starts). However, some hardware (like mceusb, probably the most popular IR receiver out there) only generates duration data (and

Re: [PATCH] em28xx: fix locks during dvb init sequence - was: Re: V4L-DVB drivers and BKL

2010-04-07 Thread Devin Heitmueller
On Wed, Apr 7, 2010 at 4:07 PM, Mauro Carvalho Chehab wrote: > Devin Heitmueller wrote: >> On Thu, Apr 1, 2010 at 11:02 AM, Mauro Carvalho Chehab >> wrote: >>> I remember I had to do it on em28xx: >>> >>> This is the init code for it: >>>        ... >>>        mutex_init(&dev->lock); >>>        m

[PATCH] em28xx: fix locks during dvb init sequence - was: Re: V4L-DVB drivers and BKL

2010-04-07 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 11:02 AM, Mauro Carvalho Chehab > wrote: >> I remember I had to do it on em28xx: >> >> This is the init code for it: >>... >>mutex_init(&dev->lock); >>mutex_lock(&dev->lock); >>em28xx_init_dev(&dev, udev, interface,

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: WARNINGS

2010-04-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Apr 7 19:00:18 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14561:7c0b887911cf git master:

Re: RFC: exposing controls in sysfs

2010-04-07 Thread Lars Hanisch
Am 06.04.2010 16:33, schrieb Mike Isely: Comments below... On Mon, 5 Apr 2010, Hans Verkuil wrote: Hi all, The new control framework makes it very easy to expose controls in sysfs. The way it is implemented now in the framework is that each device node will get a 'controls' subdirectory in s

Re: Possible bug with FusionHDTV7 Dual Express

2010-04-07 Thread Timothy D. Lenz
Ran fin without problems for several days. Changed setting to "-D 0 -D 1 -D 2" So it would use all 3 tuners (default) and left it on the 3rd tuner. Next morning first tuner was down. Today I'm trying it with "-D 0 -D 2" So it uses the first tuner of the dual and the 3rd tuner (second card). Lea

Re: s2255drv: pull request

2010-04-07 Thread Mauro Carvalho Chehab
sensoray-dev wrote: > Hi Mauro, Could you please pull the following 2255 patches? > > > https://patchwork.kernel.org/patch/89099/ > https://patchwork.kernel.org/patch/89100/ > https://patchwork.kernel.org/patch/89957/ > https://patchwork.kernel.org/patch/89958/ I have a large amount of patches

s2255drv: pull request

2010-04-07 Thread sensoray-dev
Hi Mauro, Could you please pull the following 2255 patches? https://patchwork.kernel.org/patch/89099/ https://patchwork.kernel.org/patch/89100/ https://patchwork.kernel.org/patch/89957/ https://patchwork.kernel.org/patch/89958/ Also, the official email maintainer(s) contact for the 2255 driver

[PATCH] Updated scan file for dvb-c/fi-Turku (dvb-apps)

2010-04-07 Thread Miika Vesti
Hello. Here is an updated scan file for dvb-c/fi-Turku. Source information for scan file: http://www.turunkaapelitv.fi/p9-taajuudet.html [html] http://www.turunkaapelitv.fi/files/Kanavalista-(3).pdf [pdf] Both documents are in Finnish but it should be easy to pick the relevant information and

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Jon Smirl
On Wed, Apr 7, 2010 at 9:29 AM, Mauro Carvalho Chehab wrote: > On the implementation I did, each event is passed to each decoder serialized > (yet, as one keystroke > is a series of events, it behaves as if they are processed in parallel). We > might create separate > kthreads for each decoder,

[PATCH] pt1: Support Earthsoft PT2

2010-04-07 Thread hiranotaka
Support Earthsoft PT2. Signed-off-by: HIRANO Takahito diff -r 7c0b887911cf linux/drivers/media/dvb/pt1/pt1.c --- a/linux/drivers/media/dvb/pt1/pt1.c Mon Apr 05 22:56:43 2010 -0400 +++ b/linux/drivers/media/dvb/pt1/pt1.c Wed Apr 07 23:42:41 2010 +0900 @@ -1,5 +1,5 @@ /* - * driver for Earthsoft P

Any DMB-TH hardware?

2010-04-07 Thread Sunil Khiatani
Hi, Does anyone know which Digital TV cards with DMB-TH (China Standard Digital TV standard) work in linux? Thanks Sunil -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-07 Thread Karicheri, Muralidharan
Vaibhav, >[Murali] Shouldn't we remove omap_vout_uservirt_to_phys() and use >videobuf_iolock() instead as we have done in vpfe_capture.c? > >As mentioned before, in my opinion we can address this in sub-sequent patch >series, and should not block this patch in getting to main-line. > >> +/* >> + *

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Mauro Carvalho Chehab
Jon Smirl wrote: > I had to rework this portion of code several times in the IR code I posted. > > I had the core provide input_ir_queue() which was legal to call from > interrupt context. Calling from interrupt context was an important > aspect I missed in the first versions. I made this a common

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Mauro Carvalho Chehab
David Härdeman wrote: > On Tue, Apr 06, 2010 at 11:26:35AM -0300, Mauro Carvalho Chehab wrote: >> Hi David, >> >> Em Tue, 6 Apr 2010 12:48:11 +0200 >> David Härdeman escreveu: >> >>> Content-Type: text/plain; charset=us-ascii >>> Content-Disposition: inline; filename=use-pulse-space-timings-in-ir-

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Jon Smirl
I had to rework this portion of code several times in the IR code I posted. I had the core provide input_ir_queue() which was legal to call from interrupt context. Calling from interrupt context was an important aspect I missed in the first versions. I made this a common routine so that the code d

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
On Wed, Apr 07, 2010 at 06:20:07AM -0400, Andy Walls wrote: > On Tue, 2010-04-06 at 11:26 -0300, Mauro Carvalho Chehab wrote: > > I won't comment every single bits of the change, since we're more > > interested on the conceptual > > aspects. > > > > > -int ir_raw_event_store(struct input_dev *inp

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
On Tue, Apr 06, 2010 at 11:26:35AM -0300, Mauro Carvalho Chehab wrote: > Hi David, > > Em Tue, 6 Apr 2010 12:48:11 +0200 > David Härdeman escreveu: > > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline; filename=use-pulse-space-timings-in-ir-raw > > Thunderbird 2 real

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Andy Walls
On Tue, 2010-04-06 at 11:26 -0300, Mauro Carvalho Chehab wrote: > Hi David, > > I won't comment every single bits of the change, since we're more interested > on the conceptual > aspects. > > > -int ir_raw_event_store(struct input_dev *input_dev, enum raw_event_type > > type) > > Don't remove

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-07 Thread Hiremath, Vaibhav
> -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Tuesday, April 06, 2010 11:59 PM > To: Hiremath, Vaibhav > Cc: linux-media@vger.kernel.org; Karicheri, Muralidharan; > mche...@redhat.com; linux-o...@vger.kernel.org; t...@atomide.com > Subject: Re: [PATCH 1/2] O

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-07 Thread Hiremath, Vaibhav
> -Original Message- > From: Karicheri, Muralidharan > Sent: Tuesday, April 06, 2010 11:56 PM > To: Hiremath, Vaibhav; Muralidharan Karicheri > Cc: linux-media@vger.kernel.org; mche...@redhat.com; linux- > o...@vger.kernel.org; t...@atomide.com > Subject: RE: [PATCH 1/2] OMAP2/3 V4L2: Add

[PATCH-V7] OMAP2/3: Add V4L2 display driver support

2010-04-07 Thread hvaibhav
From: Vaibhav Hiremath Changes from last version (V6): - Fixed comments from Murali, Hans and Vladimir. - Also dropped board hook-up patch, since we can add it once this patch goes in. (Actually unnecessarily that patch is floating all around with th

Re: [PATCH] V4L/DVB: saa7146: IRQF_DISABLED causes only trouble

2010-04-07 Thread Andy Walls
On Mon, 2010-03-22 at 10:28 +0100, Bjørn Mork wrote: > Andy Walls writes: > > On Sun, 2010-03-21 at 21:08 +0100, Bjørn Mork wrote: > >> As discussed many times, e.g. in http://lkml.org/lkml/2007/7/26/401 > >> mixing IRQF_DISABLED with IRQF_SHARED just doesn't make sense. > >> > >> Remove IRQF_DIS

[patch] video: comparing unsigned with negative 0

2010-04-07 Thread Dan Carpenter
soc_mbus_bytes_per_line() returns -EINVAL on error but we store it in an unsigned int so the test for less than zero doesn't work. I think it always returns "small" positive values so we can just cast it to int here. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/sh_mobile_ceu_ca

Re: [PATCH 00/15] ir-core: Several improvements to allow adding LIRC and decoder plugins

2010-04-07 Thread David Härdeman
On Mon, Apr 05, 2010 at 04:49:10PM -0400, Jarod Wilson wrote: > On Fri, Apr 2, 2010 at 6:20 AM, David Härdeman wrote: > > Porting the msmce driver to rc-core will be high on my list of > > priorities once I've done some more changes to the API. > > Very cool. Though note that the latest lirc_mceu

RE: [patch] davinci: don't return under lock on error path

2010-04-07 Thread Hiremath, Vaibhav
> -Original Message- > From: Dan Carpenter [mailto:erro...@gmail.com] > Sent: Wednesday, April 07, 2010 2:51 PM > To: Mauro Carvalho Chehab > Cc: Hans Verkuil; Hiremath, Vaibhav; Laurent Pinchart; Karicheri, > Muralidharan; linux-media@vger.kernel.org; kernel-janit...@vger.kernel.org > Sub

[patch] davinci: don't return under lock on error path

2010-04-07 Thread Dan Carpenter
If the kmalloc() failed for "ccdc_cfg = kmalloc(...);" then we would exit with the lock held. I moved the mutex_lock() below the allocation because it isn't protecting anything in that block and allocations are allocations are sometimes slow. Signed-off-by: Dan Carpenter diff --git a/drivers/m