Re: Review Request 17562: Added cluster name to page title.

> On Jan. 31, 2014, 12:56 a.m., Kevin Sweeney wrote: > > > > Suman Karumuri wrote: > Spoke to Bill before making these changes. We decided to use getInfo API > and deprecate getAPIVersion. The getInfo will return with the clusterName and > APIVersion for now. In future it may include other

Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17672/#review33560 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/OfferQueu

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33559 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 3, 2014, 9 p.m., D

Re: Review Request 17689: Fixing submit instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17689/#review33558 --- Thanks. Pushed. - Maxim Khutornenko On Feb. 4, 2014, 2 a.m., Maxi

Re: Review Request 17689: Fixing submit instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17689/#review33557 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 6 p.m., Maxim

Review Request 17689: Fixing submit instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17689/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/ --- (Updated Feb. 3, 2014, 5:10 p.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

> On Feb. 4, 2014, 12:34 a.m., Brian Wickman wrote: > > pants, line 20 > > > > > > why not PANTS_VERSION=$(cat .pantsversion) like before? > > Kevin Sweeney wrote: > This matches the convention in other virtualenv-

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/#review33550 --- Ship it! Ship It! - Brian Wickman On Feb. 3, 2014, 11:13 p.m., K

Re: Review Request 17683: change max backoff timeout to be compatible with the preemption_wait hardcoded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17683/#review33548 --- How about a newbie ticket to make the executor side of this configur

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

> On Feb. 3, 2014, 4:34 p.m., Brian Wickman wrote: > > pants, line 20 > > > > > > why not PANTS_VERSION=$(cat .pantsversion) like before? This matches the convention in other virtualenv-y scripts, but I don't have str

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/#review33543 --- thanks for doing this -- had been meaning to file an issue to do thi

Review Request 17683: change max backoff timeout to be compatible with the preemption_wait hardcoded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17683/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 17683: change max backoff timeout to be compatible with the preemption_wait hardcoded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17683/#review33542 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 4, 2014, 12:28 a.m

Re: Review Request 17562: Added cluster name to page title.

> On Jan. 31, 2014, 12:56 a.m., Kevin Sweeney wrote: > > > > Suman Karumuri wrote: > Spoke to Bill before making these changes. We decided to use getInfo API > and deprecate getAPIVersion. The getInfo will return with the clusterName and > APIVersion for now. In future it may include other

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33530 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 3:43 p.m., Ma

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 6:43 p.m.) Review request for Aurora, Bill Farner and Br

Re: Review Request 17680: Break down free slots stats into dedicated and shared.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17680/ --- (Updated Feb. 3, 2014, 11:20 p.m.) Review request for Aurora and Maxim Khutorne

Review Request 17680: Break down free slots stats into dedicated and shared.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17680/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-152 https://i

Re: Review Request 17562: Added cluster name to page title.

> On Jan. 30, 2014, 4:56 p.m., Kevin Sweeney wrote: > > > > Suman Karumuri wrote: > Spoke to Bill before making these changes. We decided to use getInfo API > and deprecate getAPIVersion. The getInfo will return with the clusterName and > APIVersion for now. In future it may include other

Re: Review Request 17056: fix dependencies for setup_py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33527 --- Ship it! Please drop a TODO with ticket number for follow-up. - Ke

Review Request 17679: Upgrade twitter.common.python to 0.3.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description -

Re: Review Request 17056: fix dependencies for setup_py

> On Feb. 3, 2014, 8:38 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/BUILD, line 68 > > > > > > I'm unclear on the convention being followed for -packaged > > dependencies. Wouldn't this be autom

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33523 --- Almost there, just one issue remaining. examples/vagrant/provision

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 5:55 p.m.) Review request for Aurora, Bill Farner and Br

Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/#review33522 --- src/main/java/org/apache/aurora/scheduler/base/Jobs.java

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

> On Feb. 3, 2014, 8:15 p.m., Mark Chu-Carroll wrote: > > src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora, line > > 32 > > > > > > Really? Shouldn't there be a newline at the end of the last line?

Re: Review Request 17676: Adding PGP key for ma...@apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17676/#review33518 --- Thanks, pushed. - Maxim Khutornenko On Feb. 3, 2014, 10:07 p.m.,

Re: Review Request 17666: Adding DRAINING state into api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33517 --- Thanks, pushed. - Maxim Khutornenko On Feb. 3, 2014, 9:41 p.m., M

Re: Review Request 17676: Adding PGP key for ma...@apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17676/#review33516 --- Ship it! Ship It! - Jake Farrell On Feb. 3, 2014, 10:07 p.m., Ma

Review Request 17676: Adding PGP key for ma...@apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17676/ --- Review request for Aurora. Repository: aurora Description --- Adding PGP

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

> On Feb. 3, 2014, 1:47 p.m., Kevin Sweeney wrote: > > examples/vagrant/provision-dev-environment.sh, line 5 > > > > > > git is already on this commandline and setuptools shouldn't be needed. > > From the virtualbox env

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

> On Feb. 3, 2014, 4:47 p.m., Kevin Sweeney wrote: > > examples/vagrant/provision-dev-environment.sh, line 5 > > > > > > git is already on this commandline and setuptools shouldn't be needed. > > From the virtualbox env

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33510 --- examples/vagrant/provision-dev-environment.sh

Re: Review Request 17666: Adding DRAINING state into api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33509 --- Ship it! Ship It! - Bill Farner On Feb. 3, 2014, 9:41 p.m., Maxi

Re: Review Request 17666: Adding DRAINING state into api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/ --- (Updated Feb. 3, 2014, 9:41 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

> On Feb. 3, 2014, 2:31 p.m., Kevin Sweeney wrote: > > examples/vagrant/provision-mesos-slave.sh, line 9 > > > > > > Rather than using sed here you can use interpolation as follows: > > > > eager expansion with

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

> On Feb. 3, 2014, 11:31 a.m., Kevin Sweeney wrote: > > examples/vagrant/provision-mesos-slave.sh, line 9 > > > > > > Rather than using sed here you can use interpolation as follows: > > > > eager expansion with

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

> On Feb. 3, 2014, 2:31 p.m., Kevin Sweeney wrote: > > examples/vagrant/provision-mesos-slave.sh, line 9 > > > > > > Rather than using sed here you can use interpolation as follows: > > > > eager expansion with

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

> On Feb. 3, 2014, 4:07 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/api/test_restarter.py, line 41 > > > > > > Mind adding a simple test with rollback_on_failure=False here? Restarter doesn'

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 3, 2014, 9 p.m.) Review request for Aurora, Mark Chu-Carroll, Max

Re: Review Request 17666: Adding DRAINING state into api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/ --- (Updated Feb. 3, 2014, 8:44 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17666: Adding DRAINING state into api.thrift.

> On Feb. 3, 2014, 7:22 p.m., Bill Farner wrote: > > You might want to do a bit more in this commit, specifically to ensure read > > sites handle the new state. You probably also want to rewrite the state in > > StorageBackfill. Also look out for another regression like > > https://issues.ap

Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17672/ --- Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Bugs: AURORA-1

Re: Review Request 17056: fix dependencies for setup_py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33495 --- src/main/python/apache/aurora/client/BUILD

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 3:16 p.m.) Review request for Aurora, Bill Farner and Br

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33490 --- src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.auror

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33475 --- examples/vagrant/provision-mesos-slave.sh

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33476 --- examples/vagrant/provision-dev-environment.sh

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33474 --- Vagrantfile

Re: Review Request 17666: Adding DRAINING state into api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33472 --- You might want to do a bit more in this commit, specifically to ensu

Re: Review Request 17270: Bridge framework for client v2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33471 --- Ship it! Ship It! - Bill Farner On Jan. 30, 2014, 9:03 p.m., Mar

Re: Review Request 17060: Fix noisy status checker debug log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17060/#review33463 --- Ship it! Ship It! - Kevin Sweeney On Jan. 17, 2014, 11:06 a.m.,

Re: Review Request 17666: Adding DRAINING state into api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33462 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 10:16 a.m., M

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

> On Feb. 3, 2014, 6:50 p.m., Jonathan Boulle wrote: > > src/main/python/apache/aurora/client/commands/admin.py, lines 174-181 > > > > > > hmm, log.error is nonfatal, so you should probably die() in these two > > case

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33458 --- src/main/python/apache/aurora/client/commands/admin.py

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33453 --- Ship it! LGTM mod formatting nits - Bill Farner On Feb. 3, 2014,

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33452 --- src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33450 --- Ship it! Looks like Mark merged this to master, it's 4abccc3. Than

Review Request 17666: Adding DRAINING state into api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-82 h

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33436 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 3, 2014, 3:58 p.m.

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33435 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 3, 2014, 10:58 a.m.

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 11:30 a.m.) Review request for Aurora, Bill Farner and B

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33429 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/ --- (Updated Feb. 3, 2014, 3:58 p.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33428 --- src/main/python/apache/aurora/client/options.py