[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377210368 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -37,15 +39,26 @@

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377210986 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -37,15 +39,26 @@

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377213249 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -58,20 +71,26 @@

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377216613 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -88,72 +107,174

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377216518 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -88,72 +107,174

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377217697 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -88,72 +107,174

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377218115 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java ## @@ -170,20

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377221352 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java ## @@ -170,20

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377232789 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java ## @@ -170,20

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377233092 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java ## @@ -170,20

[GitHub] [helix] lei-xia commented on a change in pull request #729: Implement Helix API for updating customized state

2020-02-10 Thread GitBox
lei-xia commented on a change in pull request #729: Implement Helix API for updating customized state URL: https://github.com/apache/helix/pull/729#discussion_r377241208 ## File path: helix-core/src/main/java/org/apache/helix/customizedstate/CustomizedStateProvider.java ##

[GitHub] [helix] lei-xia commented on a change in pull request #729: Implement Helix API for updating customized state

2020-02-10 Thread GitBox
lei-xia commented on a change in pull request #729: Implement Helix API for updating customized state URL: https://github.com/apache/helix/pull/729#discussion_r377241722 ## File path: helix-core/src/main/java/org/apache/helix/customizedstate/CustomizedStateProvider.java ##

[GitHub] [helix] NealSun96 commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
NealSun96 commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#issuecomment-584290121 A generic comment on all writer logics: some deletion operations can lead to a data state that is deemed "invalid" by `Z

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377250276 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java ## @@ -170,20

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377256170 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -88,72 +107,174

[GitHub] [helix] zhangmeng916 commented on a change in pull request #729: Implement Helix API for updating customized state

2020-02-10 Thread GitBox
zhangmeng916 commented on a change in pull request #729: Implement Helix API for updating customized state URL: https://github.com/apache/helix/pull/729#discussion_r377256613 ## File path: helix-core/src/main/java/org/apache/helix/customizedstate/CustomizedStateProvider.java #

[GitHub] [helix] narendly commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
narendly commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377260364 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java ## @@ -156,34

[GitHub] [helix] NealSun96 opened a new issue #737: Add routing data validation logic to ZkRoutingDataWriter

2020-02-10 Thread GitBox
NealSun96 opened a new issue #737: Add routing data validation logic to ZkRoutingDataWriter URL: https://github.com/apache/helix/issues/737 We need to add validation logic to ZkRoutingDataWriter to ensure that the routing data written to ZooKeeper is valid, and keeping the data on ZooKeepe

[GitHub] [helix] NealSun96 commented on issue #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on issue #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#issuecomment-584302971 > Please address pending comments before marking it as ready for check-in. The validation logic will be on `TrieRoutingDataWriter` and is therefore n

[GitHub] [helix] narendly commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#issuecomment-584308561 > A generic comment on all writer logics: some deletion operations can lead to a data state that is deemed "invalid" by `

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377289102 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java ## @@ -156,34

[GitHub] [helix] NealSun96 edited a comment on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
NealSun96 edited a comment on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#issuecomment-584335976 > > A generic comment on all writer logics: some deletion operations can lead to a data state that is deemed "inv

[GitHub] [helix] NealSun96 commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
NealSun96 commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#issuecomment-584335976 > > A generic comment on all writer logics: some deletion operations can lead to a data state that is deemed "invalid" b

[GitHub] [helix] NealSun96 edited a comment on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
NealSun96 edited a comment on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#issuecomment-584335976 > > A generic comment on all writer logics: some deletion operations can lead to a data state that is deemed "inv

[GitHub] [helix] alirezazamani opened a new issue #738: ConcurrentModificationException for the TaskGarbageCollectionStage

2020-02-10 Thread GitBox
alirezazamani opened a new issue #738: ConcurrentModificationException for the TaskGarbageCollectionStage URL: https://github.com/apache/helix/issues/738 In the async TaskGarbageCollectionStage, since the workflow context can be changes in other threads (main pipeline), while looping throu

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377318169 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDat

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377259958 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirect

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377311433 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDat

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377261566 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDat

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377260454 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/MetadataStor

[GitHub] [helix] jiajunwang closed issue #734: testRebalancerReset is not stable

2020-02-10 Thread GitBox
jiajunwang closed issue #734: testRebalancerReset is not stable URL: https://github.com/apache/helix/issues/734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [helix] jiajunwang opened a new issue #739: Error log about WAGED rebalancer missing is not necessary

2020-02-10 Thread GitBox
jiajunwang opened a new issue #739: Error log about WAGED rebalancer missing is not necessary URL: https://github.com/apache/helix/issues/739 This only appears in the test environment, the log is not necessarily to be an error log. 10588 [main] ERROR org.apache.helix.controller.sta

[GitHub] [helix] jiajunwang opened a new pull request #740: Change the WAGED rebalancer missing error log to warning.

2020-02-10 Thread GitBox
jiajunwang opened a new pull request #740: Change the WAGED rebalancer missing error log to warning. URL: https://github.com/apache/helix/pull/740 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: #739 ### Descriptio

[GitHub] [helix] jiajunwang closed issue #739: Error log about WAGED rebalancer missing is not necessary

2020-02-10 Thread GitBox
jiajunwang closed issue #739: Error log about WAGED rebalancer missing is not necessary URL: https://github.com/apache/helix/issues/739 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [helix] alirezazamani opened a new pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani opened a new pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #738 ###

[GitHub] [helix] jiajunwang merged pull request #740: Change the WAGED rebalancer missing error log to warning.

2020-02-10 Thread GitBox
jiajunwang merged pull request #740: Change the WAGED rebalancer missing error log to warning. URL: https://github.com/apache/helix/pull/740 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [helix] jiajunwang commented on issue #740: Change the WAGED rebalancer missing error log to warning.

2020-02-10 Thread GitBox
jiajunwang commented on issue #740: Change the WAGED rebalancer missing error log to warning. URL: https://github.com/apache/helix/pull/740#issuecomment-584373317 This PR is ready to be merged, approved by @alirezazamani Thi

[GitHub] [helix] NealSun96 commented on issue #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on issue #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#issuecomment-584374793 This PR is ready to be merged, approved by @narendly Final commit message: ## Add TrieRoutingData constructor ## This PR adds a constructor to Trie

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377342252 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDa

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377340478 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirec

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377341015 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/MetadataSto

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377341935 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDa

[GitHub] [helix] narendly commented on a change in pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377351837 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] narendly commented on a change in pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377351141 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] narendly commented on a change in pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #741: Fix the possibile ConcurrentMod exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377350657 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377356452 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDa

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377359734 ## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLockInfo.java ## @@ -0,0 +1,92 @@ +/*

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377353944 ## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLock.java ## @@ -0,0 +1,198 @@ +/* +

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377358921 ## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLockInfo.java ## @@ -0,0 +1,92 @@ +/*

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377352927 ## File path: helix-lock/src/main/java/org/apache/helix/lock/HelixLockScope.java ## @@ -0,0 +1,179 @@ +/* + * License

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377356770 ## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLock.java ## @@ -0,0 +1,198 @@ +/* +

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377357255 ## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLock.java ## @@ -0,0 +1,198 @@ +/* +

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377358330 ## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLock.java ## @@ -0,0 +1,198 @@ +/* +

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

2020-02-10 Thread GitBox
jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377359284 ## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLockInfo.java ## @@ -0,0 +1,92 @@ +/*

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377321200 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistrib

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377370447 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistrib

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377373675 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistrib

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377373000 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDat

[GitHub] [helix] dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377320038 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistrib

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377378255 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistri

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377378006 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistri

[GitHub] [helix] NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on a change in pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#discussion_r377381252 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -124,8 +128,91 @

[GitHub] [helix] NealSun96 commented on issue #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 commented on issue #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#issuecomment-584413855 This PR is ready to be merged, approved by @narendly Final commit message: ## Add TrieRoutingData constructor ## This PR adds a constructor to Trie

[GitHub] [helix] NealSun96 removed a comment on issue #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
NealSun96 removed a comment on issue #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731#issuecomment-584374793 This PR is ready to be merged, approved by @narendly Final commit message: ## Add TrieRoutingData constructor ## This PR adds a constructor

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377395026 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistri

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377394933 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistri

[GitHub] [helix] narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#discussion_r377393176 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/concurrency/ZkDistri

[GitHub] [helix] narendly merged pull request #731: Add TrieRoutingData constructor

2020-02-10 Thread GitBox
narendly merged pull request #731: Add TrieRoutingData constructor URL: https://github.com/apache/helix/pull/731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [helix] dasahcc commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
dasahcc commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#issuecomment-584429052 Remember to resolve the conflict This is an automated mes

[GitHub] [helix] JLLeitschuh opened a new pull request #742: [SECURITY] Use HTTPS to resolve dependencies in Maven Build

2020-02-10 Thread GitBox
JLLeitschuh opened a new pull request #742: [SECURITY] Use HTTPS to resolve dependencies in Maven Build URL: https://github.com/apache/helix/pull/742 [![mitm_build](https://user-images.githubusercontent.com/1323708/59226671-90645200-8ba1-11e9-8ab3-39292bef99e9.jpeg)](https://medium.com/@jo

[GitHub] [helix] narendly commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727#issuecomment-584431516 This PR is ready to be merged, approved by @dasahcc . Add MetadataStoreRoutingDataWriter with DistributedLeaderElec

[GitHub] [helix] narendly merged pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

2020-02-10 Thread GitBox
narendly merged pull request #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection URL: https://github.com/apache/helix/pull/727 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377418194 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377418237 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377418263 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] pkuwm opened a new issue #743: Add read REST endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
pkuwm opened a new issue #743: Add read REST endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/issues/743 We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. T

[GitHub] [helix] pkuwm opened a new pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
pkuwm opened a new pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Implements #74

[GitHub] [helix] narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377422265 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeepe

[GitHub] [helix] narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377422061 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeepe

[GitHub] [helix] narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377421981 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeepe

[GitHub] [helix] narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377420914 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeepe

[GitHub] [helix] narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377421482 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeepe

[GitHub] [helix] narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377421852 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeepe

[GitHub] [helix] narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377422440 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeepe

[GitHub] [helix] narendly commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377423574 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -10

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377433026 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377433026 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] narendly commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
narendly commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377434390 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -10

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377436725 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377436725 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377436725 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377436725 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-10 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r377436725 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377428667 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/M

[GitHub] [helix] pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377453982 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/M

[GitHub] [helix] pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377425791 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/M

[GitHub] [helix] pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377429155 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/M

[GitHub] [helix] pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
pkuwm commented on a change in pull request #744: [WIP] Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377428371 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/M

[GitHub] [helix] narendly commented on a change in pull request #744: Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377462688 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/Meta

[GitHub] [helix] narendly commented on a change in pull request #744: Add read endpoints of metadata store directory service to helix rest

2020-02-10 Thread GitBox
narendly commented on a change in pull request #744: Add read endpoints of metadata store directory service to helix rest URL: https://github.com/apache/helix/pull/744#discussion_r377462037 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/Meta

  1   2   >