[kudu-CR] [metrics] Add metrics for tablet replication time

2024-06-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21507 ) Change subject: [metrics] Add metrics for tablet replication time .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [metrics] Add metrics for tablet replica election

2024-06-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21490 ) Change subject: [metrics] Add metrics for tablet replica election .. Patch Set 1: Code-Review+1 (2 comments)

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-19 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#9). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 9: (1 comment)

[kudu-CR](branch-1.17.x) KUDU-3566 fix summary metrics in Prometheus format

2024-06-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21526 ) Change subject: KUDU-3566 fix summary metrics in Prometheus format .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

2024-06-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21524 ) Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 8: > Patch Set 7: > > > (1 comment) > >

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-18 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#8). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager

[kudu-CR] KUDU-3580 Fix the crash caused when binaries run on older CPU machines

2024-06-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 Fix the crash caused when binaries run on older CPU machines .. Patch Set 7: (2 comments) > Patch Set 7:

[kudu-CR] KUDU-3580 Fix the crash caused when binaries run on older CPU machines

2024-06-18 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21287 to look at the new patch set (#8). Change subject: KUDU-3580 Fix the crash caused when binaries run on older CPU

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-06-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 7: > Patch Set 7: Code-Review+2 > > (1

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-13 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#7). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-06-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21287

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 6: (2 comments)

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-12 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#6). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager

[kudu-CR] [util] remove last vestiges of chromium Atomics from metrics

2024-06-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21505 ) Change subject: [util] remove last vestiges of chromium Atomics from metrics .. Patch Set 1: (1 comment)

[kudu-CR] [util] remove last vestiges of chromium Atomics from metrics

2024-06-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21505 ) Change subject: [util] remove last vestiges of chromium Atomics from metrics .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-11 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#5). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 5: (13 comments)

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-06-11 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21287 to look at the new patch set (#7). Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-10 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#4). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-06-10 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21287 to look at the new patch set (#6). Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-06-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-06-10 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21287 to look at the new patch set (#5). Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-06-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has abandoned this change. ( http://gerrit.cloudera.org:8080/21275 ) Change subject: Skip unhealthy directories when opening DirManager .. Abandoned This is the current design. -- To view, visit

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-06-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21275 ) Change subject: Skip unhealthy directories when opening DirManager .. Patch Set 2: It is designed like this, see more details in this

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 4: (1 comment) > Patch Set 4: > > (2

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-29 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21287 to look at the new patch set (#4). Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines

[kudu-CR](branch-1.17.x) KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21465 ) Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21464 ) Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-26 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21287 to look at the new patch set (#3). Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 2: (7 comments)

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-26 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Yifan Zhang, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21287 to look at the new patch set (#2). Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines

[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-05-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21300 ) Change subject: [metrics] Add tablet level metrics for alter schema op time .. [metrics] Add tablet level metrics for alter

[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-05-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [metrics] Add tablet level metrics for alter schema op time .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21300 To

[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-05-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 ) Change subject: [metrics] Add tablet level metrics for alter schema op time .. Patch Set 6: Verified+1 -- To view, visit

[kudu-CR] Leader rebalance ignores soft deleted tables

2024-05-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 ) Change subject: Leader rebalance ignores soft deleted tables .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] Leader rebalance ignores soft deleted tables

2024-05-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21411 ) Change subject: Leader rebalance ignores soft deleted tables .. Leader rebalance ignores soft deleted tables Soft deleted

[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-05-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 ) Change subject: [metrics] Add tablet level metrics for alter schema op time .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] Allow creating a table with empty range partition

2024-05-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: Allow creating a table with empty range partition .. Allow creating a table with empty range partition

[kudu-CR] Leader rebalance ignores soft deleted tables

2024-05-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 ) Change subject: Leader rebalance ignores soft deleted tables .. Patch Set 4: Code-Review+1 (3 comments)

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-05-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 3: (1 comment)

[kudu-CR] Leader rebalance ignores soft deleted tables

2024-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 ) Change subject: Leader rebalance ignores soft deleted tables .. Patch Set 1: (7 comments)

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. Patch Set 6: (1 comment)

[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 ) Change subject: [metrics] Add tablet level metrics for alter schema op time .. Patch Set 4: (1 comment)

[kudu-CR] [metrics] Add metrics for participant op time

2024-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21375 ) Change subject: [metrics] Add metrics for participant op time .. Patch Set 1: (2 comments)

[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. Patch Set 3: (2 comments)

[kudu-CR] Allow creating a table with empty range partition

2024-05-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: Allow creating a table with empty range partition .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21328 To

[kudu-CR] Allow creating a table with empty range partition

2024-05-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: Allow creating a table with empty range partition .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-05-02 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21370 ) Change subject: [build] Fix RocksDB Snappy dependency. .. Patch Set 4: Code-Review+2 Thanks Zoltan! -- To view, visit

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-04-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. Patch Set 5: (5 comments)

[kudu-CR] Minor refactoring on Op class

2024-04-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op class .. Patch Set 3: Verified+1 Code-Review+1 -- To view, visit

[kudu-CR] Minor refactoring on Op class

2024-04-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op class .. Patch Set 2: Code-Review+1 (2 comments)

[kudu-CR] Allow creating a table with empty range partition

2024-04-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: Allow creating a table with empty range partition .. Patch Set 2: Code-Review+1 (2 comments)

[kudu-CR] [util] fix TidyBot warnings in ScopedTracer

2024-04-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21352 ) Change subject: [util] fix TidyBot warnings in ScopedTracer .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Minor refactoring on Op Class

2024-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op Class .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21342 To

[kudu-CR] Minor refactoring on Op Class

2024-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: Minor refactoring on Op Class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21342 To unsubscribe, visit

[kudu-CR] Minor refactoring on Op Class

2024-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op Class .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21342

[kudu-CR] [Partition] Allow creating a table with empty range partition

2024-04-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 ) Change subject: [Partition] Allow creating a table with empty range partition .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-04-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 3: (16 comments)

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-04-18 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#3). Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager

[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-04-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. Patch Set 1: (1 comment)

[kudu-CR] [metrics] Add tablet level metrics for alter schema op time

2024-04-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 ) Change subject: [metrics] Add tablet level metrics for alter schema op time .. Patch Set 2: (7 comments)

[kudu-CR] KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

2024-04-16 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#2). Change subject: KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

[kudu-CR] KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

2024-04-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing .. Patch Set 2: (11 comments)

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. KUDU-3371 Unify the 'rdb' directory name Change-Id:

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-15 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yifan Zhang, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21298 to look at the new patch set (#2). Change subject: KUDU-3371 Unify the 'rdb' directory name

[kudu-CR] KUDU-3371 Fix the crash bug when run binaries on older CPU machines

2024-04-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines .. Patch Set 1: > Patch Set 1: > > (1 comment) I

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21298 Change subject: KUDU-3371 Unify the 'rdb' directory name .. KUDU-3371 Unify the 'rdb' directory name Change-Id:

[kudu-CR](branch-1.17.x) KUDU-3495 Initialize the bitmap while decoding insert/upsert

2024-04-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21296 ) Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

2024-04-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21295 Change subject: KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing .. KUDU-3371 Check whether the RocksDB dir

[kudu-CR] KUDU-3371 Fix the crash bug when run binaries on older CPU machines

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21287 Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines .. KUDU-3371 Fix the crash bug when run binaries on

[kudu-CR](branch-1.17.x) KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21272 ) Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks .. Patch Set 1: Code-Review+2 --

[kudu-CR](branch-1.17.x) KUDU-3326 correct error messages in tool usage instructions

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21273 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] one less memory allocation in CBTree::count()

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21275 ) Change subject: Skip unhealthy directories when opening DirManager .. Patch Set 2: Some tests failed, I'll fix them later. -- To

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21275 ) Change subject: Skip unhealthy directories when opening DirManager .. Patch Set 2: (1 comment)

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21275 to look at the new patch set (#2). Change subject: Skip unhealthy directories when opening DirManager .. Skip

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21275 Change subject: Skip unhealthy directories when opening DirManager .. Skip unhealthy directories when opening DirManager If a directory

[kudu-CR] [codegen] use std::atomic instead of AtomicInt

2024-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [codegen] use std::atomic instead of AtomicInt

2024-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Patch Set 6: > Patch Set 6: > > Just a clarifying

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Patch Set 6: Verified+1 The failed test is not related:

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21075 To

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-15 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#6). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-11 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#5). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-11 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#4). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-10 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#3). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-10 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#2). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) ..

[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually

2024-03-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19327 ) Change subject: [Tool] KUDU-3318 Compact container metadata file manually .. Patch Set 14: (7 comments)

[kudu-CR] WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-02-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21075 Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually

2024-02-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19327 ) Change subject: [Tool] KUDU-3318 Compact container metadata file manually .. Patch Set 12: (7 comments)

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 6: Code-Review+2 > Patch Set 6: Code-Review+2 >

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 2: Thanks Marton, could you please create a

  1   2   3   4   5   6   7   8   9   10   >