Re: Review Request 37303: Moved scheduler library to http

> On Aug. 12, 2015, 5:09 a.m., Ben Mahler wrote: > > Sorry for not elaborating on all of these, I added some more explanations > > here. Main thing is cleaning up the read loop and figuring out the callback > > semantics (do we need to revisit 'connected' / 'disconnected'?). Let's keep the cal

Re: Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 12, 2015, 6:51 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37382: Introduced provisioner Backend interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95065 --- Patch looks great! Reviews applied: [37382] All tests passed. - M

Review Request 37382: Introduced provisioner Backend interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs

Re: Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review95059 --- Sorry for not elaborating on all of these, I added some more explana

Re: Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 12, 2015, 4:12 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37303: Moved scheduler library to http

> On Aug. 12, 2015, 1:20 a.m., Ben Mahler wrote: > > Thanks Anand, mostly thinking we can clean up the read logic if we have a > > struct to capture the reader / decoder. Isn't it much more simpler here? It's just a one liner "if" check to check if the reader is reader is not None and != for

Re: Review Request 37378: Updated http api tests to use V1 Protobufs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37378/#review95056 --- Patch looks great! Reviews applied: [37082, 37192, 37378] All test

Re: Review Request 37378: Updated http api tests to use V1 Protobufs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37378/#review95053 --- Ship it! Ship It! - Vinod Kone On Aug. 12, 2015, 12:14 a.m., Ana

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 12, 2015, 2:46 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 12, 2015, 2:44 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review95052 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 10:57 p.m., Ana

Re: Review Request 37377: Disallow HTTP schedulers when authentication is required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37377/#review95051 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 11:52 p.m., Ben

Re: Review Request 37377: Disallow HTTP schedulers when authentication is required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37377/#review95047 --- Patch looks great! Reviews applied: [37377] All tests passed. - M

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95046 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 399) <

Re: Review Request 37236: Added the linux filesystem isolator.

> On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 267-269 > > > > > > mesos.proto documentation on Volume::container_path and > > Volume::host_path

Re: Review Request 37336: Added `wait()` method to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review95042 --- Patch looks great! Reviews applied: [37336] All tests passed. - M

Re: Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review95036 --- Thanks Anand, mostly thinking we can clean up the read logic if we h

Re: Review Request 37267: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37267/ --- (Updated Aug. 12, 2015, 1:16 a.m.) Review request for mesos. Bugs: MESOS-2578

Re: Review Request 37266: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37266/ --- (Updated Aug. 12, 2015, 1:16 a.m.) Review request for mesos. Bugs: MESOS-2578

Re: Review Request 37268: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/ --- (Updated Aug. 12, 2015, 1:15 a.m.) Review request for mesos. Bugs: MESOS-2578

Re: Review Request 37266: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37266/ --- (Updated Aug. 12, 2015, 1:10 a.m.) Review request for mesos. Bugs: MESOS-2578

Re: Review Request 37267: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37267/ --- (Updated Aug. 12, 2015, 1:10 a.m.) Review request for mesos. Bugs: MESOS-2578

Re: Review Request 37268: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/ --- (Updated Aug. 12, 2015, 1:10 a.m.) Review request for mesos. Bugs: MESOS-2578

Re: Review Request 37133: Add a frameworks parameter to the hierarchical allocator benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37133/#review95027 --- Ship it! Sorry this took so long, I'll get this committed for you n

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/#review95034 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37199, 37200, 372

Re: Review Request 37126: Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37126/#review95021 --- src/master/http.cpp (line 593)

Review Request 37378: Updated http api tests to use V1 Protobufs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37378/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 37192: More basic call validation tests for http api

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/#review95031 --- Patch looks great! Reviews applied: [37082, 37192] All tests passe

Re: Review Request 37377: Disallow HTTP schedulers when authentication is required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37377/#review95029 --- Ship it! LGTM ! - Anand Mazumdar On Aug. 11, 2015, 11:52 p.m., B

Review Request 37377: Disallow HTTP schedulers when authentication is required.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37377/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos De

Re: Review Request 37336: Added `wait()` method to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 11, 2015, 11:36 p.m.) Review request for mesos and Joris Van Remo

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 11, 2015, 11:34 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37246: Refactor store to use updated DockerImage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37246/ --- (Updated Aug. 11, 2015, 11:32 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37245: Refactor Docker Image to exclude path and manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37245/ --- (Updated Aug. 11, 2015, 11:29 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 11, 2015, 11:26 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/ --- (Updated Aug. 11, 2015, 11:24 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 11, 2015, 11:23 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 11, 2015, 11:21 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/#review95005 --- src/slave/containerizer/provisioners/appc/store.hpp (line 39)

Re: Review Request 37303: Moved scheduler library to http

> On Aug. 11, 2015, 6:55 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 329 > > > > > > indent by 4 spaces. Not used now. Fixed the other one. - Anand -

Re: Review Request 37192: More basic call validation tests for http api

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/ --- (Updated Aug. 11, 2015, 10:58 p.m.) Review request for mesos, Ben Mahler and Vi

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 11, 2015, 10:57 p.m.) Review request for mesos, Ben Mahler and Vi

Re: Review Request 37309: Add app::paths which handles Appc related path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37309/#review95023 --- src/slave/containerizer/provisioners/appc/paths.hpp (line 55)

Re: Review Request 37374: Only accept v1 protobufs for HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37374/#review95022 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 10:13 p.m., Ben

Re: Review Request 37125: Added 'Master::authorize' for Reserve/Unreserve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37125/#review95020 --- Ship it! LGTM modulo my (blocking) concern about allowing a malicio

Re: Review Request 37315: Added basic authentication documentation

> On Aug. 11, 2015, 10:19 p.m., Vinod Kone wrote: > > Thank you. > > > > Ignore the bot failure. It's not related to your patch. Cool, I thought as much, thanks again for the feedback. - Tim --- This is an automatically generated e-ma

Re: Review Request 37315: Added basic authentication documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37315/#review95018 --- Ship it! Thank you. Ignore the bot failure. It's not related to y

Re: Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 11, 2015, 10:18 p.m.) Review request for mesos, Ben Mahler and Vi

Re: Review Request 37110: Enabled the Authorizer to handle Reserve/Unreserve ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37110/#review95011 --- src/tests/authorization_tests.cpp (line 360)

Re: Review Request 37374: Only accept v1 protobufs for HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37374/#review95015 --- Ship it! LGTM - Anand Mazumdar On Aug. 11, 2015, 10:13 p.m., Ben

Re: Review Request 37315: Added basic authentication documentation

> On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote: > > Thanks for doing this. Looking pretty good, just some minor comments. > > Tim Anderegg wrote: > Thanks for taking the time to review, Vinod. I'll make those changes > tomorrow. OK, submitted a revision. I'm not sure why the Mesos bot b

Review Request 37374: Only accept v1 protobufs for HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37374/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos De

Re: Review Request 37315: Added basic authentication documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37315/ --- (Updated Aug. 11, 2015, 10:10 p.m.) Review request for mesos. Changes ---

Re: Review Request 37002: Introduced ACL protobuf definitions for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37002/#review95010 --- Ship it! LGTM module comments. FYI - Adam is out for the next sever

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review94832 --- src/slave/containerizer/isolators/filesystem/linux.hpp (line 38)

Re: Review Request 37240: Added support to handle queries to nested HTTP paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37240/ --- (Updated Aug. 11, 2015, 9:04 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 37240: Added support to handle queries to nested HTTP paths.

> On Aug. 11, 2015, 12:19 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, line 451 > > > > > > Why the semi colon? oops. fixed. > On Aug. 11, 2015, 12:19 a.m., Ben Mahler wrote: > > 3rdpa

Re: Review Request 37247: Added Docker image reference store.

> On Aug. 8, 2015, 8:37 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/reference_store.cpp, line 186 > > > > > > Why missing layer means we don't load up the image? And when would this > >

Re: Review Request 37192: More basic call validation tests for http api

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/#review95004 --- Patch looks great! Reviews applied: [37082, 37192] All tests passe

Re: Review Request 36837: Update gmock to 1.7.0.

> On Aug. 11, 2015, 7:06 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 166 > > > > > > This line breaks the build on my machine OS X 10.10, and I'm not sure > > how to fix it becaus

Re: Review Request 37328: Remove namespace ambiguity

> On Aug. 11, 2015, 7:04 p.m., Vinod Kone wrote: > > src/tests/common/http_tests.cpp, lines 40-42 > > > > > > reorder alphabetically. Why ? We have alphabetical norms for using declarations "within" the same scope i

Re: Review Request 36837: Update gmock to 1.7.0.

> On Aug. 11, 2015, 7:06 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 166 > > > > > > This line breaks the build on my machine OS X 10.10, and I'm not sure > > how to fix it becaus

Re: Review Request 37192: More basic call validation tests for http api

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/ --- (Updated Aug. 11, 2015, 8:12 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 11, 2015, 8:11 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37310: Added Appc spec validation utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/#review94986 --- src/slave/containerizer/provisioners/appc/spec.hpp (line 38)

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94981 --- Ship it! Mostly some minor comments, I'll make the adjustments and

Re: Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37106/#review94984 --- Ship it! Ship It! - Jie Yu On Aug. 5, 2015, 12:58 a.m., Paul Bre

Re: Review Request 37304: Add authorization for http based schedulers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37304/ --- (Updated Aug. 11, 2015, 7:48 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37328: Remove namespace ambiguity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/ --- (Updated Aug. 11, 2015, 7:47 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37309: Add app::paths which handles Appc related path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37309/#review94975 --- Ship it! src/slave/containerizer/provisioners/appc/paths.cpp (line

Re: Review Request 37335: Fixed scheduler library tests after moving to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37335/#review94976 --- src/tests/scheduler_tests.cpp (lines 168 - 170)

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/#review94958 --- Ship it! Couple of comments below, but I'll make the adjustments an

Re: Review Request 36837: Update gmock to 1.7.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94974 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 166)

Re: Review Request 37328: Remove namespace ambiguity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/#review94970 --- Ship it! src/tests/common/http_tests.cpp (lines 38 - 40)

Re: Review Request 37304: Add authorization for http based schedulers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37304/#review94968 --- Ship it! I think this can be pulled out of this chain to commit it

Re: Review Request 34142: AppC provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/#review94969 --- src/slave/containerizer/provisioners/appc.cpp (lines 471 - 481)

Re: Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review94959 --- src/scheduler/scheduler.cpp (lines 328 - 332)

Re: Review Request 36867: Add "labels" to FrameworkInfo.

> On July 27, 2015, 11:36 p.m., Adam B wrote: > > Great first patch. Thanks for updating FrameworkInfo on reregistration with > > the master too! > > A handful of nits in my first pass. I'll take another look once you've > > simplified the tests with Kapil's suggestions. > > Niklas Nielsen wro

Re: Review Request 35668: Report "unevictable" memory in container statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35668/#review94955 --- Ship it! Ship It! - Jie Yu On June 19, 2015, 9:03 p.m., Chi Zhan

Re: Review Request 37308: Added AppcImageManifest protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37308/#review94953 --- include/mesos/mesos.proto (line 1402)

Re: Review Request 37192: More basic call validation tests for http api

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/#review94952 --- Patch looks great! Reviews applied: [37082, 37192] All tests passe

Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/#review94843 --- Looks pretty good, just some minor things. src/master/master.hpp (

Re: Review Request 37302: Deleted old style message handling from the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 11, 2015, 5:58 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77 > > > > > > So, why change the value to `TRUE` here? Is there some consequence of > > this, or is it just cl

Re: Review Request 37192: More basic call validation tests for http api

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/#review94946 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 5:04 p.m., Anan

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77 > > > > > > So, why change the value to `TRUE` here? Is there some consequence of > > this, or is it just cl

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94941 --- Looking. Minor issues. Please make sure when you fix an issue, you f

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 55 > > > > > > Sorry, maybe I'm a bit slow this morning -- but how are you running > > this? Windows doesn't ha

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/#review94939 --- Ship it! Ship It! - Jie Yu On Aug. 10, 2015, 6:31 p.m., Jiang Ya

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review90790 --- Ship it! LGTM! - Jie Yu On Aug. 5, 2015, 7:12 p.m., Michael Park

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 11, 2015, 5:03 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37192: More basic call validation tests for http api

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/ --- (Updated Aug. 11, 2015, 5:04 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

> On July 29, 2015, 4:04 p.m., James DeFelice wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 238 > > > > > > why MS_SHARED (bidirectional) vs MS_SLAVE (one-way)? > > > > MS_SLAVE wou

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

> On Aug. 11, 2015, 3:57 p.m., Marco Massenzio wrote: > > Wouldn't it be good if we could have some comments as to how this class is > > supposed to be used, what does it encapsulate, etc.? > > > > At the very least a URL to a design doc or something? > > > > Also, all the methods are complete

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 55 > > > > > > Sorry, maybe I'm a bit slow this morning -- but how are you running > > this? Windows doesn't ha

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review94920 --- Wouldn't it be good if we could have some comments as to how this cl

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94912 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All test

Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94913 --- Ship it! Ship It! - Guangya Liu On 八月 7, 2015, 10:44 p.m., Kapil

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 11, 2015, 2:30 p.m.) Review request for mesos, Alexander Rojas an

  1   2   >