Re: Review Request 52071: Updated docs to reflect handling of disk resource with size of 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/#review149621 --- Patch looks great! Reviews applied: [51999, 52001, 52002, 51879,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

> On 八月 25, 2016, 6:27 p.m., Kevin Klues wrote: > > src/docker/executor.cpp, line 89 > > > > > > By the time the devices are passed in here they should be of type > > `vector`, not just a string. > > > > Th

Re: Review Request 52042: Changed error message in pailer if user is unauthorized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/ --- (Updated Sept. 20, 2016, 9:41 a.m.) Review request for mesos and Adam B. Chan

Re: Review Request 52055: Exposed unknown container case from Containerizer::wait.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52055/#review149617 --- src/tests/containerizer/composing_containerizer_tests.cpp (line 1

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

> On 八月 25, 2016, 7:17 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp, lines 146-149 > > > > > > This comment is confusing. I'd probably just leave it as it was, but > > say t

Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52056/#review149626 --- Bad patch! Reviews applied: [52056, 52055, 52054, 52053] Failed

Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 19, 2016, 11:24 a.m., Jan Schlicht wrote: > > src/master/validation.cpp, lines 63-78 > > > > > > This will cause problems with tasks that don't use a container image: > > While `ContainerInfo.type` is requ

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

> On 八月 25, 2016, 7:28 p.m., Kevin Klues wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3893-3894 > > > > > > I don't understand this comment. Can you clarify? Why do we want to > > make s

Re: Review Request 52055: Exposed unknown container case from Containerizer::wait.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52055/#review149630 --- src/slave/containerizer/docker.cpp (line 1793)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 九月 20, 2016, 9:21 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 九月 20, 2016, 9:22 a.m.) Review request for mesos, Benjamin Mahler, Gua

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 九月 20, 2016, 9:24 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 九月 20, 2016, 9:25 a.m.) Review request for mesos, Benjamin Mahler, Gua

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

> On 八月 25, 2016, 6:08 p.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, lines 230-249 > > > > > > I would probably move this into the next patch alongside the other > > changes to the flags and not e

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 九月 20, 2016, 9:26 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 九月 20, 2016, 9:27 a.m.) Review request for mesos, Benjamin Mahler, Gua

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 九月 20, 2016, 9:27 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/#review149631 --- Patch looks great! Reviews applied: [46187, 52075] Passed comman

Re: Review Request 52025: Replaced unchecked `dynamic_cast` with `static_cast`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52025/#review149634 --- Just curious whether this is just a drive-by cleanup, or whether i

Re: Review Request 52062: Fixed warnings in `numify.hpp`.

> On Sept. 19, 2016, 9:24 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/numify.hpp, lines 29-32 > > > > > > Couldn't this be a static assert (failure) instead? > > > > It doesn't make sense to neg

Re: Review Request 52062: Fixed warnings in `numify.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/#review149638 --- We currently simply inherit the negation of unsigned int behavior

Review Request 52080: Replaced `Latch*` with `Latch` in executor, scheduler drivers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52080/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 20, 2016, 1:12 p.m.) Review request for mesos, Jay Guo and Jie Y

Review Request 52081: Reorganized includes in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52081/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- R

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 20, 2016, 4:38 a.m., Jie Yu wrote: > > src/Makefile.am, line 834 > > > > > > This should belong linux files below? This isolator has no hard dependency on Linux so we can build it on all platforms. I th

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 20, 2016, 1:40 p.m.) Review request for mesos, Jay Guo and Jie Y

Re: Review Request 52025: Replaced unchecked `dynamic_cast` with `static_cast`.

> On Sept. 20, 2016, 12:16 p.m., Michael Park wrote: > > Just curious whether this is just a drive-by cleanup, or whether it's > > caused us problems? > > > > Also, could we add a `static_assert`? something like: > > ``` > > static_assert( > > std::is_base_of::value, > > "`Process` requ

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149647 --- Bad review! Reviews applied: [51631, 51791, 51790, 51789, 51788,

Re: Review Request 52025: Replaced unchecked `dynamic_cast` with `static_cast`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52025/#review149650 --- Ship it! Ship It! - Michael Park On Sept. 19, 2016, 10:19 a.

Re: Review Request 52025: Replaced unchecked `dynamic_cast` with `static_cast`.

> On Sept. 20, 2016, 10:16 a.m., Michael Park wrote: > > Just curious whether this is just a drive-by cleanup, or whether it's > > caused us problems? > > > > Also, could we add a `static_assert`? something like: > > ``` > > static_assert( > > std::is_base_of::value, > > "`Process` requ

Re: Review Request 52031: Added openssl error string output to initializing failures.

> On Sept. 19, 2016, 7:02 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 509-510 > > > > > > I'd prefer the parentheses containing the `stringify(error)` to mention > > OpenSSL, since the numb

Re: Review Request 52031: Added openssl error string output to initializing failures.

> On Sept. 20, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 481-482 > > > > > > Is there any information we can provide here about where we are looking > > for the defa

Review Request 52082: Tweaked initialization order in executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52082/ --- Review request for mesos. Repository: mesos Description --- We should in

Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52080/ --- (Updated Sept. 20, 2016, 1:11 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52056/#review149620 --- src/slave/containerizer/composing.cpp (line 312)

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 20, 2016, 1:27 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 52037: Removed stout's `Set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52037/ --- Review request for mesos and Michael Park. Bugs: MESOS-6159 https://issues.

Review Request 52036: Moved user of stout's `Set` to `std::set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52036/ --- Review request for mesos and Michael Park. Bugs: MESOS-6159 https://issues.

Re: Review Request 51930: Introduced Linux capabilities support for Mesos executor.

> On Sept. 20, 2016, 2:36 a.m., Jie Yu wrote: > > src/launcher/executor.cpp, line 817 > > > > > > It looks wierd that we have ifdef here but not have that for the field > > member. I'd suggest we don't do any ifdef

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149657 --- Patch looks great! Reviews applied: [51784, 51930, 51931, 52081,

Re: Review Request 52031: Added openssl error string output to initializing failures.

> On Sept. 20, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 481-482 > > > > > > Is there any information we can provide here about where we are looking > > for the defa

Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52080/#review149659 --- Ship it! Ship It! - Michael Park On Sept. 20, 2016, 1:11 p.m

Re: Review Request 52031: Added openssl error string output to initializing failures.

> On Sept. 20, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 481-482 > > > > > > Is there any information we can provide here about where we are looking > > for the defa

Re: Review Request 52082: Tweaked initialization order in executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52082/#review149665 --- Ship it! Ship It! - Michael Park On Sept. 20, 2016, 2:26 p.m

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

> On Sept. 7, 2016, 7:21 p.m., Joris Van Remoortere wrote: > > src/slave/slave.cpp, lines 559-561 > > > > > > We should improve the error information here. Why can't we identify > > which original paths that were pr

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

> On Sept. 7, 2016, 7:21 p.m., Joris Van Remoortere wrote: > > src/slave/slave.cpp, lines 559-561 > > > > > > We should improve the error information here. Why can't we identify > > which original paths that were pr

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149669 --- Patch looks great! Reviews applied: [51631] Passed command: expo

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/#review149667 --- src/tests/containerizer/common_containerizer_tests.cpp (line 96)

Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6206 https://issues.ap

Re: Review Request 51930: Introduced Linux capabilities support for Mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51930/ --- (Updated Sept. 20, 2016, 5:39 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 52037: Removed stout's `Set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52037/ --- (Updated Sept. 20, 2016, 6:05 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52036: Moved user of stout's `Set` to `std::set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52036/ --- (Updated Sept. 20, 2016, 6:05 p.m.) Review request for mesos and Michael Park.

Re: Review Request 51930: Introduced Linux capabilities support for Mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51930/ --- (Updated Sept. 20, 2016, 6:13 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 52082: Tweaked initialization order in executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52082/#review149675 --- Patch looks great! Reviews applied: [52080, 52082] Passed comman

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149676 --- Can you follow up with some tests on this? Should be similar to S

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149624 --- include/mesos/resources.hpp (lines 60 - 64)

Re: Review Request 51857: Modified the `prepare` and `isolate` methods to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 20, 2016, 5:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52014: Added `supportsNesting` method to `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52014/ --- (Updated Sept. 20, 2016, 5:10 p.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 51986: Modified `cleanup` to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51986/ --- (Updated Sept. 20, 2016, 5:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51124: Support more layers through symlink for overlay backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review149683 --- @Zhitao, the patch LGTM. Thanks for working on it. Could you pleas

Re: Review Request 51124: Support more layers through symlink for overlay backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Sept. 20, 2016, 5:28 p.m.) Review request for mesos, Xiaojian Huang, G

Re: Review Request 51124: Support more layers through symlink for overlay backend.

> On Sept. 20, 2016, 5:21 p.m., Gilbert Song wrote: > > @Zhitao, the patch LGTM. Thanks for working on it. Could you please rebase? Done. - Zhitao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review149695 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Review Request 52090: Fixed compile error in ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52090/ --- Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang. Re

Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Review Request 52091: Replaced `set` to `hashset` in perf interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52091/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Review Request 52057: Introduced an agent API for managing child containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52057/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and Vinod Ko

Re: Review Request 52037: Removed stout's `Set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52037/#review149713 --- Patch looks great! Reviews applied: [52036, 52037] Passed comman

Re: Review Request 52057: Introduced an agent API for managing child containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52057/ --- (Updated Sept. 20, 2016, 7:34 p.m.) Review request for mesos, Anand Mazumdar, B

Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52096/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 52095: Add the new flag for executor launching with different user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52095/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 52097: Functionality to switch user when executor launches as non-root user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Sept. 20, 2016, 7:55 p.m.) Review request for mesos, Joseph Wu and Vin

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Sept. 20, 2016, 8:47 p.m.) Review request for mesos, Joseph Wu and Vin

Re: Review Request 52057: Introduced an agent API for managing child containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52057/#review149728 --- include/mesos/agent/agent.proto (line 103)

Re: Review Request 51857: Modified the `prepare` and `isolate` methods to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review149726 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 52014: Added `supportsNesting` method to `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52014/#review149731 --- Ditto on merging this patch. - Jie Yu On Sept. 20, 2016, 5:10 p

Re: Review Request 51986: Modified `cleanup` to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51986/#review149730 --- Let's merge this patch with the prepare isolate patch as well. -

Review Request 52098: Updated UUID::fromString to not throw an exception on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52098/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Review Request 52099: Updated scheduler library to handle UUID parsing error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52099/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50736/#review149729 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line 1

Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2449 https://issues.ap

Re: Review Request 52090: Fixed compile error in ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52090/#review149733 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 52055: Exposed unknown container case from Containerizer::wait.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52055/#review149735 --- Ship it! Ship It! - Vinod Kone On Sept. 20, 2016, 12:40 a.m.

Re: Review Request 52055: Exposed unknown container case from Containerizer::wait.

> On Sept. 20, 2016, 7:45 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 3785 > > > > > > Why need `recover` here? yea, can you add a comment on why you need to do a `reco

Re: Review Request 52091: Replaced `set` to `hashset` in perf interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52091/#review149736 --- Ship it! Ship It! - Jie Yu On Sept. 20, 2016, 7:22 p.m., hao

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/#review149737 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149710 --- Given these comments, do you want to punt on improving the simple

Re: Review Request 52014: Added `supportsNesting` method to `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52014/#review149743 --- Patch looks great! Reviews applied: [51857, 51986, 52014] Passed

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review149739 --- include/mesos/resources.hpp (lines 273 - 274)

Re: Review Request 51857: Modified the `prepare` and `isolate` methods to be nesting aware.

> On Sept. 20, 2016, 9:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 725-733 > > > > > > This is problematic. > > > > If both rootDir and pluginDir is not set,

Re: Review Request 51857: Modified the `prepare` and `isolate` methods to be nesting aware.

> On Sept. 20, 2016, 9:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 725-733 > > > > > > This is problematic. > > > > If both rootDir and pluginDir is not set,

Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52056/#review149738 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp (l

Re: Review Request 52057: Introduced an agent API for managing child containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52057/#review149755 --- Updated summary and description to say "nested" instead of "child"

Re: Review Request 52098: Updated UUID::fromString to not throw an exception on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52098/#review149758 --- Ship it! Ship It! - Vinod Kone On Sept. 20, 2016, 9:24 p.m.,

Re: Review Request 52099: Updated scheduler library to handle UUID parsing error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52099/#review149760 --- Ship it! Ship It! - Vinod Kone On Sept. 20, 2016, 9:24 p.m.,

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 20, 2016, 11:32 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 52105: Add smarter master redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ --- Review request for mesos. Bugs: MESOS-6210 https://issues.apache.org/jira/b

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/#review149761 --- Fix it, then Ship it! LGTM modulo the names as mentioned in the

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 21, 2016, 12:06 a.m.) Review request for mesos, Gilbert Song, Ji

  1   2   >