> On 八月 25, 2016, 6:27 p.m., Kevin Klues wrote: > > src/docker/executor.cpp, line 89 > > <https://reviews.apache.org/r/50125/diff/6/?file=1472872#file1472872line89> > > > > By the time the devices are passed in here they should be of type > > `vector<Device>`, not just a string. > > > > This is similar to how `task_environment` comes in as a simple string > > via `Flags`, but is converted to a `map<string, string>` by the time it is > > passed into `DockerExecutorProcess`.
Good idea. Changed as your comments. - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review146823 ----------------------------------------------------------- On 八月 15, 2016, 7:29 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > ----------------------------------------------------------- > > (Updated 八月 15, 2016, 7:29 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added a new flag '--devices' to mesos-docker-executor, and gave its > feature to control devices exposition, isolation, and access permission. > > > Diffs > ----- > > src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 > src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac > src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
